Minor cleanups: unused vars, unreachable code, static globals.

- All global variables should be static unless they have an explicit
  extern declaration in a header file.
- `to_compare` was not used in encryptsave and toxav tests.
- `break` in switch cases is not required directly after `return`,
  `goto`, or a noreturn function like `abort`.

1 files changed, 0 insertions, 3 deletions

diff --git a/toxav/msi.c b/toxav/msi.c
index d80d7c76..39086567 100644
--- a/toxav/msi.c
+++ b/toxav/msi.c
@@ -384,7 +384,6 @@ int msg_parse_in(Logger *log, MSIMessage *dest, const uint8_t *data, uint16_t le
             default:
                 LOGGER_ERROR(log, "Invalid id byte");
                 return -1;
-                break;
         }
     }
 
@@ -689,7 +688,6 @@ void handle_init(MSICall *call, const MSIMessage *msg)
             call->error = msi_EInvalidState;
             goto FAILURE;
         }
-        break;
     }
 
     return;
@@ -771,7 +769,6 @@ void handle_pop(MSICall *call, const MSIMessage *msg)
                 LOGGER_ERROR(call->session->messenger->log, "Handling what should be impossible case");
                 abort();
             }
-            break;
 
             case msi_CallActive: {
                 /* Hangup */