Age | Commit message (Collapse) | Author |
|
Also added a bunch of asserts to tests where they don't check allocs.
|
|
Use `bazel test //c-toxcore/... --build_tag_filters=-haskell` to run all
tests except the ones that depend on Haskell (i.e. cimple tests).
|
|
This check puts all of our code in a C++ anonymous namespace, which is
effectively making all functions `static`. This allows the compiler to
determine that a function is unused, so we can delete it.
|
|
* Use-after-free because we free network before dht in one case.
* Various unchecked allocs in tests (not so important).
* We used to not check whether ping arrays were actually allocated in DHT.
* `ping_kill` and `ping_array_kill` used to crash when passing NULL.
Also:
* Added an assert in all public API functions to ensure tox isn't NULL.
The error message you get from that is a bit nicer than "Segmentation
fault" when clients (or our tests) do things wrong.
* Decreased the sleep time in iterate_all_wait from 20ms to 5ms.
Everything seems to still work with 5ms, and this greatly decreases
the amount of time spent per test run, making oomer run much faster.
|
|
We need this for vanilla nacl builds on Linux.
|
|
|
|
If you have UINT32_MAX friends, then adding one more friend will cause an
overflow of the friend list (wrap to 0) and result in all friends being
deleted. This subsequently results in a null pointer dereference when
we're trying to add one friend to the deleted friend list.
|
|
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955319.
|
|
Use `cmake -DEXECUTION_TRACE=ON` to use it.
|
|
* Use fully static build for the bootstrap daemon.
* Store a sha256sum of the binary in the repo.
* Updated documentation for it.
* Add support for fully static build in cmake.
* Enable the docker build on every PR, so we catch changes to the
checksum. I realise this is adding toil, but having the checksum is
valuable for security of released binaries.
|
|
|
|
|
|
See https://github.com/release-drafter/release-drafter
|
|
|
|
*Total -- 23.11kb -> 12.21kb (47.19%)
/other/tox.png -- 17.50kb -> 6.99kb (60.05%)
/other/tox-warning.png -- 5.61kb -> 5.21kb (7.04%)
Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
|
|
|
|
This test was fixed by @robinlinden, but not enabled in all builds.
|
|
Also changed their return type to bool instead of 1/0 ints.
|
|
|
|
This is to prepare for ToxAV becoming independent of toxcore internal calls.
|
|
We put some tokstyle exemptions into the source files themselves,
instead. This way we can check some of the code in those files, and more
in the future when tokstyle supports more constructs (like apidsl).
Also: hacked ping_array.api.h to not emit `_array` as parameter names.
We'll need to fix apidsl to do this better. This works for now.
|
|
|
|
This adds complexity for very little value.
|
|
|
|
|
|
|
|
|
|
See https://github.com/TokTok/hs-tokstyle/pull/49 for the corresponding
tokstyle analysis.
|
|
|
|
|
|
We're actually still using it, but we got a private pointer now,
preparing us for having a private mono_time in toxav.
|
|
|
|
malloc.h doesn't exist on most platforms, and certainly not in stdc. No
functions from malloc.h are actually used here, and stdlib.h is enough.
|
|
|
|
This one is unfortunately a little more complicated to use. I may add a
simpler API later, but for now, it's JSON-based (because I couldn't get
binary data to work without it getting mangled somewhere along the way -
JSON is at least text-transport-safe).
|
|
|
|
|
|
This used to take a long time, but is now very fast.
|
|
|
|
We now check whether the cache application is reachable and running via
cURL. If it's running, we add the `--config=remote` line.
|
|
|
|
|
|
Remove useless parameter, replace with assert (just to be sure). Also
replaced some memsets with 0-initialiser and memcpy with assignment.
|
|
This function exists and simplifies some code a little bit. There are
lots of places in DHT.c where we have the exact same code, so there is a
lot of opportunity to factor out common bits. For now, we just make a
minor improvement that's easy to review.
|
|
|
|
We already have one on Cirrus, and it works fine.
|
|
code.tox.chat is down.
|
|
This may fix problems with very large conferences. Sadly, it seems
infeasible to test large conferences on one machine, so this is entirely
theoretical.
|
|
This allows invitations to work in the case that the invitee is already
in the group, which can happen if the group becomes split. Such an
invitation is automatically accepted, leading to the peers becoming
connected in the group and sharing peer lists.
|
|
We want functions declared as `static` to also be defined as `static`.
|