| Age | Commit message (Collapse) | Author |
|---|
|
**What are we doing?**
We are moving towards stateless callbacks. This means that when registering a
callback, you no longer pass a user data pointer. Instead, you pass a user data
pointer to tox_iterate. This pointer is threaded through the code, passed to
each callback. The callback can modify the data pointed at. An extra indirection
will be needed if the pointer itself can change.
**Why?**
Currently, callbacks are registered with a user data pointer. This means the
library has N pointers for N different callbacks. These pointers need to be
managed by the client code. Managing the lifetime of the pointee can be
difficult. In C++, it takes special effort to ensure that the lifetime of user
data extends at least beyond the lifetime of the Tox instance. For other
languages, the situation is much worse. Java and other garbage collected
languages may move objects in memory, so the pointers are not stable. Tox4j goes
through a lot of effort to make the Java/Scala user experience a pleasant one by
keeping a global array of Tox+userdata on the C++ side, and communicating via
protobufs. A Haskell FFI would have to do similarly complex tricks.
Stateless callbacks ensure that a user data pointer only needs to live during a
single function call. This means that the user code (or language runtime) can
move the data around at will, as long as it sets the new location in the
callback.
**How?**
We are doing this change one callback at a time. After each callback, we ensure
that everything still works as expected. This means the toxcore change will
require 15 Pull Requests.
|
|
This allows us to more clearly define interfaces between modules, and have the
linker help us ensure that module boundaries are respected.
The onion/tcp/net_crypto layer is a bit too large. This is due to a cyclic
dependency (onion -> net_crypto -> TCP -> onion). We may or may not want to
break that cycle in the future to allow the onion library to exist on its own
without net_crypto.
|
|
|
|
|
|
|
|
|
|
Also, fix the hstox build that was taking half an hour. It now takes 5 minutes.
Also, perform distcheck on travis to ensure that make dist works. It's not
actually failing the build at the moment due to broken tests.
|
|
We run astyle on Travis and check if there is a diff. The build terminates if
git finds a difference.
|
|
|
|
This is in preparation for having multiple types of build. One of the future
builds will be a hstox build, another may be frama-c or some other static
analyser. It makes sense to split these up into multiple builds, because each of
them can take a while, and running them in parallel will speed things up. Also,
the hstox test coverage should be reported separately from the toxcore auto_test
coverage.
|
|
> increased the timeout for TCP tests because per @irungentoo the network on Travis-CI can be slow sometimes
> allowed groupchats test to restart on error until timeout This had to be done because current groupchats are fundamentally broken and 3/5 times they'll 'net-split' on connect
>> Drop group chat tests, add comment to the reason
> added some debugging information to TCP tests, and a #define to force IPV6 (Travis-CI only uses IPv4 on their containers) and decreased the itr interval
> Went crazy with timeouts for Tox network stuff on Travis. Tests on TCP will still randomly fail due to timeouts. I can't reproduce on any local system. So again per @irungentoo, Travis is slow, let's offer it a short bus.
|
|
sodium_init returns 1 when the library was already initialised. Toxcore code
wasn't prepared to handle sodium errors, so it thought it was an allocation
error.
This error is still not handled correctly. If crypto fails to initialise, it
will think it's an allocation error. Fixing this requires too many code changes,
so must be done later.
|
|
Some of these (like the incompatible pointers one) are really annoying for
later refactoring.
|
|
|
|
|
|
Requested, suggested
|
|
|
|
|
|
Update the manual to provide a command necessary to open <1024 ports for users on SysVinit
|
|
The logging code is rarely tested by users, so we use Travis to exercise it.
|
|
- We use coveralls.io to report on test coverage and avoid getting below a
certain threshold. The threshold is currently 60%, but we will be increasing
it when it stabilises.
- We use gcc/clang -ftest-coverage and gcov to measure C test coverage.
- We switched to container based Travis build infrastructure, which has the
advantage of faster boot times[1] (1-6s vs. 20-52s). The trusty beta supports
caching, but the longer boot times make it an unattractive target.
- We now need to build more dependencies ourselves and cache the result. We
still fetch what we can (currently opam, libvpx, and check) from apt.
[1] https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
https://github.com/nurupo/InsertProjectNameHere
|
|
|
|
tox.h and toxav.h must be generated by apidsl instead of edited directly.
|
|
Also removal of example bootstrap nodes from the config file in one line
|
|
|
|
|
|
|
|
|
|
* Add #defines for INET/INET6 returns
* Remove magic number 3 - exact AF_INET/INET6 result found.
* Updated network_test.c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Added default return to non void functions level_syslog and level_stdout.
|
|
|
|
Fixed bug from merged PR.
Don't build useless files when building with libsodium.
|
|
|
|
|
