Age | Commit message (Collapse) | Author |
|
We can now revert the changes to the callbacks and keep supporting them
until clients have moved off them.
|
|
net_crypto has pthread types in its struct, so its size is system
dependent. In particular, the sizes are wrong on FreeBSD.
|
|
|
|
|
|
|
|
|
|
|
|
This forces us to record size changes (for LP64) and helps estimate
memory consumption of internal data structures.
|
|
Instead of 1 FT blocking all others.
|
|
|
|
We're not gaining much from this library, and it's a burden, especially
for windows development.
|
|
Also, add an auto-test for bootstrap and for LAN discovery.
Bootstrap is never tested otherwise, and LAN discovery is a prerequisite
for everything else. Having these two tests lets us rule out or identify
LAN discovery as a possible cause for test failures.
|
|
Also reduce number of people in conference to 5, because on Circle CI the
test times out trying to connect more than 6 or 7 people. The persistent
conferences PR will improve this so we can set it much higher then.
|
|
|
|
|
|
This changes only code, no string literals or comments.
|
|
|
|
follow TokTok#731. This commit
completely removed all things in namespace bit_rate, and deprecated
functions are to be added back in another commit. set_xxx() is treadted
as a property of namespace audio&video, same as bit_rate change event.
toxav_basic_test is fixed, either.
|
|
Also got rid of two VLAs. They are overused a bit in toxcore. In
irc_syncbot, the array was uninitialised and then filled by a recv system
call. This can cause uninitialised reads if recv doesn't fill the entire
array. It could not cause out of bounds read directly, because a
NUL-terminator was in place, but both cases are undefined behaviour.
|
|
Fixes #572.
As discussed in the issue, there's a risk that toxcore may not hold the
maximum bitrates libvpx supports, if toxcore insists on using integer
type. I initially proposed to have another flag in set(), so that we can
use unsigned type instead. iphydf came up with a better solution, that is
splitting the original functions, one for audio, one for video. Now, we
could safely replace int32_t with uint32_t.
Also: clean video_bit_rate_invalid()
Though this is not a part of issue #572, as it's used in the
toxav_bit_rate_set(), i cleaned the code. As mannol said, there should be
a check. Uint32_t is large enough to hold the maximum bitrates libvpx
supports, but user may pass a value larger than uint while smaller than
uint32_t. Thanks to the reminding from nurupo, it's no longer a stub
function.
Bitrate error enums are shared for both audio and video
https://github.com/TokTok/c-toxcore/pull/578#issuecomment-360095609, just
as iphydf said.
|
|
This way, developers compile toxcore, toxav, and toxencryptsave as C++ at
least once at home, reducing the likelyhood of running into travis
failures where we compile as C++ in the windows build.
|
|
This allows us to precisely see which libraries depend on which and lets
us split them up more, if necessary.
|
|
This struct will soon become opaque.
|
|
|
|
This tests that a message from tox1 is relayed via tox2 to tox3 when tox1
and tox3 are not friends.
|
|
Increasing from 256K to 1M and increasing the number of iterations from
1000 to 2000. This makes the test more accurate and less flaky.
|
|
|
|
This allows us and users to reproducibly build verified versions of the
library with checksums. It will power the toktok-stack continuous build
with checked-in checksums at specific git revisions.
|
|
|
|
|
|
Also some missing return value checks for `fopen`.
|
|
|
|
|
|
|
|
These may be useful when debugging toxcore locally, but are not useful in
unit tests.
|
|
|
|
To make it an abstract type everywhere except in network.c.
|
|
Also replace &(x) with &x for consistency.
|
|
|
|
|
|
Test uses the first node as bootstrap, but the port is hardcoded.
|
|
|
|
Port of the first tox instance will be 33445 only if this port was not
in use during testing
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|