From 2570ddcb17fdf5bea56c6bc1c5c2d04ba2068ee7 Mon Sep 17 00:00:00 2001 From: iphydf Date: Sat, 2 May 2020 20:49:41 +0100 Subject: Fix errors on error paths found by oomer. * Use-after-free because we free network before dht in one case. * Various unchecked allocs in tests (not so important). * We used to not check whether ping arrays were actually allocated in DHT. * `ping_kill` and `ping_array_kill` used to crash when passing NULL. Also: * Added an assert in all public API functions to ensure tox isn't NULL. The error message you get from that is a bit nicer than "Segmentation fault" when clients (or our tests) do things wrong. * Decreased the sleep time in iterate_all_wait from 20ms to 5ms. Everything seems to still work with 5ms, and this greatly decreases the amount of time spent per test run, making oomer run much faster. --- other/bootstrap_daemon/docker/tox-bootstrapd.sha256 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'other/bootstrap_daemon/docker/tox-bootstrapd.sha256') diff --git a/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 b/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 index 12c8c317..5287541b 100644 --- a/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 +++ b/other/bootstrap_daemon/docker/tox-bootstrapd.sha256 @@ -1 +1 @@ -c8bb5365e2cd01dab8d10a0d9c2e8f8e3be0996062151fbf95bf6304a0f1ecf1 /usr/local/bin/tox-bootstrapd +e7b6d31485b5e1561659be08f3e3ef003cef186042d7e0fe2ef48cf341932b5a /usr/local/bin/tox-bootstrapd -- cgit v1.2.3