From 2570ddcb17fdf5bea56c6bc1c5c2d04ba2068ee7 Mon Sep 17 00:00:00 2001 From: iphydf Date: Sat, 2 May 2020 20:49:41 +0100 Subject: Fix errors on error paths found by oomer. * Use-after-free because we free network before dht in one case. * Various unchecked allocs in tests (not so important). * We used to not check whether ping arrays were actually allocated in DHT. * `ping_kill` and `ping_array_kill` used to crash when passing NULL. Also: * Added an assert in all public API functions to ensure tox isn't NULL. The error message you get from that is a bit nicer than "Segmentation fault" when clients (or our tests) do things wrong. * Decreased the sleep time in iterate_all_wait from 20ms to 5ms. Everything seems to still work with 5ms, and this greatly decreases the amount of time spent per test run, making oomer run much faster. --- toxcore/util_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'toxcore/util_test.cc') diff --git a/toxcore/util_test.cc b/toxcore/util_test.cc index ff57f3fb..744c7745 100644 --- a/toxcore/util_test.cc +++ b/toxcore/util_test.cc @@ -1,9 +1,9 @@ #include "util.h" -#include "crypto_core.h" - #include +#include "crypto_core.h" + namespace { TEST(Util, TwoRandomIdsAreNotEqual) { -- cgit v1.2.3