switch instead of if

1 files changed, 6 insertions, 10 deletions

diff --git a/shopenscad.sh b/shopenscad.sh
index be1a9ec..3c71b1f 100755
--- a/shopenscad.sh
+++ b/shopenscad.sh
@@ -90,7 +90,6 @@ parse_options()
 
     SCAD_FILE="$*";
     [ -f "$SCAD_FILE" ] || die "$0: Needs an input scad file"
-
 }
 
 die() { printf 'Error: %s\n' "$*" >&2; exit 1; }
@@ -185,15 +184,12 @@ main()
 
     if [ "$PRINT_VARS" ]; then
         for k in "${scad_var_order[@]}"; do
-            # if the value is an OpenSCAD string, it needs to be wrapped in
-            # quotes
-            if [ '"' == "${SCAD[$k]:0:1}" ]; then
-                line="${k}='${SCAD[$k]}'"
-            elif [ "'" == "${SCAD[$k]:0:1}" ]; then
-                line=${k}="\"${SCAD[$k]}\""
-            else
-                line="${k}=${SCAD[$k]}"
-            fi
+            # Make sure quotes surround openscad strings
+            case "${SCAD[$k]:0:1}" in
+                \" ) line="${k}='${SCAD[$k]}'";;
+                \' ) line=${k}="\"${SCAD[$k]}\"";;
+                *  ) line="${k}=${SCAD[$k]}";;
+            esac
             echo $line
         done
         exit