Fix bug in screw tab placement

1 files changed, 10 insertions, 9 deletions

diff --git a/cubbies.scad b/cubbies.scad
index d7aa4f2..903c78d 100644
--- a/cubbies.scad
+++ b/cubbies.scad
@@ -126,12 +126,16 @@ module add_tabs ( length, male=true, between=false ) {
 
 module cubby_divider (depth, height) {
      function bracket_height () = thickness * 2;
+     screw_tab_width = 15;
+     screw_tab_height = 20;
+     screw_tab_thickness = thickness;
+
 
      divider_wall() {
+          position(TOP+FRONT+LEFT) screw_tab();
+          up(screw_tab_height) position(BOTTOM+FRONT+LEFT) screw_tab();
           attach(BOTTOM, TOP)  zrot(90) tab_bracket();
           attach(TOP, BOTTOM)  zrot(90) tab_bracket();
-          position(TOP+FRONT+LEFT) screw_tab();
-          up(bracket_height() * 2) position(BOTTOM+FRONT+LEFT) screw_tab();
      }
      children();
 
@@ -150,16 +154,13 @@ module cubby_divider (depth, height) {
      }
 
      module screw_tab () {
-          tab_width = 15;
-          tab_height = 20;
-          tab_thickness = thickness;
           difference() {
-               cuboid([tab_width, tab_thickness,tab_height], anchor=LEFT+TOP);
-               right(tab_width * (2 / 3)) zrot(90) yrot(90) {
+               cuboid([screw_tab_width, screw_tab_thickness,screw_tab_height], anchor=LEFT+TOP);
+               right(screw_tab_width * (2 / 3)) zrot(90) yrot(90) {
                     //right(#cyl(l=15, r=2, anchor=TOP+LEFT);
                     //right(tab_height - 5)  #cyl(l=15, r=2, anchor=LEFT);
-                    right(tab_height * (1 / 3)) #cyl(l=15, r=2, anchor=RIGHT);
-                    right(tab_height * (2 / 3)) #cyl(l=15, r=2, anchor=LEFT);
+                    right(screw_tab_height * (1 / 3)) #cyl(l=15, r=2, anchor=RIGHT);
+                    right(screw_tab_height * (2 / 3)) #cyl(l=15, r=2, anchor=LEFT);
                }
 
           }