diff options
author | Joshua MacDonald <josh.macdonald@gmail.com> | 2015-12-12 21:27:26 -0800 |
---|---|---|
committer | Joshua MacDonald <josh.macdonald@gmail.com> | 2015-12-12 21:27:26 -0800 |
commit | 8b44e76ba3282ebbbc7251faad24fb6235da346c (patch) | |
tree | 6de840d5959fb4f3484b2690845c14ff1e6dac0b /xdelta3 | |
parent | c362b118eaeffa62b273b56d10715ab61f49fd9d (diff) |
Comment on performance regression
Diffstat (limited to 'xdelta3')
-rw-r--r-- | xdelta3/xdelta3.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xdelta3/xdelta3.c b/xdelta3/xdelta3.c index 0bf2d77..7476b3a 100644 --- a/xdelta3/xdelta3.c +++ b/xdelta3/xdelta3.c | |||
@@ -4388,8 +4388,10 @@ xd3_srcwin_move_point (xd3_stream *stream, usize_t *next_move_point) | |||
4388 | * compression where data is deleted near the beginning of the file. | 4388 | * compression where data is deleted near the beginning of the file. |
4389 | * | 4389 | * |
4390 | * The new policy is slower and may benefit, or slightly worsen, | 4390 | * The new policy is slower and may benefit, or slightly worsen, |
4391 | * compression performance. TODO test these changes in 3.0.10 to | 4391 | * compression performance. As shown by go/src/regtest.go (see the |
4392 | * 3.0.11 releases. */ | 4392 | * 64bithash branch), this policy does worsen compression, somewhat |
4393 | * more significantly than hoped for. TODO revert. | ||
4394 | */ | ||
4393 | if (absolute_input_pos < stream->src->max_winsize / 2) | 4395 | if (absolute_input_pos < stream->src->max_winsize / 2) |
4394 | { | 4396 | { |
4395 | target_cksum_pos = stream->src->max_winsize; | 4397 | target_cksum_pos = stream->src->max_winsize; |