Option to show full URL when hovering on a link

The URL is shown in the bottom of the page.

IssueID #64

6 files changed, 18 insertions, 8 deletions

diff --git a/res/about/version.gmi b/res/about/version.gmi
index 188b56bd..3f11642d 100644
--- a/res/about/version.gmi
+++ b/res/about/version.gmi
@@ -10,6 +10,7 @@
 * Added identity importing: existing client certificates in PEM format can be imported from the current page, from clipboard, or from drag-and-dropped files.
 * Added a bold UI font. It is used for unread feed entries and default dialog buttons.
 * Added support for Finger links (courtesy of John Cowan).
+* Added option to show full link URL when hovering on it.
 * Remote bookmarks are grouped under their source in the bookmark list.
 * A bookmark's icon is updated after loading the page so it matches the site.
 * Quote border line shows up on empty quote lines, too.
diff --git a/src/app.c b/src/app.c
index 01f62bba..05739f0a 100644
--- a/src/app.c
+++ b/src/app.c
@@ -198,7 +198,7 @@ static iString *serializePrefs_App_(const iApp *d) {
     appendFormat_String(str, "prefs.biglede.changed arg:%d\n", d->prefs.bigFirstParagraph);
     appendFormat_String(str, "prefs.sideicon.changed arg:%d\n", d->prefs.sideIcon);
     appendFormat_String(str, "quoteicon.set arg:%d\n", d->prefs.quoteIcon ? 1 : 0);
-    appendFormat_String(str, "prefs.hoveroutline.changed arg:%d\n", d->prefs.hoverOutline);
+    appendFormat_String(str, "prefs.hoverlink.changed arg:%d\n", d->prefs.hoverLink);
     appendFormat_String(str, "theme.set arg:%d auto:1\n", d->prefs.theme);
     appendFormat_String(str, "ostheme arg:%d\n", d->prefs.useSystemTheme);
     appendFormat_String(str, "doctheme.dark.set arg:%d\n", d->prefs.docThemeDark);
@@ -1129,8 +1129,8 @@ iBool handleCommand_App(const char *cmd) {
         postRefresh_App();
         return iTrue;
     }
-    else if (equal_Command(cmd, "prefs.hoveroutline.changed")) {
-        d->prefs.hoverOutline = arg_Command(cmd) != 0;
+    else if (equal_Command(cmd, "prefs.hoverlink.changed")) {
+        d->prefs.hoverLink = arg_Command(cmd) != 0;
         postRefresh_App();
         return iTrue;
     }
@@ -1273,7 +1273,7 @@ iBool handleCommand_App(const char *cmd) {
         iWidget *dlg = makePreferences_Widget();
         updatePrefsThemeButtons_(dlg);
         setText_InputWidget(findChild_Widget(dlg, "prefs.downloads"), &d->prefs.downloadDir);
-        setToggle_Widget(findChild_Widget(dlg, "prefs.hoveroutline"), d->prefs.hoverOutline);
+        setToggle_Widget(findChild_Widget(dlg, "prefs.hoverlink"), d->prefs.hoverLink);
         setToggle_Widget(findChild_Widget(dlg, "prefs.smoothscroll"), d->prefs.smoothScrolling);
         setToggle_Widget(findChild_Widget(dlg, "prefs.imageloadscroll"), d->prefs.loadImageInsteadOfScrolling);
         setToggle_Widget(findChild_Widget(dlg, "prefs.ostheme"), d->prefs.useSystemTheme);
diff --git a/src/prefs.c b/src/prefs.c
index 31ffe03b..188938a2 100644
--- a/src/prefs.c
+++ b/src/prefs.c
@@ -30,7 +30,7 @@ void init_Prefs(iPrefs *d) {
     d->uiScale           = 1.0f; /* default set elsewhere */
     d->zoomPercent       = 100;
     d->sideIcon          = iTrue;
-    d->hoverOutline      = iFalse;
+    d->hoverLink         = iTrue;
     d->smoothScrolling   = iTrue;
     d->loadImageInsteadOfScrolling = iFalse;
     d->decodeUserVisibleURLs = iTrue;
diff --git a/src/prefs.h b/src/prefs.h
index e95a32da..07298eac 100644
--- a/src/prefs.h
+++ b/src/prefs.h
@@ -44,7 +44,7 @@ struct Impl_Prefs {
     iBool            sideIcon;
     /* Behavior */
     iString          downloadDir;
-    iBool            hoverOutline;
+    iBool            hoverLink;
     iBool            smoothScrolling;
     iBool            loadImageInsteadOfScrolling;
     /* Network */
diff --git a/src/ui/documentwidget.c b/src/ui/documentwidget.c
index 78624c7a..9d284840 100644
--- a/src/ui/documentwidget.c
+++ b/src/ui/documentwidget.c
@@ -3194,6 +3194,15 @@ static void draw_DocumentWidget_(const iDocumentWidget *d) {
                        tmBackground_ColorId);
     }
     drawSideElements_DocumentWidget_(d);
+    if (prefs_App()->hoverLink && d->hoverLink) {
+        const int      font     = uiLabel_FontId;
+        const iRangecc linkUrl  = range_String(linkUrl_GmDocument(d->doc, d->hoverLink->linkId));
+        const iInt2    size     = measureRange_Text(font, linkUrl);
+        const iRect    linkRect = { addY_I2(bottomLeft_Rect(bounds), -size.y),
+                                    addX_I2(size, 2 * gap_UI) };
+        fillRect_Paint(&ctx.paint, linkRect, tmBackground_ColorId);
+        drawRange_Text(font, addX_I2(topLeft_Rect(linkRect), gap_UI), tmParagraph_ColorId, linkUrl);
+    }
     draw_Widget(w);
 }
 
diff --git a/src/ui/util.c b/src/ui/util.c
index fd297ce2..6615a454 100644
--- a/src/ui/util.c
+++ b/src/ui/util.c
@@ -1043,8 +1043,8 @@ iWidget *makePreferences_Widget(void) {
         appendTwoColumnPage_(tabs, "General", '1', &headings, &values);
         addChild_Widget(headings, iClob(makeHeading_Widget("Downloads folder:")));
         setId_Widget(addChild_Widget(values, iClob(new_InputWidget(0))), "prefs.downloads");
-        /*addChild_Widget(headings, iClob(makeHeading_Widget("Outline on scrollbar:")));
-        addChild_Widget(values, iClob(makeToggle_Widget("prefs.hoveroutline")));*/
+        addChild_Widget(headings, iClob(makeHeading_Widget("Full link on hover:")));
+        addChild_Widget(values, iClob(makeToggle_Widget("prefs.hoverlink")));
         addChild_Widget(headings, iClob(makeHeading_Widget("Smooth scrolling:")));
         addChild_Widget(values, iClob(makeToggle_Widget("prefs.smoothscroll")));
         addChild_Widget(headings, iClob(makeHeading_Widget("Load image on scroll:")));