Keeping track of current UI root

The current UI root should always be set explicitly before the UI
is accessed.

4 files changed, 26 insertions, 7 deletions

diff --git a/src/app.c b/src/app.c
index cefb707d..675edf4c 100644
--- a/src/app.c
+++ b/src/app.c
@@ -392,6 +392,7 @@ static iBool loadState_App_(iApp *d) {
             printf("%s: unsupported version\n", cstr_String(path_File(f)));
             return iFalse;
         }
+        setCurrent_Root(&d->window->root);
         setVersion_Stream(stream_File(f), version);
         iDocumentWidget *doc = document_App();
         iDocumentWidget *current = NULL;
@@ -409,10 +410,12 @@ static iBool loadState_App_(iApp *d) {
             }
             else {
                 printf("%s: unrecognized data\n", cstr_String(path_File(f)));
+                setCurrent_Root(NULL);
                 return iFalse;
             }
         }
         postCommandf_App("tabs.switch page:%p", current);
+        setCurrent_Root(NULL);
         return iTrue;
     }
     return iFalse;
@@ -436,12 +439,14 @@ static void saveState_App_(const iApp *d) {
     if (open_File(f, writeOnly_FileMode)) {
         writeData_File(f, magicState_App_, 4);
         writeU32_File(f, latest_FileVersion); /* version */
+        setCurrent_Root(&d->window->root);
         iConstForEach(ObjectList, i, iClob(listDocuments_App())) {
             iAssert(isInstance_Object(i.object, &Class_DocumentWidget));
             writeData_File(f, magicTabDocument_App_, 4);
             write8_File(f, document_App() == i.object ? 1 : 0);
             serializeState_DocumentWidget(i.object, stream_File(f));
         }
+        setCurrent_Root(NULL);
     }
     else {
         fprintf(stderr, "[App] failed to save state: %s\n", strerror(errno));
@@ -1082,12 +1087,14 @@ static void runTickers_App_(iApp *d) {
     iSortedArray *pending = copy_SortedArray(&d->tickers);
     clear_SortedArray(&d->tickers);
     postRefresh_App();
+    setCurrent_Root(&d->window->root); /* TODO: Each ticker has its own root. */
     iConstForEach(Array, i, &pending->values) {
         const iTicker *ticker = i.value;
         if (ticker->callback) {
             ticker->callback(ticker->context);
         }
     }
+    setCurrent_Root(NULL);
     delete_SortedArray(pending);
     if (isEmpty_SortedArray(&d->tickers)) {
         d->lastTickerTime = 0;
@@ -1121,6 +1128,7 @@ static int run_App_(iApp *d) {
 #endif
     while (d->isRunning) {
         processEvents_App(waitForNewEvents_AppEventMode);
+        setCurrent_Root(NULL);
         runTickers_App_(d);
         refresh_App();
         recycle_Garbage();
diff --git a/src/periodic.c b/src/periodic.c
index 9e9dfdba..ab3b66e6 100644
--- a/src/periodic.c
+++ b/src/periodic.c
@@ -22,6 +22,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
 
 #include "periodic.h"
 #include "ui/widget.h"
+#include "ui/window.h"
 #include "app.h"
 
 #include <the_Foundation/string.h>
@@ -64,6 +65,7 @@ iBool dispatchCommands_Periodic(iPeriodic *d) {
     d->lastPostTime = now;
     iBool wasPosted = iFalse;
     lock_Mutex(d->mutex);
+    setCurrent_Root(&get_Window()->root);
     iConstForEach(Array, i, &d->commands.values) {
         const iPeriodicCommand *pc = i.value;
         const SDL_UserEvent ev = {
@@ -75,6 +77,7 @@ iBool dispatchCommands_Periodic(iPeriodic *d) {
         dispatchEvent_Widget(pc->context, (const SDL_Event *) &ev);
         wasPosted = iTrue;
     }
+    setCurrent_Root(NULL);
     unlock_Mutex(d->mutex);
     return wasPosted;
 }
diff --git a/src/ui/root.c b/src/ui/root.c
index 1fa36851..bd7d07a1 100644
--- a/src/ui/root.c
+++ b/src/ui/root.c
@@ -251,10 +251,12 @@ void setCurrent_Root(iRoot *root) {
 }
 
 iRoot *get_Root(void) {
+    iAssert(activeRoot_);
     return activeRoot_;
 }
 
 void destroyPending_Root(iRoot *d) {
+    setCurrent_Root(d);    
     iForEach(PtrSet, i, d->pendingDestruction) {
         iWidget *widget = *i.value;
         if (!isFinished_Anim(&widget->visualOffset)) {
@@ -267,6 +269,7 @@ void destroyPending_Root(iRoot *d) {
         iRelease(widget);
         remove_PtrSetIterator(&i);
     }
+    setCurrent_Root(NULL);
 }
 
 iPtrArray *onTop_Root(iRoot *d) {
diff --git a/src/ui/window.c b/src/ui/window.c
index 627f16b1..1e98b167 100644
--- a/src/ui/window.c
+++ b/src/ui/window.c
@@ -167,6 +167,7 @@ static void setupUserInterface_Window(iWindow *d) {
 #endif
     setCurrent_Root(&d->root);
     createUserInterface_Root(&d->root);
+    setCurrent_Root(NULL);
 }
 
 static void updateRootSize_Window_(iWindow *d, iBool notifyAlways) {
@@ -449,19 +450,21 @@ void init_Window(iWindow *d, iRect rect) {
 }
 
 void deinit_Window(iWindow *d) {
+    setCurrent_Root(&d->root);
     iRecycle();
     if (theWindow_ == d) {
         theWindow_ = NULL;
     }
+    deinit_Root(&d->root);
+    setCurrent_Root(NULL);
+    deinit_Text();
+    SDL_DestroyRenderer(d->render);
+    SDL_DestroyWindow(d->win);
     iForIndices(i, d->cursors) {
         if (d->cursors[i]) {
             SDL_FreeCursor(d->cursors[i]);
         }
     }
-    deinit_Root(&d->root);
-    deinit_Text();
-    SDL_DestroyRenderer(d->render);
-    SDL_DestroyWindow(d->win);
 }
 
 SDL_Renderer *renderer_Window(const iWindow *d) {
@@ -766,6 +769,7 @@ iBool processEvent_Window(iWindow *d, const SDL_Event *ev) {
                 event.button.x = pos.x;
                 event.button.y = pos.y;
             }
+            setCurrent_Root(&d->root);
             iWidget *widget = d->root.widget;
             if (event.type == SDL_MOUSEMOTION || event.type == SDL_MOUSEWHEEL ||
                 event.type == SDL_MOUSEBUTTONUP || event.type == SDL_MOUSEBUTTONDOWN) {
@@ -866,10 +870,11 @@ void draw_Window(iWindow *d) {
     /* Draw widgets. */
     d->frameTime = SDL_GetTicks();
     if (isExposed_Window(d)) {
+        setCurrent_Root(&d->root);
         draw_Widget(d->root.widget);
 #if defined (LAGRANGE_ENABLE_CUSTOM_FRAME)
         /* App icon. */
-        const iWidget *appIcon = findChild_Widget(d->root, "winbar.icon");
+        const iWidget *appIcon = findChild_Widget(d->root.widget, "winbar.icon");
         if (isVisible_Widget(appIcon)) {
             const int   size    = appIconSize_();
             const iRect rect    = bounds_Widget(appIcon);
@@ -885,11 +890,11 @@ void draw_Window(iWindow *d) {
                 &(SDL_Rect){ left_Rect(rect) + gap_UI * 1.25f, mid.y - size / 2, size, size });
         }
 #endif
+        setCurrent_Root(NULL);
     }
 #if 0
     /* Text cache debugging. */ {
-        SDL_Texture *cache = glyphCache_Text();
-        SDL_Rect rect = { d->root->rect.size.x - 640, 0, 640, 2.5 * 640 };
+        SDL_Rect rect = { d->root.widget->rect.size.x - 640, 0, 640, 2.5 * 640 };
         SDL_SetRenderDrawColor(d->render, 0, 0, 0, 255);
         SDL_RenderFillRect(d->render, &rect);
         SDL_RenderCopy(d->render, glyphCache_Text(), NULL, &rect);