Bookmarks: Finding a bookmark by URL

This needs a better lookup if there are tons of bookmarks.

2 files changed, 13 insertions, 1 deletions

diff --git a/src/bookmarks.c b/src/bookmarks.c
index 7e98fb27..f97ef0c6 100644
--- a/src/bookmarks.c
+++ b/src/bookmarks.c
@@ -54,7 +54,7 @@ static const char *fileName_Bookmarks_ = "bookmarks.txt";
 struct Impl_Bookmarks {
     iMutex *mtx;
     int     idEnum;
-    iHash   bookmarks;
+    iHash   bookmarks; /* bookmark ID is the hash key */
 };
 
 iDefineTypeConstruction(Bookmarks)
@@ -173,6 +173,17 @@ iBool filterTagsRegExp_Bookmarks(void *regExp, const iBookmark *bm) {
     return matchString_RegExp(regExp, &bm->tags, &m);
 }
 
+static iBool matchUrl_(void *url, const iBookmark *bm) {
+    return equalCase_String(url, &bm->url);
+}
+
+uint32_t findUrl_Bookmarks(const iBookmarks *d, const iString *url) {
+    /* TODO: O(n), boo */
+    const iPtrArray *found = list_Bookmarks(d, NULL, matchUrl_, (void *) url);
+    if (isEmpty_PtrArray(found)) return 0;
+    return id_Bookmark(constFront_PtrArray(found));
+}
+
 const iPtrArray *list_Bookmarks(const iBookmarks *d, iBookmarksCompareFunc cmp,
                                 iBookmarksFilterFunc filter, void *context) {
     lock_Mutex(d->mtx);
diff --git a/src/bookmarks.h b/src/bookmarks.h
index 4889e7b5..84bdbd68 100644
--- a/src/bookmarks.h
+++ b/src/bookmarks.h
@@ -51,6 +51,7 @@ void    save_Bookmarks      (const iBookmarks *, const char *dirPath);
 void    add_Bookmarks       (iBookmarks *, const iString *url, const iString *title, const iString *tags, iChar icon);
 iBool   remove_Bookmarks    (iBookmarks *, uint32_t id);
 iBookmark *get_Bookmarks    (iBookmarks *, uint32_t id);
+uint32_t findUrl_Bookmarks  (const iBookmarks *, const iString *url); /* O(n) */
 
 typedef iBool (*iBookmarksFilterFunc) (void *context, const iBookmark *);
 typedef int   (*iBookmarksCompareFunc)(const iBookmark **, const iBookmark **);