summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJaakko Keränen <jaakko.keranen@iki.fi>2021-11-29 18:24:25 +0200
committerJaakko Keränen <jaakko.keranen@iki.fi>2021-11-29 18:24:25 +0200
commit8320401d3b32ef400072106eedb3c75367e1a12b (patch)
tree64a8c608ab7ac9684981f306971273a3384cb35e
parent6f8a62955d9faf2b8f5b498852962e5e8f509001 (diff)
Fixed crash when creating a bookmark
The parent folder pointer was possibly uninitialized.
-rw-r--r--src/ui/sidebarwidget.c1
-rw-r--r--src/ui/util.c4
2 files changed, 4 insertions, 1 deletions
diff --git a/src/ui/sidebarwidget.c b/src/ui/sidebarwidget.c
index 550fccde..844f6d7c 100644
--- a/src/ui/sidebarwidget.c
+++ b/src/ui/sidebarwidget.c
@@ -927,6 +927,7 @@ static void itemClicked_SidebarWidget_(iSidebarWidget *d, iSidebarItem *item, si
927 } 927 }
928 else { 928 else {
929 insert_IntSet(d->closedFolders, item->id); 929 insert_IntSet(d->closedFolders, item->id);
930 setRecentFolder_Bookmarks(bookmarks_App(), 0);
930 } 931 }
931 updateItems_SidebarWidget_(d); 932 updateItems_SidebarWidget_(d);
932 break; 933 break;
diff --git a/src/ui/util.c b/src/ui/util.c
index baa05082..84de4b74 100644
--- a/src/ui/util.c
+++ b/src/ui/util.c
@@ -2862,8 +2862,10 @@ iWidget *makeBookmarkEditor_Widget(void) {
2862 constData_Array(folderItems), 2862 constData_Array(folderItems),
2863 size_Array(folderItems))), alignLeft_WidgetFlag), 2863 size_Array(folderItems))), alignLeft_WidgetFlag),
2864 "bmed.folder"); 2864 "bmed.folder");
2865 const uint32_t recentFolderId = recentFolder_Bookmarks(bookmarks_App());
2865 updateDropdownSelection_LabelWidget( 2866 updateDropdownSelection_LabelWidget(
2866 folderButton, format_CStr(" arg:%u", recentFolder_Bookmarks(bookmarks_App()))); 2867 folderButton, format_CStr(" arg:%u", recentFolderId));
2868 setUserData_Object(folderButton, get_Bookmarks(bookmarks_App(), recentFolderId));
2867 } 2869 }
2868 addDialogInputWithHeading_(headings, values, "${dlg.bookmark.tags}", "bmed.tags", iClob(inputs[2] = new_InputWidget(0))); 2870 addDialogInputWithHeading_(headings, values, "${dlg.bookmark.tags}", "bmed.tags", iClob(inputs[2] = new_InputWidget(0)));
2869 addDialogInputWithHeading_(headings, values, "${dlg.bookmark.icon}", "bmed.icon", iClob(inputs[3] = new_InputWidget(1))); 2871 addDialogInputWithHeading_(headings, values, "${dlg.bookmark.icon}", "bmed.icon", iClob(inputs[3] = new_InputWidget(1)));