Fixed page timestamp; 24-hour time preference

IssueID #349

31 files changed, 36 insertions, 2 deletions

diff --git a/po/en.po b/po/en.po
index b8dc8964..b95d3c5a 100644
--- a/po/en.po
+++ b/po/en.po
@@ -1379,6 +1379,9 @@ msgstr "Orange"
 msgid "prefs.uilang"
 msgstr "Language:"
 
+msgid "prefs.time.24h"
+msgstr "24-Hour Time"
+
 msgid "prefs.uiscale"
 msgstr "UI scale factor:"
 
diff --git a/res/about/version.gmi b/res/about/version.gmi
index 61ea4476..c510d07a 100644
--- a/res/about/version.gmi
+++ b/res/about/version.gmi
@@ -7,6 +7,8 @@
 # Release notes
 
 ## 1.9.1
+* Added "24-Hour Time" preference.
+* Fixed drawing the page timestamp (bottom left corner) that was always hidden.
 * Heading level 3 is indented like regular text lines, making the difference to level 2 evident.
 
 ## 1.9
diff --git a/res/lang/cs.bin b/res/lang/cs.bin
index ebeb9323..beb44264 100644
--- a/res/lang/cs.bin
+++ b/res/lang/cs.bin
diff --git a/res/lang/de.bin b/res/lang/de.bin
index 5ed89b6e..2bd48e02 100644
--- a/res/lang/de.bin
+++ b/res/lang/de.bin
diff --git a/res/lang/en.bin b/res/lang/en.bin
index b9535bb1..2e95dd20 100644
--- a/res/lang/en.bin
+++ b/res/lang/en.bin
diff --git a/res/lang/eo.bin b/res/lang/eo.bin
index 134ef668..f9dc80e6 100644
--- a/res/lang/eo.bin
+++ b/res/lang/eo.bin
diff --git a/res/lang/es.bin b/res/lang/es.bin
index ef450137..29d94600 100644
--- a/res/lang/es.bin
+++ b/res/lang/es.bin
diff --git a/res/lang/es_MX.bin b/res/lang/es_MX.bin
index aac305ba..2d6ea258 100644
--- a/res/lang/es_MX.bin
+++ b/res/lang/es_MX.bin
diff --git a/res/lang/fi.bin b/res/lang/fi.bin
index bf5772dc..631a6497 100644
--- a/res/lang/fi.bin
+++ b/res/lang/fi.bin
diff --git a/res/lang/fr.bin b/res/lang/fr.bin
index bc332333..8d292ef8 100644
--- a/res/lang/fr.bin
+++ b/res/lang/fr.bin
diff --git a/res/lang/gl.bin b/res/lang/gl.bin
index 029e3533..ec7e0502 100644
--- a/res/lang/gl.bin
+++ b/res/lang/gl.bin
diff --git a/res/lang/hu.bin b/res/lang/hu.bin
index d00d1b44..d4dc0811 100644
--- a/res/lang/hu.bin
+++ b/res/lang/hu.bin
diff --git a/res/lang/ia.bin b/res/lang/ia.bin
index 0c80ba38..43b8e871 100644
--- a/res/lang/ia.bin
+++ b/res/lang/ia.bin
diff --git a/res/lang/ie.bin b/res/lang/ie.bin
index d0b05aaa..79f370d2 100644
--- a/res/lang/ie.bin
+++ b/res/lang/ie.bin
diff --git a/res/lang/isv.bin b/res/lang/isv.bin
index 65581678..2af9a9d7 100644
--- a/res/lang/isv.bin
+++ b/res/lang/isv.bin
diff --git a/res/lang/pl.bin b/res/lang/pl.bin
index 6f67a909..9e1590a6 100644
--- a/res/lang/pl.bin
+++ b/res/lang/pl.bin
diff --git a/res/lang/ru.bin b/res/lang/ru.bin
index 88f89856..1fbd1097 100644
--- a/res/lang/ru.bin
+++ b/res/lang/ru.bin
diff --git a/res/lang/sk.bin b/res/lang/sk.bin
index de3772c9..b4603c7d 100644
--- a/res/lang/sk.bin
+++ b/res/lang/sk.bin
diff --git a/res/lang/sr.bin b/res/lang/sr.bin
index 743909a6..2e8d131c 100644
--- a/res/lang/sr.bin
+++ b/res/lang/sr.bin
diff --git a/res/lang/tok.bin b/res/lang/tok.bin
index 89314f0f..582b24de 100644
--- a/res/lang/tok.bin
+++ b/res/lang/tok.bin
diff --git a/res/lang/tr.bin b/res/lang/tr.bin
index 7463b776..d7788667 100644
--- a/res/lang/tr.bin
+++ b/res/lang/tr.bin
diff --git a/res/lang/uk.bin b/res/lang/uk.bin
index 80ed9cb4..62d480a7 100644
--- a/res/lang/uk.bin
+++ b/res/lang/uk.bin
diff --git a/res/lang/zh_Hans.bin b/res/lang/zh_Hans.bin
index 1a8dc868..0b9b3360 100644
--- a/res/lang/zh_Hans.bin
+++ b/res/lang/zh_Hans.bin
diff --git a/res/lang/zh_Hant.bin b/res/lang/zh_Hant.bin
index 344bd848..b6e7b5d0 100644
--- a/res/lang/zh_Hant.bin
+++ b/res/lang/zh_Hant.bin
diff --git a/src/app.c b/src/app.c
index 75e37a0b..a2de03ca 100644
--- a/src/app.c
+++ b/src/app.c
@@ -240,6 +240,7 @@ static iString *serializePrefs_App_(const iApp *d) {
         const char * id;
         const iBool *value;
     } boolPrefs[] = {
+        { "prefs.time.24h", &d->prefs.time24h },
         { "prefs.animate", &d->prefs.uiAnimations },
         { "prefs.font.smooth", &d->prefs.fontSmoothing },
         { "prefs.mono.gemini", &d->prefs.monospaceGemini },
@@ -2573,6 +2574,10 @@ iBool handleCommand_App(const char *cmd) {
         d->prefs.uiAnimations = arg_Command(cmd) != 0;
         return iTrue;
     }
+    else if (equal_Command(cmd, "prefs.time.24h.changed")) {
+        d->prefs.time24h = arg_Command(cmd) != 0;
+        return iTrue;
+    }
     else if (equal_Command(cmd, "saturation.set")) {
         d->prefs.saturation = (float) arg_Command(cmd) / 100.0f;
         if (!isFrozen) {
@@ -2892,6 +2897,7 @@ iBool handleCommand_App(const char *cmd) {
         updateScrollSpeedButtons_(dlg, mouse_ScrollType, d->prefs.smoothScrollSpeed[mouse_ScrollType]);
         updateScrollSpeedButtons_(dlg, keyboard_ScrollType, d->prefs.smoothScrollSpeed[keyboard_ScrollType]);
         updateDropdownSelection_LabelWidget(findChild_Widget(dlg, "prefs.uilang"), cstr_String(&d->prefs.strings[uiLanguage_PrefsString]));
+        setToggle_Widget(findChild_Widget(dlg, "prefs.time.24h"), d->prefs.time24h);
         updateDropdownSelection_LabelWidget(
             findChild_Widget(dlg, "prefs.returnkey"),
             format_CStr("returnkey.set arg:%d", d->prefs.returnKey));
diff --git a/src/lang.c b/src/lang.c
index 905601ca..831fa58f 100644
--- a/src/lang.c
+++ b/src/lang.c
@@ -22,6 +22,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
 
 #include "lang.h"
 #include "resources.h"
+#include "prefs.h"
+#include "app.h"
 
 #include <the_Foundation/sortedarray.h>
 #include <the_Foundation/string.h>
@@ -261,3 +263,17 @@ const char *format_Lang(const char *formatTextWithIds, ...) {
     va_end(args);
     return cstr_Block(collect_Block(msg));
 }
+
+iString *timeFormatHourPreference_Lang(const char *formatMsgId) {
+    iString *str = newCStr_String(cstr_Lang(formatMsgId));
+    translate_Lang(str);
+    if (prefs_App()->time24h) {
+        replace_String(str, "%I", "%H");
+        replace_String(str, " %p", "");
+        replace_String(str, "%p", "");
+    }
+    else {
+        replace_String(str, "%H:%M", "%I:%M %p");
+    }
+    return str;
+}
diff --git a/src/lang.h b/src/lang.h
index e3e6c433..8ed5eca9 100644
--- a/src/lang.h
+++ b/src/lang.h
@@ -40,3 +40,5 @@ const char *    cstrCount_Lang      (const char *msgId, int count);
 const char *    formatCStr_Lang     (const char *formatMsgId, int count);
 const char *    formatCStrs_Lang    (const char *formatMsgId, size_t count);
 const char *    format_Lang         (const char *formatTextWithIds, ...);
+
+iString *   timeFormatHourPreference_Lang   (const char *formatMsgId);
diff --git a/src/prefs.c b/src/prefs.c
index 956a75ae..10df9ade 100644
--- a/src/prefs.c
+++ b/src/prefs.c
@@ -43,6 +43,7 @@ void init_Prefs(iPrefs *d) {
     d->sideIcon          = iTrue;
     d->hideToolbarOnScroll = iTrue;
     d->pinSplit          = 1;
+    d->time24h           = iTrue;
     d->returnKey         = default_ReturnKeyBehavior;
     d->hoverLink         = iFalse;
     d->smoothScrolling   = iTrue;
diff --git a/src/prefs.h b/src/prefs.h
index d7712c9d..2fbff9de 100644
--- a/src/prefs.h
+++ b/src/prefs.h
@@ -73,6 +73,7 @@ struct Impl_Prefs {
     iBool            sideIcon;
     iBool            hideToolbarOnScroll;
     int              pinSplit; /* 0: no pinning, 1: left doc, 2: right doc */
+    iBool            time24h;
     /* Behavior */
     int              returnKey;
     iBool            hoverLink;
diff --git a/src/ui/documentwidget.c b/src/ui/documentwidget.c
index c41c77d6..aac77572 100644
--- a/src/ui/documentwidget.c
+++ b/src/ui/documentwidget.c
@@ -1038,10 +1038,12 @@ static void updateTimestampBuf_DocumentWidget_(const iDocumentWidget *d) {
         d->drawBufs->timestampBuf = NULL;
     }
     if (isValid_Time(&d->sourceTime)) {
+        iString *fmt = timeFormatHourPreference_Lang("page.timestamp");
         d->drawBufs->timestampBuf = newRange_TextBuf(
             uiLabel_FontId,
             white_ColorId,
-            range_String(collect_String(format_Time(&d->sourceTime, cstr_Lang("page.timestamp")))));
+            range_String(collect_String(format_Time(&d->sourceTime, cstr_String(fmt)))));
+        delete_String(fmt);
     }
     d->drawBufs->flags &= ~updateTimestampBuf_DrawBufsFlag;
 }
@@ -4792,7 +4794,7 @@ static void drawSideElements_DocumentWidget_(const iDocumentWidget *d) {
                 bottomLeft_Rect(bounds),
                 init_I2(margin,
                         -margin + -dbuf->timestampBuf->size.y +
-                            iMax(0, d->scrollY.max + viewPos_DocumentWidget_(d)))),
+                            iMax(0, d->scrollY.max - pos_SmoothScroll(&d->scrollY)))),
             tmQuoteIcon_ColorId);
     }
     unsetClip_Paint(&p);
diff --git a/src/ui/util.c b/src/ui/util.c
index 57fa9f3d..baa05082 100644
--- a/src/ui/util.c
+++ b/src/ui/util.c
@@ -2507,6 +2507,7 @@ iWidget *makePreferences_Widget(void) {
                                               alignLeft_WidgetFlag),
                          "prefs.uilang");
         }
+        addDialogToggle_(headings, values, "${prefs.time.24h}", "prefs.time.24h");
     }
     /* User Interface. */ {
         appendTwoColumnTabPage_Widget(tabs, "${heading.prefs.interface}", '2', &headings, &values);