Cleanup

Warnings about lost precision.

14 files changed, 22 insertions, 21 deletions

diff --git a/src/audio/player.c b/src/audio/player.c
index bf853e3f..de430b17 100644
--- a/src/audio/player.c
+++ b/src/audio/player.c
@@ -192,7 +192,7 @@ static enum iDecoderStatus decodeVorbis_Decoder_(iDecoder *d) {
         int error;
         int consumed;
         d->vorbis = stb_vorbis_open_pushdata(
-            constData_Block(input), size_Block(input), &consumed, &error, NULL);
+            constData_Block(input), (int) size_Block(input), &consumed, &error, NULL);
         if (!d->vorbis) {
             return needMoreInput_DecoderStatus;
         }
@@ -225,7 +225,7 @@ static enum iDecoderStatus decodeVorbis_Decoder_(iDecoder *d) {
         lock_Mutex(&d->input->mtx);
         d->totalInputSize = size_Block(input);
         int error = 0;
-        stb_vorbis *vrb = stb_vorbis_open_memory(constData_Block(input), size_Block(input),
+        stb_vorbis *vrb = stb_vorbis_open_memory(constData_Block(input), (int) size_Block(input),
                                                  &error, NULL);
         if (vrb) {
             d->totalSamples = stb_vorbis_stream_length_in_samples(vrb);
diff --git a/src/feeds.c b/src/feeds.c
index b7ce739b..7fe13617 100644
--- a/src/feeds.c
+++ b/src/feeds.c
@@ -437,7 +437,7 @@ static iThreadResult fetch_Feeds_(iThread *thread) {
     iZap(work);
     iBool gotNew = iFalse;
     postCommand_App("feeds.update.started");
-    const int totalJobs = size_PtrArray(&d->jobs);
+    const size_t totalJobs = size_PtrArray(&d->jobs);
     int numFinishedJobs = 0;
     while (!d->stopWorker) {
         /* Start new jobs. */
@@ -476,7 +476,7 @@ static iThreadResult fetch_Feeds_(iThread *thread) {
             }
         }
         if (doNotify) {
-            postCommandf_App("feeds.update.progress arg:%d total:%d", numFinishedJobs, totalJobs);
+            postCommandf_App("feeds.update.progress arg:%d total:%zu", numFinishedJobs, totalJobs);
         }
         /* Stop if everything has finished. */
         if (ongoing == 0 && isEmpty_PtrArray(&d->jobs)) {
@@ -614,7 +614,7 @@ static void load_Feeds_(iFeeds *d) {
                     /* TODO: Cleanup needed...
                        All right, this could maybe use a bit more robust, structured format.
                        The code below is messy. */
-                    const uint32_t feedId = strtoul(line.start, NULL, 16);
+                    const uint32_t feedId = (uint32_t) strtoul(line.start, NULL, 16);
                     if (!nextSplit_Rangecc(range_Block(src), "\n", &line)) {
                         goto aborted;
                     }
diff --git a/src/gmcerts.c b/src/gmcerts.c
index ed4759be..8f7bf181 100644
--- a/src/gmcerts.c
+++ b/src/gmcerts.c
@@ -90,7 +90,7 @@ void serialize_GmIdentity(const iGmIdentity *d, iStream *outs) {
     writeU32_Stream(outs, d->icon);
     serialize_String(&d->notes, outs);
     write32_Stream(outs, d->flags);
-    writeU32_Stream(outs, size_StringSet(d->useUrls));
+    writeU32_Stream(outs, (uint32_t) size_StringSet(d->useUrls));
     iConstForEach(StringSet, i, d->useUrls) {
         serialize_String(i.value, outs);
     }
diff --git a/src/gmrequest.c b/src/gmrequest.c
index 23845475..a9c5919d 100644
--- a/src/gmrequest.c
+++ b/src/gmrequest.c
@@ -790,7 +790,8 @@ void submit_GmRequest(iGmRequest *d) {
                                                 cstr_String(containerUrl));
                             appendFormat_String(page, "# %s\n\n", cstr_Rangecc(containerName));
                             appendFormat_String(page,
-                                                cstrCount_Lang("archive.summary.n", numEntries_Archive(arch)),
+                                                cstrCount_Lang("archive.summary.n",
+                                                               (int) numEntries_Archive(arch)),
                                                 numEntries_Archive(arch),
                                                 (double) sourceSize_Archive(arch) / 1.0e6);
                             appendCStr_String(page, "\n\n");
@@ -802,7 +803,7 @@ void submit_GmRequest(iGmRequest *d) {
                             }
                             else if (size_StringSet(contents) > 1) {
                                 appendFormat_String(page, cstrCount_Lang("dir.summary.n",
-                                                                         size_StringSet(contents)),
+                                                                         (int) size_StringSet(contents)),
                                                     size_StringSet(contents));
                                 appendCStr_String(page, "\n\n");
                             }
diff --git a/src/media.c b/src/media.c
index a3f381ec..c02090b0 100644
--- a/src/media.c
+++ b/src/media.c
@@ -144,7 +144,7 @@ void makeTexture_GmImage(iGmImage *d) {
     }
     else {
         imgData = stbi_load_from_memory(
-            constData_Block(data), size_Block(data), &d->size.x, &d->size.y, NULL, 4);
+            constData_Block(data), (int) size_Block(data), &d->size.x, &d->size.y, NULL, 4);
         if (!imgData) {
             fprintf(stderr, "[media] image load failed: %s\n", stbi_failure_reason());
         }
diff --git a/src/sitespec.c b/src/sitespec.c
index f8b77c86..fe80ad13 100644
--- a/src/sitespec.c
+++ b/src/sitespec.c
@@ -141,7 +141,7 @@ static void handleIniKeyValue_SiteSpec_(void *context, const iString *table, con
         set_String(&d->loadParams->titanIdentity, value->value.string);
     }
     else if (!cmp_String(key, "dismissWarnings") && value->type == int64_TomlType) {
-        d->loadParams->dismissWarnings = value->value.int64;
+        d->loadParams->dismissWarnings = (int) value->value.int64;
     }
     else if (!cmp_String(key, "usedIdentities") && value->type == string_TomlType) {
         iRangecc seg = iNullRange;
diff --git a/src/ui/color.c b/src/ui/color.c
index ed17f580..3c2f0339 100644
--- a/src/ui/color.c
+++ b/src/ui/color.c
@@ -832,7 +832,7 @@ void ansiColors_Color(iRangecc escapeSequence, int fgDefault, int bgDefault,
                     int rgb[3] = { 0, 0, 0 };
                     iForIndices(i, rgb) {
                         if (ch >= escapeSequence.end) break;
-                        rgb[i] = strtoul(ch + 1, &endPtr, 10);
+                        rgb[i] = (int) strtoul(ch + 1, &endPtr, 10);
                         ch = endPtr;
                     }
                     dst->r = iClamp(rgb[0], 0, 255);
diff --git a/src/ui/command.c b/src/ui/command.c
index d6c668db..a4868ca9 100644
--- a/src/ui/command.c
+++ b/src/ui/command.c
@@ -80,7 +80,7 @@ uint32_t argU32Label_Command(const char *cmd, const char *label) {
     init_Token(&tok, label);
     const iRangecc ptr = find_Token(&tok, cmd);    
     if (ptr.start) {
-        return strtoul(ptr.end, NULL, 10);
+        return (uint32_t) strtoul(ptr.end, NULL, 10);
     }
     return 0;
 }
diff --git a/src/ui/mobile.c b/src/ui/mobile.c
index bffc2177..08d8dba2 100644
--- a/src/ui/mobile.c
+++ b/src/ui/mobile.c
@@ -210,7 +210,7 @@ static iBool topPanelHandler_(iWidget *topPanel, const char *cmd) {
             /* Animate the current panel in. */
             if (child == panel && isPortrait) {
                 setupSheetTransition_Mobile(panel, iTrue);
-                panelIndex = childIndex;
+                panelIndex = (int) childIndex;
             }
             childIndex++;
         }
diff --git a/src/ui/paint.c b/src/ui/paint.c
index c3b22343..5e66f521 100644
--- a/src/ui/paint.c
+++ b/src/ui/paint.c
@@ -175,7 +175,7 @@ void drawLines_Paint(const iPaint *d, const iInt2 *points, size_t n, int color)
     for (size_t i = 0; i < n; i++) {
         offsetPoints[i] = add_I2(points[i], origin_Paint);
     }
-    SDL_RenderDrawLines(renderer_Paint_(d), (const SDL_Point *) offsetPoints, n);
+    SDL_RenderDrawLines(renderer_Paint_(d), (const SDL_Point *) offsetPoints, (int) n);
     free(offsetPoints);
 }
 
diff --git a/src/ui/scrollwidget.c b/src/ui/scrollwidget.c
index b6f73b6c..651669c6 100644
--- a/src/ui/scrollwidget.c
+++ b/src/ui/scrollwidget.c
@@ -107,7 +107,7 @@ static iRect bounds_ScrollWidget_(const iScrollWidget *d) {
 static iRect thumbRect_ScrollWidget_(const iScrollWidget *d) {
     const iRect bounds = bounds_ScrollWidget_(d);
     iRect rect = init_Rect(bounds.pos.x, bounds.pos.y, bounds.size.x, 0);
-    const int total = size_Range(&d->range);
+    const int total = (int) size_Range(&d->range);
     if (total > 0) {
         const int tsize = thumbSize_ScrollWidget_(d);
 //        iAssert(tsize <= height_Rect(bounds));
@@ -197,7 +197,7 @@ static iBool processEvent_ScrollWidget_(iScrollWidget *d, const SDL_Event *ev) {
         case drag_ClickResult: {
             const iRect bounds = bounds_ScrollWidget_(d);
             const int offset = delta_Click(&d->click).y;
-            const int total = size_Range(&d->range);
+            const int total = (int) size_Range(&d->range);
             int dpos = (float) offset / (float) (height_Rect(bounds) - thumbSize_ScrollWidget_(d)) * total;
             d->thumb = iClamp(d->startThumb + dpos, d->range.start, d->range.end);
             postCommand_Widget(w, "scroll.moved arg:%d", d->thumb);
diff --git a/src/ui/util.c b/src/ui/util.c
index 58e49230..4ce40ae4 100644
--- a/src/ui/util.c
+++ b/src/ui/util.c
@@ -1427,7 +1427,7 @@ static iBool tabSwitcher_(iWidget *tabs, const char *cmd) {
             iWidget *nextTabs = findChild_Widget(otherRoot_Window(get_Window(), tabs->root)->widget,
                                                  "doctabs");
             iWidget *nextPages = findChild_Widget(nextTabs, "tabs.pages");
-            tabIndex = (dir < 0 ? childCount_Widget(nextPages) - 1 : 0);
+            tabIndex = (int) (dir < 0 ? childCount_Widget(nextPages) - 1 : 0);
             showTabPage_Widget(nextTabs, child_Widget(nextPages, tabIndex));
             postCommand_App("keyroot.next");
         }
diff --git a/src/ui/window.c b/src/ui/window.c
index 7f3371c8..d694146a 100644
--- a/src/ui/window.c
+++ b/src/ui/window.c
@@ -442,7 +442,7 @@ void create_Window_(iWindow *d, iRect rect, uint32_t flags) {
 static SDL_Surface *loadImage_(const iBlock *data, int resized) {
     int      w = 0, h = 0, num = 4;
     stbi_uc *pixels = stbi_load_from_memory(
-        constData_Block(data), size_Block(data), &w, &h, &num, STBI_rgb_alpha);
+        constData_Block(data), (int) size_Block(data), &w, &h, &num, STBI_rgb_alpha);
     if (resized) {
         stbi_uc *rsPixels = malloc(num * resized * resized);
         stbir_resize_uint8(pixels, w, h, 0, rsPixels, resized, resized, 0, num);
@@ -1549,9 +1549,9 @@ void setSplitMode_MainWindow(iMainWindow *d, int splitFlags) {
                 iWidget *docTabs1 = findChild_Widget(w->roots[newRootIndex]->widget, "doctabs");
                 /* If the old root has multiple tabs, move the current one to the new split. */
                 if (tabCount_Widget(docTabs0) >= 2) {
-                    int movedIndex = tabPageIndex_Widget(docTabs0, moved);
+                    size_t movedIndex = tabPageIndex_Widget(docTabs0, moved);
                     removeTabPage_Widget(docTabs0, movedIndex);
-                    showTabPage_Widget(docTabs0, tabPage_Widget(docTabs0, iMax(movedIndex - 1, 0)));
+                    showTabPage_Widget(docTabs0, tabPage_Widget(docTabs0, iMax((int) movedIndex - 1, 0)));
                     iRelease(removeTabPage_Widget(docTabs1, 0)); /* delete the default tab */
                     setRoot_Widget(as_Widget(moved), w->roots[newRootIndex]);
                     prependTabPage_Widget(docTabs1, iClob(moved), "", 0, 0);
diff --git a/src/visited.c b/src/visited.c
index 4552a053..83e09071 100644
--- a/src/visited.c
+++ b/src/visited.c
@@ -105,7 +105,7 @@ void load_Visited(iVisited *d, const char *dirPath) {
             char *endp = NULL;
             const unsigned long long ts = strtoull(line.start, &endp, 10);
             if (ts == 0) break;
-            const uint32_t flags = strtoul(skipSpace_CStr(endp), &endp, 16);
+            const uint32_t flags = (uint32_t) strtoul(skipSpace_CStr(endp), &endp, 16);
             const char *urlStart = skipSpace_CStr(endp);
             iVisitedUrl item;
             item.when.ts = (struct timespec){ .tv_sec = ts };