Bookmarks: Internal tags have a dot prefix

Internal behavior tags are now written in bookmarks.ini with a dot prefix (like hidden files on Unix), and at runtime they are removed from the tags string.

This makes things more efficient as it isn't necessary to compile regular expressions all the time.

TODO: Add "Edit Feed..." into the Bookmarks context menu, and a new menu item for listing all subscriptions.

IssueID #331

1 files changed, 3 insertions, 9 deletions

diff --git a/src/feeds.c b/src/feeds.c
index 26b3d6db..b7ce739b 100644
--- a/src/feeds.c
+++ b/src/feeds.c
@@ -97,8 +97,8 @@ static void init_FeedJob(iFeedJob *d, const iBookmark *bookmark) {
     init_PtrArray(&d->results);
     iZap(d->startTime);
     d->isFirstUpdate = iFalse;
-    d->checkHeadings = hasTag_Bookmark(bookmark, headings_BookmarkTag);
-    d->ignoreWeb     = hasTag_Bookmark(bookmark, ignoreWeb_BookmarkTag);
+    d->checkHeadings = (bookmark->flags & headings_BookmarkFlag) != 0;
+    d->ignoreWeb     = (bookmark->flags & ignoreWeb_BookmarkFlag) != 0;
 }
 
 static void deinit_FeedJob(iFeedJob *d) {
@@ -146,13 +146,7 @@ static void submit_FeedJob_(iFeedJob *d) {
 
 static iBool isSubscribed_(void *context, const iBookmark *bm) {
     iUnused(context);
-    static iRegExp *pattern_ = NULL;
-    if (!pattern_) {
-        pattern_ = new_RegExp("\\bsubscribed\\b", caseSensitive_RegExpOption);
-    }
-    iRegExpMatch m;
-    init_RegExpMatch(&m);
-    return matchString_RegExp(pattern_, &bm->tags, &m);
+    return (bm->flags & subscribed_BookmarkFlag) != 0;
 }
 
 static const iPtrArray *listSubscriptions_(void) {