Added a keybinding to hover on links via keyboard

Enables viewing full URLs when navigating via keyboard.

2 files changed, 13 insertions, 4 deletions

diff --git a/src/ui/documentwidget.c b/src/ui/documentwidget.c
index b3235755..3373771d 100644
--- a/src/ui/documentwidget.c
+++ b/src/ui/documentwidget.c
@@ -131,6 +131,7 @@ enum iDocumentWidgetFlag {
     selecting_DocumentWidgetFlag             = iBit(1),
     noHoverWhileScrolling_DocumentWidgetFlag = iBit(2),
     showLinkNumbers_DocumentWidgetFlag       = iBit(3),
+    setHoverViaKeys_DocumentWidgetFlag       = iBit(4),
 };
 
 enum iDocumentLinkOrdinalMode {
@@ -1786,6 +1787,8 @@ static iBool handleCommand_DocumentWidget_(iDocumentWidget *d, const char *cmd)
         else {
             d->ordinalMode = arg_Command(cmd);
             iChangeFlags(d->flags, showLinkNumbers_DocumentWidgetFlag, iTrue);
+            iChangeFlags(d->flags, setHoverViaKeys_DocumentWidgetFlag,
+                         argLabel_Command(cmd, "hover") != 0);
         }
         invalidateVisibleLinks_DocumentWidget_(d);
         refresh_Widget(d);
@@ -2195,10 +2198,15 @@ static iBool processEvent_DocumentWidget_(iDocumentWidget *d, const SDL_Event *e
                 const iGmRun *run = i.ptr;
                 if (run->flags & decoration_GmRunFlag &&
                     visibleLinkOrdinal_DocumentWidget_(d, run->linkId) == ord) {
-                    postCommandf_App("open newtab:%d url:%s",
-                                     openTabMode_Sym(SDL_GetModState()),
-                                     cstr_String(absoluteUrl_String(
-                                         d->mod.url, linkUrl_GmDocument(d->doc, run->linkId))));
+                    if (d->flags & setHoverViaKeys_DocumentWidgetFlag) {
+                        d->hoverLink = run;
+                    }
+                    else {
+                        postCommandf_App("open newtab:%d url:%s",
+                                         openTabMode_Sym(SDL_GetModState()),
+                                         cstr_String(absoluteUrl_String(
+                                             d->mod.url, linkUrl_GmDocument(d->doc, run->linkId))));
+                    }
                     iChangeFlags(d->flags, showLinkNumbers_DocumentWidgetFlag, iFalse);
                     invalidateVisibleLinks_DocumentWidget_(d);
                     refresh_Widget(d);
diff --git a/src/ui/keys.c b/src/ui/keys.c
index 99000d54..941dda54 100644
--- a/src/ui/keys.c
+++ b/src/ui/keys.c
@@ -77,6 +77,7 @@ static const struct { int id; iMenuItem bind; int flags; } defaultBindings_[] =
     { 35, { "Reload page",               reload_KeyShortcut,            "document.reload"    }, 0 },
     { 40, { "Open link via home row keys", 'f', 0,                      "document.linkkeys arg:1" }, 0 },
     { 41, { "Open link via modifier key", SDLK_LALT, 0,                 "document.linkkeys arg:0" }, argRelease_BindFlag },
+    { 45, { "Hover on link via home row keys", 'f', KMOD_SHIFT,         "document.linkkeys arg:1 hover:1" }, 0 },
     { 70, { "Zoom in",                   SDLK_EQUALS, KMOD_PRIMARY,     "zoom.delta arg:10"  }, 0 },
     { 71, { "Zoom out",                  SDLK_MINUS, KMOD_PRIMARY,      "zoom.delta arg:-10" }, 0 },
     { 72, { "Reset zoom",                SDLK_0, KMOD_PRIMARY,          "zoom.set arg:100"   }, 0 },