- (dtucker) bug #1530: strip trailing ":" from hostname in ssh-copy-id.

   based in part on a patch from Colin Watson, ok djm@

2 files changed, 7 insertions, 2 deletions

diff --git a/ChangeLog b/ChangeLog
index 184c36980..23ecb0618 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,8 @@
  - (djm) bz#1561: don't bother setting IFF_UP on tun(4) device if it is
    already set. Makes FreeBSD user openable tunnels useful; patch from
    richard.burakowski+ossh AT mrburak.net, ok dtucker@
+ - (dtucker) bug #1530: strip trailing ":" from hostname in ssh-copy-id.
+   based in part on a patch from Colin Watson, ok djm@
 
 20100809
  - OpenBSD CVS Sync
diff --git a/contrib/ssh-copy-id b/contrib/ssh-copy-id
index 4c5493bd0..368645cb4 100644
--- a/contrib/ssh-copy-id
+++ b/contrib/ssh-copy-id
@@ -38,10 +38,13 @@ if [ "$#" -lt 1 ] || [ "$1" = "-h" ] || [ "$1" = "--help" ]; then
   exit 1
 fi
 
-{ eval "$GET_ID" ; } | ssh $1 "umask 077; test -d ~/.ssh || mkdir ~/.ssh ; cat >> ~/.ssh/authorized_keys" || exit 1
+# strip any trailing colon
+host=`echo $1 | sed 's/:$//'`
+
+{ eval "$GET_ID" ; } | ssh $host "umask 077; test -d ~/.ssh || mkdir ~/.ssh ; cat >> ~/.ssh/authorized_keys" || exit 1
 
 cat <<EOF
-Now try logging into the machine, with "ssh '$1'", and check in:
+Now try logging into the machine, with "ssh '$host'", and check in:
 
   ~/.ssh/authorized_keys