- deraadt@cvs.openbsd.org 2006/03/25 18:56:55

     [bufaux.c channels.c packet.c]
     remove (char *) casts to a function that accepts void * for the arg

4 files changed, 13 insertions, 10 deletions

diff --git a/ChangeLog b/ChangeLog
index da5a1ded5..407649967 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -168,6 +168,9 @@
    - deraadt@cvs.openbsd.org 2006/03/25 18:43:30
      [channels.c]
      use strtonum() instead of atoi() [limit X screens to 400, sorry]
+   - deraadt@cvs.openbsd.org 2006/03/25 18:56:55
+     [bufaux.c channels.c packet.c]
+     remove (char *) casts to a function that accepts void * for the arg
 
 20060325
  - OpenBSD CVS Sync
@@ -4425,4 +4428,4 @@
    - (djm) Trim deprecated options from INSTALL. Mention UsePAM
    - (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu
 
-$Id: ChangeLog,v 1.4283 2006/03/26 03:28:32 djm Exp $
+$Id: ChangeLog,v 1.4284 2006/03/26 03:28:50 djm Exp $
diff --git a/bufaux.c b/bufaux.c
index b7c9f2ecd..21a2badf1 100644
--- a/bufaux.c
+++ b/bufaux.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: bufaux.c,v 1.39 2006/03/25 13:17:01 djm Exp $ */
+/* $OpenBSD: bufaux.c,v 1.40 2006/03/25 18:56:54 deraadt Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -71,7 +71,7 @@ buffer_put_bignum_ret(Buffer *buffer, const BIGNUM *value)
         PUT_16BIT(msg, bits);
         buffer_append(buffer, msg, 2);
         /* Store the binary data. */
-        buffer_append(buffer, (char *)buf, oi);
+        buffer_append(buffer, buf, oi);
 
         memset(buf, 0, bin_size);
         xfree(buf);
diff --git a/channels.c b/channels.c
index 70ffd7b33..57634a21d 100644
--- a/channels.c
+++ b/channels.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: channels.c,v 1.245 2006/03/25 18:43:30 deraadt Exp $ */
+/* $OpenBSD: channels.c,v 1.246 2006/03/25 18:56:54 deraadt Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -988,7 +988,7 @@ channel_decode_socks4(Channel *c, fd_set *readset, fd_set *writeset)
         s4_rsp.command = 90;                    /* cd: req granted */
         s4_rsp.dest_port = 0;                   /* ignored */
         s4_rsp.dest_addr.s_addr = INADDR_ANY;   /* ignored */
-        buffer_append(&c->output, (char *)&s4_rsp, sizeof(s4_rsp));
+        buffer_append(&c->output, &s4_rsp, sizeof(s4_rsp));
         return 1;
 }
 
@@ -1097,9 +1097,9 @@ channel_decode_socks5(Channel *c, fd_set *readset, fd_set *writeset)
         ((struct in_addr *)&dest_addr)->s_addr = INADDR_ANY;
         dest_port = 0;                          /* ignored */
 
-        buffer_append(&c->output, (char *)&s5_rsp, sizeof(s5_rsp));
-        buffer_append(&c->output, (char *)&dest_addr, sizeof(struct in_addr));
-        buffer_append(&c->output, (char *)&dest_port, sizeof(dest_port));
+        buffer_append(&c->output, &s5_rsp, sizeof(s5_rsp));
+        buffer_append(&c->output, &dest_addr, sizeof(struct in_addr));
+        buffer_append(&c->output, &dest_port, sizeof(dest_port));
         return 1;
 }
 
diff --git a/packet.c b/packet.c
index fceeef666..5eb2c1c9e 100644
--- a/packet.c
+++ b/packet.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: packet.c,v 1.129 2006/03/25 18:29:35 deraadt Exp $ */
+/* $OpenBSD: packet.c,v 1.130 2006/03/25 18:56:55 deraadt Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -788,7 +788,7 @@ packet_send2_wrapped(void)
             buffer_len(&outgoing_packet));
         /* append unencrypted MAC */
         if (mac && mac->enabled)
-                buffer_append(&output, (char *)macbuf, mac->mac_len);
+                buffer_append(&output, macbuf, mac->mac_len);
 #ifdef PACKET_DEBUG
         fprintf(stderr, "encrypted: ");
         buffer_dump(&output);