diff options
author | Damien Miller <djm@mindrot.org> | 2020-06-26 16:07:12 +1000 |
---|---|---|
committer | Damien Miller <djm@mindrot.org> | 2020-06-26 16:07:24 +1000 |
commit | 598c3a5e3885080ced0d7c40fde00f1d5cdbb32b (patch) | |
tree | 1cc1f15ed29f3b2810bdf092f345d8921f88b5ec /auth-pam.c | |
parent | 976c4f86286d52a0cb2aadf4a095d379c0da752e (diff) |
document a PAM spec problem in a frustrated comment
Diffstat (limited to 'auth-pam.c')
-rw-r--r-- | auth-pam.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/auth-pam.c b/auth-pam.c index 5a3ba09b4..832382151 100644 --- a/auth-pam.c +++ b/auth-pam.c | |||
@@ -375,7 +375,11 @@ import_environments(struct sshbuf *b) | |||
375 | error("PAM: pam_putenv: %s", | 375 | error("PAM: pam_putenv: %s", |
376 | pam_strerror(sshpam_handle, r)); | 376 | pam_strerror(sshpam_handle, r)); |
377 | } | 377 | } |
378 | /* XXX leak env? */ | 378 | /* |
379 | * XXX this possibly leaks env because it is not documented | ||
380 | * what pam_putenv() does with it. Does it copy it? Does it | ||
381 | * take ownweship? We don't know, so it's safest just to leak. | ||
382 | */ | ||
379 | } | 383 | } |
380 | #endif | 384 | #endif |
381 | } | 385 | } |