upstream: When system calls indicate an error they return -1, not

some arbitrary value < 0.  errno is only updated in this case.  Change all
(most?) callers of syscalls to follow this better, and let's see if this
strictness helps us in the future.

OpenBSD-Commit-ID: 48081f00db7518e3b712a49dca06efc2a5428075

1 files changed, 5 insertions, 5 deletions

diff --git a/auth-rhosts.c b/auth-rhosts.c
index 57296e1f6..63c1c8acb 100644
--- a/auth-rhosts.c
+++ b/auth-rhosts.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth-rhosts.c,v 1.49 2018/07/09 21:35:50 markus Exp $ */
+/* $OpenBSD: auth-rhosts.c,v 1.50 2019/06/28 13:35:04 deraadt Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -222,8 +222,8 @@ auth_rhosts2(struct passwd *pw, const char *client_user, const char *hostname,
          * are no system-wide files.
          */
         if (!rhosts_files[rhosts_file_index] &&
-            stat(_PATH_RHOSTS_EQUIV, &st) < 0 &&
-            stat(_PATH_SSH_HOSTS_EQUIV, &st) < 0) {
+            stat(_PATH_RHOSTS_EQUIV, &st) == -1 &&
+            stat(_PATH_SSH_HOSTS_EQUIV, &st) == -1) {
                 debug3("%s: no hosts access files exist", __func__);
                 return 0;
         }
@@ -253,7 +253,7 @@ auth_rhosts2(struct passwd *pw, const char *client_user, const char *hostname,
          * Check that the home directory is owned by root or the user, and is
          * not group or world writable.
          */
-        if (stat(pw->pw_dir, &st) < 0) {
+        if (stat(pw->pw_dir, &st) == -1) {
                 logit("Rhosts authentication refused for %.100s: "
                     "no home directory %.200s", pw->pw_name, pw->pw_dir);
                 auth_debug_add("Rhosts authentication refused for %.100s: "
@@ -278,7 +278,7 @@ auth_rhosts2(struct passwd *pw, const char *client_user, const char *hostname,
                 /* Check users .rhosts or .shosts. */
                 snprintf(buf, sizeof buf, "%.500s/%.100s",
                          pw->pw_dir, rhosts_files[rhosts_file_index]);
-                if (stat(buf, &st) < 0)
+                if (stat(buf, &st) == -1)
                         continue;
 
                 /*