diff options
author | Colin Watson <cjwatson@debian.org> | 2014-02-09 16:09:58 +0000 |
---|---|---|
committer | Colin Watson <cjwatson@debian.org> | 2017-10-04 13:54:48 +0100 |
commit | b1033fed87fd9fa24dccab45f00cadcbc7144c47 (patch) | |
tree | 3f6838395acfa6e09710644c99bf003e2b8dcc23 /auth.c | |
parent | 215bd91f12b0ddb9754483ee6e3c3b4751256dca (diff) |
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
group-writable, provided that the group in question contains only the file's
owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
about the contents of gr->gr_mem). Given that per-user groups and umask 002
are the default setup in Debian (for good reasons - this makes operating in
setgid directories with other groups much easier), we need to permit this by
default.
Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
Last-Update: 2017-10-04
Patch-Name: user-group-modes.patch
Diffstat (limited to 'auth.c')
-rw-r--r-- | auth.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -467,8 +467,7 @@ check_key_in_hostfiles(struct passwd *pw, struct sshkey *key, const char *host, | |||
467 | user_hostfile = tilde_expand_filename(userfile, pw->pw_uid); | 467 | user_hostfile = tilde_expand_filename(userfile, pw->pw_uid); |
468 | if (options.strict_modes && | 468 | if (options.strict_modes && |
469 | (stat(user_hostfile, &st) == 0) && | 469 | (stat(user_hostfile, &st) == 0) && |
470 | ((st.st_uid != 0 && st.st_uid != pw->pw_uid) || | 470 | !secure_permissions(&st, pw->pw_uid)) { |
471 | (st.st_mode & 022) != 0)) { | ||
472 | logit("Authentication refused for %.100s: " | 471 | logit("Authentication refused for %.100s: " |
473 | "bad owner or modes for %.200s", | 472 | "bad owner or modes for %.200s", |
474 | pw->pw_name, user_hostfile); | 473 | pw->pw_name, user_hostfile); |