upstream commit

Drop compatibility hacks for some ancient SSH
implementations, including ssh.com <=2.* and OpenSSH <= 3.*.

These versions were all released in or before 2001 and predate the
final SSH RFCs. The hacks in question aren't necessary for RFC-
compliant SSH implementations.

ok markus@

OpenBSD-Commit-ID: 4be81c67db57647f907f4e881fb9341448606138

1 files changed, 3 insertions, 5 deletions

diff --git a/auth2-hostbased.c b/auth2-hostbased.c
index 8112cfaa3..8996f7e05 100644
--- a/auth2-hostbased.c
+++ b/auth2-hostbased.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2-hostbased.c,v 1.32 2017/12/18 02:25:15 djm Exp $ */
+/* $OpenBSD: auth2-hostbased.c,v 1.33 2018/01/23 05:27:21 djm Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -62,7 +62,7 @@ userauth_hostbased(struct ssh *ssh)
         Authctxt *authctxt = ssh->authctxt;
         struct sshbuf *b;
         struct sshkey *key = NULL;
-        char *pkalg, *cuser, *chost, *service;
+        char *pkalg, *cuser, *chost;
         u_char *pkblob, *sig;
         size_t alen, blen, slen;
         int r, pktype, authenticated = 0;
@@ -118,15 +118,13 @@ userauth_hostbased(struct ssh *ssh)
                 goto done;
         }
 
-        service = ssh->compat & SSH_BUG_HBSERVICE ? "ssh-userauth" :
-            authctxt->service;
         if ((b = sshbuf_new()) == NULL)
                 fatal("%s: sshbuf_new failed", __func__);
         /* reconstruct packet */
         if ((r = sshbuf_put_string(b, session_id2, session_id2_len)) != 0 ||
             (r = sshbuf_put_u8(b, SSH2_MSG_USERAUTH_REQUEST)) != 0 ||
             (r = sshbuf_put_cstring(b, authctxt->user)) != 0 ||
-            (r = sshbuf_put_cstring(b, service)) != 0 ||
+            (r = sshbuf_put_cstring(b, authctxt->service)) != 0 ||
             (r = sshbuf_put_cstring(b, "hostbased")) != 0 ||
             (r = sshbuf_put_string(b, pkalg, alen)) != 0 ||
             (r = sshbuf_put_string(b, pkblob, blen)) != 0 ||