- djm@cvs.openbsd.org 2013/05/17 00:13:13

     [xmalloc.h cipher.c sftp-glob.c ssh-keyscan.c ssh.c sftp-common.c
     ssh-ecdsa.c auth2-chall.c compat.c readconf.c kexgexs.c monitor.c
     gss-genr.c cipher-3des1.c kex.c monitor_wrap.c ssh-pkcs11-client.c
     auth-options.c rsa.c auth2-pubkey.c sftp.c hostfile.c auth2.c
     servconf.c auth.c authfile.c xmalloc.c uuencode.c sftp-client.c
     auth2-gss.c sftp-server.c bufaux.c mac.c session.c jpake.c kexgexc.c
     sshconnect.c auth-chall.c auth2-passwd.c sshconnect1.c buffer.c
     kexecdhs.c kexdhs.c ssh-rsa.c auth1.c ssh-pkcs11.c auth2-kbdint.c
     kexdhc.c sshd.c umac.c ssh-dss.c auth2-jpake.c bufbn.c clientloop.c
     monitor_mm.c scp.c roaming_client.c serverloop.c key.c auth-rsa.c
     ssh-pkcs11-helper.c ssh-keysign.c ssh-keygen.c match.c channels.c
     sshconnect2.c addrmatch.c mux.c canohost.c kexecdhc.c schnorr.c
     ssh-add.c misc.c auth2-hostbased.c ssh-agent.c bufec.c groupaccess.c
     dns.c packet.c readpass.c authfd.c moduli.c]
     bye, bye xfree(); ok markus@

1 files changed, 8 insertions, 9 deletions

diff --git a/auth2.c b/auth2.c
index e44482164..5f136ce09 100644
--- a/auth2.c
+++ b/auth2.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2.c,v 1.127 2013/03/07 19:27:25 markus Exp $ */
+/* $OpenBSD: auth2.c,v 1.128 2013/05/17 00:13:13 djm Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -130,7 +130,7 @@ auth2_read_banner(void)
         close(fd);
 
         if (n != len) {
-                xfree(banner);
+                free(banner);
                 return (NULL);
         }
         banner[n] = '\0';
@@ -166,8 +166,7 @@ userauth_banner(void)
         userauth_send_banner(banner);
 
 done:
-        if (banner)
-                xfree(banner);
+        free(banner);
 }
 
 /*
@@ -212,7 +211,7 @@ input_service_request(int type, u_int32_t seq, void *ctxt)
                 debug("bad service request %s", service);
                 packet_disconnect("bad service request %s", service);
         }
-        xfree(service);
+        free(service);
 }
 
 /*ARGSUSED*/
@@ -292,9 +291,9 @@ input_userauth_request(int type, u_int32_t seq, void *ctxt)
         }
         userauth_finish(authctxt, authenticated, method, NULL);
 
-        xfree(service);
-        xfree(user);
-        xfree(method);
+        free(service);
+        free(user);
+        free(method);
 }
 
 void
@@ -382,7 +381,7 @@ userauth_finish(Authctxt *authctxt, int authenticated, const char *method,
                 packet_put_char(partial);
                 packet_send();
                 packet_write_wait();
-                xfree(methods);
+                free(methods);
         }
 }