upstream: When system calls indicate an error they return -1, not

some arbitrary value < 0.  errno is only updated in this case.  Change all
(most?) callers of syscalls to follow this better, and let's see if this
strictness helps us in the future.

OpenBSD-Commit-ID: 48081f00db7518e3b712a49dca06efc2a5428075

1 files changed, 3 insertions, 3 deletions

diff --git a/authfd.c b/authfd.c
index 327a333d2..fd8f336fc 100644
--- a/authfd.c
+++ b/authfd.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: authfd.c,v 1.114 2019/06/21 04:21:04 djm Exp $ */
+/* $OpenBSD: authfd.c,v 1.115 2019/06/28 13:35:04 deraadt Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -101,12 +101,12 @@ ssh_get_authentication_socket(int *fdp)
         sunaddr.sun_family = AF_UNIX;
         strlcpy(sunaddr.sun_path, authsocket, sizeof(sunaddr.sun_path));
 
-        if ((sock = socket(AF_UNIX, SOCK_STREAM, 0)) < 0)
+        if ((sock = socket(AF_UNIX, SOCK_STREAM, 0)) == -1)
                 return SSH_ERR_SYSTEM_ERROR;
 
         /* close on exec */
         if (fcntl(sock, F_SETFD, FD_CLOEXEC) == -1 ||
-            connect(sock, (struct sockaddr *)&sunaddr, sizeof(sunaddr)) < 0) {
+            connect(sock, (struct sockaddr *)&sunaddr, sizeof(sunaddr)) == -1) {
                 oerrno = errno;
                 close(sock);
                 errno = oerrno;