- markus@cvs.openbsd.org 2013/12/06 13:30:08

     [authfd.c key.c key.h ssh-agent.c]
     move private key (de)serialization to key.c; ok djm

1 files changed, 3 insertions, 54 deletions

diff --git a/authfd.c b/authfd.c
index 5cce93b76..2cda8b309 100644
--- a/authfd.c
+++ b/authfd.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: authfd.c,v 1.88 2013/11/08 00:39:14 djm Exp $ */
+/* $OpenBSD: authfd.c,v 1.89 2013/12/06 13:30:08 markus Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -42,8 +42,8 @@
 #include <sys/socket.h>
 
 #include <openssl/evp.h>
-
 #include <openssl/crypto.h>
+
 #include <fcntl.h>
 #include <stdlib.h>
 #include <signal.h>
@@ -474,58 +474,7 @@ ssh_encode_identity_rsa1(Buffer *b, RSA *key, const char *comment)
 static void
 ssh_encode_identity_ssh2(Buffer *b, Key *key, const char *comment)
 {
-        buffer_put_cstring(b, key_ssh_name(key));
-        switch (key->type) {
-        case KEY_RSA:
-                buffer_put_bignum2(b, key->rsa->n);
-                buffer_put_bignum2(b, key->rsa->e);
-                buffer_put_bignum2(b, key->rsa->d);
-                buffer_put_bignum2(b, key->rsa->iqmp);
-                buffer_put_bignum2(b, key->rsa->p);
-                buffer_put_bignum2(b, key->rsa->q);
-                break;
-        case KEY_RSA_CERT_V00:
-        case KEY_RSA_CERT:
-                if (key->cert == NULL || buffer_len(&key->cert->certblob) == 0)
-                        fatal("%s: no cert/certblob", __func__);
-                buffer_put_string(b, buffer_ptr(&key->cert->certblob),
-                    buffer_len(&key->cert->certblob));
-                buffer_put_bignum2(b, key->rsa->d);
-                buffer_put_bignum2(b, key->rsa->iqmp);
-                buffer_put_bignum2(b, key->rsa->p);
-                buffer_put_bignum2(b, key->rsa->q);
-                break;
-        case KEY_DSA:
-                buffer_put_bignum2(b, key->dsa->p);
-                buffer_put_bignum2(b, key->dsa->q);
-                buffer_put_bignum2(b, key->dsa->g);
-                buffer_put_bignum2(b, key->dsa->pub_key);
-                buffer_put_bignum2(b, key->dsa->priv_key);
-                break;
-        case KEY_DSA_CERT_V00:
-        case KEY_DSA_CERT:
-                if (key->cert == NULL || buffer_len(&key->cert->certblob) == 0)
-                        fatal("%s: no cert/certblob", __func__);
-                buffer_put_string(b, buffer_ptr(&key->cert->certblob),
-                    buffer_len(&key->cert->certblob));
-                buffer_put_bignum2(b, key->dsa->priv_key);
-                break;
-#ifdef OPENSSL_HAS_ECC
-        case KEY_ECDSA:
-                buffer_put_cstring(b, key_curve_nid_to_name(key->ecdsa_nid));
-                buffer_put_ecpoint(b, EC_KEY_get0_group(key->ecdsa),
-                    EC_KEY_get0_public_key(key->ecdsa));
-                buffer_put_bignum2(b, EC_KEY_get0_private_key(key->ecdsa));
-                break;
-        case KEY_ECDSA_CERT:
-                if (key->cert == NULL || buffer_len(&key->cert->certblob) == 0)
-                        fatal("%s: no cert/certblob", __func__);
-                buffer_put_string(b, buffer_ptr(&key->cert->certblob),
-                    buffer_len(&key->cert->certblob));
-                buffer_put_bignum2(b, EC_KEY_get0_private_key(key->ecdsa));
-                break;
-#endif
-        }
+        key_private_serialize(key, b);
         buffer_put_cstring(b, comment);
 }