- OpenBSD CVS updates to v1.2.3

	[ssh.h atomicio.c]
	 - int atomicio -> ssize_t (for alpha). ok deraadt@
	[auth-rsa.c]
	 - delay MD5 computation until client sends response, free() early, cleanup.
	[cipher.c]
	 - void* -> unsigned char*, ok niels@
	[hostfile.c]
	 - remove unused variable 'len'. fix comments.
	 - remove unused variable
	[log-client.c log-server.c]
	 - rename a cpp symbol, to avoid param.h collision
	[packet.c]
	 - missing xfree()
	 - getsockname() requires initialized tolen; andy@guildsoftware.com
	 - use getpeername() in packet_connection_is_on_socket(), fixes sshd -i;
	from Holger.Trapp@Informatik.TU-Chemnitz.DE
	[pty.c pty.h]
	 - register cleanup for pty earlier. move code for pty-owner handling to
   	pty.c ok provos@, dugsong@
	[readconf.c]
	 - turn off x11-fwd for the client, too.
	[rsa.c]
	 - PKCS#1 padding
	[scp.c]
	 - allow '.' in usernames; from jedgar@fxp.org
	[servconf.c]
	 - typo: ignore_user_known_hosts int->flag; naddy@mips.rhein-neckar.de
	 - sync with sshd_config
	[ssh-keygen.c]
	 - enable ssh-keygen -l -f ~/.ssh/known_hosts, ok deraadt@
	[ssh.1]
	 - Change invalid 'CHAT' loglevel to 'VERBOSE'
	[ssh.c]
	 - suppress AAAA query host when '-4' is used; from shin@nd.net.fujitsu.co.jp
	 - turn off x11-fwd for the client, too.
	[sshconnect.c]
	 - missing xfree()
	 - retry rresvport_af(), too. from sumikawa@ebina.hitachi.co.jp.
	 - read error vs. "Connection closed by remote host"
	[sshd.8]
	 - ie. -> i.e.,
	 - do not link to a commercial page..
	 - sync with sshd_config
	[sshd.c]
	 - no need for poll.h; from bright@wintelcom.net
	 - log with level log() not fatal() if peer behaves badly.
	 - don't panic if client behaves strange. ok deraadt@
	 - make no-port-forwarding for RSA keys deny both -L and -R style fwding
	 - delay close() of pty until the pty has been chowned back to root
	 - oops, fix comment, too.
	 - missing xfree()
	 - move XAUTHORITY to subdir. ok dugsong@. fixes debian bug #57907, too.
   	(http://cgi.debian.org/cgi-bin/bugreport.cgi?archive=no&bug=57907)
	 - register cleanup for pty earlier. move code for pty-owner handling to
      pty.c ok provos@, dugsong@
	 - create x11 cookie file
	 - fix pr 1113, fclose() -> pclose(), todo: remote popen()
	 - version 1.2.3
 - Cleaned up

1 files changed, 9 insertions, 9 deletions

diff --git a/cipher.c b/cipher.c
index 5589c24fa..c55c7dcbd 100644
--- a/cipher.c
+++ b/cipher.c
@@ -12,7 +12,7 @@
  */
 
 #include "includes.h"
-RCSID("$Id: cipher.c,v 1.12 2000/01/22 23:32:03 damien Exp $");
+RCSID("$Id: cipher.c,v 1.13 2000/03/09 10:27:50 damien Exp $");
 
 #include "ssh.h"
 #include "cipher.h"
@@ -41,7 +41,7 @@ void
 SSH_3CBC_ENCRYPT(des_key_schedule ks1,
                  des_key_schedule ks2, des_cblock * iv2,
                  des_key_schedule ks3, des_cblock * iv3,
-                 void *dest, void *src,
+                 unsigned char *dest, unsigned char *src,
                  unsigned int len)
 {
         des_cblock iv1;
@@ -49,20 +49,20 @@ SSH_3CBC_ENCRYPT(des_key_schedule ks1,
         memcpy(&iv1, iv2, 8);
 
         des_cbc_encrypt(src, dest, len, ks1, &iv1, DES_ENCRYPT);
-        memcpy(&iv1, (char *)dest + len - 8, 8);
+        memcpy(&iv1, dest + len - 8, 8);
 
         des_cbc_encrypt(dest, dest, len, ks2, iv2, DES_DECRYPT);
         memcpy(iv2, &iv1, 8);   /* Note how iv1 == iv2 on entry and exit. */
 
         des_cbc_encrypt(dest, dest, len, ks3, iv3, DES_ENCRYPT);
-        memcpy(iv3, (char *)dest + len - 8, 8);
+        memcpy(iv3, dest + len - 8, 8);
 }
 
 void
 SSH_3CBC_DECRYPT(des_key_schedule ks1,
                  des_key_schedule ks2, des_cblock * iv2,
                  des_key_schedule ks3, des_cblock * iv3,
-                 void *dest, void *src,
+                 unsigned char *dest, unsigned char *src,
                  unsigned int len)
 {
         des_cblock iv1;
@@ -70,10 +70,10 @@ SSH_3CBC_DECRYPT(des_key_schedule ks1,
         memcpy(&iv1, iv2, 8);
 
         des_cbc_encrypt(src, dest, len, ks3, iv3, DES_DECRYPT);
-        memcpy(iv3, (char *)src + len - 8, 8);
+        memcpy(iv3, src + len - 8, 8);
 
         des_cbc_encrypt(dest, dest, len, ks2, iv2, DES_ENCRYPT);
-        memcpy(iv2, (char *)dest + len - 8, 8);
+        memcpy(iv2, dest + len - 8, 8);
 
         des_cbc_encrypt(dest, dest, len, ks1, &iv1, DES_DECRYPT);
         /* memcpy(&iv1, iv2, 8); */
@@ -273,7 +273,7 @@ cipher_encrypt(CipherContext *context, unsigned char *dest,
                 SSH_3CBC_ENCRYPT(context->u.des3.key1,
                                  context->u.des3.key2, &context->u.des3.iv2,
                                  context->u.des3.key3, &context->u.des3.iv3,
-                                 dest, (void *) src, len);
+                                 dest, (unsigned char *) src, len);
                 break;
 
         case SSH_CIPHER_BLOWFISH:
@@ -308,7 +308,7 @@ cipher_decrypt(CipherContext *context, unsigned char *dest,
                 SSH_3CBC_DECRYPT(context->u.des3.key1,
                                  context->u.des3.key2, &context->u.des3.iv2,
                                  context->u.des3.key3, &context->u.des3.iv3,
-                                 dest, (void *) src, len);
+                                 dest, (unsigned char *) src, len);
                 break;
 
         case SSH_CIPHER_BLOWFISH: