refactor libcrypto initialisation

Don't call OpenSSL_add_all_algorithms() unless OpenSSL actually
supports it.

Move all libcrypto initialisation to a single function, and call that
from seed_rng() that is called early in each tool's main().

Prompted by patch from Rosen Penev

1 files changed, 22 insertions, 13 deletions

diff --git a/entropy.c b/entropy.c
index fc710ec23..97e836087 100644
--- a/entropy.c
+++ b/entropy.c
@@ -56,6 +56,8 @@
 #include "sshbuf.h"
 #include "ssherr.h"
 
+#define RANDOM_SEED_SIZE 48
+
 /*
  * Portable OpenSSH PRNG seeding:
  * If OpenSSL has not "internally seeded" itself (e.g. pulled data from
@@ -64,8 +66,6 @@
  */
 #ifndef OPENSSL_PRNG_ONLY
 
-#define RANDOM_SEED_SIZE 48
-
 /*
  * Collect 'len' bytes of entropy into 'buf' from PRNGD/EGD daemon
  * listening either on 'tcp_port', or via Unix domain socket at *
@@ -216,9 +216,11 @@ rexec_recv_rng_seed(struct sshbuf *m)
 void
 seed_rng(void)
 {
-#ifndef OPENSSL_PRNG_ONLY
         unsigned char buf[RANDOM_SEED_SIZE];
-#endif
+
+        /* Initialise libcrypto */
+        ssh_libcrypto_init();
+
         if (!ssh_compatible_openssl(OPENSSL_VERSION_NUMBER,
             OpenSSL_version_num()))
                 fatal("OpenSSL version mismatch. Built against %lx, you "
@@ -226,27 +228,34 @@ seed_rng(void)
                     OpenSSL_version_num());
 
 #ifndef OPENSSL_PRNG_ONLY
-        if (RAND_status() == 1) {
+        if (RAND_status() == 1)
                 debug3("RNG is ready, skipping seeding");
-                return;
+        else {
+                if (seed_from_prngd(buf, sizeof(buf)) == -1)
+                        fatal("Could not obtain seed from PRNGd");
+                RAND_add(buf, sizeof(buf), sizeof(buf));
         }
-
-        if (seed_from_prngd(buf, sizeof(buf)) == -1)
-                fatal("Could not obtain seed from PRNGd");
-        RAND_add(buf, sizeof(buf), sizeof(buf));
-        memset(buf, '\0', sizeof(buf));
-
 #endif /* OPENSSL_PRNG_ONLY */
+
         if (RAND_status() != 1)
                 fatal("PRNG is not seeded");
+
+        /* Ensure arc4random() is primed */
+        arc4random_buf(buf, sizeof(buf));
+        explicit_bzero(buf, sizeof(buf));
 }
 
 #else /* WITH_OPENSSL */
 
-/* Handled in arc4random() */
+/* Acutal initialisation is handled in arc4random() */
 void
 seed_rng(void)
 {
+        unsigned char buf[RANDOM_SEED_SIZE];
+
+        /* Ensure arc4random() is primed */
+        arc4random_buf(buf, sizeof(buf));
+        explicit_bzero(buf, sizeof(buf));
 }
 
 #endif /* WITH_OPENSSL */