summaryrefslogtreecommitdiff
path: root/misc.c
diff options
context:
space:
mode:
authordtucker@openbsd.org <dtucker@openbsd.org>2018-12-07 04:36:09 +0000
committerDamien Miller <djm@mindrot.org>2018-12-27 14:30:17 +1100
commit434b587afe41c19391821e7392005068fda76248 (patch)
tree2aee75c1f39344d80af0772aa4dacf6885e827f5 /misc.c
parenta6a0788cbbe8dfce2819ee43b09c80725742e21c (diff)
upstream: Fix calculation of initial bandwidth limits. Account for
written bytes before the initial timer check so that the first buffer written is accounted. Set the threshold after which the timer is checked such that the limit starts being computed as soon as possible, ie after the second buffer is written. This prevents an initial burst of traffic and provides a more accurate bandwidth limit. bz#2927, ok djm. OpenBSD-Commit-ID: ff3ef76e4e43040ec198c2718d5682c36b255cb6
Diffstat (limited to 'misc.c')
-rw-r--r--misc.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/misc.c b/misc.c
index dd74c8d45..275e68141 100644
--- a/misc.c
+++ b/misc.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: misc.c,v 1.134 2018/11/16 03:26:01 djm Exp $ */ 1/* $OpenBSD: misc.c,v 1.135 2018/12/07 04:36:09 dtucker Exp $ */
2/* 2/*
3 * Copyright (c) 2000 Markus Friedl. All rights reserved. 3 * Copyright (c) 2000 Markus Friedl. All rights reserved.
4 * Copyright (c) 2005,2006 Damien Miller. All rights reserved. 4 * Copyright (c) 2005,2006 Damien Miller. All rights reserved.
@@ -1335,11 +1335,11 @@ bandwidth_limit_init(struct bwlimit *bw, u_int64_t kbps, size_t buflen)
1335{ 1335{
1336 bw->buflen = buflen; 1336 bw->buflen = buflen;
1337 bw->rate = kbps; 1337 bw->rate = kbps;
1338 bw->thresh = bw->rate; 1338 bw->thresh = buflen;
1339 bw->lamt = 0; 1339 bw->lamt = 0;
1340 timerclear(&bw->bwstart); 1340 timerclear(&bw->bwstart);
1341 timerclear(&bw->bwend); 1341 timerclear(&bw->bwend);
1342} 1342}
1343 1343
1344/* Callback from read/write loop to insert bandwidth-limiting delays */ 1344/* Callback from read/write loop to insert bandwidth-limiting delays */
1345void 1345void
@@ -1348,12 +1348,11 @@ bandwidth_limit(struct bwlimit *bw, size_t read_len)
1348 u_int64_t waitlen; 1348 u_int64_t waitlen;
1349 struct timespec ts, rm; 1349 struct timespec ts, rm;
1350 1350
1351 bw->lamt += read_len;
1351 if (!timerisset(&bw->bwstart)) { 1352 if (!timerisset(&bw->bwstart)) {
1352 monotime_tv(&bw->bwstart); 1353 monotime_tv(&bw->bwstart);
1353 return; 1354 return;
1354 } 1355 }
1355
1356 bw->lamt += read_len;
1357 if (bw->lamt < bw->thresh) 1356 if (bw->lamt < bw->thresh)
1358 return; 1357 return;
1359 1358