summaryrefslogtreecommitdiff
path: root/misc.c
diff options
context:
space:
mode:
authordtucker@openbsd.org <dtucker@openbsd.org>2020-05-29 09:02:44 +0000
committerDarren Tucker <dtucker@dtucker.net>2020-05-29 20:10:21 +1000
commitf85b118d2150847cc333895296bc230e367be6b5 (patch)
tree35f468141a64ffa74643b5e36d49f323cbf087d5 /misc.c
parentec1d50b01c84ff667240ed525f669454c4ebc8e9 (diff)
upstream: Pass a NULL instead of zeroed out va_list from
dollar_expand. The original intent was in case there's some platform where va_list is not a pointer equivalent, but on i386 this chokes on the memset. This unbreaks that build, but will require further consideration. OpenBSD-Commit-ID: 7b90afcd8e1137a1d863204060052aef415baaf7
Diffstat (limited to 'misc.c')
-rw-r--r--misc.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/misc.c b/misc.c
index 3ec02d79e..9ba913c3e 100644
--- a/misc.c
+++ b/misc.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: misc.c,v 1.150 2020/05/29 04:25:40 dtucker Exp $ */ 1/* $OpenBSD: misc.c,v 1.151 2020/05/29 09:02:44 dtucker Exp $ */
2/* 2/*
3 * Copyright (c) 2000 Markus Friedl. All rights reserved. 3 * Copyright (c) 2000 Markus Friedl. All rights reserved.
4 * Copyright (c) 2005-2020 Damien Miller. All rights reserved. 4 * Copyright (c) 2005-2020 Damien Miller. All rights reserved.
@@ -1212,10 +1212,8 @@ dollar_expand(int *parseerr, const char *string)
1212{ 1212{
1213 char *ret; 1213 char *ret;
1214 int err; 1214 int err;
1215 va_list ap;
1216 1215
1217 memset(ap, 0, sizeof(ap)); /* unused */ 1216 ret = vdollar_percent_expand(&err, 1, 0, string, NULL);
1218 ret = vdollar_percent_expand(&err, 1, 0, string, ap);
1219 if (parseerr != NULL) 1217 if (parseerr != NULL)
1220 *parseerr = err; 1218 *parseerr = err;
1221 return ret; 1219 return ret;