- djm@cvs.openbsd.org 2013/05/17 00:13:13

     [xmalloc.h cipher.c sftp-glob.c ssh-keyscan.c ssh.c sftp-common.c
     ssh-ecdsa.c auth2-chall.c compat.c readconf.c kexgexs.c monitor.c
     gss-genr.c cipher-3des1.c kex.c monitor_wrap.c ssh-pkcs11-client.c
     auth-options.c rsa.c auth2-pubkey.c sftp.c hostfile.c auth2.c
     servconf.c auth.c authfile.c xmalloc.c uuencode.c sftp-client.c
     auth2-gss.c sftp-server.c bufaux.c mac.c session.c jpake.c kexgexc.c
     sshconnect.c auth-chall.c auth2-passwd.c sshconnect1.c buffer.c
     kexecdhs.c kexdhs.c ssh-rsa.c auth1.c ssh-pkcs11.c auth2-kbdint.c
     kexdhc.c sshd.c umac.c ssh-dss.c auth2-jpake.c bufbn.c clientloop.c
     monitor_mm.c scp.c roaming_client.c serverloop.c key.c auth-rsa.c
     ssh-pkcs11-helper.c ssh-keysign.c ssh-keygen.c match.c channels.c
     sshconnect2.c addrmatch.c mux.c canohost.c kexecdhc.c schnorr.c
     ssh-add.c misc.c auth2-hostbased.c ssh-agent.c bufec.c groupaccess.c
     dns.c packet.c readpass.c authfd.c moduli.c]
     bye, bye xfree(); ok markus@

1 files changed, 52 insertions, 70 deletions

diff --git a/mux.c b/mux.c
index a6bcbbaca..6c55db981 100644
--- a/mux.c
+++ b/mux.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: mux.c,v 1.40 2013/04/22 01:17:18 dtucker Exp $ */
+/* $OpenBSD: mux.c,v 1.41 2013/05/17 00:13:13 djm Exp $ */
 /*
  * Copyright (c) 2002-2008 Damien Miller <djm@openbsd.org>
  *
@@ -287,13 +287,12 @@ process_mux_master_hello(u_int rid, Channel *c, Buffer *m, Buffer *r)
                 char *value = buffer_get_string_ret(m, NULL);
 
                 if (name == NULL || value == NULL) {
-                        if (name != NULL)
-                                xfree(name);
+                        free(name);
                         goto malf;
                 }
                 debug2("Unrecognised slave extension \"%s\"", name);
-                xfree(name);
-                xfree(value);
+                free(name);
+                free(value);
         }
         state->hello_rcvd = 1;
         return 0;
@@ -324,21 +323,17 @@ process_mux_new_session(u_int rid, Channel *c, Buffer *m, Buffer *r)
             (cctx->term = buffer_get_string_ret(m, &len)) == NULL ||
             (cmd = buffer_get_string_ret(m, &len)) == NULL) {
  malf:
-                if (cmd != NULL)
-                        xfree(cmd);
-                if (reserved != NULL)
-                        xfree(reserved);
+                free(cmd);
+                free(reserved);
                 for (j = 0; j < env_len; j++)
-                        xfree(cctx->env[j]);
-                if (env_len > 0)
-                        xfree(cctx->env);
-                if (cctx->term != NULL)
-                        xfree(cctx->term);
-                xfree(cctx);
+                        free(cctx->env[j]);
+                free(cctx->env);
+                free(cctx->term);
+                free(cctx);
                 error("%s: malformed message", __func__);
                 return -1;
         }
-        xfree(reserved);
+        free(reserved);
         reserved = NULL;
 
         while (buffer_len(m) > 0) {
@@ -346,7 +341,7 @@ process_mux_new_session(u_int rid, Channel *c, Buffer *m, Buffer *r)
                 if ((cp = buffer_get_string_ret(m, &len)) == NULL)
                         goto malf;
                 if (!env_permitted(cp)) {
-                        xfree(cp);
+                        free(cp);
                         continue;
                 }
                 cctx->env = xrealloc(cctx->env, env_len + 2,
@@ -367,7 +362,7 @@ process_mux_new_session(u_int rid, Channel *c, Buffer *m, Buffer *r)
 
         buffer_init(&cctx->cmd);
         buffer_append(&cctx->cmd, cmd, strlen(cmd));
-        xfree(cmd);
+        free(cmd);
         cmd = NULL;
 
         /* Gather fds from client */
@@ -378,12 +373,11 @@ process_mux_new_session(u_int rid, Channel *c, Buffer *m, Buffer *r)
                         for (j = 0; j < i; j++)
                                 close(new_fd[j]);
                         for (j = 0; j < env_len; j++)
-                                xfree(cctx->env[j]);
-                        if (env_len > 0)
-                                xfree(cctx->env);
-                        xfree(cctx->term);
+                                free(cctx->env[j]);
+                        free(cctx->env);
+                        free(cctx->term);
                         buffer_free(&cctx->cmd);
-                        xfree(cctx);
+                        free(cctx);
 
                         /* prepare reply */
                         buffer_put_int(r, MUX_S_FAILURE);
@@ -408,14 +402,14 @@ process_mux_new_session(u_int rid, Channel *c, Buffer *m, Buffer *r)
                 close(new_fd[0]);
                 close(new_fd[1]);
                 close(new_fd[2]);
-                xfree(cctx->term);
+                free(cctx->term);
                 if (env_len != 0) {
                         for (i = 0; i < env_len; i++)
-                                xfree(cctx->env[i]);
-                        xfree(cctx->env);
+                                free(cctx->env[i]);
+                        free(cctx->env);
                 }
                 buffer_free(&cctx->cmd);
-                xfree(cctx);
+                free(cctx);
                 return 0;
         }
 
@@ -620,7 +614,7 @@ mux_confirm_remote_forward(int type, u_int32_t seq, void *ctxt)
         buffer_put_int(&out, MUX_S_FAILURE);
         buffer_put_int(&out, fctx->rid);
         buffer_put_cstring(&out, failmsg);
-        xfree(failmsg);
+        free(failmsg);
  out:
         buffer_put_string(&c->output, buffer_ptr(&out), buffer_len(&out));
         buffer_free(&out);
@@ -649,11 +643,11 @@ process_mux_open_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
         }
 
         if (*fwd.listen_host == '\0') {
-                xfree(fwd.listen_host);
+                free(fwd.listen_host);
                 fwd.listen_host = NULL;
         }
         if (*fwd.connect_host == '\0') {
-                xfree(fwd.connect_host);
+                free(fwd.connect_host);
                 fwd.connect_host = NULL;
         }
 
@@ -664,10 +658,8 @@ process_mux_open_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
             ftype != MUX_FWD_DYNAMIC) {
                 logit("%s: invalid forwarding type %u", __func__, ftype);
  invalid:
-                if (fwd.listen_host)
-                        xfree(fwd.listen_host);
-                if (fwd.connect_host)
-                        xfree(fwd.connect_host);
+                free(fwd.listen_host);
+                free(fwd.connect_host);
                 buffer_put_int(r, MUX_S_FAILURE);
                 buffer_put_int(r, rid);
                 buffer_put_cstring(r, "Invalid forwarding request");
@@ -769,13 +761,10 @@ process_mux_open_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
         buffer_put_int(r, MUX_S_OK);
         buffer_put_int(r, rid);
  out:
-        if (fwd_desc != NULL)
-                xfree(fwd_desc);
+        free(fwd_desc);
         if (freefwd) {
-                if (fwd.listen_host != NULL)
-                        xfree(fwd.listen_host);
-                if (fwd.connect_host != NULL)
-                        xfree(fwd.connect_host);
+                free(fwd.listen_host);
+                free(fwd.connect_host);
         }
         return ret;
 }
@@ -801,11 +790,11 @@ process_mux_close_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
         }
 
         if (*fwd.listen_host == '\0') {
-                xfree(fwd.listen_host);
+                free(fwd.listen_host);
                 fwd.listen_host = NULL;
         }
         if (*fwd.connect_host == '\0') {
-                xfree(fwd.connect_host);
+                free(fwd.connect_host);
                 fwd.connect_host = NULL;
         }
 
@@ -862,10 +851,8 @@ process_mux_close_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
                 buffer_put_int(r, MUX_S_OK);
                 buffer_put_int(r, rid);
 
-                if (found_fwd->listen_host != NULL)
-                        xfree(found_fwd->listen_host);
-                if (found_fwd->connect_host != NULL)
-                        xfree(found_fwd->connect_host);
+                free(found_fwd->listen_host);
+                free(found_fwd->connect_host);
                 found_fwd->listen_host = found_fwd->connect_host = NULL;
                 found_fwd->listen_port = found_fwd->connect_port = 0;
         } else {
@@ -874,12 +861,9 @@ process_mux_close_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
                 buffer_put_cstring(r, error_reason);
         }
  out:
-        if (fwd_desc != NULL)
-                xfree(fwd_desc);
-        if (fwd.listen_host != NULL)
-                xfree(fwd.listen_host);
-        if (fwd.connect_host != NULL)
-                xfree(fwd.connect_host);
+        free(fwd_desc);
+        free(fwd.listen_host);
+        free(fwd.connect_host);
 
         return ret;
 }
@@ -896,14 +880,12 @@ process_mux_stdio_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
         if ((reserved = buffer_get_string_ret(m, NULL)) == NULL ||
            (chost = buffer_get_string_ret(m, NULL)) == NULL ||
             buffer_get_int_ret(&cport, m) != 0) {
-                if (reserved != NULL)
-                        xfree(reserved);
-                if (chost != NULL)
-                        xfree(chost);
+                free(reserved);
+                free(chost);
                 error("%s: malformed message", __func__);
                 return -1;
         }
-        xfree(reserved);
+        free(reserved);
 
         debug2("%s: channel %d: request stdio fwd to %s:%u",
             __func__, c->self, chost, cport);
@@ -915,7 +897,7 @@ process_mux_stdio_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
                             __func__, i);
                         for (j = 0; j < i; j++)
                                 close(new_fd[j]);
-                        xfree(chost);
+                        free(chost);
 
                         /* prepare reply */
                         buffer_put_int(r, MUX_S_FAILURE);
@@ -939,7 +921,7 @@ process_mux_stdio_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
  cleanup:
                 close(new_fd[0]);
                 close(new_fd[1]);
-                xfree(chost);
+                free(chost);
                 return 0;
         }
 
@@ -1001,7 +983,7 @@ process_mux_stop_listening(u_int rid, Channel *c, Buffer *m, Buffer *r)
         if (mux_listener_channel != NULL) {
                 channel_free(mux_listener_channel);
                 client_stop_mux();
-                xfree(options.control_path);
+                free(options.control_path);
                 options.control_path = NULL;
                 mux_listener_channel = NULL;
                 muxserver_sock = -1;
@@ -1198,8 +1180,8 @@ muxserver_listen(void)
                                 close(muxserver_sock);
                                 muxserver_sock = -1;
                         }
-                        xfree(orig_control_path);
-                        xfree(options.control_path);
+                        free(orig_control_path);
+                        free(options.control_path);
                         options.control_path = NULL;
                         options.control_master = SSHCTL_MASTER_NO;
                         return;
@@ -1224,7 +1206,7 @@ muxserver_listen(void)
                 goto disable_mux_master;
         }
         unlink(options.control_path);
-        xfree(options.control_path);
+        free(options.control_path);
         options.control_path = orig_control_path;
 
         set_nonblock(muxserver_sock);
@@ -1309,13 +1291,13 @@ mux_session_confirm(int id, int success, void *arg)
         cc->mux_pause = 0; /* start processing messages again */
         c->open_confirm_ctx = NULL;
         buffer_free(&cctx->cmd);
-        xfree(cctx->term);
+        free(cctx->term);
         if (cctx->env != NULL) {
                 for (i = 0; cctx->env[i] != NULL; i++)
-                        xfree(cctx->env[i]);
-                xfree(cctx->env);
+                        free(cctx->env[i]);
+                free(cctx->env);
         }
-        xfree(cctx);
+        free(cctx);
 }
 
 /* ** Multiplexing client support */
@@ -1499,8 +1481,8 @@ mux_client_hello_exchange(int fd)
                 char *value = buffer_get_string(&m, NULL);
 
                 debug2("Unrecognised master extension \"%s\"", name);
-                xfree(name);
-                xfree(value);
+                free(name);
+                free(value);
         }
         buffer_free(&m);
         return 0;
@@ -1609,7 +1591,7 @@ mux_client_forward(int fd, int cancel_flag, u_int ftype, Forward *fwd)
         fwd_desc = format_forward(ftype, fwd);
         debug("Requesting %s %s",
             cancel_flag ? "cancellation of" : "forwarding of", fwd_desc);
-        xfree(fwd_desc);
+        free(fwd_desc);
 
         buffer_init(&m);
         buffer_put_int(&m, cancel_flag ? MUX_C_CLOSE_FWD : MUX_C_OPEN_FWD);