diff options
author | Colin Watson <cjwatson@debian.org> | 2014-02-09 16:09:58 +0000 |
---|---|---|
committer | Colin Watson <cjwatson@debian.org> | 2017-03-29 01:39:47 +0100 |
commit | 0b9c0482cbff9ce16384e4247d955676d4d77df3 (patch) | |
tree | dcaaa33c770f1520a423e31d287ef10d827acc1b /readconf.c | |
parent | 980646a9f7f03b43b678272b2a56e30906c6ddec (diff) |
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
group-writable, provided that the group in question contains only the file's
owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
about the contents of gr->gr_mem). Given that per-user groups and umask 002
are the default setup in Debian (for good reasons - this makes operating in
setgid directories with other groups much easier), we need to permit this by
default.
Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
Last-Update: 2013-09-14
Patch-Name: user-group-modes.patch
Diffstat (limited to 'readconf.c')
-rw-r--r-- | readconf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/readconf.c b/readconf.c index 0b1370a8e..70fac6824 100644 --- a/readconf.c +++ b/readconf.c | |||
@@ -1773,8 +1773,7 @@ read_config_file_depth(const char *filename, struct passwd *pw, | |||
1773 | 1773 | ||
1774 | if (fstat(fileno(f), &sb) == -1) | 1774 | if (fstat(fileno(f), &sb) == -1) |
1775 | fatal("fstat %s: %s", filename, strerror(errno)); | 1775 | fatal("fstat %s: %s", filename, strerror(errno)); |
1776 | if (((sb.st_uid != 0 && sb.st_uid != getuid()) || | 1776 | if (!secure_permissions(&sb, getuid())) |
1777 | (sb.st_mode & 022) != 0)) | ||
1778 | fatal("Bad owner or permissions on %s", filename); | 1777 | fatal("Bad owner or permissions on %s", filename); |
1779 | } | 1778 | } |
1780 | 1779 | ||