- djm@cvs.openbsd.org 2011/05/24 07:15:47

     [readconf.c readconf.h ssh.c ssh_config.5 sshconnect.c sshconnect2.c]
     Remove undocumented legacy options UserKnownHostsFile2 and
     GlobalKnownHostsFile2 by making UserKnownHostsFile/GlobalKnownHostsFile
     accept multiple paths per line and making their defaults include
     known_hosts2; ok markus

1 files changed, 40 insertions, 29 deletions

diff --git a/readconf.c b/readconf.c
index 4780ae289..91dfa566f 100644
--- a/readconf.c
+++ b/readconf.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: readconf.c,v 1.192 2011/05/06 21:34:32 djm Exp $ */
+/* $OpenBSD: readconf.c,v 1.193 2011/05/24 07:15:47 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -193,9 +193,9 @@ static struct {
         { "host", oHost },
         { "escapechar", oEscapeChar },
         { "globalknownhostsfile", oGlobalKnownHostsFile },
-        { "globalknownhostsfile2", oGlobalKnownHostsFile2 },    /* obsolete */
+        { "globalknownhostsfile2", oDeprecated },
         { "userknownhostsfile", oUserKnownHostsFile },
-        { "userknownhostsfile2", oUserKnownHostsFile2 },        /* obsolete */
+        { "userknownhostsfile2", oDeprecated }, 
         { "connectionattempts", oConnectionAttempts },
         { "batchmode", oBatchMode },
         { "checkhostip", oCheckHostIP },
@@ -354,7 +354,9 @@ process_config_line(Options *options, const char *host,
                     char *line, const char *filename, int linenum,
                     int *activep)
 {
-        char *s, **charptr, *endofnumber, *keyword, *arg, *arg2, fwdarg[256];
+        char *s, **charptr, *endofnumber, *keyword, *arg, *arg2;
+        char **cpptr, fwdarg[256];
+        u_int *uintptr, max_entries = 0;
         int negated, opcode, *intptr, value, value2, scale;
         LogLevel *log_level_ptr;
         long long orig, val64;
@@ -598,26 +600,33 @@ parse_yesnoask:
 parse_string:
                 arg = strdelim(&s);
                 if (!arg || *arg == '\0')
-                        fatal("%.200s line %d: Missing argument.", filename, linenum);
+                        fatal("%.200s line %d: Missing argument.",
+                            filename, linenum);
                 if (*activep && *charptr == NULL)
                         *charptr = xstrdup(arg);
                 break;
 
         case oGlobalKnownHostsFile:
-                charptr = &options->system_hostfile;
-                goto parse_string;
+                cpptr = (char **)&options->system_hostfiles;
+                uintptr = &options->num_system_hostfiles;
+                max_entries = SSH_MAX_HOSTS_FILES;
+parse_char_array:
+                if (*activep && *uintptr == 0) {
+                        while ((arg = strdelim(&s)) != NULL && *arg != '\0') {
+                                if ((*uintptr) >= max_entries)
+                                        fatal("%s line %d: "
+                                            "too many authorized keys files.",
+                                            filename, linenum);
+                                cpptr[(*uintptr)++] = xstrdup(arg);
+                        }
+                }
+                return 0;
 
         case oUserKnownHostsFile:
-                charptr = &options->user_hostfile;
-                goto parse_string;
-
-        case oGlobalKnownHostsFile2:
-                charptr = &options->system_hostfile2;
-                goto parse_string;
-
-        case oUserKnownHostsFile2:
-                charptr = &options->user_hostfile2;
-                goto parse_string;
+                cpptr = (char **)&options->user_hostfiles;
+                uintptr = &options->num_user_hostfiles;
+                max_entries = SSH_MAX_HOSTS_FILES;
+                goto parse_char_array;
 
         case oHostName:
                 charptr = &options->hostname;
@@ -1158,10 +1167,8 @@ initialize_options(Options * options)
         options->proxy_command = NULL;
         options->user = NULL;
         options->escape_char = -1;
-        options->system_hostfile = NULL;
-        options->user_hostfile = NULL;
-        options->system_hostfile2 = NULL;
-        options->user_hostfile2 = NULL;
+        options->num_system_hostfiles = 0;
+        options->num_user_hostfiles = 0;
         options->local_forwards = NULL;
         options->num_local_forwards = 0;
         options->remote_forwards = NULL;
@@ -1301,14 +1308,18 @@ fill_default_options(Options * options)
         }
         if (options->escape_char == -1)
                 options->escape_char = '~';
-        if (options->system_hostfile == NULL)
-                options->system_hostfile = _PATH_SSH_SYSTEM_HOSTFILE;
-        if (options->user_hostfile == NULL)
-                options->user_hostfile = _PATH_SSH_USER_HOSTFILE;
-        if (options->system_hostfile2 == NULL)
-                options->system_hostfile2 = _PATH_SSH_SYSTEM_HOSTFILE2;
-        if (options->user_hostfile2 == NULL)
-                options->user_hostfile2 = _PATH_SSH_USER_HOSTFILE2;
+        if (options->num_system_hostfiles == 0) {
+                options->system_hostfiles[options->num_system_hostfiles++] =
+                    xstrdup(_PATH_SSH_SYSTEM_HOSTFILE);
+                options->system_hostfiles[options->num_system_hostfiles++] =
+                    xstrdup(_PATH_SSH_SYSTEM_HOSTFILE2);
+        }
+        if (options->num_user_hostfiles == 0) {
+                options->user_hostfiles[options->num_user_hostfiles++] =
+                    xstrdup(_PATH_SSH_USER_HOSTFILE);
+                options->user_hostfiles[options->num_user_hostfiles++] =
+                    xstrdup(_PATH_SSH_USER_HOSTFILE2);
+        }
         if (options->log_level == SYSLOG_LEVEL_NOT_SET)
                 options->log_level = SYSLOG_LEVEL_INFO;
         if (options->clear_forwardings == 1)