diff options
author | Colin Watson <cjwatson@debian.org> | 2014-02-09 16:09:58 +0000 |
---|---|---|
committer | Colin Watson <cjwatson@debian.org> | 2018-08-24 17:49:07 +0100 |
commit | 840f43066f9cdf5f6bb07992aca1c5f43be8eb80 (patch) | |
tree | eada7af8840576ed8b715b291101bc150914d004 /readconf.c | |
parent | d47fa6fefb418c6d8f5a6d3dd49fd9dc7fce0c74 (diff) |
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
group-writable, provided that the group in question contains only the file's
owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
about the contents of gr->gr_mem). Given that per-user groups and umask 002
are the default setup in Debian (for good reasons - this makes operating in
setgid directories with other groups much easier), we need to permit this by
default.
Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
Last-Update: 2017-10-04
Patch-Name: user-group-modes.patch
Diffstat (limited to 'readconf.c')
-rw-r--r-- | readconf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/readconf.c b/readconf.c index 3fd0fe7b7..3ed6dfb54 100644 --- a/readconf.c +++ b/readconf.c | |||
@@ -1795,8 +1795,7 @@ read_config_file_depth(const char *filename, struct passwd *pw, | |||
1795 | 1795 | ||
1796 | if (fstat(fileno(f), &sb) == -1) | 1796 | if (fstat(fileno(f), &sb) == -1) |
1797 | fatal("fstat %s: %s", filename, strerror(errno)); | 1797 | fatal("fstat %s: %s", filename, strerror(errno)); |
1798 | if (((sb.st_uid != 0 && sb.st_uid != getuid()) || | 1798 | if (!secure_permissions(&sb, getuid())) |
1799 | (sb.st_mode & 022) != 0)) | ||
1800 | fatal("Bad owner or permissions on %s", filename); | 1799 | fatal("Bad owner or permissions on %s", filename); |
1801 | } | 1800 | } |
1802 | 1801 | ||