* New upstream release (closes: #536182). Yes, I know 5.3p1 has been out

  for a while, but there's no GSSAPI patch available for it yet.
  - Change the default cipher order to prefer the AES CTR modes and the
    revised "arcfour256" mode to CBC mode ciphers that are susceptible to
    CPNI-957037 "Plaintext Recovery Attack Against SSH".
  - Add countermeasures to mitigate CPNI-957037-style attacks against the
    SSH protocol's use of CBC-mode ciphers. Upon detection of an invalid
    packet length or Message Authentication Code, ssh/sshd will continue
    reading up to the maximum supported packet length rather than
    immediately terminating the connection. This eliminates most of the
    known differences in behaviour that leaked information about the
    plaintext of injected data which formed the basis of this attack
    (closes: #506115, LP: #379329).
  - ForceCommand directive now accepts commandline arguments for the
    internal-sftp server (closes: #524423, LP: #362511).
  - Add AllowAgentForwarding to available Match keywords list (closes:
    #540623).
  - Make ssh(1) send the correct channel number for
    SSH2_MSG_CHANNEL_SUCCESS and SSH2_MSG_CHANNEL_FAILURE messages to
    avoid triggering 'Non-public channel' error messages on sshd(8) in
    openssh-5.1.
  - Avoid printing 'Non-public channel' warnings in sshd(8), since the
    ssh(1) has sent incorrect channel numbers since ~2004 (this reverts a
    behaviour introduced in openssh-5.1; closes: #496017).
* Update to GSSAPI patch from
  http://www.sxw.org.uk/computing/patches/openssh-5.2p1-gsskex-all-20090726.patch,
  including cascading credentials support (LP: #416958).

1 files changed, 25 insertions, 30 deletions

diff --git a/ssh.c b/ssh.c
index 2b55e6397..9e1a4b797 100644
--- a/ssh.c
+++ b/ssh.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh.c,v 1.318 2008/07/02 13:47:39 djm Exp $ */
+/* $OpenBSD: ssh.c,v 1.324 2009/02/12 03:00:56 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -179,7 +179,7 @@ static void
 usage(void)
 {
         fprintf(stderr,
-"usage: ssh [-1246AaCfgKkMNnqsTtVvXxY] [-b bind_address] [-c cipher_spec]\n"
+"usage: ssh [-1246AaCfgKkMNnqsTtVvXxYy] [-b bind_address] [-c cipher_spec]\n"
 "           [-D [bind_address:]port] [-e escape_char] [-F configfile]\n"
 "           [-i identity_file] [-L [bind_address:]port:host:hostport]\n"
 "           [-l login_name] [-m mac_spec] [-O ctl_cmd] [-o option] [-p port]\n"
@@ -203,7 +203,7 @@ void muxserver_listen(void);
 int
 main(int ac, char **av)
 {
-        int i, opt, exit_status;
+        int i, opt, exit_status, use_syslog;
         char *p, *cp, *line, buf[256];
         struct stat st;
         struct passwd *pw;
@@ -269,10 +269,11 @@ main(int ac, char **av)
 
         /* Parse command-line arguments. */
         host = NULL;
+        use_syslog = 0;
 
  again:
         while ((opt = getopt(ac, av, "1246ab:c:e:fgi:kl:m:no:p:qstvx"
-            "ACD:F:I:KL:MNO:PR:S:TVw:XY")) != -1) {
+            "ACD:F:I:KL:MNO:PR:S:TVw:XYy")) != -1) {
                 switch (opt) {
                 case '1':
                         options.protocol = SSH_PROTO_1;
@@ -299,6 +300,9 @@ main(int ac, char **av)
                 case 'X':
                         options.forward_x11 = 1;
                         break;
+                case 'y':
+                        use_syslog = 1;
+                        break;
                 case 'Y':
                         options.forward_x11 = 1;
                         options.forward_x11_trusted = 1;
@@ -444,7 +448,7 @@ main(int ac, char **av)
                         break;
                 case 'p':
                         options.port = a2port(optarg);
-                        if (options.port == 0) {
+                        if (options.port <= 0) {
                                 fprintf(stderr, "Bad port '%s'\n", optarg);
                                 exit(255);
                         }
@@ -454,7 +458,7 @@ main(int ac, char **av)
                         break;
 
                 case 'L':
-                        if (parse_forward(&fwd, optarg))
+                        if (parse_forward(&fwd, optarg, 0, 0))
                                 add_local_forward(&options, &fwd);
                         else {
                                 fprintf(stderr,
@@ -465,7 +469,7 @@ main(int ac, char **av)
                         break;
 
                 case 'R':
-                        if (parse_forward(&fwd, optarg)) {
+                        if (parse_forward(&fwd, optarg, 0, 1)) {
                                 add_remote_forward(&options, &fwd);
                         } else {
                                 fprintf(stderr,
@@ -476,30 +480,14 @@ main(int ac, char **av)
                         break;
 
                 case 'D':
-                        cp = p = xstrdup(optarg);
-                        memset(&fwd, '\0', sizeof(fwd));
-                        fwd.connect_host = "socks";
-                        if ((fwd.listen_host = hpdelim(&cp)) == NULL) {
-                                fprintf(stderr, "Bad dynamic forwarding "
-                                    "specification '%.100s'\n", optarg);
-                                exit(255);
-                        }
-                        if (cp != NULL) {
-                                fwd.listen_port = a2port(cp);
-                                fwd.listen_host =
-                                    cleanhostname(fwd.listen_host);
+                        if (parse_forward(&fwd, optarg, 1, 0)) {
+                                add_local_forward(&options, &fwd);
                         } else {
-                                fwd.listen_port = a2port(fwd.listen_host);
-                                fwd.listen_host = NULL;
-                        }
-
-                        if (fwd.listen_port == 0) {
-                                fprintf(stderr, "Bad dynamic port '%s'\n",
-                                    optarg);
+                                fprintf(stderr,
+                                    "Bad dynamic forwarding specification "
+                                    "'%s'\n", optarg);
                                 exit(255);
                         }
-                        add_local_forward(&options, &fwd);
-                        xfree(p);
                         break;
 
                 case 'C':
@@ -619,7 +607,7 @@ main(int ac, char **av)
          */
         log_init(av[0],
             options.log_level == -1 ? SYSLOG_LEVEL_INFO : options.log_level,
-            SYSLOG_FACILITY_USER, 1);
+            SYSLOG_FACILITY_USER, !use_syslog);
 
         /*
          * Read per-user configuration file.  Ignore the system wide config
@@ -645,7 +633,7 @@ main(int ac, char **av)
         channel_set_af(options.address_family);
 
         /* reinit */
-        log_init(av[0], options.log_level, SYSLOG_FACILITY_USER, 1);
+        log_init(av[0], options.log_level, SYSLOG_FACILITY_USER, !use_syslog);
 
         seed_rng();
 
@@ -854,9 +842,16 @@ ssh_confirm_remote_forward(int type, u_int32_t seq, void *ctxt)
 {
         Forward *rfwd = (Forward *)ctxt;
 
+        /* XXX verbose() on failure? */
         debug("remote forward %s for: listen %d, connect %s:%d",
             type == SSH2_MSG_REQUEST_SUCCESS ? "success" : "failure",
             rfwd->listen_port, rfwd->connect_host, rfwd->connect_port);
+        if (type == SSH2_MSG_REQUEST_SUCCESS && rfwd->listen_port == 0) {
+                logit("Allocated port %u for remote forward to %s:%d",
+                        packet_get_int(),
+                        rfwd->connect_host, rfwd->connect_port);
+        }
+        
         if (type == SSH2_MSG_REQUEST_FAILURE) {
                 if (options.exit_on_forward_failure)
                         fatal("Error: remote port forwarding failed for "