summaryrefslogtreecommitdiff
path: root/sshconnect.c
diff options
context:
space:
mode:
authorColin Watson <cjwatson@debian.org>2014-02-09 16:10:00 +0000
committerColin Watson <cjwatson@debian.org>2014-03-20 00:32:29 +0000
commit6103c29d855e82c098e88ee12f05a6eb41f659ce (patch)
tree90840fe4ee4dbf9ed07d1e4fd5452037d35111a4 /sshconnect.c
parent8ab204ee192e655d5a8f4d599adb3d99eeabedc6 (diff)
Look for $SHELL on the path for ProxyCommand/LocalCommand
There's some debate on the upstream bug about whether POSIX requires this. I (Colin Watson) agree with Vincent and think it does. Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1494 Bug-Debian: http://bugs.debian.org/492728 Last-Update: 2013-09-14 Patch-Name: shell-path.patch
Diffstat (limited to 'sshconnect.c')
-rw-r--r--sshconnect.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sshconnect.c b/sshconnect.c
index 573d7a8e8..9e02837ac 100644
--- a/sshconnect.c
+++ b/sshconnect.c
@@ -227,7 +227,7 @@ ssh_proxy_connect(const char *host, u_short port, const char *proxy_command)
227 /* Execute the proxy command. Note that we gave up any 227 /* Execute the proxy command. Note that we gave up any
228 extra privileges above. */ 228 extra privileges above. */
229 signal(SIGPIPE, SIG_DFL); 229 signal(SIGPIPE, SIG_DFL);
230 execv(argv[0], argv); 230 execvp(argv[0], argv);
231 perror(argv[0]); 231 perror(argv[0]);
232 exit(1); 232 exit(1);
233 } 233 }
@@ -1387,7 +1387,7 @@ ssh_local_cmd(const char *args)
1387 if (pid == 0) { 1387 if (pid == 0) {
1388 signal(SIGPIPE, SIG_DFL); 1388 signal(SIGPIPE, SIG_DFL);
1389 debug3("Executing %s -c \"%s\"", shell, args); 1389 debug3("Executing %s -c \"%s\"", shell, args);
1390 execl(shell, shell, "-c", args, (char *)NULL); 1390 execlp(shell, shell, "-c", args, (char *)NULL);
1391 error("Couldn't execute %s -c \"%s\": %s", 1391 error("Couldn't execute %s -c \"%s\": %s",
1392 shell, args, strerror(errno)); 1392 shell, args, strerror(errno));
1393 _exit(1); 1393 _exit(1);