- djm@cvs.openbsd.org 2006/03/25 00:05:41

     [auth-bsdauth.c auth-skey.c auth.c auth2-chall.c channels.c]
     [clientloop.c deattack.c gss-genr.c kex.c key.c misc.c moduli.c]
     [monitor.c monitor_wrap.c packet.c scard.c sftp-server.c ssh-agent.c]
     [ssh-keyscan.c ssh.c sshconnect.c sshconnect2.c sshd.c uuencode.c]
     [xmalloc.c xmalloc.h]
     introduce xcalloc() and xasprintf() failure-checked allocations
     functions and use them throughout openssh

     xcalloc is particularly important because malloc(nmemb * size) is a
     dangerous idiom (subject to integer overflow) and it is time for it
     to die

     feedback and ok deraadt@

1 files changed, 3 insertions, 7 deletions

diff --git a/sshconnect2.c b/sshconnect2.c
index f8d21489e..c3501c2a5 100644
--- a/sshconnect2.c
+++ b/sshconnect2.c
@@ -1029,8 +1029,7 @@ pubkey_prepare(Authctxt *authctxt)
                 if (key && key->type == KEY_RSA1)
                         continue;
                 options.identity_keys[i] = NULL;
-                id = xmalloc(sizeof(*id));
-                memset(id, 0, sizeof(*id));
+                id = xcalloc(1, sizeof(*id));
                 id->key = key;
                 id->filename = xstrdup(options.identity_files[i]);
                 TAILQ_INSERT_TAIL(&files, id, next);
@@ -1054,8 +1053,7 @@ pubkey_prepare(Authctxt *authctxt)
                                 }
                         }
                         if (!found && !options.identities_only) {
-                                id = xmalloc(sizeof(*id));
-                                memset(id, 0, sizeof(*id));
+                                id = xcalloc(1, sizeof(*id));
                                 id->key = key;
                                 id->filename = comment;
                                 id->ac = ac;
@@ -1336,9 +1334,7 @@ userauth_hostbased(Authctxt *authctxt)
                 return 0;
         }
         len = strlen(p) + 2;
-        chost = xmalloc(len);
-        strlcpy(chost, p, len);
-        strlcat(chost, ".", len);
+        xasprintf(&chost, "%s.", p);
         debug2("userauth_hostbased: chost %s", chost);
         xfree(p);