upstream: use sshpkt_fatal() for kex_exchange_identification()

errors. This ensures that the logged errors are consistent with other
transport- layer errors and that the relevant IP addresses are logged. bz3129
ok dtucker@

OpenBSD-Commit-ID: 2c22891f0b9e1a6cd46771cedbb26ac96ec2e6ab

1 files changed, 4 insertions, 3 deletions

diff --git a/sshd.c b/sshd.c
index e59077911..6f8f11a3b 100644
--- a/sshd.c
+++ b/sshd.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sshd.c,v 1.551 2020/03/13 03:24:49 dtucker Exp $ */
+/* $OpenBSD: sshd.c,v 1.552 2020/03/13 04:01:57 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -2155,8 +2155,9 @@ main(int ac, char **av)
         if (!debug_flag)
                 alarm(options.login_grace_time);
 
-        if (kex_exchange_identification(ssh, -1, options.version_addendum) != 0)
-                cleanup_exit(255); /* error already logged */
+        if ((r = kex_exchange_identification(ssh, -1,
+            options.version_addendum)) != 0)
+                sshpkt_fatal(ssh, r, "banner exchange");
 
         ssh_packet_set_nonblocking(ssh);