Fix memory leak of blacklisted host keys (thanks, Dmitry V. Levin).

1 files changed, 5 insertions, 4 deletions

diff --git a/sshd.c b/sshd.c
index 80cfd56d8..ac539d6bb 100644
--- a/sshd.c
+++ b/sshd.c
@@ -1496,10 +1496,6 @@ main(int ac, char **av)
 
         for (i = 0; i < options.num_host_key_files; i++) {
                 key = key_load_private(options.host_key_files[i], "", NULL);
-                if (key && reject_blacklisted_key(key, 1) == 1) {
-                        sensitive_data.host_keys[i] = NULL;
-                        continue;
-                }
                 sensitive_data.host_keys[i] = key;
                 if (key == NULL) {
                         error("Could not load host key: %s",
@@ -1507,6 +1503,11 @@ main(int ac, char **av)
                         sensitive_data.host_keys[i] = NULL;
                         continue;
                 }
+                if (reject_blacklisted_key(key, 1) == 1) {
+                        key_free(key);
+                        sensitive_data.host_keys[i] = NULL;
+                        continue;
+                }
                 switch (key->type) {
                 case KEY_RSA1:
                         sensitive_data.ssh1_host_key = key;