diff options
author | Damien Miller <djm@mindrot.org> | 2019-09-13 13:12:42 +1000 |
---|---|---|
committer | Damien Miller <djm@mindrot.org> | 2019-09-13 13:15:14 +1000 |
commit | c17e4638e5592688264fc0349f61bfc7b4425aa5 (patch) | |
tree | 58f25b12311c84426d1a250d33398ddea5a48c49 /uidswap.c | |
parent | 91a2135f32acdd6378476c5bae475a6e7811a6a2 (diff) |
explicitly test set[ug]id() return values
Legacy !_POSIX_SAVED_IDS path only; coverity report via Ed Maste
ok dtucker@
Diffstat (limited to 'uidswap.c')
-rw-r--r-- | uidswap.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -162,8 +162,10 @@ restore_uid(void) | |||
162 | * Propagate the real uid (usually more privileged) to effective uid | 162 | * Propagate the real uid (usually more privileged) to effective uid |
163 | * as well. | 163 | * as well. |
164 | */ | 164 | */ |
165 | setuid(getuid()); | 165 | if (setuid(getuid()) == -1) |
166 | setgid(getgid()); | 166 | fatal("%s: setuid failed: %s", __func__, strerror(errno)); |
167 | if (setgid(getgid()) == -1) | ||
168 | fatal("%s: setgid failed: %s", __func__, strerror(errno)); | ||
167 | #endif /* SAVED_IDS_WORK_WITH_SETEUID */ | 169 | #endif /* SAVED_IDS_WORK_WITH_SETEUID */ |
168 | 170 | ||
169 | if (setgroups(saved_egroupslen, saved_egroups) == -1) | 171 | if (setgroups(saved_egroupslen, saved_egroups) == -1) |