summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog6
-rw-r--r--dh.c3
-rw-r--r--readconf.c3
-rw-r--r--servconf.c3
4 files changed, 11 insertions, 4 deletions
diff --git a/ChangeLog b/ChangeLog
index 1093f5453..19425d867 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -26,6 +26,10 @@
26 [hostfile.c] 26 [hostfile.c]
27 FILE* leak detected by Coverity via elad AT netbsd.org; 27 FILE* leak detected by Coverity via elad AT netbsd.org;
28 ok deraadt@ 28 ok deraadt@
29 - djm@cvs.openbsd.org 2006/03/19 02:24:05
30 [dh.c readconf.c servconf.c]
31 potential NULL pointer dereferences detected by Coverity
32 via elad AT netbsd.org; ok deraadt@
29 33
3020060325 3420060325
31 - OpenBSD CVS Sync 35 - OpenBSD CVS Sync
@@ -4283,4 +4287,4 @@
4283 - (djm) Trim deprecated options from INSTALL. Mention UsePAM 4287 - (djm) Trim deprecated options from INSTALL. Mention UsePAM
4284 - (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu 4288 - (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu
4285 4289
4286$Id: ChangeLog,v 1.4248 2006/03/26 02:52:20 djm Exp $ 4290$Id: ChangeLog,v 1.4249 2006/03/26 02:53:32 djm Exp $
diff --git a/dh.c b/dh.c
index a30b704fb..e8ce3d1a9 100644
--- a/dh.c
+++ b/dh.c
@@ -45,7 +45,8 @@ parse_prime(int linenum, char *line, struct dhgroup *dhg)
45 char *strsize, *gen, *prime; 45 char *strsize, *gen, *prime;
46 46
47 cp = line; 47 cp = line;
48 arg = strdelim(&cp); 48 if ((arg = strdelim(&cp)) == NULL)
49 return 0;
49 /* Ignore leading whitespace */ 50 /* Ignore leading whitespace */
50 if (*arg == '\0') 51 if (*arg == '\0')
51 arg = strdelim(&cp); 52 arg = strdelim(&cp);
diff --git a/readconf.c b/readconf.c
index 1112d0d86..e2e10d9d6 100644
--- a/readconf.c
+++ b/readconf.c
@@ -324,7 +324,8 @@ process_config_line(Options *options, const char *host,
324 324
325 s = line; 325 s = line;
326 /* Get the keyword. (Each line is supposed to begin with a keyword). */ 326 /* Get the keyword. (Each line is supposed to begin with a keyword). */
327 keyword = strdelim(&s); 327 if ((keyword = strdelim(&s)) == NULL)
328 return 0;
328 /* Ignore leading whitespace. */ 329 /* Ignore leading whitespace. */
329 if (*keyword == '\0') 330 if (*keyword == '\0')
330 keyword = strdelim(&s); 331 keyword = strdelim(&s);
diff --git a/servconf.c b/servconf.c
index 2ae93d4c3..7923f5df4 100644
--- a/servconf.c
+++ b/servconf.c
@@ -447,7 +447,8 @@ process_server_config_line(ServerOptions *options, char *line,
447 u_int i; 447 u_int i;
448 448
449 cp = line; 449 cp = line;
450 arg = strdelim(&cp); 450 if ((arg = strdelim(&cp)) != NULL)
451 return 0;
451 /* Ignore leading whitespace */ 452 /* Ignore leading whitespace */
452 if (*arg == '\0') 453 if (*arg == '\0')
453 arg = strdelim(&cp); 454 arg = strdelim(&cp);