1 files changed, 62 insertions, 24 deletions

diff --git a/auth2-pubkey.c b/auth2-pubkey.c
index f980b0dad..7c0ceee55 100644
--- a/auth2-pubkey.c
+++ b/auth2-pubkey.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: auth2-pubkey.c,v 1.34 2013/02/14 21:35:59 djm Exp $ */
+/* $OpenBSD: auth2-pubkey.c,v 1.38 2013/06/21 00:34:49 djm Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -75,7 +75,7 @@ userauth_pubkey(Authctxt *authctxt)
 {
         Buffer b;
         Key *key = NULL;
-        char *pkalg;
+        char *pkalg, *userstyle;
         u_char *pkblob, *sig;
         u_int alen, blen, slen;
         int have_sig, pktype;
@@ -127,7 +127,11 @@ userauth_pubkey(Authctxt *authctxt)
                 }
                 /* reconstruct packet */
                 buffer_put_char(&b, SSH2_MSG_USERAUTH_REQUEST);
-                buffer_put_cstring(&b, authctxt->user);
+                xasprintf(&userstyle, "%s%s%s", authctxt->user,
+                    authctxt->style ? ":" : "",
+                    authctxt->style ? authctxt->style : "");
+                buffer_put_cstring(&b, userstyle);
+                free(userstyle);
                 buffer_put_cstring(&b,
                     datafellows & SSH_BUG_PKSERVICE ?
                     "ssh-userauth" :
@@ -143,6 +147,8 @@ userauth_pubkey(Authctxt *authctxt)
 #ifdef DEBUG_PK
                 buffer_dump(&b);
 #endif
+                pubkey_auth_info(authctxt, key, NULL);
+
                 /* test for correct signature */
                 authenticated = 0;
                 if (PRIVSEP(user_key_allowed(authctxt->pw, key)) &&
@@ -150,7 +156,7 @@ userauth_pubkey(Authctxt *authctxt)
                     buffer_len(&b))) == 1)
                         authenticated = 1;
                 buffer_free(&b);
-                xfree(sig);
+                free(sig);
         } else {
                 debug("test whether pkalg/pkblob are acceptable");
                 packet_check_eom();
@@ -178,11 +184,45 @@ done:
         debug2("userauth_pubkey: authenticated %d pkalg %s", authenticated, pkalg);
         if (key != NULL)
                 key_free(key);
-        xfree(pkalg);
-        xfree(pkblob);
+        free(pkalg);
+        free(pkblob);
         return authenticated;
 }
 
+void
+pubkey_auth_info(Authctxt *authctxt, const Key *key, const char *fmt, ...)
+{
+        char *fp, *extra;
+        va_list ap;
+        int i;
+
+        extra = NULL;
+        if (fmt != NULL) {
+                va_start(ap, fmt);
+                i = vasprintf(&extra, fmt, ap);
+                va_end(ap);
+                if (i < 0 || extra == NULL)
+                        fatal("%s: vasprintf failed", __func__);        
+        }
+
+        if (key_is_cert(key)) {
+                fp = key_fingerprint(key->cert->signature_key,
+                    SSH_FP_MD5, SSH_FP_HEX);
+                auth_info(authctxt, "%s ID %s (serial %llu) CA %s %s%s%s", 
+                    key_type(key), key->cert->key_id,
+                    (unsigned long long)key->cert->serial,
+                    key_type(key->cert->signature_key), fp,
+                    extra == NULL ? "" : ", ", extra == NULL ? "" : extra);
+                free(fp);
+        } else {
+                fp = key_fingerprint(key, SSH_FP_MD5, SSH_FP_HEX);
+                auth_info(authctxt, "%s %s%s%s", key_type(key), fp,
+                    extra == NULL ? "" : ", ", extra == NULL ? "" : extra);
+                free(fp);
+        }
+        free(extra);
+}
+
 static int
 match_principals_option(const char *principal_list, struct KeyCert *cert)
 {
@@ -196,7 +236,7 @@ match_principals_option(const char *principal_list, struct KeyCert *cert)
                     principal_list, NULL)) != NULL) {
                         debug3("matched principal from key options \"%.100s\"",
                             result);
-                        xfree(result);
+                        free(result);
                         return 1;
                 }
         }
@@ -277,13 +317,14 @@ check_authkeys_file(FILE *f, char *file, Key* key, struct passwd *pw)
         char *fp;
 
         found_key = 0;
-        found = key_new(key_is_cert(key) ? KEY_UNSPEC : key->type);
 
+        found = NULL;
         auth_start_parse_options();
-
         while (read_keyfile_line(f, file, line, sizeof(line), &linenum) != -1) {
                 char *cp, *key_options = NULL;
-
+                if (found != NULL)
+                        key_free(found);
+                found = key_new(key_is_cert(key) ? KEY_UNSPEC : key->type);
                 auth_clear_options();
 
                 /* Skip leading whitespace, empty and comment lines. */
@@ -335,7 +376,7 @@ check_authkeys_file(FILE *f, char *file, Key* key, struct passwd *pw)
                                 reason = "Certificate does not contain an "
                                     "authorized principal";
  fail_reason:
-                                xfree(fp);
+                                free(fp);
                                 error("%s", reason);
                                 auth_debug_add("%s", reason);
                                 continue;
@@ -345,13 +386,13 @@ check_authkeys_file(FILE *f, char *file, Key* key, struct passwd *pw)
                             &reason) != 0)
                                 goto fail_reason;
                         if (auth_cert_options(key, pw) != 0) {
-                                xfree(fp);
+                                free(fp);
                                 continue;
                         }
                         verbose("Accepted certificate ID \"%s\" "
                             "signed by %s CA %s via %s", key->cert->key_id,
                             key_type(found), fp, file);
-                        xfree(fp);
+                        free(fp);
                         found_key = 1;
                         break;
                 } else if (key_equal(found, key)) {
@@ -361,16 +402,15 @@ check_authkeys_file(FILE *f, char *file, Key* key, struct passwd *pw)
                         if (key_is_cert_authority)
                                 continue;
                         found_key = 1;
-                        debug("matching key found: file %s, line %lu",
-                            file, linenum);
                         fp = key_fingerprint(found, SSH_FP_MD5, SSH_FP_HEX);
-                        verbose("Found matching %s key: %s",
-                            key_type(found), fp);
-                        xfree(fp);
+                        debug("matching key found: file %s, line %lu %s %s",
+                            file, linenum, key_type(found), fp);
+                        free(fp);
                         break;
                 }
         }
-        key_free(found);
+        if (found != NULL)
+                key_free(found);
         if (!found_key)
                 debug2("key not found");
         return found_key;
@@ -425,10 +465,8 @@ user_cert_trusted_ca(struct passwd *pw, Key *key)
         ret = 1;
 
  out:
-        if (principals_file != NULL)
-                xfree(principals_file);
-        if (ca_fp != NULL)
-                xfree(ca_fp);
+        free(principals_file);
+        free(ca_fp);
         return ret;
 }
 
@@ -634,7 +672,7 @@ user_key_allowed(struct passwd *pw, Key *key)
                     options.authorized_keys_files[i], pw);
 
                 success = user_key_allowed2(pw, key, file);
-                xfree(file);
+                free(file);
         }
 
         return success;