summaryrefslogtreecommitdiff
path: root/debian/patches
diff options
context:
space:
mode:
Diffstat (limited to 'debian/patches')
-rw-r--r--debian/patches/auth-log-verbosity.patch133
-rw-r--r--debian/patches/authorized-keys-man-symlink.patch26
-rw-r--r--debian/patches/consolekit.patch576
-rw-r--r--debian/patches/debian-banner.patch111
-rw-r--r--debian/patches/debian-config.patch157
-rw-r--r--debian/patches/dnssec-sshfp.patch94
-rw-r--r--debian/patches/doc-hash-tab-completion.patch28
-rw-r--r--debian/patches/doc-upstart.patch29
-rw-r--r--debian/patches/gnome-ssh-askpass2-icon.patch26
-rw-r--r--debian/patches/gssapi.patch3085
-rw-r--r--debian/patches/helpful-wait-terminate.patch26
-rw-r--r--debian/patches/keepalive-extensions.patch135
-rw-r--r--debian/patches/lintian-symlink-pickiness.patch32
-rw-r--r--debian/patches/mention-ssh-keygen-on-keychange.patch41
-rw-r--r--debian/patches/no-openssl-version-status.patch62
-rw-r--r--debian/patches/openbsd-docs.patch148
-rw-r--r--debian/patches/package-versioning.patch65
-rw-r--r--debian/patches/quieter-signals.patch40
-rw-r--r--debian/patches/restore-tcp-wrappers.patch172
-rw-r--r--debian/patches/scp-quoting.patch41
-rw-r--r--debian/patches/selinux-role.patch504
-rw-r--r--debian/patches/series29
-rw-r--r--debian/patches/shell-path.patch39
-rw-r--r--debian/patches/sigstop.patch35
-rw-r--r--debian/patches/ssh-agent-setgid.patch40
-rw-r--r--debian/patches/ssh-argv0.patch31
-rw-r--r--debian/patches/ssh-vulnkey-compat.patch42
-rw-r--r--debian/patches/ssh1-keepalive.patch74
-rw-r--r--debian/patches/syslog-level-silent.patch47
-rw-r--r--debian/patches/user-group-modes.patch266
30 files changed, 6134 insertions, 0 deletions
diff --git a/debian/patches/auth-log-verbosity.patch b/debian/patches/auth-log-verbosity.patch
new file mode 100644
index 000000000..491656be2
--- /dev/null
+++ b/debian/patches/auth-log-verbosity.patch
@@ -0,0 +1,133 @@
1From c9c2ebb4680ea6872218b1e4519fe31a2043a27a Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:02 +0000
4Subject: Quieten logs when multiple from= restrictions are used
5
6Bug-Debian: http://bugs.debian.org/630606
7Forwarded: no
8Last-Update: 2013-09-14
9
10Patch-Name: auth-log-verbosity.patch
11---
12 auth-options.c | 35 ++++++++++++++++++++++++++---------
13 auth-options.h | 1 +
14 auth-rsa.c | 2 ++
15 auth2-pubkey.c | 3 +++
16 4 files changed, 32 insertions(+), 9 deletions(-)
17
18diff --git a/auth-options.c b/auth-options.c
19index 4f0da9c..3fa236e 100644
20--- a/auth-options.c
21+++ b/auth-options.c
22@@ -58,9 +58,20 @@ int forced_tun_device = -1;
23 /* "principals=" option. */
24 char *authorized_principals = NULL;
25
26+/* Throttle log messages. */
27+int logged_from_hostip = 0;
28+int logged_cert_hostip = 0;
29+
30 extern ServerOptions options;
31
32 void
33+auth_start_parse_options(void)
34+{
35+ logged_from_hostip = 0;
36+ logged_cert_hostip = 0;
37+}
38+
39+void
40 auth_clear_options(void)
41 {
42 no_agent_forwarding_flag = 0;
43@@ -288,10 +299,13 @@ auth_parse_options(struct passwd *pw, char *opts, char *file, u_long linenum)
44 /* FALLTHROUGH */
45 case 0:
46 free(patterns);
47- logit("Authentication tried for %.100s with "
48- "correct key but not from a permitted "
49- "host (host=%.200s, ip=%.200s).",
50- pw->pw_name, remote_host, remote_ip);
51+ if (!logged_from_hostip) {
52+ logit("Authentication tried for %.100s with "
53+ "correct key but not from a permitted "
54+ "host (host=%.200s, ip=%.200s).",
55+ pw->pw_name, remote_host, remote_ip);
56+ logged_from_hostip = 1;
57+ }
58 auth_debug_add("Your host '%.200s' is not "
59 "permitted to use this key for login.",
60 remote_host);
61@@ -514,11 +528,14 @@ parse_option_list(struct sshbuf *oblob, struct passwd *pw,
62 break;
63 case 0:
64 /* no match */
65- logit("Authentication tried for %.100s "
66- "with valid certificate but not "
67- "from a permitted host "
68- "(ip=%.200s).", pw->pw_name,
69- remote_ip);
70+ if (!logged_cert_hostip) {
71+ logit("Authentication tried for %.100s "
72+ "with valid certificate but not "
73+ "from a permitted host "
74+ "(ip=%.200s).", pw->pw_name,
75+ remote_ip);
76+ logged_cert_hostip = 1;
77+ }
78 auth_debug_add("Your address '%.200s' "
79 "is not permitted to use this "
80 "certificate for login.",
81diff --git a/auth-options.h b/auth-options.h
82index 34852e5..1653855 100644
83--- a/auth-options.h
84+++ b/auth-options.h
85@@ -33,6 +33,7 @@ extern int forced_tun_device;
86 extern int key_is_cert_authority;
87 extern char *authorized_principals;
88
89+void auth_start_parse_options(void);
90 int auth_parse_options(struct passwd *, char *, char *, u_long);
91 void auth_clear_options(void);
92 int auth_cert_options(struct sshkey *, struct passwd *);
93diff --git a/auth-rsa.c b/auth-rsa.c
94index cbd971b..4cf2163 100644
95--- a/auth-rsa.c
96+++ b/auth-rsa.c
97@@ -181,6 +181,8 @@ rsa_key_allowed_in_file(struct passwd *pw, char *file,
98 if ((f = auth_openkeyfile(file, pw, options.strict_modes)) == NULL)
99 return 0;
100
101+ auth_start_parse_options();
102+
103 /*
104 * Go though the accepted keys, looking for the current key. If
105 * found, perform a challenge-response dialog to verify that the
106diff --git a/auth2-pubkey.c b/auth2-pubkey.c
107index d943efa..0bda5c9 100644
108--- a/auth2-pubkey.c
109+++ b/auth2-pubkey.c
110@@ -282,6 +282,7 @@ match_principals_file(char *file, struct passwd *pw, struct sshkey_cert *cert)
111 restore_uid();
112 return 0;
113 }
114+ auth_start_parse_options();
115 while (read_keyfile_line(f, file, line, sizeof(line), &linenum) != -1) {
116 /* Skip leading whitespace. */
117 for (cp = line; *cp == ' ' || *cp == '\t'; cp++)
118@@ -343,6 +344,7 @@ check_authkeys_file(FILE *f, char *file, Key* key, struct passwd *pw)
119 found_key = 0;
120
121 found = NULL;
122+ auth_start_parse_options();
123 while (read_keyfile_line(f, file, line, sizeof(line), &linenum) != -1) {
124 char *cp, *key_options = NULL;
125 if (found != NULL)
126@@ -482,6 +484,7 @@ user_cert_trusted_ca(struct passwd *pw, Key *key)
127 if (key_cert_check_authority(key, 0, 1,
128 principals_file == NULL ? pw->pw_name : NULL, &reason) != 0)
129 goto fail_reason;
130+ auth_start_parse_options();
131 if (auth_cert_options(key, pw) != 0)
132 goto out;
133
diff --git a/debian/patches/authorized-keys-man-symlink.patch b/debian/patches/authorized-keys-man-symlink.patch
new file mode 100644
index 000000000..eb398f6a4
--- /dev/null
+++ b/debian/patches/authorized-keys-man-symlink.patch
@@ -0,0 +1,26 @@
1From 8a1a563ee326222155c74454e11e6ed62297c403 Mon Sep 17 00:00:00 2001
2From: Tomas Pospisek <tpo_deb@sourcepole.ch>
3Date: Sun, 9 Feb 2014 16:10:07 +0000
4Subject: Install authorized_keys(5) as a symlink to sshd(8)
5
6Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1720
7Bug-Debian: http://bugs.debian.org/441817
8Last-Update: 2013-09-14
9
10Patch-Name: authorized-keys-man-symlink.patch
11---
12 Makefile.in | 1 +
13 1 file changed, 1 insertion(+)
14
15diff --git a/Makefile.in b/Makefile.in
16index c406aec..37cb023 100644
17--- a/Makefile.in
18+++ b/Makefile.in
19@@ -325,6 +325,7 @@ install-files:
20 $(INSTALL) -m 644 sshd_config.5.out $(DESTDIR)$(mandir)/$(mansubdir)5/sshd_config.5
21 $(INSTALL) -m 644 ssh_config.5.out $(DESTDIR)$(mandir)/$(mansubdir)5/ssh_config.5
22 $(INSTALL) -m 644 sshd.8.out $(DESTDIR)$(mandir)/$(mansubdir)8/sshd.8
23+ ln -s ../$(mansubdir)8/sshd.8 $(DESTDIR)$(mandir)/$(mansubdir)5/authorized_keys.5
24 $(INSTALL) -m 644 sftp.1.out $(DESTDIR)$(mandir)/$(mansubdir)1/sftp.1
25 $(INSTALL) -m 644 sftp-server.8.out $(DESTDIR)$(mandir)/$(mansubdir)8/sftp-server.8
26 $(INSTALL) -m 644 ssh-keysign.8.out $(DESTDIR)$(mandir)/$(mansubdir)8/ssh-keysign.8
diff --git a/debian/patches/consolekit.patch b/debian/patches/consolekit.patch
new file mode 100644
index 000000000..0438b8f74
--- /dev/null
+++ b/debian/patches/consolekit.patch
@@ -0,0 +1,576 @@
1From 8b3111d597316954caaf8ddf2e7746491976c248 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@ubuntu.com>
3Date: Sun, 9 Feb 2014 16:09:57 +0000
4Subject: Add support for registering ConsoleKit sessions on login
5
6Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1450
7Last-Updated: 2015-08-19
8
9Patch-Name: consolekit.patch
10---
11 Makefile.in | 3 +-
12 configure.ac | 25 ++++++
13 consolekit.c | 241 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
14 consolekit.h | 24 ++++++
15 monitor.c | 42 ++++++++++
16 monitor.h | 2 +
17 monitor_wrap.c | 30 +++++++
18 monitor_wrap.h | 4 +
19 session.c | 13 ++++
20 session.h | 6 ++
21 10 files changed, 389 insertions(+), 1 deletion(-)
22 create mode 100644 consolekit.c
23 create mode 100644 consolekit.h
24
25diff --git a/Makefile.in b/Makefile.in
26index 3d2a328..c406aec 100644
27--- a/Makefile.in
28+++ b/Makefile.in
29@@ -111,7 +111,8 @@ SSHDOBJS=sshd.o auth-rhosts.o auth-passwd.o auth-rsa.o auth-rh-rsa.o \
30 sftp-server.o sftp-common.o \
31 roaming_common.o roaming_serv.o \
32 sandbox-null.o sandbox-rlimit.o sandbox-systrace.o sandbox-darwin.o \
33- sandbox-seccomp-filter.o sandbox-capsicum.o
34+ sandbox-seccomp-filter.o sandbox-capsicum.o \
35+ consolekit.o
36
37 MANPAGES = moduli.5.out scp.1.out ssh-add.1.out ssh-agent.1.out ssh-keygen.1.out ssh-keyscan.1.out ssh.1.out sshd.8.out sftp-server.8.out sftp.1.out ssh-keysign.8.out ssh-pkcs11-helper.8.out sshd_config.5.out ssh_config.5.out
38 MANPAGES_IN = moduli.5 scp.1 ssh-add.1 ssh-agent.1 ssh-keygen.1 ssh-keyscan.1 ssh.1 sshd.8 sftp-server.8 sftp.1 ssh-keysign.8 ssh-pkcs11-helper.8 sshd_config.5 ssh_config.5
39diff --git a/configure.ac b/configure.ac
40index 5f606ea..f7ce777 100644
41--- a/configure.ac
42+++ b/configure.ac
43@@ -4180,6 +4180,30 @@ AC_ARG_WITH([kerberos5],
44 AC_SUBST([GSSLIBS])
45 AC_SUBST([K5LIBS])
46
47+# Check whether user wants ConsoleKit support
48+CONSOLEKIT_MSG="no"
49+LIBCK_CONNECTOR=""
50+AC_ARG_WITH(consolekit,
51+ [ --with-consolekit Enable ConsoleKit support],
52+ [ if test "x$withval" != "xno" ; then
53+ AC_PATH_TOOL([PKGCONFIG], [pkg-config], [no])
54+ if test "$PKGCONFIG" != "no"; then
55+ AC_MSG_CHECKING([for ck-connector])
56+ if $PKGCONFIG --exists ck-connector; then
57+ CKCON_CFLAGS=`$PKGCONFIG --cflags ck-connector`
58+ CKCON_LIBS=`$PKGCONFIG --libs ck-connector`
59+ CPPFLAGS="$CPPFLAGS $CKCON_CFLAGS"
60+ SSHDLIBS="$SSHDLIBS $CKCON_LIBS"
61+ AC_MSG_RESULT([yes])
62+ AC_DEFINE(USE_CONSOLEKIT, 1, [Define if you want ConsoleKit support.])
63+ CONSOLEKIT_MSG="yes"
64+ else
65+ AC_MSG_RESULT([no])
66+ fi
67+ fi
68+ fi ]
69+)
70+
71 # Looking for programs, paths and files
72
73 PRIVSEP_PATH=/var/empty
74@@ -4981,6 +5005,7 @@ echo " MD5 password support: $MD5_MSG"
75 echo " libedit support: $LIBEDIT_MSG"
76 echo " Solaris process contract support: $SPC_MSG"
77 echo " Solaris project support: $SP_MSG"
78+echo " ConsoleKit support: $CONSOLEKIT_MSG"
79 echo " IP address in \$DISPLAY hack: $DISPLAY_HACK_MSG"
80 echo " Translate v4 in v6 hack: $IPV4_IN6_HACK_MSG"
81 echo " BSD Auth support: $BSD_AUTH_MSG"
82diff --git a/consolekit.c b/consolekit.c
83new file mode 100644
84index 0000000..0266f06
85--- /dev/null
86+++ b/consolekit.c
87@@ -0,0 +1,241 @@
88+/*
89+ * Copyright (c) 2008 Colin Watson. All rights reserved.
90+ *
91+ * Permission to use, copy, modify, and distribute this software for any
92+ * purpose with or without fee is hereby granted, provided that the above
93+ * copyright notice and this permission notice appear in all copies.
94+ *
95+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
96+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
97+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
98+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
99+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
100+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
101+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
102+ */
103+/*
104+ * Loosely based on pam-ck-connector, which is:
105+ *
106+ * Copyright (c) 2007 David Zeuthen <davidz@redhat.com>
107+ *
108+ * Permission is hereby granted, free of charge, to any person
109+ * obtaining a copy of this software and associated documentation
110+ * files (the "Software"), to deal in the Software without
111+ * restriction, including without limitation the rights to use,
112+ * copy, modify, merge, publish, distribute, sublicense, and/or sell
113+ * copies of the Software, and to permit persons to whom the
114+ * Software is furnished to do so, subject to the following
115+ * conditions:
116+ *
117+ * The above copyright notice and this permission notice shall be
118+ * included in all copies or substantial portions of the Software.
119+ *
120+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
121+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
122+ * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
123+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
124+ * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
125+ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
126+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
127+ * OTHER DEALINGS IN THE SOFTWARE.
128+ */
129+
130+#include "includes.h"
131+
132+#ifdef USE_CONSOLEKIT
133+
134+#include <ck-connector.h>
135+
136+#include "openbsd-compat/sys-queue.h"
137+#include "xmalloc.h"
138+#include "channels.h"
139+#include "key.h"
140+#include "hostfile.h"
141+#include "auth.h"
142+#include "log.h"
143+#include "misc.h"
144+#include "servconf.h"
145+#include "canohost.h"
146+#include "session.h"
147+#include "consolekit.h"
148+
149+extern ServerOptions options;
150+extern u_int utmp_len;
151+
152+void
153+set_active(const char *cookie)
154+{
155+ DBusError err;
156+ DBusConnection *connection;
157+ DBusMessage *message = NULL, *reply = NULL;
158+ char *sid;
159+ DBusMessageIter iter, subiter;
160+ const char *interface, *property;
161+ dbus_bool_t active;
162+
163+ dbus_error_init(&err);
164+ connection = dbus_bus_get_private(DBUS_BUS_SYSTEM, &err);
165+ if (!connection) {
166+ if (dbus_error_is_set(&err)) {
167+ error("unable to open DBus connection: %s",
168+ err.message);
169+ dbus_error_free(&err);
170+ }
171+ goto out;
172+ }
173+ dbus_connection_set_exit_on_disconnect(connection, FALSE);
174+
175+ message = dbus_message_new_method_call("org.freedesktop.ConsoleKit",
176+ "/org/freedesktop/ConsoleKit/Manager",
177+ "org.freedesktop.ConsoleKit.Manager",
178+ "GetSessionForCookie");
179+ if (!message)
180+ goto out;
181+ if (!dbus_message_append_args(message, DBUS_TYPE_STRING, &cookie,
182+ DBUS_TYPE_INVALID)) {
183+ if (dbus_error_is_set(&err)) {
184+ error("unable to get current session: %s",
185+ err.message);
186+ dbus_error_free(&err);
187+ }
188+ goto out;
189+ }
190+
191+ dbus_error_init(&err);
192+ reply = dbus_connection_send_with_reply_and_block(connection, message,
193+ -1, &err);
194+ if (!reply) {
195+ if (dbus_error_is_set(&err)) {
196+ error("unable to get current session: %s",
197+ err.message);
198+ dbus_error_free(&err);
199+ }
200+ goto out;
201+ }
202+
203+ dbus_error_init(&err);
204+ if (!dbus_message_get_args(reply, &err,
205+ DBUS_TYPE_OBJECT_PATH, &sid,
206+ DBUS_TYPE_INVALID)) {
207+ if (dbus_error_is_set(&err)) {
208+ error("unable to get current session: %s",
209+ err.message);
210+ dbus_error_free(&err);
211+ }
212+ goto out;
213+ }
214+ dbus_message_unref(reply);
215+ dbus_message_unref(message);
216+ message = reply = NULL;
217+
218+ message = dbus_message_new_method_call("org.freedesktop.ConsoleKit",
219+ sid, "org.freedesktop.DBus.Properties", "Set");
220+ if (!message)
221+ goto out;
222+ interface = "org.freedesktop.ConsoleKit.Session";
223+ property = "active";
224+ if (!dbus_message_append_args(message,
225+ DBUS_TYPE_STRING, &interface, DBUS_TYPE_STRING, &property,
226+ DBUS_TYPE_INVALID))
227+ goto out;
228+ dbus_message_iter_init_append(message, &iter);
229+ if (!dbus_message_iter_open_container(&iter, DBUS_TYPE_VARIANT,
230+ DBUS_TYPE_BOOLEAN_AS_STRING, &subiter))
231+ goto out;
232+ active = TRUE;
233+ if (!dbus_message_iter_append_basic(&subiter, DBUS_TYPE_BOOLEAN,
234+ &active))
235+ goto out;
236+ if (!dbus_message_iter_close_container(&iter, &subiter))
237+ goto out;
238+
239+ dbus_error_init(&err);
240+ reply = dbus_connection_send_with_reply_and_block(connection, message,
241+ -1, &err);
242+ if (!reply) {
243+ if (dbus_error_is_set(&err)) {
244+ error("unable to make current session active: %s",
245+ err.message);
246+ dbus_error_free(&err);
247+ }
248+ goto out;
249+ }
250+
251+out:
252+ if (reply)
253+ dbus_message_unref(reply);
254+ if (message)
255+ dbus_message_unref(message);
256+}
257+
258+/*
259+ * We pass display separately rather than using s->display because the
260+ * latter is not available in the monitor when using privsep.
261+ */
262+
263+char *
264+consolekit_register(Session *s, const char *display)
265+{
266+ DBusError err;
267+ const char *tty = s->tty;
268+ const char *remote_host_name;
269+ dbus_bool_t is_local = FALSE;
270+ const char *cookie = NULL;
271+
272+ if (s->ckc) {
273+ debug("already registered with ConsoleKit");
274+ return xstrdup(ck_connector_get_cookie(s->ckc));
275+ }
276+
277+ s->ckc = ck_connector_new();
278+ if (!s->ckc) {
279+ error("ck_connector_new failed");
280+ return NULL;
281+ }
282+
283+ if (!tty)
284+ tty = "";
285+ if (!display)
286+ display = "";
287+ remote_host_name = get_remote_name_or_ip(utmp_len, options.use_dns);
288+ if (!remote_host_name)
289+ remote_host_name = "";
290+
291+ dbus_error_init(&err);
292+ if (!ck_connector_open_session_with_parameters(s->ckc, &err,
293+ "unix-user", &s->pw->pw_uid,
294+ "display-device", &tty,
295+ "x11-display", &display,
296+ "remote-host-name", &remote_host_name,
297+ "is-local", &is_local,
298+ NULL)) {
299+ if (dbus_error_is_set(&err)) {
300+ debug("%s", err.message);
301+ dbus_error_free(&err);
302+ } else {
303+ debug("insufficient privileges or D-Bus / ConsoleKit "
304+ "not available");
305+ }
306+ return NULL;
307+ }
308+
309+ debug("registered uid=%d on tty='%s' with ConsoleKit",
310+ s->pw->pw_uid, s->tty);
311+
312+ cookie = ck_connector_get_cookie(s->ckc);
313+ set_active(cookie);
314+ return xstrdup(cookie);
315+}
316+
317+void
318+consolekit_unregister(Session *s)
319+{
320+ if (s->ckc) {
321+ debug("unregistering ConsoleKit session %s",
322+ ck_connector_get_cookie(s->ckc));
323+ ck_connector_unref(s->ckc);
324+ s->ckc = NULL;
325+ }
326+}
327+
328+#endif /* USE_CONSOLEKIT */
329diff --git a/consolekit.h b/consolekit.h
330new file mode 100644
331index 0000000..8ce3716
332--- /dev/null
333+++ b/consolekit.h
334@@ -0,0 +1,24 @@
335+/*
336+ * Copyright (c) 2008 Colin Watson. All rights reserved.
337+ *
338+ * Permission to use, copy, modify, and distribute this software for any
339+ * purpose with or without fee is hereby granted, provided that the above
340+ * copyright notice and this permission notice appear in all copies.
341+ *
342+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
343+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
344+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
345+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
346+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
347+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
348+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
349+ */
350+
351+#ifdef USE_CONSOLEKIT
352+
353+struct Session;
354+
355+char * consolekit_register(struct Session *, const char *);
356+void consolekit_unregister(struct Session *);
357+
358+#endif /* USE_CONSOLEKIT */
359diff --git a/monitor.c b/monitor.c
360index 6ff05e4..ce7ba07 100644
361--- a/monitor.c
362+++ b/monitor.c
363@@ -104,6 +104,9 @@
364 #include "authfd.h"
365 #include "match.h"
366 #include "ssherr.h"
367+#ifdef USE_CONSOLEKIT
368+#include "consolekit.h"
369+#endif
370
371 #ifdef GSSAPI
372 static Gssctxt *gsscontext = NULL;
373@@ -169,6 +172,10 @@ int mm_answer_audit_command(int, Buffer *);
374
375 static int monitor_read_log(struct monitor *);
376
377+#ifdef USE_CONSOLEKIT
378+int mm_answer_consolekit_register(int, Buffer *);
379+#endif
380+
381 static Authctxt *authctxt;
382
383 #ifdef WITH_SSH1
384@@ -261,6 +268,9 @@ struct mon_table mon_dispatch_postauth20[] = {
385 {MONITOR_REQ_AUDIT_EVENT, MON_PERMIT, mm_answer_audit_event},
386 {MONITOR_REQ_AUDIT_COMMAND, MON_PERMIT, mm_answer_audit_command},
387 #endif
388+#ifdef USE_CONSOLEKIT
389+ {MONITOR_REQ_CONSOLEKIT_REGISTER, 0, mm_answer_consolekit_register},
390+#endif
391 {0, 0, NULL}
392 };
393
394@@ -306,6 +316,9 @@ struct mon_table mon_dispatch_postauth15[] = {
395 {MONITOR_REQ_AUDIT_EVENT, MON_PERMIT, mm_answer_audit_event},
396 {MONITOR_REQ_AUDIT_COMMAND, MON_PERMIT|MON_ONCE, mm_answer_audit_command},
397 #endif
398+#ifdef USE_CONSOLEKIT
399+ {MONITOR_REQ_CONSOLEKIT_REGISTER, 0, mm_answer_consolekit_register},
400+#endif
401 #endif /* WITH_SSH1 */
402 {0, 0, NULL}
403 };
404@@ -488,6 +501,9 @@ monitor_child_postauth(struct monitor *pmonitor)
405 monitor_permit(mon_dispatch, MONITOR_REQ_PTY, 1);
406 monitor_permit(mon_dispatch, MONITOR_REQ_PTYCLEANUP, 1);
407 }
408+#ifdef USE_CONSOLEKIT
409+ monitor_permit(mon_dispatch, MONITOR_REQ_CONSOLEKIT_REGISTER, 1);
410+#endif
411
412 for (;;)
413 monitor_read(pmonitor, mon_dispatch, NULL);
414@@ -2187,3 +2203,29 @@ mm_answer_gss_updatecreds(int socket, Buffer *m) {
415
416 #endif /* GSSAPI */
417
418+#ifdef USE_CONSOLEKIT
419+int
420+mm_answer_consolekit_register(int sock, Buffer *m)
421+{
422+ Session *s;
423+ char *tty, *display;
424+ char *cookie = NULL;
425+
426+ debug3("%s entering", __func__);
427+
428+ tty = buffer_get_string(m, NULL);
429+ display = buffer_get_string(m, NULL);
430+ s = session_by_tty(tty);
431+ if (s != NULL)
432+ cookie = consolekit_register(s, display);
433+ buffer_clear(m);
434+ buffer_put_cstring(m, cookie != NULL ? cookie : "");
435+ mm_request_send(sock, MONITOR_ANS_CONSOLEKIT_REGISTER, m);
436+
437+ free(cookie);
438+ free(display);
439+ free(tty);
440+
441+ return (0);
442+}
443+#endif /* USE_CONSOLEKIT */
444diff --git a/monitor.h b/monitor.h
445index 2d82b8b..fd8d92c 100644
446--- a/monitor.h
447+++ b/monitor.h
448@@ -70,6 +70,8 @@ enum monitor_reqtype {
449
450 MONITOR_REQ_AUTHROLE = 154,
451
452+ MONITOR_REQ_CONSOLEKIT_REGISTER = 156, MONITOR_ANS_CONSOLEKIT_REGISTER = 157,
453+
454 };
455
456 struct mm_master;
457diff --git a/monitor_wrap.c b/monitor_wrap.c
458index 5aa9c47..a5f4e9d 100644
459--- a/monitor_wrap.c
460+++ b/monitor_wrap.c
461@@ -1150,3 +1150,33 @@ mm_ssh_gssapi_update_creds(ssh_gssapi_ccache *store)
462
463 #endif /* GSSAPI */
464
465+#ifdef USE_CONSOLEKIT
466+char *
467+mm_consolekit_register(Session *s, const char *display)
468+{
469+ Buffer m;
470+ char *cookie;
471+
472+ debug3("%s entering", __func__);
473+
474+ if (s->ttyfd == -1)
475+ return NULL;
476+ buffer_init(&m);
477+ buffer_put_cstring(&m, s->tty);
478+ buffer_put_cstring(&m, display != NULL ? display : "");
479+ mm_request_send(pmonitor->m_recvfd, MONITOR_REQ_CONSOLEKIT_REGISTER, &m);
480+ buffer_clear(&m);
481+
482+ mm_request_receive_expect(pmonitor->m_recvfd,
483+ MONITOR_ANS_CONSOLEKIT_REGISTER, &m);
484+ cookie = buffer_get_string(&m, NULL);
485+ buffer_free(&m);
486+
487+ /* treat empty cookie as missing cookie */
488+ if (strlen(cookie) == 0) {
489+ free(cookie);
490+ cookie = NULL;
491+ }
492+ return (cookie);
493+}
494+#endif /* USE_CONSOLEKIT */
495diff --git a/monitor_wrap.h b/monitor_wrap.h
496index 4d1e899..f99c31c 100644
497--- a/monitor_wrap.h
498+++ b/monitor_wrap.h
499@@ -108,4 +108,8 @@ int mm_skey_respond(void *, u_int, char **);
500 /* zlib allocation hooks */
501 void mm_init_compression(struct mm_master *);
502
503+#ifdef USE_CONSOLEKIT
504+char *mm_consolekit_register(struct Session *, const char *);
505+#endif /* USE_CONSOLEKIT */
506+
507 #endif /* _MM_WRAP_H_ */
508diff --git a/session.c b/session.c
509index d4b7725..785833f 100644
510--- a/session.c
511+++ b/session.c
512@@ -94,6 +94,7 @@
513 #include "kex.h"
514 #include "monitor_wrap.h"
515 #include "sftp.h"
516+#include "consolekit.h"
517
518 #if defined(KRB5) && defined(USE_AFS)
519 #include <kafs.h>
520@@ -1144,6 +1145,9 @@ do_setup_env(Session *s, const char *shell)
521 #if !defined (HAVE_LOGIN_CAP) && !defined (HAVE_CYGWIN)
522 char *path = NULL;
523 #endif
524+#ifdef USE_CONSOLEKIT
525+ const char *ckcookie = NULL;
526+#endif /* USE_CONSOLEKIT */
527
528 /* Initialize the environment. */
529 envsize = 100;
530@@ -1288,6 +1292,11 @@ do_setup_env(Session *s, const char *shell)
531 child_set_env(&env, &envsize, "KRB5CCNAME",
532 s->authctxt->krb5_ccname);
533 #endif
534+#ifdef USE_CONSOLEKIT
535+ ckcookie = PRIVSEP(consolekit_register(s, s->display));
536+ if (ckcookie)
537+ child_set_env(&env, &envsize, "XDG_SESSION_COOKIE", ckcookie);
538+#endif /* USE_CONSOLEKIT */
539 #ifdef USE_PAM
540 /*
541 * Pull in any environment variables that may have
542@@ -2351,6 +2360,10 @@ session_pty_cleanup2(Session *s)
543
544 debug("session_pty_cleanup: session %d release %s", s->self, s->tty);
545
546+#ifdef USE_CONSOLEKIT
547+ consolekit_unregister(s);
548+#endif /* USE_CONSOLEKIT */
549+
550 /* Record that the user has logged out. */
551 if (s->pid != 0)
552 record_logout(s->pid, s->tty, s->pw->pw_name);
553diff --git a/session.h b/session.h
554index ef6593c..a6b6983 100644
555--- a/session.h
556+++ b/session.h
557@@ -26,6 +26,8 @@
558 #ifndef SESSION_H
559 #define SESSION_H
560
561+struct _CkConnector;
562+
563 #define TTYSZ 64
564 typedef struct Session Session;
565 struct Session {
566@@ -61,6 +63,10 @@ struct Session {
567 char *name;
568 char *val;
569 } *env;
570+
571+#ifdef USE_CONSOLEKIT
572+ struct _CkConnector *ckc;
573+#endif /* USE_CONSOLEKIT */
574 };
575
576 void do_authenticated(Authctxt *);
diff --git a/debian/patches/debian-banner.patch b/debian/patches/debian-banner.patch
new file mode 100644
index 000000000..5bc70a566
--- /dev/null
+++ b/debian/patches/debian-banner.patch
@@ -0,0 +1,111 @@
1From 2c31a85436f1eac46e185382c2aa15406ae6c0ac Mon Sep 17 00:00:00 2001
2From: Kees Cook <kees@debian.org>
3Date: Sun, 9 Feb 2014 16:10:06 +0000
4Subject: Add DebianBanner server configuration option
5
6Setting this to "no" causes sshd to omit the Debian revision from its
7initial protocol handshake, for those scared by package-versioning.patch.
8
9Bug-Debian: http://bugs.debian.org/562048
10Forwarded: not-needed
11Last-Update: 2015-08-19
12
13Patch-Name: debian-banner.patch
14---
15 servconf.c | 9 +++++++++
16 servconf.h | 2 ++
17 sshd.c | 3 ++-
18 sshd_config.5 | 5 +++++
19 4 files changed, 18 insertions(+), 1 deletion(-)
20
21diff --git a/servconf.c b/servconf.c
22index b3a2841..bec53e0 100644
23--- a/servconf.c
24+++ b/servconf.c
25@@ -166,6 +166,7 @@ initialize_server_options(ServerOptions *options)
26 options->ip_qos_bulk = -1;
27 options->version_addendum = NULL;
28 options->fingerprint_hash = -1;
29+ options->debian_banner = -1;
30 }
31
32 /* Returns 1 if a string option is unset or set to "none" or 0 otherwise. */
33@@ -342,6 +343,8 @@ fill_default_server_options(ServerOptions *options)
34 options->fwd_opts.streamlocal_bind_unlink = 0;
35 if (options->fingerprint_hash == -1)
36 options->fingerprint_hash = SSH_FP_HASH_DEFAULT;
37+ if (options->debian_banner == -1)
38+ options->debian_banner = 1;
39 /* Turn privilege separation on by default */
40 if (use_privsep == -1)
41 use_privsep = PRIVSEP_NOSANDBOX;
42@@ -412,6 +415,7 @@ typedef enum {
43 sAuthenticationMethods, sHostKeyAgent, sPermitUserRC,
44 sStreamLocalBindMask, sStreamLocalBindUnlink,
45 sAllowStreamLocalForwarding, sFingerprintHash,
46+ sDebianBanner,
47 sDeprecated, sUnsupported
48 } ServerOpCodes;
49
50@@ -556,6 +560,7 @@ static struct {
51 { "streamlocalbindunlink", sStreamLocalBindUnlink, SSHCFG_ALL },
52 { "allowstreamlocalforwarding", sAllowStreamLocalForwarding, SSHCFG_ALL },
53 { "fingerprinthash", sFingerprintHash, SSHCFG_GLOBAL },
54+ { "debianbanner", sDebianBanner, SSHCFG_GLOBAL },
55 { NULL, sBadOption, 0 }
56 };
57
58@@ -1777,6 +1782,10 @@ process_server_config_line(ServerOptions *options, char *line,
59 options->fingerprint_hash = value;
60 break;
61
62+ case sDebianBanner:
63+ intptr = &options->debian_banner;
64+ goto parse_int;
65+
66 case sDeprecated:
67 logit("%s line %d: Deprecated option %s",
68 filename, linenum, arg);
69diff --git a/servconf.h b/servconf.h
70index d2ed4d7..ed0f171 100644
71--- a/servconf.h
72+++ b/servconf.h
73@@ -192,6 +192,8 @@ typedef struct {
74 char *auth_methods[MAX_AUTH_METHODS];
75
76 int fingerprint_hash;
77+
78+ int debian_banner;
79 } ServerOptions;
80
81 /* Information about the incoming connection as used by Match */
82diff --git a/sshd.c b/sshd.c
83index c362209..5435968 100644
84--- a/sshd.c
85+++ b/sshd.c
86@@ -442,7 +442,8 @@ sshd_exchange_identification(int sock_in, int sock_out)
87 }
88
89 xasprintf(&server_version_string, "SSH-%d.%d-%.100s%s%s%s",
90- major, minor, SSH_RELEASE,
91+ major, minor,
92+ options.debian_banner ? SSH_RELEASE : SSH_RELEASE_MINIMUM,
93 *options.version_addendum == '\0' ? "" : " ",
94 options.version_addendum, newline);
95
96diff --git a/sshd_config.5 b/sshd_config.5
97index d14576e..ec58635 100644
98--- a/sshd_config.5
99+++ b/sshd_config.5
100@@ -476,6 +476,11 @@ or
101 .Dq no .
102 The default is
103 .Dq delayed .
104+.It Cm DebianBanner
105+Specifies whether the distribution-specified extra version suffix is
106+included during initial protocol handshake.
107+The default is
108+.Dq yes .
109 .It Cm DenyGroups
110 This keyword can be followed by a list of group name patterns, separated
111 by spaces.
diff --git a/debian/patches/debian-config.patch b/debian/patches/debian-config.patch
new file mode 100644
index 000000000..a346ba678
--- /dev/null
+++ b/debian/patches/debian-config.patch
@@ -0,0 +1,157 @@
1From 8698446b972003b63dfe5dcbdb86acfe986afb85 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:18 +0000
4Subject: Various Debian-specific configuration changes
5
6ssh: Enable ForwardX11Trusted, returning to earlier semantics which cause
7fewer problems with existing setups (http://bugs.debian.org/237021).
8
9ssh: Set 'SendEnv LANG LC_*' by default (http://bugs.debian.org/264024).
10
11ssh: Enable HashKnownHosts by default to try to limit the spread of ssh
12worms.
13
14ssh: Enable GSSAPIAuthentication and disable GSSAPIDelegateCredentials by
15default.
16
17sshd: Refer to /usr/share/doc/openssh-server/README.Debian.gz alongside
18PermitRootLogin default.
19
20Document all of this, along with several sshd defaults set in
21debian/openssh-server.postinst.
22
23Author: Russ Allbery <rra@debian.org>
24Forwarded: not-needed
25Last-Update: 2015-08-19
26
27Patch-Name: debian-config.patch
28---
29 readconf.c | 2 +-
30 ssh_config | 7 ++++++-
31 ssh_config.5 | 19 ++++++++++++++++++-
32 sshd_config | 1 +
33 sshd_config.5 | 25 +++++++++++++++++++++++++
34 5 files changed, 51 insertions(+), 3 deletions(-)
35
36diff --git a/readconf.c b/readconf.c
37index 2ef8d7b..66a62f2 100644
38--- a/readconf.c
39+++ b/readconf.c
40@@ -1748,7 +1748,7 @@ fill_default_options(Options * options)
41 if (options->forward_x11 == -1)
42 options->forward_x11 = 0;
43 if (options->forward_x11_trusted == -1)
44- options->forward_x11_trusted = 0;
45+ options->forward_x11_trusted = 1;
46 if (options->forward_x11_timeout == -1)
47 options->forward_x11_timeout = 1200;
48 if (options->exit_on_forward_failure == -1)
49diff --git a/ssh_config b/ssh_config
50index 228e5ab..c9386aa 100644
51--- a/ssh_config
52+++ b/ssh_config
53@@ -17,9 +17,10 @@
54 # list of available options, their meanings and defaults, please see the
55 # ssh_config(5) man page.
56
57-# Host *
58+Host *
59 # ForwardAgent no
60 # ForwardX11 no
61+# ForwardX11Trusted yes
62 # RhostsRSAAuthentication no
63 # RSAAuthentication yes
64 # PasswordAuthentication yes
65@@ -48,3 +49,7 @@
66 # VisualHostKey no
67 # ProxyCommand ssh -q -W %h:%p gateway.example.com
68 # RekeyLimit 1G 1h
69+ SendEnv LANG LC_*
70+ HashKnownHosts yes
71+ GSSAPIAuthentication yes
72+ GSSAPIDelegateCredentials no
73diff --git a/ssh_config.5 b/ssh_config.5
74index 3bd80fd..da8e544 100644
75--- a/ssh_config.5
76+++ b/ssh_config.5
77@@ -74,6 +74,22 @@ Since the first obtained value for each parameter is used, more
78 host-specific declarations should be given near the beginning of the
79 file, and general defaults at the end.
80 .Pp
81+Note that the Debian
82+.Ic openssh-client
83+package sets several options as standard in
84+.Pa /etc/ssh/ssh_config
85+which are not the default in
86+.Xr ssh 1 :
87+.Pp
88+.Bl -bullet -offset indent -compact
89+.It
90+.Cm SendEnv No LANG LC_*
91+.It
92+.Cm HashKnownHosts No yes
93+.It
94+.Cm GSSAPIAuthentication No yes
95+.El
96+.Pp
97 The configuration file has the following format:
98 .Pp
99 Empty lines and lines starting with
100@@ -715,7 +731,8 @@ token used for the session will be set to expire after 20 minutes.
101 Remote clients will be refused access after this time.
102 .Pp
103 The default is
104-.Dq no .
105+.Dq yes
106+(Debian-specific).
107 .Pp
108 See the X11 SECURITY extension specification for full details on
109 the restrictions imposed on untrusted clients.
110diff --git a/sshd_config b/sshd_config
111index a71ad19..3391233 100644
112--- a/sshd_config
113+++ b/sshd_config
114@@ -41,6 +41,7 @@
115 # Authentication:
116
117 #LoginGraceTime 2m
118+# See /usr/share/doc/openssh-server/README.Debian.gz.
119 #PermitRootLogin yes
120 #StrictModes yes
121 #MaxAuthTries 6
122diff --git a/sshd_config.5 b/sshd_config.5
123index 453d741..db1f2fd 100644
124--- a/sshd_config.5
125+++ b/sshd_config.5
126@@ -57,6 +57,31 @@ Arguments may optionally be enclosed in double quotes
127 .Pq \&"
128 in order to represent arguments containing spaces.
129 .Pp
130+Note that the Debian
131+.Ic openssh-server
132+package sets several options as standard in
133+.Pa /etc/ssh/sshd_config
134+which are not the default in
135+.Xr sshd 8 .
136+The exact list depends on whether the package was installed fresh or
137+upgraded from various possible previous versions, but includes at least the
138+following:
139+.Pp
140+.Bl -bullet -offset indent -compact
141+.It
142+.Cm ChallengeResponseAuthentication No no
143+.It
144+.Cm X11Forwarding No yes
145+.It
146+.Cm PrintMotd No no
147+.It
148+.Cm AcceptEnv No LANG LC_*
149+.It
150+.Cm Subsystem No sftp /usr/lib/openssh/sftp-server
151+.It
152+.Cm UsePAM No yes
153+.El
154+.Pp
155 The possible
156 keywords and their meanings are as follows (note that
157 keywords are case-insensitive and arguments are case-sensitive):
diff --git a/debian/patches/dnssec-sshfp.patch b/debian/patches/dnssec-sshfp.patch
new file mode 100644
index 000000000..97fe79aef
--- /dev/null
+++ b/debian/patches/dnssec-sshfp.patch
@@ -0,0 +1,94 @@
1From 5cbcc7353649b84b5a7528e583458ee9473fd527 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:01 +0000
4Subject: Force use of DNSSEC even if "options edns0" isn't in resolv.conf
5
6This allows SSHFP DNS records to be verified if glibc 2.11 is installed.
7
8Origin: vendor, https://cvs.fedoraproject.org/viewvc/F-12/openssh/openssh-5.2p1-edns.patch?revision=1.1&view=markup
9Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=572049
10Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=572049
11Last-Update: 2010-04-06
12
13Patch-Name: dnssec-sshfp.patch
14---
15 dns.c | 14 +++++++++++++-
16 openbsd-compat/getrrsetbyname.c | 10 +++++-----
17 openbsd-compat/getrrsetbyname.h | 3 +++
18 3 files changed, 21 insertions(+), 6 deletions(-)
19
20diff --git a/dns.c b/dns.c
21index f201b60..a406f58 100644
22--- a/dns.c
23+++ b/dns.c
24@@ -206,6 +206,7 @@ verify_host_key_dns(const char *hostname, struct sockaddr *address,
25 {
26 u_int counter;
27 int result;
28+ unsigned int rrset_flags = 0;
29 struct rrsetinfo *fingerprints = NULL;
30
31 u_int8_t hostkey_algorithm;
32@@ -229,8 +230,19 @@ verify_host_key_dns(const char *hostname, struct sockaddr *address,
33 return -1;
34 }
35
36+ /*
37+ * Original getrrsetbyname function, found on OpenBSD for example,
38+ * doesn't accept any flag and prerequisite for obtaining AD bit in
39+ * DNS response is set by "options edns0" in resolv.conf.
40+ *
41+ * Our version is more clever and use RRSET_FORCE_EDNS0 flag.
42+ */
43+#ifndef HAVE_GETRRSETBYNAME
44+ rrset_flags |= RRSET_FORCE_EDNS0;
45+#endif
46 result = getrrsetbyname(hostname, DNS_RDATACLASS_IN,
47- DNS_RDATATYPE_SSHFP, 0, &fingerprints);
48+ DNS_RDATATYPE_SSHFP, rrset_flags, &fingerprints);
49+
50 if (result) {
51 verbose("DNS lookup error: %s", dns_result_totext(result));
52 return -1;
53diff --git a/openbsd-compat/getrrsetbyname.c b/openbsd-compat/getrrsetbyname.c
54index dc6fe05..e061a29 100644
55--- a/openbsd-compat/getrrsetbyname.c
56+++ b/openbsd-compat/getrrsetbyname.c
57@@ -209,8 +209,8 @@ getrrsetbyname(const char *hostname, unsigned int rdclass,
58 goto fail;
59 }
60
61- /* don't allow flags yet, unimplemented */
62- if (flags) {
63+ /* Allow RRSET_FORCE_EDNS0 flag only. */
64+ if ((flags & !RRSET_FORCE_EDNS0) != 0) {
65 result = ERRSET_INVAL;
66 goto fail;
67 }
68@@ -226,9 +226,9 @@ getrrsetbyname(const char *hostname, unsigned int rdclass,
69 #endif /* DEBUG */
70
71 #ifdef RES_USE_DNSSEC
72- /* turn on DNSSEC if EDNS0 is configured */
73- if (_resp->options & RES_USE_EDNS0)
74- _resp->options |= RES_USE_DNSSEC;
75+ /* turn on DNSSEC if required */
76+ if (flags & RRSET_FORCE_EDNS0)
77+ _resp->options |= (RES_USE_EDNS0|RES_USE_DNSSEC);
78 #endif /* RES_USE_DNSEC */
79
80 /* make query */
81diff --git a/openbsd-compat/getrrsetbyname.h b/openbsd-compat/getrrsetbyname.h
82index 1283f55..dbbc85a 100644
83--- a/openbsd-compat/getrrsetbyname.h
84+++ b/openbsd-compat/getrrsetbyname.h
85@@ -72,6 +72,9 @@
86 #ifndef RRSET_VALIDATED
87 # define RRSET_VALIDATED 1
88 #endif
89+#ifndef RRSET_FORCE_EDNS0
90+# define RRSET_FORCE_EDNS0 0x0001
91+#endif
92
93 /*
94 * Return codes for getrrsetbyname()
diff --git a/debian/patches/doc-hash-tab-completion.patch b/debian/patches/doc-hash-tab-completion.patch
new file mode 100644
index 000000000..35d589353
--- /dev/null
+++ b/debian/patches/doc-hash-tab-completion.patch
@@ -0,0 +1,28 @@
1From b0146d5a8c1b9d87f4255cbee40b31c938fea2f8 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:11 +0000
4Subject: Document that HashKnownHosts may break tab-completion
5
6Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1727
7Bug-Debian: http://bugs.debian.org/430154
8Last-Update: 2013-09-14
9
10Patch-Name: doc-hash-tab-completion.patch
11---
12 ssh_config.5 | 3 +++
13 1 file changed, 3 insertions(+)
14
15diff --git a/ssh_config.5 b/ssh_config.5
16index 8abcf40..3bd80fd 100644
17--- a/ssh_config.5
18+++ b/ssh_config.5
19@@ -801,6 +801,9 @@ Note that existing names and addresses in known hosts files
20 will not be converted automatically,
21 but may be manually hashed using
22 .Xr ssh-keygen 1 .
23+Use of this option may break facilities such as tab-completion that rely
24+on being able to read unhashed host names from
25+.Pa ~/.ssh/known_hosts .
26 .It Cm HostbasedAuthentication
27 Specifies whether to try rhosts based authentication with public key
28 authentication.
diff --git a/debian/patches/doc-upstart.patch b/debian/patches/doc-upstart.patch
new file mode 100644
index 000000000..8002929ab
--- /dev/null
+++ b/debian/patches/doc-upstart.patch
@@ -0,0 +1,29 @@
1From c679bacbff13edaa44255c4f4c32ef5bc0f4ccbc Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@ubuntu.com>
3Date: Sun, 9 Feb 2014 16:10:12 +0000
4Subject: Refer to ssh's Upstart job as well as its init script
5
6Forwarded: not-needed
7Last-Update: 2013-09-14
8
9Patch-Name: doc-upstart.patch
10---
11 sshd.8 | 5 ++++-
12 1 file changed, 4 insertions(+), 1 deletion(-)
13
14diff --git a/sshd.8 b/sshd.8
15index 8dba6cf..e198017 100644
16--- a/sshd.8
17+++ b/sshd.8
18@@ -67,7 +67,10 @@ over an insecure network.
19 .Nm
20 listens for connections from clients.
21 It is normally started at boot from
22-.Pa /etc/init.d/ssh .
23+.Pa /etc/init.d/ssh
24+(or
25+.Pa /etc/init/ssh.conf
26+on systems using the Upstart init daemon).
27 It forks a new
28 daemon for each incoming connection.
29 The forked daemons handle
diff --git a/debian/patches/gnome-ssh-askpass2-icon.patch b/debian/patches/gnome-ssh-askpass2-icon.patch
new file mode 100644
index 000000000..79efb8971
--- /dev/null
+++ b/debian/patches/gnome-ssh-askpass2-icon.patch
@@ -0,0 +1,26 @@
1From 02662744e60e6bbe532ff22c7f563026a7424b6c Mon Sep 17 00:00:00 2001
2From: Vincent Untz <vuntz@ubuntu.com>
3Date: Sun, 9 Feb 2014 16:10:16 +0000
4Subject: Give the ssh-askpass-gnome window a default icon
5
6Bug-Ubuntu: https://bugs.launchpad.net/bugs/27152
7Last-Update: 2010-02-28
8
9Patch-Name: gnome-ssh-askpass2-icon.patch
10---
11 contrib/gnome-ssh-askpass2.c | 2 ++
12 1 file changed, 2 insertions(+)
13
14diff --git a/contrib/gnome-ssh-askpass2.c b/contrib/gnome-ssh-askpass2.c
15index 9d97c30..04b3a11 100644
16--- a/contrib/gnome-ssh-askpass2.c
17+++ b/contrib/gnome-ssh-askpass2.c
18@@ -209,6 +209,8 @@ main(int argc, char **argv)
19
20 gtk_init(&argc, &argv);
21
22+ gtk_window_set_default_icon_from_file ("/usr/share/pixmaps/ssh-askpass-gnome.png", NULL);
23+
24 if (argc > 1) {
25 message = g_strjoinv(" ", argv + 1);
26 } else {
diff --git a/debian/patches/gssapi.patch b/debian/patches/gssapi.patch
new file mode 100644
index 000000000..b3c437194
--- /dev/null
+++ b/debian/patches/gssapi.patch
@@ -0,0 +1,3085 @@
1From 06879e71614170580ffa7568ec5c009f60a9d084 Mon Sep 17 00:00:00 2001
2From: Simon Wilkinson <simon@sxw.org.uk>
3Date: Sun, 9 Feb 2014 16:09:48 +0000
4Subject: GSSAPI key exchange support
5
6This patch has been rejected upstream: "None of the OpenSSH developers are
7in favour of adding this, and this situation has not changed for several
8years. This is not a slight on Simon's patch, which is of fine quality, but
9just that a) we don't trust GSSAPI implementations that much and b) we don't
10like adding new KEX since they are pre-auth attack surface. This one is
11particularly scary, since it requires hooks out to typically root-owned
12system resources."
13
14However, quite a lot of people rely on this in Debian, and it's better to
15have it merged into the main openssh package rather than having separate
16-krb5 packages (as we used to have). It seems to have a generally good
17security history.
18
19Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1242
20Last-Updated: 2015-08-19
21
22Patch-Name: gssapi.patch
23---
24 ChangeLog.gssapi | 113 +++++++++++++++++++
25 Makefile.in | 5 +-
26 auth-krb5.c | 17 ++-
27 auth2-gss.c | 48 +++++++-
28 auth2.c | 2 +
29 clientloop.c | 13 +++
30 config.h.in | 6 +
31 configure.ac | 24 ++++
32 gss-genr.c | 275 ++++++++++++++++++++++++++++++++++++++++++++-
33 gss-serv-krb5.c | 85 ++++++++++++--
34 gss-serv.c | 221 +++++++++++++++++++++++++++++++-----
35 kex.c | 16 +++
36 kex.h | 14 +++
37 kexgssc.c | 336 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
38 kexgsss.c | 295 ++++++++++++++++++++++++++++++++++++++++++++++++
39 monitor.c | 108 +++++++++++++++++-
40 monitor.h | 3 +
41 monitor_wrap.c | 47 +++++++-
42 monitor_wrap.h | 4 +-
43 readconf.c | 42 +++++++
44 readconf.h | 5 +
45 servconf.c | 38 ++++++-
46 servconf.h | 3 +
47 ssh-gss.h | 41 ++++++-
48 ssh_config | 2 +
49 ssh_config.5 | 34 +++++-
50 sshconnect2.c | 124 +++++++++++++++++++-
51 sshd.c | 110 ++++++++++++++++++
52 sshd_config | 2 +
53 sshd_config.5 | 28 +++++
54 sshkey.c | 3 +-
55 sshkey.h | 1 +
56 32 files changed, 2005 insertions(+), 60 deletions(-)
57 create mode 100644 ChangeLog.gssapi
58 create mode 100644 kexgssc.c
59 create mode 100644 kexgsss.c
60
61diff --git a/ChangeLog.gssapi b/ChangeLog.gssapi
62new file mode 100644
63index 0000000..f117a33
64--- /dev/null
65+++ b/ChangeLog.gssapi
66@@ -0,0 +1,113 @@
67+20110101
68+ - Finally update for OpenSSH 5.6p1
69+ - Add GSSAPIServerIdentity option from Jim Basney
70+
71+20100308
72+ - [ Makefile.in, key.c, key.h ]
73+ Updates for OpenSSH 5.4p1
74+ - [ servconf.c ]
75+ Include GSSAPI options in the sshd -T configuration dump, and flag
76+ some older configuration options as being unsupported. Thanks to Colin
77+ Watson.
78+ -
79+
80+20100124
81+ - [ sshconnect2.c ]
82+ Adapt to deal with additional element in Authmethod structure. Thanks to
83+ Colin Watson
84+
85+20090615
86+ - [ gss-genr.c gss-serv.c kexgssc.c kexgsss.c monitor.c sshconnect2.c
87+ sshd.c ]
88+ Fix issues identified by Greg Hudson following a code review
89+ Check return value of gss_indicate_mechs
90+ Protect GSSAPI calls in monitor, so they can only be used if enabled
91+ Check return values of bignum functions in key exchange
92+ Use BN_clear_free to clear other side's DH value
93+ Make ssh_gssapi_id_kex more robust
94+ Only configure kex table pointers if GSSAPI is enabled
95+ Don't leak mechanism list, or gss mechanism list
96+ Cast data.length before printing
97+ If serverkey isn't provided, use an empty string, rather than NULL
98+
99+20090201
100+ - [ gss-genr.c gss-serv.c kex.h kexgssc.c readconf.c readconf.h ssh-gss.h
101+ ssh_config.5 sshconnet2.c ]
102+ Add support for the GSSAPIClientIdentity option, which allows the user
103+ to specify which GSSAPI identity to use to contact a given server
104+
105+20080404
106+ - [ gss-serv.c ]
107+ Add code to actually implement GSSAPIStrictAcceptCheck, which had somehow
108+ been omitted from a previous version of this patch. Reported by Borislav
109+ Stoichkov
110+
111+20070317
112+ - [ gss-serv-krb5.c ]
113+ Remove C99ism, where new_ccname was being declared in the middle of a
114+ function
115+
116+20061220
117+ - [ servconf.c ]
118+ Make default for GSSAPIStrictAcceptorCheck be Yes, to match previous, and
119+ documented, behaviour. Reported by Dan Watson.
120+
121+20060910
122+ - [ gss-genr.c kexgssc.c kexgsss.c kex.h monitor.c sshconnect2.c sshd.c
123+ ssh-gss.h ]
124+ add support for gss-group14-sha1 key exchange mechanisms
125+ - [ gss-serv.c servconf.c servconf.h sshd_config sshd_config.5 ]
126+ Add GSSAPIStrictAcceptorCheck option to allow the disabling of
127+ acceptor principal checking on multi-homed machines.
128+ <Bugzilla #928>
129+ - [ sshd_config ssh_config ]
130+ Add settings for GSSAPIKeyExchange and GSSAPITrustDNS to the sample
131+ configuration files
132+ - [ kexgss.c kegsss.c sshconnect2.c sshd.c ]
133+ Code cleanup. Replace strlen/xmalloc/snprintf sequences with xasprintf()
134+ Limit length of error messages displayed by client
135+
136+20060909
137+ - [ gss-genr.c gss-serv.c ]
138+ move ssh_gssapi_acquire_cred() and ssh_gssapi_server_ctx to be server
139+ only, where they belong
140+ <Bugzilla #1225>
141+
142+20060829
143+ - [ gss-serv-krb5.c ]
144+ Fix CCAPI credentials cache name when creating KRB5CCNAME environment
145+ variable
146+
147+20060828
148+ - [ gss-genr.c ]
149+ Avoid Heimdal context freeing problem
150+ <Fixed upstream 20060829>
151+
152+20060818
153+ - [ gss-genr.c ssh-gss.h sshconnect2.c ]
154+ Make sure that SPENGO is disabled
155+ <Bugzilla #1218 - Fixed upstream 20060818>
156+
157+20060421
158+ - [ gssgenr.c, sshconnect2.c ]
159+ a few type changes (signed versus unsigned, int versus size_t) to
160+ fix compiler errors/warnings
161+ (from jbasney AT ncsa.uiuc.edu)
162+ - [ kexgssc.c, sshconnect2.c ]
163+ fix uninitialized variable warnings
164+ (from jbasney AT ncsa.uiuc.edu)
165+ - [ gssgenr.c ]
166+ pass oid to gss_display_status (helpful when using GSSAPI mechglue)
167+ (from jbasney AT ncsa.uiuc.edu)
168+ <Bugzilla #1220 >
169+ - [ gss-serv-krb5.c ]
170+ #ifdef HAVE_GSSAPI_KRB5 should be #ifdef HAVE_GSSAPI_KRB5_H
171+ (from jbasney AT ncsa.uiuc.edu)
172+ <Fixed upstream 20060304>
173+ - [ readconf.c, readconf.h, ssh_config.5, sshconnect2.c
174+ add client-side GssapiKeyExchange option
175+ (from jbasney AT ncsa.uiuc.edu)
176+ - [ sshconnect2.c ]
177+ add support for GssapiTrustDns option for gssapi-with-mic
178+ (from jbasney AT ncsa.uiuc.edu)
179+ <gssapi-with-mic support is Bugzilla #1008>
180diff --git a/Makefile.in b/Makefile.in
181index 40cc7aa..3d2a328 100644
182--- a/Makefile.in
183+++ b/Makefile.in
184@@ -91,7 +91,8 @@ LIBSSH_OBJS=${LIBOPENSSH_OBJS} \
185 sc25519.o ge25519.o fe25519.o ed25519.o verify.o hash.o blocks.o \
186 kex.o kexdh.o kexgex.o kexecdh.o kexc25519.o \
187 kexdhc.o kexgexc.o kexecdhc.o kexc25519c.o \
188- kexdhs.o kexgexs.o kexecdhs.o kexc25519s.o
189+ kexdhs.o kexgexs.o kexecdhs.o kexc25519s.o \
190+ kexgssc.o
191
192 SSHOBJS= ssh.o readconf.o clientloop.o sshtty.o \
193 sshconnect.o sshconnect1.o sshconnect2.o mux.o \
194@@ -105,7 +106,7 @@ SSHDOBJS=sshd.o auth-rhosts.o auth-passwd.o auth-rsa.o auth-rh-rsa.o \
195 auth-skey.o auth-bsdauth.o auth2-hostbased.o auth2-kbdint.o \
196 auth2-none.o auth2-passwd.o auth2-pubkey.o \
197 monitor_mm.o monitor.o monitor_wrap.o auth-krb5.o \
198- auth2-gss.o gss-serv.o gss-serv-krb5.o \
199+ auth2-gss.o gss-serv.o gss-serv-krb5.o kexgsss.o \
200 loginrec.o auth-pam.o auth-shadow.o auth-sia.o md5crypt.o \
201 sftp-server.o sftp-common.o \
202 roaming_common.o roaming_serv.o \
203diff --git a/auth-krb5.c b/auth-krb5.c
204index 0089b18..ec47869 100644
205--- a/auth-krb5.c
206+++ b/auth-krb5.c
207@@ -183,8 +183,13 @@ auth_krb5_password(Authctxt *authctxt, const char *password)
208
209 len = strlen(authctxt->krb5_ticket_file) + 6;
210 authctxt->krb5_ccname = xmalloc(len);
211+#ifdef USE_CCAPI
212+ snprintf(authctxt->krb5_ccname, len, "API:%s",
213+ authctxt->krb5_ticket_file);
214+#else
215 snprintf(authctxt->krb5_ccname, len, "FILE:%s",
216 authctxt->krb5_ticket_file);
217+#endif
218
219 #ifdef USE_PAM
220 if (options.use_pam)
221@@ -241,15 +246,22 @@ krb5_cleanup_proc(Authctxt *authctxt)
222 #ifndef HEIMDAL
223 krb5_error_code
224 ssh_krb5_cc_gen(krb5_context ctx, krb5_ccache *ccache) {
225- int tmpfd, ret, oerrno;
226+ int ret, oerrno;
227 char ccname[40];
228 mode_t old_umask;
229+#ifdef USE_CCAPI
230+ char cctemplate[] = "API:krb5cc_%d";
231+#else
232+ char cctemplate[] = "FILE:/tmp/krb5cc_%d_XXXXXXXXXX";
233+ int tmpfd;
234+#endif
235
236 ret = snprintf(ccname, sizeof(ccname),
237- "FILE:/tmp/krb5cc_%d_XXXXXXXXXX", geteuid());
238+ cctemplate, geteuid());
239 if (ret < 0 || (size_t)ret >= sizeof(ccname))
240 return ENOMEM;
241
242+#ifndef USE_CCAPI
243 old_umask = umask(0177);
244 tmpfd = mkstemp(ccname + strlen("FILE:"));
245 oerrno = errno;
246@@ -266,6 +278,7 @@ ssh_krb5_cc_gen(krb5_context ctx, krb5_ccache *ccache) {
247 return oerrno;
248 }
249 close(tmpfd);
250+#endif
251
252 return (krb5_cc_resolve(ctx, ccname, ccache));
253 }
254diff --git a/auth2-gss.c b/auth2-gss.c
255index 1ca8357..3b5036d 100644
256--- a/auth2-gss.c
257+++ b/auth2-gss.c
258@@ -1,7 +1,7 @@
259 /* $OpenBSD: auth2-gss.c,v 1.22 2015/01/19 20:07:45 markus Exp $ */
260
261 /*
262- * Copyright (c) 2001-2003 Simon Wilkinson. All rights reserved.
263+ * Copyright (c) 2001-2007 Simon Wilkinson. All rights reserved.
264 *
265 * Redistribution and use in source and binary forms, with or without
266 * modification, are permitted provided that the following conditions
267@@ -53,6 +53,40 @@ static int input_gssapi_mic(int type, u_int32_t plen, void *ctxt);
268 static int input_gssapi_exchange_complete(int type, u_int32_t plen, void *ctxt);
269 static int input_gssapi_errtok(int, u_int32_t, void *);
270
271+/*
272+ * The 'gssapi_keyex' userauth mechanism.
273+ */
274+static int
275+userauth_gsskeyex(Authctxt *authctxt)
276+{
277+ int authenticated = 0;
278+ Buffer b;
279+ gss_buffer_desc mic, gssbuf;
280+ u_int len;
281+
282+ mic.value = packet_get_string(&len);
283+ mic.length = len;
284+
285+ packet_check_eom();
286+
287+ ssh_gssapi_buildmic(&b, authctxt->user, authctxt->service,
288+ "gssapi-keyex");
289+
290+ gssbuf.value = buffer_ptr(&b);
291+ gssbuf.length = buffer_len(&b);
292+
293+ /* gss_kex_context is NULL with privsep, so we can't check it here */
294+ if (!GSS_ERROR(PRIVSEP(ssh_gssapi_checkmic(gss_kex_context,
295+ &gssbuf, &mic))))
296+ authenticated = PRIVSEP(ssh_gssapi_userok(authctxt->user,
297+ authctxt->pw));
298+
299+ buffer_free(&b);
300+ free(mic.value);
301+
302+ return (authenticated);
303+}
304+
305 /*
306 * We only support those mechanisms that we know about (ie ones that we know
307 * how to check local user kuserok and the like)
308@@ -238,7 +272,8 @@ input_gssapi_exchange_complete(int type, u_int32_t plen, void *ctxt)
309
310 packet_check_eom();
311
312- authenticated = PRIVSEP(ssh_gssapi_userok(authctxt->user));
313+ authenticated = PRIVSEP(ssh_gssapi_userok(authctxt->user,
314+ authctxt->pw));
315
316 authctxt->postponed = 0;
317 dispatch_set(SSH2_MSG_USERAUTH_GSSAPI_TOKEN, NULL);
318@@ -274,7 +309,8 @@ input_gssapi_mic(int type, u_int32_t plen, void *ctxt)
319 gssbuf.length = buffer_len(&b);
320
321 if (!GSS_ERROR(PRIVSEP(ssh_gssapi_checkmic(gssctxt, &gssbuf, &mic))))
322- authenticated = PRIVSEP(ssh_gssapi_userok(authctxt->user));
323+ authenticated =
324+ PRIVSEP(ssh_gssapi_userok(authctxt->user, authctxt->pw));
325 else
326 logit("GSSAPI MIC check failed");
327
328@@ -290,6 +326,12 @@ input_gssapi_mic(int type, u_int32_t plen, void *ctxt)
329 return 0;
330 }
331
332+Authmethod method_gsskeyex = {
333+ "gssapi-keyex",
334+ userauth_gsskeyex,
335+ &options.gss_authentication
336+};
337+
338 Authmethod method_gssapi = {
339 "gssapi-with-mic",
340 userauth_gssapi,
341diff --git a/auth2.c b/auth2.c
342index 7177962..3f49bdc 100644
343--- a/auth2.c
344+++ b/auth2.c
345@@ -70,6 +70,7 @@ extern Authmethod method_passwd;
346 extern Authmethod method_kbdint;
347 extern Authmethod method_hostbased;
348 #ifdef GSSAPI
349+extern Authmethod method_gsskeyex;
350 extern Authmethod method_gssapi;
351 #endif
352
353@@ -77,6 +78,7 @@ Authmethod *authmethods[] = {
354 &method_none,
355 &method_pubkey,
356 #ifdef GSSAPI
357+ &method_gsskeyex,
358 &method_gssapi,
359 #endif
360 &method_passwd,
361diff --git a/clientloop.c b/clientloop.c
362index a9c8a90..7df9413 100644
363--- a/clientloop.c
364+++ b/clientloop.c
365@@ -114,6 +114,10 @@
366 #include "ssherr.h"
367 #include "hostfile.h"
368
369+#ifdef GSSAPI
370+#include "ssh-gss.h"
371+#endif
372+
373 /* import options */
374 extern Options options;
375
376@@ -1596,6 +1600,15 @@ client_loop(int have_pty, int escape_char_arg, int ssh2_chan_id)
377 /* Do channel operations unless rekeying in progress. */
378 if (!rekeying) {
379 channel_after_select(readset, writeset);
380+
381+#ifdef GSSAPI
382+ if (options.gss_renewal_rekey &&
383+ ssh_gssapi_credentials_updated(NULL)) {
384+ debug("credentials updated - forcing rekey");
385+ need_rekeying = 1;
386+ }
387+#endif
388+
389 if (need_rekeying || packet_need_rekeying()) {
390 debug("need rekeying");
391 active_state->kex->done = 0;
392diff --git a/config.h.in b/config.h.in
393index 7e7e38e..6c7de98 100644
394--- a/config.h.in
395+++ b/config.h.in
396@@ -1623,6 +1623,9 @@
397 /* Use btmp to log bad logins */
398 #undef USE_BTMP
399
400+/* platform uses an in-memory credentials cache */
401+#undef USE_CCAPI
402+
403 /* Use libedit for sftp */
404 #undef USE_LIBEDIT
405
406@@ -1638,6 +1641,9 @@
407 /* Use PIPES instead of a socketpair() */
408 #undef USE_PIPES
409
410+/* platform has the Security Authorization Session API */
411+#undef USE_SECURITY_SESSION_API
412+
413 /* Define if you have Solaris process contracts */
414 #undef USE_SOLARIS_PROCESS_CONTRACTS
415
416diff --git a/configure.ac b/configure.ac
417index b4d6598..216a9fd 100644
418--- a/configure.ac
419+++ b/configure.ac
420@@ -620,6 +620,30 @@ main() { if (NSVersionOfRunTimeLibrary("System") >= (60 << 16))
421 [Use tunnel device compatibility to OpenBSD])
422 AC_DEFINE([SSH_TUN_PREPEND_AF], [1],
423 [Prepend the address family to IP tunnel traffic])
424+ AC_MSG_CHECKING([if we have the Security Authorization Session API])
425+ AC_TRY_COMPILE([#include <Security/AuthSession.h>],
426+ [SessionCreate(0, 0);],
427+ [ac_cv_use_security_session_api="yes"
428+ AC_DEFINE([USE_SECURITY_SESSION_API], [1],
429+ [platform has the Security Authorization Session API])
430+ LIBS="$LIBS -framework Security"
431+ AC_MSG_RESULT([yes])],
432+ [ac_cv_use_security_session_api="no"
433+ AC_MSG_RESULT([no])])
434+ AC_MSG_CHECKING([if we have an in-memory credentials cache])
435+ AC_TRY_COMPILE(
436+ [#include <Kerberos/Kerberos.h>],
437+ [cc_context_t c;
438+ (void) cc_initialize (&c, 0, NULL, NULL);],
439+ [AC_DEFINE([USE_CCAPI], [1],
440+ [platform uses an in-memory credentials cache])
441+ LIBS="$LIBS -framework Security"
442+ AC_MSG_RESULT([yes])
443+ if test "x$ac_cv_use_security_session_api" = "xno"; then
444+ AC_MSG_ERROR([*** Need a security framework to use the credentials cache API ***])
445+ fi],
446+ [AC_MSG_RESULT([no])]
447+ )
448 m4_pattern_allow([AU_IPv])
449 AC_CHECK_DECL([AU_IPv4], [],
450 AC_DEFINE([AU_IPv4], [0], [System only supports IPv4 audit records])
451diff --git a/gss-genr.c b/gss-genr.c
452index 60ac65f..5610f0b 100644
453--- a/gss-genr.c
454+++ b/gss-genr.c
455@@ -1,7 +1,7 @@
456 /* $OpenBSD: gss-genr.c,v 1.23 2015/01/20 23:14:00 deraadt Exp $ */
457
458 /*
459- * Copyright (c) 2001-2007 Simon Wilkinson. All rights reserved.
460+ * Copyright (c) 2001-2009 Simon Wilkinson. All rights reserved.
461 *
462 * Redistribution and use in source and binary forms, with or without
463 * modification, are permitted provided that the following conditions
464@@ -40,12 +40,167 @@
465 #include "buffer.h"
466 #include "log.h"
467 #include "ssh2.h"
468+#include "cipher.h"
469+#include "key.h"
470+#include "kex.h"
471+#include <openssl/evp.h>
472
473 #include "ssh-gss.h"
474
475 extern u_char *session_id2;
476 extern u_int session_id2_len;
477
478+typedef struct {
479+ char *encoded;
480+ gss_OID oid;
481+} ssh_gss_kex_mapping;
482+
483+/*
484+ * XXX - It would be nice to find a more elegant way of handling the
485+ * XXX passing of the key exchange context to the userauth routines
486+ */
487+
488+Gssctxt *gss_kex_context = NULL;
489+
490+static ssh_gss_kex_mapping *gss_enc2oid = NULL;
491+
492+int
493+ssh_gssapi_oid_table_ok(void) {
494+ return (gss_enc2oid != NULL);
495+}
496+
497+/*
498+ * Return a list of the gss-group1-sha1 mechanisms supported by this program
499+ *
500+ * We test mechanisms to ensure that we can use them, to avoid starting
501+ * a key exchange with a bad mechanism
502+ */
503+
504+char *
505+ssh_gssapi_client_mechanisms(const char *host, const char *client) {
506+ gss_OID_set gss_supported;
507+ OM_uint32 min_status;
508+
509+ if (GSS_ERROR(gss_indicate_mechs(&min_status, &gss_supported)))
510+ return NULL;
511+
512+ return(ssh_gssapi_kex_mechs(gss_supported, ssh_gssapi_check_mechanism,
513+ host, client));
514+}
515+
516+char *
517+ssh_gssapi_kex_mechs(gss_OID_set gss_supported, ssh_gssapi_check_fn *check,
518+ const char *host, const char *client) {
519+ Buffer buf;
520+ size_t i;
521+ int oidpos, enclen;
522+ char *mechs, *encoded;
523+ u_char digest[EVP_MAX_MD_SIZE];
524+ char deroid[2];
525+ const EVP_MD *evp_md = EVP_md5();
526+ EVP_MD_CTX md;
527+
528+ if (gss_enc2oid != NULL) {
529+ for (i = 0; gss_enc2oid[i].encoded != NULL; i++)
530+ free(gss_enc2oid[i].encoded);
531+ free(gss_enc2oid);
532+ }
533+
534+ gss_enc2oid = xmalloc(sizeof(ssh_gss_kex_mapping) *
535+ (gss_supported->count + 1));
536+
537+ buffer_init(&buf);
538+
539+ oidpos = 0;
540+ for (i = 0; i < gss_supported->count; i++) {
541+ if (gss_supported->elements[i].length < 128 &&
542+ (*check)(NULL, &(gss_supported->elements[i]), host, client)) {
543+
544+ deroid[0] = SSH_GSS_OIDTYPE;
545+ deroid[1] = gss_supported->elements[i].length;
546+
547+ EVP_DigestInit(&md, evp_md);
548+ EVP_DigestUpdate(&md, deroid, 2);
549+ EVP_DigestUpdate(&md,
550+ gss_supported->elements[i].elements,
551+ gss_supported->elements[i].length);
552+ EVP_DigestFinal(&md, digest, NULL);
553+
554+ encoded = xmalloc(EVP_MD_size(evp_md) * 2);
555+ enclen = __b64_ntop(digest, EVP_MD_size(evp_md),
556+ encoded, EVP_MD_size(evp_md) * 2);
557+
558+ if (oidpos != 0)
559+ buffer_put_char(&buf, ',');
560+
561+ buffer_append(&buf, KEX_GSS_GEX_SHA1_ID,
562+ sizeof(KEX_GSS_GEX_SHA1_ID) - 1);
563+ buffer_append(&buf, encoded, enclen);
564+ buffer_put_char(&buf, ',');
565+ buffer_append(&buf, KEX_GSS_GRP1_SHA1_ID,
566+ sizeof(KEX_GSS_GRP1_SHA1_ID) - 1);
567+ buffer_append(&buf, encoded, enclen);
568+ buffer_put_char(&buf, ',');
569+ buffer_append(&buf, KEX_GSS_GRP14_SHA1_ID,
570+ sizeof(KEX_GSS_GRP14_SHA1_ID) - 1);
571+ buffer_append(&buf, encoded, enclen);
572+
573+ gss_enc2oid[oidpos].oid = &(gss_supported->elements[i]);
574+ gss_enc2oid[oidpos].encoded = encoded;
575+ oidpos++;
576+ }
577+ }
578+ gss_enc2oid[oidpos].oid = NULL;
579+ gss_enc2oid[oidpos].encoded = NULL;
580+
581+ buffer_put_char(&buf, '\0');
582+
583+ mechs = xmalloc(buffer_len(&buf));
584+ buffer_get(&buf, mechs, buffer_len(&buf));
585+ buffer_free(&buf);
586+
587+ if (strlen(mechs) == 0) {
588+ free(mechs);
589+ mechs = NULL;
590+ }
591+
592+ return (mechs);
593+}
594+
595+gss_OID
596+ssh_gssapi_id_kex(Gssctxt *ctx, char *name, int kex_type) {
597+ int i = 0;
598+
599+ switch (kex_type) {
600+ case KEX_GSS_GRP1_SHA1:
601+ if (strlen(name) < sizeof(KEX_GSS_GRP1_SHA1_ID))
602+ return GSS_C_NO_OID;
603+ name += sizeof(KEX_GSS_GRP1_SHA1_ID) - 1;
604+ break;
605+ case KEX_GSS_GRP14_SHA1:
606+ if (strlen(name) < sizeof(KEX_GSS_GRP14_SHA1_ID))
607+ return GSS_C_NO_OID;
608+ name += sizeof(KEX_GSS_GRP14_SHA1_ID) - 1;
609+ break;
610+ case KEX_GSS_GEX_SHA1:
611+ if (strlen(name) < sizeof(KEX_GSS_GEX_SHA1_ID))
612+ return GSS_C_NO_OID;
613+ name += sizeof(KEX_GSS_GEX_SHA1_ID) - 1;
614+ break;
615+ default:
616+ return GSS_C_NO_OID;
617+ }
618+
619+ while (gss_enc2oid[i].encoded != NULL &&
620+ strcmp(name, gss_enc2oid[i].encoded) != 0)
621+ i++;
622+
623+ if (gss_enc2oid[i].oid != NULL && ctx != NULL)
624+ ssh_gssapi_set_oid(ctx, gss_enc2oid[i].oid);
625+
626+ return gss_enc2oid[i].oid;
627+}
628+
629 /* Check that the OID in a data stream matches that in the context */
630 int
631 ssh_gssapi_check_oid(Gssctxt *ctx, void *data, size_t len)
632@@ -198,7 +353,7 @@ ssh_gssapi_init_ctx(Gssctxt *ctx, int deleg_creds, gss_buffer_desc *recv_tok,
633 }
634
635 ctx->major = gss_init_sec_context(&ctx->minor,
636- GSS_C_NO_CREDENTIAL, &ctx->context, ctx->name, ctx->oid,
637+ ctx->client_creds, &ctx->context, ctx->name, ctx->oid,
638 GSS_C_MUTUAL_FLAG | GSS_C_INTEG_FLAG | deleg_flag,
639 0, NULL, recv_tok, NULL, send_tok, flags, NULL);
640
641@@ -228,8 +383,42 @@ ssh_gssapi_import_name(Gssctxt *ctx, const char *host)
642 }
643
644 OM_uint32
645+ssh_gssapi_client_identity(Gssctxt *ctx, const char *name)
646+{
647+ gss_buffer_desc gssbuf;
648+ gss_name_t gssname;
649+ OM_uint32 status;
650+ gss_OID_set oidset;
651+
652+ gssbuf.value = (void *) name;
653+ gssbuf.length = strlen(gssbuf.value);
654+
655+ gss_create_empty_oid_set(&status, &oidset);
656+ gss_add_oid_set_member(&status, ctx->oid, &oidset);
657+
658+ ctx->major = gss_import_name(&ctx->minor, &gssbuf,
659+ GSS_C_NT_USER_NAME, &gssname);
660+
661+ if (!ctx->major)
662+ ctx->major = gss_acquire_cred(&ctx->minor,
663+ gssname, 0, oidset, GSS_C_INITIATE,
664+ &ctx->client_creds, NULL, NULL);
665+
666+ gss_release_name(&status, &gssname);
667+ gss_release_oid_set(&status, &oidset);
668+
669+ if (ctx->major)
670+ ssh_gssapi_error(ctx);
671+
672+ return(ctx->major);
673+}
674+
675+OM_uint32
676 ssh_gssapi_sign(Gssctxt *ctx, gss_buffer_t buffer, gss_buffer_t hash)
677 {
678+ if (ctx == NULL)
679+ return -1;
680+
681 if ((ctx->major = gss_get_mic(&ctx->minor, ctx->context,
682 GSS_C_QOP_DEFAULT, buffer, hash)))
683 ssh_gssapi_error(ctx);
684@@ -237,6 +426,19 @@ ssh_gssapi_sign(Gssctxt *ctx, gss_buffer_t buffer, gss_buffer_t hash)
685 return (ctx->major);
686 }
687
688+/* Priviledged when used by server */
689+OM_uint32
690+ssh_gssapi_checkmic(Gssctxt *ctx, gss_buffer_t gssbuf, gss_buffer_t gssmic)
691+{
692+ if (ctx == NULL)
693+ return -1;
694+
695+ ctx->major = gss_verify_mic(&ctx->minor, ctx->context,
696+ gssbuf, gssmic, NULL);
697+
698+ return (ctx->major);
699+}
700+
701 void
702 ssh_gssapi_buildmic(Buffer *b, const char *user, const char *service,
703 const char *context)
704@@ -250,11 +452,16 @@ ssh_gssapi_buildmic(Buffer *b, const char *user, const char *service,
705 }
706
707 int
708-ssh_gssapi_check_mechanism(Gssctxt **ctx, gss_OID oid, const char *host)
709+ssh_gssapi_check_mechanism(Gssctxt **ctx, gss_OID oid, const char *host,
710+ const char *client)
711 {
712 gss_buffer_desc token = GSS_C_EMPTY_BUFFER;
713 OM_uint32 major, minor;
714 gss_OID_desc spnego_oid = {6, (void *)"\x2B\x06\x01\x05\x05\x02"};
715+ Gssctxt *intctx = NULL;
716+
717+ if (ctx == NULL)
718+ ctx = &intctx;
719
720 /* RFC 4462 says we MUST NOT do SPNEGO */
721 if (oid->length == spnego_oid.length &&
722@@ -264,6 +471,10 @@ ssh_gssapi_check_mechanism(Gssctxt **ctx, gss_OID oid, const char *host)
723 ssh_gssapi_build_ctx(ctx);
724 ssh_gssapi_set_oid(*ctx, oid);
725 major = ssh_gssapi_import_name(*ctx, host);
726+
727+ if (!GSS_ERROR(major) && client)
728+ major = ssh_gssapi_client_identity(*ctx, client);
729+
730 if (!GSS_ERROR(major)) {
731 major = ssh_gssapi_init_ctx(*ctx, 0, GSS_C_NO_BUFFER, &token,
732 NULL);
733@@ -273,10 +484,66 @@ ssh_gssapi_check_mechanism(Gssctxt **ctx, gss_OID oid, const char *host)
734 GSS_C_NO_BUFFER);
735 }
736
737- if (GSS_ERROR(major))
738+ if (GSS_ERROR(major) || intctx != NULL)
739 ssh_gssapi_delete_ctx(ctx);
740
741 return (!GSS_ERROR(major));
742 }
743
744+int
745+ssh_gssapi_credentials_updated(Gssctxt *ctxt) {
746+ static gss_name_t saved_name = GSS_C_NO_NAME;
747+ static OM_uint32 saved_lifetime = 0;
748+ static gss_OID saved_mech = GSS_C_NO_OID;
749+ static gss_name_t name;
750+ static OM_uint32 last_call = 0;
751+ OM_uint32 lifetime, now, major, minor;
752+ int equal;
753+
754+ now = time(NULL);
755+
756+ if (ctxt) {
757+ debug("Rekey has happened - updating saved versions");
758+
759+ if (saved_name != GSS_C_NO_NAME)
760+ gss_release_name(&minor, &saved_name);
761+
762+ major = gss_inquire_cred(&minor, GSS_C_NO_CREDENTIAL,
763+ &saved_name, &saved_lifetime, NULL, NULL);
764+
765+ if (!GSS_ERROR(major)) {
766+ saved_mech = ctxt->oid;
767+ saved_lifetime+= now;
768+ } else {
769+ /* Handle the error */
770+ }
771+ return 0;
772+ }
773+
774+ if (now - last_call < 10)
775+ return 0;
776+
777+ last_call = now;
778+
779+ if (saved_mech == GSS_C_NO_OID)
780+ return 0;
781+
782+ major = gss_inquire_cred(&minor, GSS_C_NO_CREDENTIAL,
783+ &name, &lifetime, NULL, NULL);
784+ if (major == GSS_S_CREDENTIALS_EXPIRED)
785+ return 0;
786+ else if (GSS_ERROR(major))
787+ return 0;
788+
789+ major = gss_compare_name(&minor, saved_name, name, &equal);
790+ gss_release_name(&minor, &name);
791+ if (GSS_ERROR(major))
792+ return 0;
793+
794+ if (equal && (saved_lifetime < lifetime + now - 10))
795+ return 1;
796+
797+ return 0;
798+}
799+
800 #endif /* GSSAPI */
801diff --git a/gss-serv-krb5.c b/gss-serv-krb5.c
802index 795992d..fd8b371 100644
803--- a/gss-serv-krb5.c
804+++ b/gss-serv-krb5.c
805@@ -1,7 +1,7 @@
806 /* $OpenBSD: gss-serv-krb5.c,v 1.8 2013/07/20 01:55:13 djm Exp $ */
807
808 /*
809- * Copyright (c) 2001-2003 Simon Wilkinson. All rights reserved.
810+ * Copyright (c) 2001-2007 Simon Wilkinson. All rights reserved.
811 *
812 * Redistribution and use in source and binary forms, with or without
813 * modification, are permitted provided that the following conditions
814@@ -121,8 +121,8 @@ ssh_gssapi_krb5_storecreds(ssh_gssapi_client *client)
815 krb5_error_code problem;
816 krb5_principal princ;
817 OM_uint32 maj_status, min_status;
818- int len;
819 const char *errmsg;
820+ const char *new_ccname;
821
822 if (client->creds == NULL) {
823 debug("No credentials stored");
824@@ -181,11 +181,16 @@ ssh_gssapi_krb5_storecreds(ssh_gssapi_client *client)
825 return;
826 }
827
828- client->store.filename = xstrdup(krb5_cc_get_name(krb_context, ccache));
829+ new_ccname = krb5_cc_get_name(krb_context, ccache);
830+
831 client->store.envvar = "KRB5CCNAME";
832- len = strlen(client->store.filename) + 6;
833- client->store.envval = xmalloc(len);
834- snprintf(client->store.envval, len, "FILE:%s", client->store.filename);
835+#ifdef USE_CCAPI
836+ xasprintf(&client->store.envval, "API:%s", new_ccname);
837+ client->store.filename = NULL;
838+#else
839+ xasprintf(&client->store.envval, "FILE:%s", new_ccname);
840+ client->store.filename = xstrdup(new_ccname);
841+#endif
842
843 #ifdef USE_PAM
844 if (options.use_pam)
845@@ -197,6 +202,71 @@ ssh_gssapi_krb5_storecreds(ssh_gssapi_client *client)
846 return;
847 }
848
849+int
850+ssh_gssapi_krb5_updatecreds(ssh_gssapi_ccache *store,
851+ ssh_gssapi_client *client)
852+{
853+ krb5_ccache ccache = NULL;
854+ krb5_principal principal = NULL;
855+ char *name = NULL;
856+ krb5_error_code problem;
857+ OM_uint32 maj_status, min_status;
858+
859+ if ((problem = krb5_cc_resolve(krb_context, store->envval, &ccache))) {
860+ logit("krb5_cc_resolve(): %.100s",
861+ krb5_get_err_text(krb_context, problem));
862+ return 0;
863+ }
864+
865+ /* Find out who the principal in this cache is */
866+ if ((problem = krb5_cc_get_principal(krb_context, ccache,
867+ &principal))) {
868+ logit("krb5_cc_get_principal(): %.100s",
869+ krb5_get_err_text(krb_context, problem));
870+ krb5_cc_close(krb_context, ccache);
871+ return 0;
872+ }
873+
874+ if ((problem = krb5_unparse_name(krb_context, principal, &name))) {
875+ logit("krb5_unparse_name(): %.100s",
876+ krb5_get_err_text(krb_context, problem));
877+ krb5_free_principal(krb_context, principal);
878+ krb5_cc_close(krb_context, ccache);
879+ return 0;
880+ }
881+
882+
883+ if (strcmp(name,client->exportedname.value)!=0) {
884+ debug("Name in local credentials cache differs. Not storing");
885+ krb5_free_principal(krb_context, principal);
886+ krb5_cc_close(krb_context, ccache);
887+ krb5_free_unparsed_name(krb_context, name);
888+ return 0;
889+ }
890+ krb5_free_unparsed_name(krb_context, name);
891+
892+ /* Name matches, so lets get on with it! */
893+
894+ if ((problem = krb5_cc_initialize(krb_context, ccache, principal))) {
895+ logit("krb5_cc_initialize(): %.100s",
896+ krb5_get_err_text(krb_context, problem));
897+ krb5_free_principal(krb_context, principal);
898+ krb5_cc_close(krb_context, ccache);
899+ return 0;
900+ }
901+
902+ krb5_free_principal(krb_context, principal);
903+
904+ if ((maj_status = gss_krb5_copy_ccache(&min_status, client->creds,
905+ ccache))) {
906+ logit("gss_krb5_copy_ccache() failed. Sorry!");
907+ krb5_cc_close(krb_context, ccache);
908+ return 0;
909+ }
910+
911+ return 1;
912+}
913+
914 ssh_gssapi_mech gssapi_kerberos_mech = {
915 "toWM5Slw5Ew8Mqkay+al2g==",
916 "Kerberos",
917@@ -204,7 +274,8 @@ ssh_gssapi_mech gssapi_kerberos_mech = {
918 NULL,
919 &ssh_gssapi_krb5_userok,
920 NULL,
921- &ssh_gssapi_krb5_storecreds
922+ &ssh_gssapi_krb5_storecreds,
923+ &ssh_gssapi_krb5_updatecreds
924 };
925
926 #endif /* KRB5 */
927diff --git a/gss-serv.c b/gss-serv.c
928index e7b8c52..539862d 100644
929--- a/gss-serv.c
930+++ b/gss-serv.c
931@@ -1,7 +1,7 @@
932 /* $OpenBSD: gss-serv.c,v 1.28 2015/01/20 23:14:00 deraadt Exp $ */
933
934 /*
935- * Copyright (c) 2001-2003 Simon Wilkinson. All rights reserved.
936+ * Copyright (c) 2001-2009 Simon Wilkinson. All rights reserved.
937 *
938 * Redistribution and use in source and binary forms, with or without
939 * modification, are permitted provided that the following conditions
940@@ -44,15 +44,21 @@
941 #include "channels.h"
942 #include "session.h"
943 #include "misc.h"
944+#include "servconf.h"
945+#include "uidswap.h"
946
947 #include "ssh-gss.h"
948+#include "monitor_wrap.h"
949+
950+extern ServerOptions options;
951
952 static ssh_gssapi_client gssapi_client =
953 { GSS_C_EMPTY_BUFFER, GSS_C_EMPTY_BUFFER,
954- GSS_C_NO_CREDENTIAL, NULL, {NULL, NULL, NULL, NULL}};
955+ GSS_C_NO_CREDENTIAL, GSS_C_NO_NAME, NULL,
956+ {NULL, NULL, NULL, NULL, NULL}, 0, 0};
957
958 ssh_gssapi_mech gssapi_null_mech =
959- { NULL, NULL, {0, NULL}, NULL, NULL, NULL, NULL};
960+ { NULL, NULL, {0, NULL}, NULL, NULL, NULL, NULL, NULL};
961
962 #ifdef KRB5
963 extern ssh_gssapi_mech gssapi_kerberos_mech;
964@@ -99,25 +105,32 @@ ssh_gssapi_acquire_cred(Gssctxt *ctx)
965 char lname[NI_MAXHOST];
966 gss_OID_set oidset;
967
968- gss_create_empty_oid_set(&status, &oidset);
969- gss_add_oid_set_member(&status, ctx->oid, &oidset);
970+ if (options.gss_strict_acceptor) {
971+ gss_create_empty_oid_set(&status, &oidset);
972+ gss_add_oid_set_member(&status, ctx->oid, &oidset);
973
974- if (gethostname(lname, sizeof(lname))) {
975- gss_release_oid_set(&status, &oidset);
976- return (-1);
977- }
978+ if (gethostname(lname, sizeof(lname))) {
979+ gss_release_oid_set(&status, &oidset);
980+ return (-1);
981+ }
982+
983+ if (GSS_ERROR(ssh_gssapi_import_name(ctx, lname))) {
984+ gss_release_oid_set(&status, &oidset);
985+ return (ctx->major);
986+ }
987+
988+ if ((ctx->major = gss_acquire_cred(&ctx->minor,
989+ ctx->name, 0, oidset, GSS_C_ACCEPT, &ctx->creds,
990+ NULL, NULL)))
991+ ssh_gssapi_error(ctx);
992
993- if (GSS_ERROR(ssh_gssapi_import_name(ctx, lname))) {
994 gss_release_oid_set(&status, &oidset);
995 return (ctx->major);
996+ } else {
997+ ctx->name = GSS_C_NO_NAME;
998+ ctx->creds = GSS_C_NO_CREDENTIAL;
999 }
1000-
1001- if ((ctx->major = gss_acquire_cred(&ctx->minor,
1002- ctx->name, 0, oidset, GSS_C_ACCEPT, &ctx->creds, NULL, NULL)))
1003- ssh_gssapi_error(ctx);
1004-
1005- gss_release_oid_set(&status, &oidset);
1006- return (ctx->major);
1007+ return GSS_S_COMPLETE;
1008 }
1009
1010 /* Privileged */
1011@@ -132,6 +145,29 @@ ssh_gssapi_server_ctx(Gssctxt **ctx, gss_OID oid)
1012 }
1013
1014 /* Unprivileged */
1015+char *
1016+ssh_gssapi_server_mechanisms(void) {
1017+ gss_OID_set supported;
1018+
1019+ ssh_gssapi_supported_oids(&supported);
1020+ return (ssh_gssapi_kex_mechs(supported, &ssh_gssapi_server_check_mech,
1021+ NULL, NULL));
1022+}
1023+
1024+/* Unprivileged */
1025+int
1026+ssh_gssapi_server_check_mech(Gssctxt **dum, gss_OID oid, const char *data,
1027+ const char *dummy) {
1028+ Gssctxt *ctx = NULL;
1029+ int res;
1030+
1031+ res = !GSS_ERROR(PRIVSEP(ssh_gssapi_server_ctx(&ctx, oid)));
1032+ ssh_gssapi_delete_ctx(&ctx);
1033+
1034+ return (res);
1035+}
1036+
1037+/* Unprivileged */
1038 void
1039 ssh_gssapi_supported_oids(gss_OID_set *oidset)
1040 {
1041@@ -141,7 +177,9 @@ ssh_gssapi_supported_oids(gss_OID_set *oidset)
1042 gss_OID_set supported;
1043
1044 gss_create_empty_oid_set(&min_status, oidset);
1045- gss_indicate_mechs(&min_status, &supported);
1046+
1047+ if (GSS_ERROR(gss_indicate_mechs(&min_status, &supported)))
1048+ return;
1049
1050 while (supported_mechs[i]->name != NULL) {
1051 if (GSS_ERROR(gss_test_oid_set_member(&min_status,
1052@@ -267,8 +305,48 @@ OM_uint32
1053 ssh_gssapi_getclient(Gssctxt *ctx, ssh_gssapi_client *client)
1054 {
1055 int i = 0;
1056+ int equal = 0;
1057+ gss_name_t new_name = GSS_C_NO_NAME;
1058+ gss_buffer_desc ename = GSS_C_EMPTY_BUFFER;
1059+
1060+ if (options.gss_store_rekey && client->used && ctx->client_creds) {
1061+ if (client->mech->oid.length != ctx->oid->length ||
1062+ (memcmp(client->mech->oid.elements,
1063+ ctx->oid->elements, ctx->oid->length) !=0)) {
1064+ debug("Rekeyed credentials have different mechanism");
1065+ return GSS_S_COMPLETE;
1066+ }
1067+
1068+ if ((ctx->major = gss_inquire_cred_by_mech(&ctx->minor,
1069+ ctx->client_creds, ctx->oid, &new_name,
1070+ NULL, NULL, NULL))) {
1071+ ssh_gssapi_error(ctx);
1072+ return (ctx->major);
1073+ }
1074+
1075+ ctx->major = gss_compare_name(&ctx->minor, client->name,
1076+ new_name, &equal);
1077
1078- gss_buffer_desc ename;
1079+ if (GSS_ERROR(ctx->major)) {
1080+ ssh_gssapi_error(ctx);
1081+ return (ctx->major);
1082+ }
1083+
1084+ if (!equal) {
1085+ debug("Rekeyed credentials have different name");
1086+ return GSS_S_COMPLETE;
1087+ }
1088+
1089+ debug("Marking rekeyed credentials for export");
1090+
1091+ gss_release_name(&ctx->minor, &client->name);
1092+ gss_release_cred(&ctx->minor, &client->creds);
1093+ client->name = new_name;
1094+ client->creds = ctx->client_creds;
1095+ ctx->client_creds = GSS_C_NO_CREDENTIAL;
1096+ client->updated = 1;
1097+ return GSS_S_COMPLETE;
1098+ }
1099
1100 client->mech = NULL;
1101
1102@@ -283,6 +361,13 @@ ssh_gssapi_getclient(Gssctxt *ctx, ssh_gssapi_client *client)
1103 if (client->mech == NULL)
1104 return GSS_S_FAILURE;
1105
1106+ if (ctx->client_creds &&
1107+ (ctx->major = gss_inquire_cred_by_mech(&ctx->minor,
1108+ ctx->client_creds, ctx->oid, &client->name, NULL, NULL, NULL))) {
1109+ ssh_gssapi_error(ctx);
1110+ return (ctx->major);
1111+ }
1112+
1113 if ((ctx->major = gss_display_name(&ctx->minor, ctx->client,
1114 &client->displayname, NULL))) {
1115 ssh_gssapi_error(ctx);
1116@@ -300,6 +385,8 @@ ssh_gssapi_getclient(Gssctxt *ctx, ssh_gssapi_client *client)
1117 return (ctx->major);
1118 }
1119
1120+ gss_release_buffer(&ctx->minor, &ename);
1121+
1122 /* We can't copy this structure, so we just move the pointer to it */
1123 client->creds = ctx->client_creds;
1124 ctx->client_creds = GSS_C_NO_CREDENTIAL;
1125@@ -347,7 +434,7 @@ ssh_gssapi_do_child(char ***envp, u_int *envsizep)
1126
1127 /* Privileged */
1128 int
1129-ssh_gssapi_userok(char *user)
1130+ssh_gssapi_userok(char *user, struct passwd *pw)
1131 {
1132 OM_uint32 lmin;
1133
1134@@ -357,9 +444,11 @@ ssh_gssapi_userok(char *user)
1135 return 0;
1136 }
1137 if (gssapi_client.mech && gssapi_client.mech->userok)
1138- if ((*gssapi_client.mech->userok)(&gssapi_client, user))
1139+ if ((*gssapi_client.mech->userok)(&gssapi_client, user)) {
1140+ gssapi_client.used = 1;
1141+ gssapi_client.store.owner = pw;
1142 return 1;
1143- else {
1144+ } else {
1145 /* Destroy delegated credentials if userok fails */
1146 gss_release_buffer(&lmin, &gssapi_client.displayname);
1147 gss_release_buffer(&lmin, &gssapi_client.exportedname);
1148@@ -373,14 +462,90 @@ ssh_gssapi_userok(char *user)
1149 return (0);
1150 }
1151
1152-/* Privileged */
1153-OM_uint32
1154-ssh_gssapi_checkmic(Gssctxt *ctx, gss_buffer_t gssbuf, gss_buffer_t gssmic)
1155+/* These bits are only used for rekeying. The unpriviledged child is running
1156+ * as the user, the monitor is root.
1157+ *
1158+ * In the child, we want to :
1159+ * *) Ask the monitor to store our credentials into the store we specify
1160+ * *) If it succeeds, maybe do a PAM update
1161+ */
1162+
1163+/* Stuff for PAM */
1164+
1165+#ifdef USE_PAM
1166+static int ssh_gssapi_simple_conv(int n, const struct pam_message **msg,
1167+ struct pam_response **resp, void *data)
1168 {
1169- ctx->major = gss_verify_mic(&ctx->minor, ctx->context,
1170- gssbuf, gssmic, NULL);
1171+ return (PAM_CONV_ERR);
1172+}
1173+#endif
1174
1175- return (ctx->major);
1176+void
1177+ssh_gssapi_rekey_creds(void) {
1178+ int ok;
1179+ int ret;
1180+#ifdef USE_PAM
1181+ pam_handle_t *pamh = NULL;
1182+ struct pam_conv pamconv = {ssh_gssapi_simple_conv, NULL};
1183+ char *envstr;
1184+#endif
1185+
1186+ if (gssapi_client.store.filename == NULL &&
1187+ gssapi_client.store.envval == NULL &&
1188+ gssapi_client.store.envvar == NULL)
1189+ return;
1190+
1191+ ok = PRIVSEP(ssh_gssapi_update_creds(&gssapi_client.store));
1192+
1193+ if (!ok)
1194+ return;
1195+
1196+ debug("Rekeyed credentials stored successfully");
1197+
1198+ /* Actually managing to play with the ssh pam stack from here will
1199+ * be next to impossible. In any case, we may want different options
1200+ * for rekeying. So, use our own :)
1201+ */
1202+#ifdef USE_PAM
1203+ if (!use_privsep) {
1204+ debug("Not even going to try and do PAM with privsep disabled");
1205+ return;
1206+ }
1207+
1208+ ret = pam_start("sshd-rekey", gssapi_client.store.owner->pw_name,
1209+ &pamconv, &pamh);
1210+ if (ret)
1211+ return;
1212+
1213+ xasprintf(&envstr, "%s=%s", gssapi_client.store.envvar,
1214+ gssapi_client.store.envval);
1215+
1216+ ret = pam_putenv(pamh, envstr);
1217+ if (!ret)
1218+ pam_setcred(pamh, PAM_REINITIALIZE_CRED);
1219+ pam_end(pamh, PAM_SUCCESS);
1220+#endif
1221+}
1222+
1223+int
1224+ssh_gssapi_update_creds(ssh_gssapi_ccache *store) {
1225+ int ok = 0;
1226+
1227+ /* Check we've got credentials to store */
1228+ if (!gssapi_client.updated)
1229+ return 0;
1230+
1231+ gssapi_client.updated = 0;
1232+
1233+ temporarily_use_uid(gssapi_client.store.owner);
1234+ if (gssapi_client.mech && gssapi_client.mech->updatecreds)
1235+ ok = (*gssapi_client.mech->updatecreds)(store, &gssapi_client);
1236+ else
1237+ debug("No update function for this mechanism");
1238+
1239+ restore_uid();
1240+
1241+ return ok;
1242 }
1243
1244 #endif
1245diff --git a/kex.c b/kex.c
1246index 8c2b001..be938ad 100644
1247--- a/kex.c
1248+++ b/kex.c
1249@@ -55,6 +55,10 @@
1250 #include "sshbuf.h"
1251 #include "digest.h"
1252
1253+#ifdef GSSAPI
1254+#include "ssh-gss.h"
1255+#endif
1256+
1257 #if OPENSSL_VERSION_NUMBER >= 0x00907000L
1258 # if defined(HAVE_EVP_SHA256)
1259 # define evp_ssh_sha256 EVP_sha256
1260@@ -97,6 +101,14 @@ static const struct kexalg kexalgs[] = {
1261 #endif /* HAVE_EVP_SHA256 || !WITH_OPENSSL */
1262 { NULL, -1, -1, -1},
1263 };
1264+static const struct kexalg kexalg_prefixes[] = {
1265+#ifdef GSSAPI
1266+ { KEX_GSS_GEX_SHA1_ID, KEX_GSS_GEX_SHA1, 0, SSH_DIGEST_SHA1 },
1267+ { KEX_GSS_GRP1_SHA1_ID, KEX_GSS_GRP1_SHA1, 0, SSH_DIGEST_SHA1 },
1268+ { KEX_GSS_GRP14_SHA1_ID, KEX_GSS_GRP14_SHA1, 0, SSH_DIGEST_SHA1 },
1269+#endif
1270+ { NULL, -1, -1, -1 },
1271+};
1272
1273 char *
1274 kex_alg_list(char sep)
1275@@ -129,6 +141,10 @@ kex_alg_by_name(const char *name)
1276 if (strcmp(k->name, name) == 0)
1277 return k;
1278 }
1279+ for (k = kexalg_prefixes; k->name != NULL; k++) {
1280+ if (strncmp(k->name, name, strlen(k->name)) == 0)
1281+ return k;
1282+ }
1283 return NULL;
1284 }
1285
1286diff --git a/kex.h b/kex.h
1287index f70b81f..7194b14 100644
1288--- a/kex.h
1289+++ b/kex.h
1290@@ -93,6 +93,9 @@ enum kex_exchange {
1291 KEX_DH_GEX_SHA256,
1292 KEX_ECDH_SHA2,
1293 KEX_C25519_SHA256,
1294+ KEX_GSS_GRP1_SHA1,
1295+ KEX_GSS_GRP14_SHA1,
1296+ KEX_GSS_GEX_SHA1,
1297 KEX_MAX
1298 };
1299
1300@@ -139,6 +142,12 @@ struct kex {
1301 u_int flags;
1302 int hash_alg;
1303 int ec_nid;
1304+#ifdef GSSAPI
1305+ int gss_deleg_creds;
1306+ int gss_trust_dns;
1307+ char *gss_host;
1308+ char *gss_client;
1309+#endif
1310 char *client_version_string;
1311 char *server_version_string;
1312 int (*verify_host_key)(struct sshkey *, struct ssh *);
1313@@ -184,6 +193,11 @@ int kexecdh_server(struct ssh *);
1314 int kexc25519_client(struct ssh *);
1315 int kexc25519_server(struct ssh *);
1316
1317+#ifdef GSSAPI
1318+int kexgss_client(struct ssh *);
1319+int kexgss_server(struct ssh *);
1320+#endif
1321+
1322 int kex_dh_hash(const char *, const char *,
1323 const u_char *, size_t, const u_char *, size_t, const u_char *, size_t,
1324 const BIGNUM *, const BIGNUM *, const BIGNUM *, u_char *, size_t *);
1325diff --git a/kexgssc.c b/kexgssc.c
1326new file mode 100644
1327index 0000000..a49bac2
1328--- /dev/null
1329+++ b/kexgssc.c
1330@@ -0,0 +1,336 @@
1331+/*
1332+ * Copyright (c) 2001-2009 Simon Wilkinson. All rights reserved.
1333+ *
1334+ * Redistribution and use in source and binary forms, with or without
1335+ * modification, are permitted provided that the following conditions
1336+ * are met:
1337+ * 1. Redistributions of source code must retain the above copyright
1338+ * notice, this list of conditions and the following disclaimer.
1339+ * 2. Redistributions in binary form must reproduce the above copyright
1340+ * notice, this list of conditions and the following disclaimer in the
1341+ * documentation and/or other materials provided with the distribution.
1342+ *
1343+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR `AS IS'' AND ANY EXPRESS OR
1344+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
1345+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
1346+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
1347+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
1348+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
1349+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
1350+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
1351+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
1352+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
1353+ */
1354+
1355+#include "includes.h"
1356+
1357+#ifdef GSSAPI
1358+
1359+#include "includes.h"
1360+
1361+#include <openssl/crypto.h>
1362+#include <openssl/bn.h>
1363+
1364+#include <string.h>
1365+
1366+#include "xmalloc.h"
1367+#include "buffer.h"
1368+#include "ssh2.h"
1369+#include "key.h"
1370+#include "cipher.h"
1371+#include "kex.h"
1372+#include "log.h"
1373+#include "packet.h"
1374+#include "dh.h"
1375+#include "digest.h"
1376+
1377+#include "ssh-gss.h"
1378+
1379+int
1380+kexgss_client(struct ssh *ssh) {
1381+ gss_buffer_desc send_tok = GSS_C_EMPTY_BUFFER;
1382+ gss_buffer_desc recv_tok, gssbuf, msg_tok, *token_ptr;
1383+ Gssctxt *ctxt;
1384+ OM_uint32 maj_status, min_status, ret_flags;
1385+ u_int klen, kout, slen = 0, strlen;
1386+ DH *dh;
1387+ BIGNUM *dh_server_pub = NULL;
1388+ BIGNUM *shared_secret = NULL;
1389+ BIGNUM *p = NULL;
1390+ BIGNUM *g = NULL;
1391+ u_char *kbuf;
1392+ u_char *serverhostkey = NULL;
1393+ u_char *empty = "";
1394+ char *msg;
1395+ int type = 0;
1396+ int first = 1;
1397+ int nbits = 0, min = DH_GRP_MIN, max = DH_GRP_MAX;
1398+ u_char hash[SSH_DIGEST_MAX_LENGTH];
1399+ size_t hashlen;
1400+
1401+ /* Initialise our GSSAPI world */
1402+ ssh_gssapi_build_ctx(&ctxt);
1403+ if (ssh_gssapi_id_kex(ctxt, ssh->kex->name, ssh->kex->kex_type)
1404+ == GSS_C_NO_OID)
1405+ fatal("Couldn't identify host exchange");
1406+
1407+ if (ssh_gssapi_import_name(ctxt, ssh->kex->gss_host))
1408+ fatal("Couldn't import hostname");
1409+
1410+ if (ssh->kex->gss_client &&
1411+ ssh_gssapi_client_identity(ctxt, ssh->kex->gss_client))
1412+ fatal("Couldn't acquire client credentials");
1413+
1414+ switch (ssh->kex->kex_type) {
1415+ case KEX_GSS_GRP1_SHA1:
1416+ dh = dh_new_group1();
1417+ break;
1418+ case KEX_GSS_GRP14_SHA1:
1419+ dh = dh_new_group14();
1420+ break;
1421+ case KEX_GSS_GEX_SHA1:
1422+ debug("Doing group exchange\n");
1423+ nbits = dh_estimate(ssh->kex->we_need * 8);
1424+ packet_start(SSH2_MSG_KEXGSS_GROUPREQ);
1425+ packet_put_int(min);
1426+ packet_put_int(nbits);
1427+ packet_put_int(max);
1428+
1429+ packet_send();
1430+
1431+ packet_read_expect(SSH2_MSG_KEXGSS_GROUP);
1432+
1433+ if ((p = BN_new()) == NULL)
1434+ fatal("BN_new() failed");
1435+ packet_get_bignum2(p);
1436+ if ((g = BN_new()) == NULL)
1437+ fatal("BN_new() failed");
1438+ packet_get_bignum2(g);
1439+ packet_check_eom();
1440+
1441+ if (BN_num_bits(p) < min || BN_num_bits(p) > max)
1442+ fatal("GSSGRP_GEX group out of range: %d !< %d !< %d",
1443+ min, BN_num_bits(p), max);
1444+
1445+ dh = dh_new_group(g, p);
1446+ break;
1447+ default:
1448+ fatal("%s: Unexpected KEX type %d", __func__, ssh->kex->kex_type);
1449+ }
1450+
1451+ /* Step 1 - e is dh->pub_key */
1452+ dh_gen_key(dh, ssh->kex->we_need * 8);
1453+
1454+ /* This is f, we initialise it now to make life easier */
1455+ dh_server_pub = BN_new();
1456+ if (dh_server_pub == NULL)
1457+ fatal("dh_server_pub == NULL");
1458+
1459+ token_ptr = GSS_C_NO_BUFFER;
1460+
1461+ do {
1462+ debug("Calling gss_init_sec_context");
1463+
1464+ maj_status = ssh_gssapi_init_ctx(ctxt,
1465+ ssh->kex->gss_deleg_creds, token_ptr, &send_tok,
1466+ &ret_flags);
1467+
1468+ if (GSS_ERROR(maj_status)) {
1469+ if (send_tok.length != 0) {
1470+ packet_start(SSH2_MSG_KEXGSS_CONTINUE);
1471+ packet_put_string(send_tok.value,
1472+ send_tok.length);
1473+ }
1474+ fatal("gss_init_context failed");
1475+ }
1476+
1477+ /* If we've got an old receive buffer get rid of it */
1478+ if (token_ptr != GSS_C_NO_BUFFER)
1479+ free(recv_tok.value);
1480+
1481+ if (maj_status == GSS_S_COMPLETE) {
1482+ /* If mutual state flag is not true, kex fails */
1483+ if (!(ret_flags & GSS_C_MUTUAL_FLAG))
1484+ fatal("Mutual authentication failed");
1485+
1486+ /* If integ avail flag is not true kex fails */
1487+ if (!(ret_flags & GSS_C_INTEG_FLAG))
1488+ fatal("Integrity check failed");
1489+ }
1490+
1491+ /*
1492+ * If we have data to send, then the last message that we
1493+ * received cannot have been a 'complete'.
1494+ */
1495+ if (send_tok.length != 0) {
1496+ if (first) {
1497+ packet_start(SSH2_MSG_KEXGSS_INIT);
1498+ packet_put_string(send_tok.value,
1499+ send_tok.length);
1500+ packet_put_bignum2(dh->pub_key);
1501+ first = 0;
1502+ } else {
1503+ packet_start(SSH2_MSG_KEXGSS_CONTINUE);
1504+ packet_put_string(send_tok.value,
1505+ send_tok.length);
1506+ }
1507+ packet_send();
1508+ gss_release_buffer(&min_status, &send_tok);
1509+
1510+ /* If we've sent them data, they should reply */
1511+ do {
1512+ type = packet_read();
1513+ if (type == SSH2_MSG_KEXGSS_HOSTKEY) {
1514+ debug("Received KEXGSS_HOSTKEY");
1515+ if (serverhostkey)
1516+ fatal("Server host key received more than once");
1517+ serverhostkey =
1518+ packet_get_string(&slen);
1519+ }
1520+ } while (type == SSH2_MSG_KEXGSS_HOSTKEY);
1521+
1522+ switch (type) {
1523+ case SSH2_MSG_KEXGSS_CONTINUE:
1524+ debug("Received GSSAPI_CONTINUE");
1525+ if (maj_status == GSS_S_COMPLETE)
1526+ fatal("GSSAPI Continue received from server when complete");
1527+ recv_tok.value = packet_get_string(&strlen);
1528+ recv_tok.length = strlen;
1529+ break;
1530+ case SSH2_MSG_KEXGSS_COMPLETE:
1531+ debug("Received GSSAPI_COMPLETE");
1532+ packet_get_bignum2(dh_server_pub);
1533+ msg_tok.value = packet_get_string(&strlen);
1534+ msg_tok.length = strlen;
1535+
1536+ /* Is there a token included? */
1537+ if (packet_get_char()) {
1538+ recv_tok.value=
1539+ packet_get_string(&strlen);
1540+ recv_tok.length = strlen;
1541+ /* If we're already complete - protocol error */
1542+ if (maj_status == GSS_S_COMPLETE)
1543+ packet_disconnect("Protocol error: received token when complete");
1544+ } else {
1545+ /* No token included */
1546+ if (maj_status != GSS_S_COMPLETE)
1547+ packet_disconnect("Protocol error: did not receive final token");
1548+ }
1549+ break;
1550+ case SSH2_MSG_KEXGSS_ERROR:
1551+ debug("Received Error");
1552+ maj_status = packet_get_int();
1553+ min_status = packet_get_int();
1554+ msg = packet_get_string(NULL);
1555+ (void) packet_get_string_ptr(NULL);
1556+ fatal("GSSAPI Error: \n%.400s",msg);
1557+ default:
1558+ packet_disconnect("Protocol error: didn't expect packet type %d",
1559+ type);
1560+ }
1561+ token_ptr = &recv_tok;
1562+ } else {
1563+ /* No data, and not complete */
1564+ if (maj_status != GSS_S_COMPLETE)
1565+ fatal("Not complete, and no token output");
1566+ }
1567+ } while (maj_status & GSS_S_CONTINUE_NEEDED);
1568+
1569+ /*
1570+ * We _must_ have received a COMPLETE message in reply from the
1571+ * server, which will have set dh_server_pub and msg_tok
1572+ */
1573+
1574+ if (type != SSH2_MSG_KEXGSS_COMPLETE)
1575+ fatal("Didn't receive a SSH2_MSG_KEXGSS_COMPLETE when I expected it");
1576+
1577+ /* Check f in range [1, p-1] */
1578+ if (!dh_pub_is_valid(dh, dh_server_pub))
1579+ packet_disconnect("bad server public DH value");
1580+
1581+ /* compute K=f^x mod p */
1582+ klen = DH_size(dh);
1583+ kbuf = xmalloc(klen);
1584+ kout = DH_compute_key(kbuf, dh_server_pub, dh);
1585+ if (kout < 0)
1586+ fatal("DH_compute_key: failed");
1587+
1588+ shared_secret = BN_new();
1589+ if (shared_secret == NULL)
1590+ fatal("kexgss_client: BN_new failed");
1591+
1592+ if (BN_bin2bn(kbuf, kout, shared_secret) == NULL)
1593+ fatal("kexdh_client: BN_bin2bn failed");
1594+
1595+ memset(kbuf, 0, klen);
1596+ free(kbuf);
1597+
1598+ hashlen = sizeof(hash);
1599+ switch (ssh->kex->kex_type) {
1600+ case KEX_GSS_GRP1_SHA1:
1601+ case KEX_GSS_GRP14_SHA1:
1602+ kex_dh_hash( ssh->kex->client_version_string,
1603+ ssh->kex->server_version_string,
1604+ buffer_ptr(ssh->kex->my), buffer_len(ssh->kex->my),
1605+ buffer_ptr(ssh->kex->peer), buffer_len(ssh->kex->peer),
1606+ (serverhostkey ? serverhostkey : empty), slen,
1607+ dh->pub_key, /* e */
1608+ dh_server_pub, /* f */
1609+ shared_secret, /* K */
1610+ hash, &hashlen
1611+ );
1612+ break;
1613+ case KEX_GSS_GEX_SHA1:
1614+ kexgex_hash(
1615+ ssh->kex->hash_alg,
1616+ ssh->kex->client_version_string,
1617+ ssh->kex->server_version_string,
1618+ buffer_ptr(ssh->kex->my), buffer_len(ssh->kex->my),
1619+ buffer_ptr(ssh->kex->peer), buffer_len(ssh->kex->peer),
1620+ (serverhostkey ? serverhostkey : empty), slen,
1621+ min, nbits, max,
1622+ dh->p, dh->g,
1623+ dh->pub_key,
1624+ dh_server_pub,
1625+ shared_secret,
1626+ hash, &hashlen
1627+ );
1628+ break;
1629+ default:
1630+ fatal("%s: Unexpected KEX type %d", __func__, ssh->kex->kex_type);
1631+ }
1632+
1633+ gssbuf.value = hash;
1634+ gssbuf.length = hashlen;
1635+
1636+ /* Verify that the hash matches the MIC we just got. */
1637+ if (GSS_ERROR(ssh_gssapi_checkmic(ctxt, &gssbuf, &msg_tok)))
1638+ packet_disconnect("Hash's MIC didn't verify");
1639+
1640+ free(msg_tok.value);
1641+
1642+ DH_free(dh);
1643+ free(serverhostkey);
1644+ BN_clear_free(dh_server_pub);
1645+
1646+ /* save session id */
1647+ if (ssh->kex->session_id == NULL) {
1648+ ssh->kex->session_id_len = hashlen;
1649+ ssh->kex->session_id = xmalloc(ssh->kex->session_id_len);
1650+ memcpy(ssh->kex->session_id, hash, ssh->kex->session_id_len);
1651+ }
1652+
1653+ if (ssh->kex->gss_deleg_creds)
1654+ ssh_gssapi_credentials_updated(ctxt);
1655+
1656+ if (gss_kex_context == NULL)
1657+ gss_kex_context = ctxt;
1658+ else
1659+ ssh_gssapi_delete_ctx(&ctxt);
1660+
1661+ kex_derive_keys_bn(ssh, hash, hashlen, shared_secret);
1662+ BN_clear_free(shared_secret);
1663+ return kex_send_newkeys(ssh);
1664+}
1665+
1666+#endif /* GSSAPI */
1667diff --git a/kexgsss.c b/kexgsss.c
1668new file mode 100644
1669index 0000000..0847469
1670--- /dev/null
1671+++ b/kexgsss.c
1672@@ -0,0 +1,295 @@
1673+/*
1674+ * Copyright (c) 2001-2009 Simon Wilkinson. All rights reserved.
1675+ *
1676+ * Redistribution and use in source and binary forms, with or without
1677+ * modification, are permitted provided that the following conditions
1678+ * are met:
1679+ * 1. Redistributions of source code must retain the above copyright
1680+ * notice, this list of conditions and the following disclaimer.
1681+ * 2. Redistributions in binary form must reproduce the above copyright
1682+ * notice, this list of conditions and the following disclaimer in the
1683+ * documentation and/or other materials provided with the distribution.
1684+ *
1685+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR `AS IS'' AND ANY EXPRESS OR
1686+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
1687+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
1688+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
1689+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
1690+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
1691+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
1692+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
1693+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
1694+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
1695+ */
1696+
1697+#include "includes.h"
1698+
1699+#ifdef GSSAPI
1700+
1701+#include <string.h>
1702+
1703+#include <openssl/crypto.h>
1704+#include <openssl/bn.h>
1705+
1706+#include "xmalloc.h"
1707+#include "buffer.h"
1708+#include "ssh2.h"
1709+#include "key.h"
1710+#include "cipher.h"
1711+#include "kex.h"
1712+#include "log.h"
1713+#include "packet.h"
1714+#include "dh.h"
1715+#include "ssh-gss.h"
1716+#include "monitor_wrap.h"
1717+#include "misc.h"
1718+#include "servconf.h"
1719+#include "digest.h"
1720+
1721+extern ServerOptions options;
1722+
1723+int
1724+kexgss_server(struct ssh *ssh)
1725+{
1726+ OM_uint32 maj_status, min_status;
1727+
1728+ /*
1729+ * Some GSSAPI implementations use the input value of ret_flags (an
1730+ * output variable) as a means of triggering mechanism specific
1731+ * features. Initializing it to zero avoids inadvertently
1732+ * activating this non-standard behaviour.
1733+ */
1734+
1735+ OM_uint32 ret_flags = 0;
1736+ gss_buffer_desc gssbuf, recv_tok, msg_tok;
1737+ gss_buffer_desc send_tok = GSS_C_EMPTY_BUFFER;
1738+ Gssctxt *ctxt = NULL;
1739+ u_int slen, klen, kout;
1740+ u_char *kbuf;
1741+ DH *dh;
1742+ int min = -1, max = -1, nbits = -1;
1743+ BIGNUM *shared_secret = NULL;
1744+ BIGNUM *dh_client_pub = NULL;
1745+ int type = 0;
1746+ gss_OID oid;
1747+ char *mechs;
1748+ u_char hash[SSH_DIGEST_MAX_LENGTH];
1749+ size_t hashlen;
1750+
1751+ /* Initialise GSSAPI */
1752+
1753+ /* If we're rekeying, privsep means that some of the private structures
1754+ * in the GSSAPI code are no longer available. This kludges them back
1755+ * into life
1756+ */
1757+ if (!ssh_gssapi_oid_table_ok()) {
1758+ mechs = ssh_gssapi_server_mechanisms();
1759+ free(mechs);
1760+ }
1761+
1762+ debug2("%s: Identifying %s", __func__, ssh->kex->name);
1763+ oid = ssh_gssapi_id_kex(NULL, ssh->kex->name, ssh->kex->kex_type);
1764+ if (oid == GSS_C_NO_OID)
1765+ fatal("Unknown gssapi mechanism");
1766+
1767+ debug2("%s: Acquiring credentials", __func__);
1768+
1769+ if (GSS_ERROR(PRIVSEP(ssh_gssapi_server_ctx(&ctxt, oid))))
1770+ fatal("Unable to acquire credentials for the server");
1771+
1772+ switch (ssh->kex->kex_type) {
1773+ case KEX_GSS_GRP1_SHA1:
1774+ dh = dh_new_group1();
1775+ break;
1776+ case KEX_GSS_GRP14_SHA1:
1777+ dh = dh_new_group14();
1778+ break;
1779+ case KEX_GSS_GEX_SHA1:
1780+ debug("Doing group exchange");
1781+ packet_read_expect(SSH2_MSG_KEXGSS_GROUPREQ);
1782+ min = packet_get_int();
1783+ nbits = packet_get_int();
1784+ max = packet_get_int();
1785+ min = MAX(DH_GRP_MIN, min);
1786+ max = MIN(DH_GRP_MAX, max);
1787+ packet_check_eom();
1788+ if (max < min || nbits < min || max < nbits)
1789+ fatal("GSS_GEX, bad parameters: %d !< %d !< %d",
1790+ min, nbits, max);
1791+ dh = PRIVSEP(choose_dh(min, nbits, max));
1792+ if (dh == NULL)
1793+ packet_disconnect("Protocol error: no matching group found");
1794+
1795+ packet_start(SSH2_MSG_KEXGSS_GROUP);
1796+ packet_put_bignum2(dh->p);
1797+ packet_put_bignum2(dh->g);
1798+ packet_send();
1799+
1800+ packet_write_wait();
1801+ break;
1802+ default:
1803+ fatal("%s: Unexpected KEX type %d", __func__, ssh->kex->kex_type);
1804+ }
1805+
1806+ dh_gen_key(dh, ssh->kex->we_need * 8);
1807+
1808+ do {
1809+ debug("Wait SSH2_MSG_GSSAPI_INIT");
1810+ type = packet_read();
1811+ switch(type) {
1812+ case SSH2_MSG_KEXGSS_INIT:
1813+ if (dh_client_pub != NULL)
1814+ fatal("Received KEXGSS_INIT after initialising");
1815+ recv_tok.value = packet_get_string(&slen);
1816+ recv_tok.length = slen;
1817+
1818+ if ((dh_client_pub = BN_new()) == NULL)
1819+ fatal("dh_client_pub == NULL");
1820+
1821+ packet_get_bignum2(dh_client_pub);
1822+
1823+ /* Send SSH_MSG_KEXGSS_HOSTKEY here, if we want */
1824+ break;
1825+ case SSH2_MSG_KEXGSS_CONTINUE:
1826+ recv_tok.value = packet_get_string(&slen);
1827+ recv_tok.length = slen;
1828+ break;
1829+ default:
1830+ packet_disconnect(
1831+ "Protocol error: didn't expect packet type %d",
1832+ type);
1833+ }
1834+
1835+ maj_status = PRIVSEP(ssh_gssapi_accept_ctx(ctxt, &recv_tok,
1836+ &send_tok, &ret_flags));
1837+
1838+ free(recv_tok.value);
1839+
1840+ if (maj_status != GSS_S_COMPLETE && send_tok.length == 0)
1841+ fatal("Zero length token output when incomplete");
1842+
1843+ if (dh_client_pub == NULL)
1844+ fatal("No client public key");
1845+
1846+ if (maj_status & GSS_S_CONTINUE_NEEDED) {
1847+ debug("Sending GSSAPI_CONTINUE");
1848+ packet_start(SSH2_MSG_KEXGSS_CONTINUE);
1849+ packet_put_string(send_tok.value, send_tok.length);
1850+ packet_send();
1851+ gss_release_buffer(&min_status, &send_tok);
1852+ }
1853+ } while (maj_status & GSS_S_CONTINUE_NEEDED);
1854+
1855+ if (GSS_ERROR(maj_status)) {
1856+ if (send_tok.length > 0) {
1857+ packet_start(SSH2_MSG_KEXGSS_CONTINUE);
1858+ packet_put_string(send_tok.value, send_tok.length);
1859+ packet_send();
1860+ }
1861+ fatal("accept_ctx died");
1862+ }
1863+
1864+ if (!(ret_flags & GSS_C_MUTUAL_FLAG))
1865+ fatal("Mutual Authentication flag wasn't set");
1866+
1867+ if (!(ret_flags & GSS_C_INTEG_FLAG))
1868+ fatal("Integrity flag wasn't set");
1869+
1870+ if (!dh_pub_is_valid(dh, dh_client_pub))
1871+ packet_disconnect("bad client public DH value");
1872+
1873+ klen = DH_size(dh);
1874+ kbuf = xmalloc(klen);
1875+ kout = DH_compute_key(kbuf, dh_client_pub, dh);
1876+ if (kout < 0)
1877+ fatal("DH_compute_key: failed");
1878+
1879+ shared_secret = BN_new();
1880+ if (shared_secret == NULL)
1881+ fatal("kexgss_server: BN_new failed");
1882+
1883+ if (BN_bin2bn(kbuf, kout, shared_secret) == NULL)
1884+ fatal("kexgss_server: BN_bin2bn failed");
1885+
1886+ memset(kbuf, 0, klen);
1887+ free(kbuf);
1888+
1889+ hashlen = sizeof(hash);
1890+ switch (ssh->kex->kex_type) {
1891+ case KEX_GSS_GRP1_SHA1:
1892+ case KEX_GSS_GRP14_SHA1:
1893+ kex_dh_hash(
1894+ ssh->kex->client_version_string, ssh->kex->server_version_string,
1895+ buffer_ptr(ssh->kex->peer), buffer_len(ssh->kex->peer),
1896+ buffer_ptr(ssh->kex->my), buffer_len(ssh->kex->my),
1897+ NULL, 0, /* Change this if we start sending host keys */
1898+ dh_client_pub, dh->pub_key, shared_secret,
1899+ hash, &hashlen
1900+ );
1901+ break;
1902+ case KEX_GSS_GEX_SHA1:
1903+ kexgex_hash(
1904+ ssh->kex->hash_alg,
1905+ ssh->kex->client_version_string, ssh->kex->server_version_string,
1906+ buffer_ptr(ssh->kex->peer), buffer_len(ssh->kex->peer),
1907+ buffer_ptr(ssh->kex->my), buffer_len(ssh->kex->my),
1908+ NULL, 0,
1909+ min, nbits, max,
1910+ dh->p, dh->g,
1911+ dh_client_pub,
1912+ dh->pub_key,
1913+ shared_secret,
1914+ hash, &hashlen
1915+ );
1916+ break;
1917+ default:
1918+ fatal("%s: Unexpected KEX type %d", __func__, ssh->kex->kex_type);
1919+ }
1920+
1921+ BN_clear_free(dh_client_pub);
1922+
1923+ if (ssh->kex->session_id == NULL) {
1924+ ssh->kex->session_id_len = hashlen;
1925+ ssh->kex->session_id = xmalloc(ssh->kex->session_id_len);
1926+ memcpy(ssh->kex->session_id, hash, ssh->kex->session_id_len);
1927+ }
1928+
1929+ gssbuf.value = hash;
1930+ gssbuf.length = hashlen;
1931+
1932+ if (GSS_ERROR(PRIVSEP(ssh_gssapi_sign(ctxt,&gssbuf,&msg_tok))))
1933+ fatal("Couldn't get MIC");
1934+
1935+ packet_start(SSH2_MSG_KEXGSS_COMPLETE);
1936+ packet_put_bignum2(dh->pub_key);
1937+ packet_put_string(msg_tok.value,msg_tok.length);
1938+
1939+ if (send_tok.length != 0) {
1940+ packet_put_char(1); /* true */
1941+ packet_put_string(send_tok.value, send_tok.length);
1942+ } else {
1943+ packet_put_char(0); /* false */
1944+ }
1945+ packet_send();
1946+
1947+ gss_release_buffer(&min_status, &send_tok);
1948+ gss_release_buffer(&min_status, &msg_tok);
1949+
1950+ if (gss_kex_context == NULL)
1951+ gss_kex_context = ctxt;
1952+ else
1953+ ssh_gssapi_delete_ctx(&ctxt);
1954+
1955+ DH_free(dh);
1956+
1957+ kex_derive_keys_bn(ssh, hash, hashlen, shared_secret);
1958+ BN_clear_free(shared_secret);
1959+ kex_send_newkeys(ssh);
1960+
1961+ /* If this was a rekey, then save out any delegated credentials we
1962+ * just exchanged. */
1963+ if (options.gss_store_rekey)
1964+ ssh_gssapi_rekey_creds();
1965+ return 0;
1966+}
1967+#endif /* GSSAPI */
1968diff --git a/monitor.c b/monitor.c
1969index bab6ce8..a2027e5 100644
1970--- a/monitor.c
1971+++ b/monitor.c
1972@@ -157,6 +157,8 @@ int mm_answer_gss_setup_ctx(int, Buffer *);
1973 int mm_answer_gss_accept_ctx(int, Buffer *);
1974 int mm_answer_gss_userok(int, Buffer *);
1975 int mm_answer_gss_checkmic(int, Buffer *);
1976+int mm_answer_gss_sign(int, Buffer *);
1977+int mm_answer_gss_updatecreds(int, Buffer *);
1978 #endif
1979
1980 #ifdef SSH_AUDIT_EVENTS
1981@@ -234,11 +236,18 @@ struct mon_table mon_dispatch_proto20[] = {
1982 {MONITOR_REQ_GSSSTEP, MON_ISAUTH, mm_answer_gss_accept_ctx},
1983 {MONITOR_REQ_GSSUSEROK, MON_AUTH, mm_answer_gss_userok},
1984 {MONITOR_REQ_GSSCHECKMIC, MON_ISAUTH, mm_answer_gss_checkmic},
1985+ {MONITOR_REQ_GSSSIGN, MON_ONCE, mm_answer_gss_sign},
1986 #endif
1987 {0, 0, NULL}
1988 };
1989
1990 struct mon_table mon_dispatch_postauth20[] = {
1991+#ifdef GSSAPI
1992+ {MONITOR_REQ_GSSSETUP, 0, mm_answer_gss_setup_ctx},
1993+ {MONITOR_REQ_GSSSTEP, 0, mm_answer_gss_accept_ctx},
1994+ {MONITOR_REQ_GSSSIGN, 0, mm_answer_gss_sign},
1995+ {MONITOR_REQ_GSSUPCREDS, 0, mm_answer_gss_updatecreds},
1996+#endif
1997 #ifdef WITH_OPENSSL
1998 {MONITOR_REQ_MODULI, 0, mm_answer_moduli},
1999 #endif
2000@@ -353,6 +362,10 @@ monitor_child_preauth(Authctxt *_authctxt, struct monitor *pmonitor)
2001 /* Permit requests for moduli and signatures */
2002 monitor_permit(mon_dispatch, MONITOR_REQ_MODULI, 1);
2003 monitor_permit(mon_dispatch, MONITOR_REQ_SIGN, 1);
2004+#ifdef GSSAPI
2005+ /* and for the GSSAPI key exchange */
2006+ monitor_permit(mon_dispatch, MONITOR_REQ_GSSSETUP, 1);
2007+#endif
2008 } else {
2009 mon_dispatch = mon_dispatch_proto15;
2010
2011@@ -461,6 +474,10 @@ monitor_child_postauth(struct monitor *pmonitor)
2012 monitor_permit(mon_dispatch, MONITOR_REQ_MODULI, 1);
2013 monitor_permit(mon_dispatch, MONITOR_REQ_SIGN, 1);
2014 monitor_permit(mon_dispatch, MONITOR_REQ_TERM, 1);
2015+#ifdef GSSAPI
2016+ /* and for the GSSAPI key exchange */
2017+ monitor_permit(mon_dispatch, MONITOR_REQ_GSSSETUP, 1);
2018+#endif
2019 } else {
2020 mon_dispatch = mon_dispatch_postauth15;
2021 monitor_permit(mon_dispatch, MONITOR_REQ_TERM, 1);
2022@@ -1860,6 +1877,13 @@ monitor_apply_keystate(struct monitor *pmonitor)
2023 # endif
2024 #endif /* WITH_OPENSSL */
2025 kex->kex[KEX_C25519_SHA256] = kexc25519_server;
2026+#ifdef GSSAPI
2027+ if (options.gss_keyex) {
2028+ kex->kex[KEX_GSS_GRP1_SHA1] = kexgss_server;
2029+ kex->kex[KEX_GSS_GRP14_SHA1] = kexgss_server;
2030+ kex->kex[KEX_GSS_GEX_SHA1] = kexgss_server;
2031+ }
2032+#endif
2033 kex->load_host_public_key=&get_hostkey_public_by_type;
2034 kex->load_host_private_key=&get_hostkey_private_by_type;
2035 kex->host_key_index=&get_hostkey_index;
2036@@ -1959,6 +1983,9 @@ mm_answer_gss_setup_ctx(int sock, Buffer *m)
2037 OM_uint32 major;
2038 u_int len;
2039
2040+ if (!options.gss_authentication && !options.gss_keyex)
2041+ fatal("In GSSAPI monitor when GSSAPI is disabled");
2042+
2043 goid.elements = buffer_get_string(m, &len);
2044 goid.length = len;
2045
2046@@ -1986,6 +2013,9 @@ mm_answer_gss_accept_ctx(int sock, Buffer *m)
2047 OM_uint32 flags = 0; /* GSI needs this */
2048 u_int len;
2049
2050+ if (!options.gss_authentication && !options.gss_keyex)
2051+ fatal("In GSSAPI monitor when GSSAPI is disabled");
2052+
2053 in.value = buffer_get_string(m, &len);
2054 in.length = len;
2055 major = ssh_gssapi_accept_ctx(gsscontext, &in, &out, &flags);
2056@@ -2003,6 +2033,7 @@ mm_answer_gss_accept_ctx(int sock, Buffer *m)
2057 monitor_permit(mon_dispatch, MONITOR_REQ_GSSSTEP, 0);
2058 monitor_permit(mon_dispatch, MONITOR_REQ_GSSUSEROK, 1);
2059 monitor_permit(mon_dispatch, MONITOR_REQ_GSSCHECKMIC, 1);
2060+ monitor_permit(mon_dispatch, MONITOR_REQ_GSSSIGN, 1);
2061 }
2062 return (0);
2063 }
2064@@ -2014,6 +2045,9 @@ mm_answer_gss_checkmic(int sock, Buffer *m)
2065 OM_uint32 ret;
2066 u_int len;
2067
2068+ if (!options.gss_authentication && !options.gss_keyex)
2069+ fatal("In GSSAPI monitor when GSSAPI is disabled");
2070+
2071 gssbuf.value = buffer_get_string(m, &len);
2072 gssbuf.length = len;
2073 mic.value = buffer_get_string(m, &len);
2074@@ -2040,7 +2074,11 @@ mm_answer_gss_userok(int sock, Buffer *m)
2075 {
2076 int authenticated;
2077
2078- authenticated = authctxt->valid && ssh_gssapi_userok(authctxt->user);
2079+ if (!options.gss_authentication && !options.gss_keyex)
2080+ fatal("In GSSAPI monitor when GSSAPI is disabled");
2081+
2082+ authenticated = authctxt->valid &&
2083+ ssh_gssapi_userok(authctxt->user, authctxt->pw);
2084
2085 buffer_clear(m);
2086 buffer_put_int(m, authenticated);
2087@@ -2053,5 +2091,73 @@ mm_answer_gss_userok(int sock, Buffer *m)
2088 /* Monitor loop will terminate if authenticated */
2089 return (authenticated);
2090 }
2091+
2092+int
2093+mm_answer_gss_sign(int socket, Buffer *m)
2094+{
2095+ gss_buffer_desc data;
2096+ gss_buffer_desc hash = GSS_C_EMPTY_BUFFER;
2097+ OM_uint32 major, minor;
2098+ u_int len;
2099+
2100+ if (!options.gss_authentication && !options.gss_keyex)
2101+ fatal("In GSSAPI monitor when GSSAPI is disabled");
2102+
2103+ data.value = buffer_get_string(m, &len);
2104+ data.length = len;
2105+ if (data.length != 20)
2106+ fatal("%s: data length incorrect: %d", __func__,
2107+ (int) data.length);
2108+
2109+ /* Save the session ID on the first time around */
2110+ if (session_id2_len == 0) {
2111+ session_id2_len = data.length;
2112+ session_id2 = xmalloc(session_id2_len);
2113+ memcpy(session_id2, data.value, session_id2_len);
2114+ }
2115+ major = ssh_gssapi_sign(gsscontext, &data, &hash);
2116+
2117+ free(data.value);
2118+
2119+ buffer_clear(m);
2120+ buffer_put_int(m, major);
2121+ buffer_put_string(m, hash.value, hash.length);
2122+
2123+ mm_request_send(socket, MONITOR_ANS_GSSSIGN, m);
2124+
2125+ gss_release_buffer(&minor, &hash);
2126+
2127+ /* Turn on getpwnam permissions */
2128+ monitor_permit(mon_dispatch, MONITOR_REQ_PWNAM, 1);
2129+
2130+ /* And credential updating, for when rekeying */
2131+ monitor_permit(mon_dispatch, MONITOR_REQ_GSSUPCREDS, 1);
2132+
2133+ return (0);
2134+}
2135+
2136+int
2137+mm_answer_gss_updatecreds(int socket, Buffer *m) {
2138+ ssh_gssapi_ccache store;
2139+ int ok;
2140+
2141+ store.filename = buffer_get_string(m, NULL);
2142+ store.envvar = buffer_get_string(m, NULL);
2143+ store.envval = buffer_get_string(m, NULL);
2144+
2145+ ok = ssh_gssapi_update_creds(&store);
2146+
2147+ free(store.filename);
2148+ free(store.envvar);
2149+ free(store.envval);
2150+
2151+ buffer_clear(m);
2152+ buffer_put_int(m, ok);
2153+
2154+ mm_request_send(socket, MONITOR_ANS_GSSUPCREDS, m);
2155+
2156+ return(0);
2157+}
2158+
2159 #endif /* GSSAPI */
2160
2161diff --git a/monitor.h b/monitor.h
2162index 93b8b66..bc50ade 100644
2163--- a/monitor.h
2164+++ b/monitor.h
2165@@ -65,6 +65,9 @@ enum monitor_reqtype {
2166 MONITOR_REQ_PAM_FREE_CTX = 110, MONITOR_ANS_PAM_FREE_CTX = 111,
2167 MONITOR_REQ_AUDIT_EVENT = 112, MONITOR_REQ_AUDIT_COMMAND = 113,
2168
2169+ MONITOR_REQ_GSSSIGN = 150, MONITOR_ANS_GSSSIGN = 151,
2170+ MONITOR_REQ_GSSUPCREDS = 152, MONITOR_ANS_GSSUPCREDS = 153,
2171+
2172 };
2173
2174 struct mm_master;
2175diff --git a/monitor_wrap.c b/monitor_wrap.c
2176index b379f05..b667218 100644
2177--- a/monitor_wrap.c
2178+++ b/monitor_wrap.c
2179@@ -1068,7 +1068,7 @@ mm_ssh_gssapi_checkmic(Gssctxt *ctx, gss_buffer_t gssbuf, gss_buffer_t gssmic)
2180 }
2181
2182 int
2183-mm_ssh_gssapi_userok(char *user)
2184+mm_ssh_gssapi_userok(char *user, struct passwd *pw)
2185 {
2186 Buffer m;
2187 int authenticated = 0;
2188@@ -1085,5 +1085,50 @@ mm_ssh_gssapi_userok(char *user)
2189 debug3("%s: user %sauthenticated",__func__, authenticated ? "" : "not ");
2190 return (authenticated);
2191 }
2192+
2193+OM_uint32
2194+mm_ssh_gssapi_sign(Gssctxt *ctx, gss_buffer_desc *data, gss_buffer_desc *hash)
2195+{
2196+ Buffer m;
2197+ OM_uint32 major;
2198+ u_int len;
2199+
2200+ buffer_init(&m);
2201+ buffer_put_string(&m, data->value, data->length);
2202+
2203+ mm_request_send(pmonitor->m_recvfd, MONITOR_REQ_GSSSIGN, &m);
2204+ mm_request_receive_expect(pmonitor->m_recvfd, MONITOR_ANS_GSSSIGN, &m);
2205+
2206+ major = buffer_get_int(&m);
2207+ hash->value = buffer_get_string(&m, &len);
2208+ hash->length = len;
2209+
2210+ buffer_free(&m);
2211+
2212+ return(major);
2213+}
2214+
2215+int
2216+mm_ssh_gssapi_update_creds(ssh_gssapi_ccache *store)
2217+{
2218+ Buffer m;
2219+ int ok;
2220+
2221+ buffer_init(&m);
2222+
2223+ buffer_put_cstring(&m, store->filename ? store->filename : "");
2224+ buffer_put_cstring(&m, store->envvar ? store->envvar : "");
2225+ buffer_put_cstring(&m, store->envval ? store->envval : "");
2226+
2227+ mm_request_send(pmonitor->m_recvfd, MONITOR_REQ_GSSUPCREDS, &m);
2228+ mm_request_receive_expect(pmonitor->m_recvfd, MONITOR_ANS_GSSUPCREDS, &m);
2229+
2230+ ok = buffer_get_int(&m);
2231+
2232+ buffer_free(&m);
2233+
2234+ return (ok);
2235+}
2236+
2237 #endif /* GSSAPI */
2238
2239diff --git a/monitor_wrap.h b/monitor_wrap.h
2240index e18784a..0c770e8 100644
2241--- a/monitor_wrap.h
2242+++ b/monitor_wrap.h
2243@@ -58,8 +58,10 @@ BIGNUM *mm_auth_rsa_generate_challenge(Key *);
2244 OM_uint32 mm_ssh_gssapi_server_ctx(Gssctxt **, gss_OID);
2245 OM_uint32 mm_ssh_gssapi_accept_ctx(Gssctxt *,
2246 gss_buffer_desc *, gss_buffer_desc *, OM_uint32 *);
2247-int mm_ssh_gssapi_userok(char *user);
2248+int mm_ssh_gssapi_userok(char *user, struct passwd *);
2249 OM_uint32 mm_ssh_gssapi_checkmic(Gssctxt *, gss_buffer_t, gss_buffer_t);
2250+OM_uint32 mm_ssh_gssapi_sign(Gssctxt *, gss_buffer_t, gss_buffer_t);
2251+int mm_ssh_gssapi_update_creds(ssh_gssapi_ccache *);
2252 #endif
2253
2254 #ifdef USE_PAM
2255diff --git a/readconf.c b/readconf.c
2256index 42a2961..254dbce 100644
2257--- a/readconf.c
2258+++ b/readconf.c
2259@@ -147,6 +147,8 @@ typedef enum {
2260 oClearAllForwardings, oNoHostAuthenticationForLocalhost,
2261 oEnableSSHKeysign, oRekeyLimit, oVerifyHostKeyDNS, oConnectTimeout,
2262 oAddressFamily, oGssAuthentication, oGssDelegateCreds,
2263+ oGssTrustDns, oGssKeyEx, oGssClientIdentity, oGssRenewalRekey,
2264+ oGssServerIdentity,
2265 oServerAliveInterval, oServerAliveCountMax, oIdentitiesOnly,
2266 oSendEnv, oControlPath, oControlMaster, oControlPersist,
2267 oHashKnownHosts,
2268@@ -191,10 +193,19 @@ static struct {
2269 { "afstokenpassing", oUnsupported },
2270 #if defined(GSSAPI)
2271 { "gssapiauthentication", oGssAuthentication },
2272+ { "gssapikeyexchange", oGssKeyEx },
2273 { "gssapidelegatecredentials", oGssDelegateCreds },
2274+ { "gssapitrustdns", oGssTrustDns },
2275+ { "gssapiclientidentity", oGssClientIdentity },
2276+ { "gssapiserveridentity", oGssServerIdentity },
2277+ { "gssapirenewalforcesrekey", oGssRenewalRekey },
2278 #else
2279 { "gssapiauthentication", oUnsupported },
2280+ { "gssapikeyexchange", oUnsupported },
2281 { "gssapidelegatecredentials", oUnsupported },
2282+ { "gssapitrustdns", oUnsupported },
2283+ { "gssapiclientidentity", oUnsupported },
2284+ { "gssapirenewalforcesrekey", oUnsupported },
2285 #endif
2286 { "fallbacktorsh", oDeprecated },
2287 { "usersh", oDeprecated },
2288@@ -892,10 +903,30 @@ parse_time:
2289 intptr = &options->gss_authentication;
2290 goto parse_flag;
2291
2292+ case oGssKeyEx:
2293+ intptr = &options->gss_keyex;
2294+ goto parse_flag;
2295+
2296 case oGssDelegateCreds:
2297 intptr = &options->gss_deleg_creds;
2298 goto parse_flag;
2299
2300+ case oGssTrustDns:
2301+ intptr = &options->gss_trust_dns;
2302+ goto parse_flag;
2303+
2304+ case oGssClientIdentity:
2305+ charptr = &options->gss_client_identity;
2306+ goto parse_string;
2307+
2308+ case oGssServerIdentity:
2309+ charptr = &options->gss_server_identity;
2310+ goto parse_string;
2311+
2312+ case oGssRenewalRekey:
2313+ intptr = &options->gss_renewal_rekey;
2314+ goto parse_flag;
2315+
2316 case oBatchMode:
2317 intptr = &options->batch_mode;
2318 goto parse_flag;
2319@@ -1601,7 +1632,12 @@ initialize_options(Options * options)
2320 options->pubkey_authentication = -1;
2321 options->challenge_response_authentication = -1;
2322 options->gss_authentication = -1;
2323+ options->gss_keyex = -1;
2324 options->gss_deleg_creds = -1;
2325+ options->gss_trust_dns = -1;
2326+ options->gss_renewal_rekey = -1;
2327+ options->gss_client_identity = NULL;
2328+ options->gss_server_identity = NULL;
2329 options->password_authentication = -1;
2330 options->kbd_interactive_authentication = -1;
2331 options->kbd_interactive_devices = NULL;
2332@@ -1728,8 +1764,14 @@ fill_default_options(Options * options)
2333 options->challenge_response_authentication = 1;
2334 if (options->gss_authentication == -1)
2335 options->gss_authentication = 0;
2336+ if (options->gss_keyex == -1)
2337+ options->gss_keyex = 0;
2338 if (options->gss_deleg_creds == -1)
2339 options->gss_deleg_creds = 0;
2340+ if (options->gss_trust_dns == -1)
2341+ options->gss_trust_dns = 0;
2342+ if (options->gss_renewal_rekey == -1)
2343+ options->gss_renewal_rekey = 0;
2344 if (options->password_authentication == -1)
2345 options->password_authentication = 1;
2346 if (options->kbd_interactive_authentication == -1)
2347diff --git a/readconf.h b/readconf.h
2348index 576b9e3..ef39c4c 100644
2349--- a/readconf.h
2350+++ b/readconf.h
2351@@ -45,7 +45,12 @@ typedef struct {
2352 int challenge_response_authentication;
2353 /* Try S/Key or TIS, authentication. */
2354 int gss_authentication; /* Try GSS authentication */
2355+ int gss_keyex; /* Try GSS key exchange */
2356 int gss_deleg_creds; /* Delegate GSS credentials */
2357+ int gss_trust_dns; /* Trust DNS for GSS canonicalization */
2358+ int gss_renewal_rekey; /* Credential renewal forces rekey */
2359+ char *gss_client_identity; /* Principal to initiate GSSAPI with */
2360+ char *gss_server_identity; /* GSSAPI target principal */
2361 int password_authentication; /* Try password
2362 * authentication. */
2363 int kbd_interactive_authentication; /* Try keyboard-interactive auth. */
2364diff --git a/servconf.c b/servconf.c
2365index 3185462..f68c0d0 100644
2366--- a/servconf.c
2367+++ b/servconf.c
2368@@ -114,7 +114,10 @@ initialize_server_options(ServerOptions *options)
2369 options->kerberos_ticket_cleanup = -1;
2370 options->kerberos_get_afs_token = -1;
2371 options->gss_authentication=-1;
2372+ options->gss_keyex = -1;
2373 options->gss_cleanup_creds = -1;
2374+ options->gss_strict_acceptor = -1;
2375+ options->gss_store_rekey = -1;
2376 options->password_authentication = -1;
2377 options->kbd_interactive_authentication = -1;
2378 options->challenge_response_authentication = -1;
2379@@ -269,8 +272,14 @@ fill_default_server_options(ServerOptions *options)
2380 options->kerberos_get_afs_token = 0;
2381 if (options->gss_authentication == -1)
2382 options->gss_authentication = 0;
2383+ if (options->gss_keyex == -1)
2384+ options->gss_keyex = 0;
2385 if (options->gss_cleanup_creds == -1)
2386 options->gss_cleanup_creds = 1;
2387+ if (options->gss_strict_acceptor == -1)
2388+ options->gss_strict_acceptor = 1;
2389+ if (options->gss_store_rekey == -1)
2390+ options->gss_store_rekey = 0;
2391 if (options->password_authentication == -1)
2392 options->password_authentication = 1;
2393 if (options->kbd_interactive_authentication == -1)
2394@@ -391,7 +400,9 @@ typedef enum {
2395 sBanner, sUseDNS, sHostbasedAuthentication,
2396 sHostbasedUsesNameFromPacketOnly, sHostbasedAcceptedKeyTypes,
2397 sClientAliveInterval, sClientAliveCountMax, sAuthorizedKeysFile,
2398- sGssAuthentication, sGssCleanupCreds, sAcceptEnv, sPermitTunnel,
2399+ sGssAuthentication, sGssCleanupCreds, sGssStrictAcceptor,
2400+ sGssKeyEx, sGssStoreRekey,
2401+ sAcceptEnv, sPermitTunnel,
2402 sMatch, sPermitOpen, sForceCommand, sChrootDirectory,
2403 sUsePrivilegeSeparation, sAllowAgentForwarding,
2404 sHostCertificate,
2405@@ -462,10 +473,20 @@ static struct {
2406 #ifdef GSSAPI
2407 { "gssapiauthentication", sGssAuthentication, SSHCFG_ALL },
2408 { "gssapicleanupcredentials", sGssCleanupCreds, SSHCFG_GLOBAL },
2409+ { "gssapicleanupcreds", sGssCleanupCreds, SSHCFG_GLOBAL },
2410+ { "gssapistrictacceptorcheck", sGssStrictAcceptor, SSHCFG_GLOBAL },
2411+ { "gssapikeyexchange", sGssKeyEx, SSHCFG_GLOBAL },
2412+ { "gssapistorecredentialsonrekey", sGssStoreRekey, SSHCFG_GLOBAL },
2413 #else
2414 { "gssapiauthentication", sUnsupported, SSHCFG_ALL },
2415 { "gssapicleanupcredentials", sUnsupported, SSHCFG_GLOBAL },
2416+ { "gssapicleanupcreds", sUnsupported, SSHCFG_GLOBAL },
2417+ { "gssapistrictacceptorcheck", sUnsupported, SSHCFG_GLOBAL },
2418+ { "gssapikeyexchange", sUnsupported, SSHCFG_GLOBAL },
2419+ { "gssapistorecredentialsonrekey", sUnsupported, SSHCFG_GLOBAL },
2420 #endif
2421+ { "gssusesessionccache", sUnsupported, SSHCFG_GLOBAL },
2422+ { "gssapiusesessioncredcache", sUnsupported, SSHCFG_GLOBAL },
2423 { "passwordauthentication", sPasswordAuthentication, SSHCFG_ALL },
2424 { "kbdinteractiveauthentication", sKbdInteractiveAuthentication, SSHCFG_ALL },
2425 { "challengeresponseauthentication", sChallengeResponseAuthentication, SSHCFG_GLOBAL },
2426@@ -1166,10 +1187,22 @@ process_server_config_line(ServerOptions *options, char *line,
2427 intptr = &options->gss_authentication;
2428 goto parse_flag;
2429
2430+ case sGssKeyEx:
2431+ intptr = &options->gss_keyex;
2432+ goto parse_flag;
2433+
2434 case sGssCleanupCreds:
2435 intptr = &options->gss_cleanup_creds;
2436 goto parse_flag;
2437
2438+ case sGssStrictAcceptor:
2439+ intptr = &options->gss_strict_acceptor;
2440+ goto parse_flag;
2441+
2442+ case sGssStoreRekey:
2443+ intptr = &options->gss_store_rekey;
2444+ goto parse_flag;
2445+
2446 case sPasswordAuthentication:
2447 intptr = &options->password_authentication;
2448 goto parse_flag;
2449@@ -2125,7 +2158,10 @@ dump_config(ServerOptions *o)
2450 #endif
2451 #ifdef GSSAPI
2452 dump_cfg_fmtint(sGssAuthentication, o->gss_authentication);
2453+ dump_cfg_fmtint(sGssKeyEx, o->gss_keyex);
2454 dump_cfg_fmtint(sGssCleanupCreds, o->gss_cleanup_creds);
2455+ dump_cfg_fmtint(sGssStrictAcceptor, o->gss_strict_acceptor);
2456+ dump_cfg_fmtint(sGssStoreRekey, o->gss_store_rekey);
2457 #endif
2458 dump_cfg_fmtint(sPasswordAuthentication, o->password_authentication);
2459 dump_cfg_fmtint(sKbdInteractiveAuthentication,
2460diff --git a/servconf.h b/servconf.h
2461index 9922f0c..d2ed4d7 100644
2462--- a/servconf.h
2463+++ b/servconf.h
2464@@ -115,7 +115,10 @@ typedef struct {
2465 int kerberos_get_afs_token; /* If true, try to get AFS token if
2466 * authenticated with Kerberos. */
2467 int gss_authentication; /* If true, permit GSSAPI authentication */
2468+ int gss_keyex; /* If true, permit GSSAPI key exchange */
2469 int gss_cleanup_creds; /* If true, destroy cred cache on logout */
2470+ int gss_strict_acceptor; /* If true, restrict the GSSAPI acceptor name */
2471+ int gss_store_rekey;
2472 int password_authentication; /* If true, permit password
2473 * authentication. */
2474 int kbd_interactive_authentication; /* If true, permit */
2475diff --git a/ssh-gss.h b/ssh-gss.h
2476index a99d7f0..914701b 100644
2477--- a/ssh-gss.h
2478+++ b/ssh-gss.h
2479@@ -1,6 +1,6 @@
2480 /* $OpenBSD: ssh-gss.h,v 1.11 2014/02/26 20:28:44 djm Exp $ */
2481 /*
2482- * Copyright (c) 2001-2003 Simon Wilkinson. All rights reserved.
2483+ * Copyright (c) 2001-2009 Simon Wilkinson. All rights reserved.
2484 *
2485 * Redistribution and use in source and binary forms, with or without
2486 * modification, are permitted provided that the following conditions
2487@@ -61,10 +61,22 @@
2488
2489 #define SSH_GSS_OIDTYPE 0x06
2490
2491+#define SSH2_MSG_KEXGSS_INIT 30
2492+#define SSH2_MSG_KEXGSS_CONTINUE 31
2493+#define SSH2_MSG_KEXGSS_COMPLETE 32
2494+#define SSH2_MSG_KEXGSS_HOSTKEY 33
2495+#define SSH2_MSG_KEXGSS_ERROR 34
2496+#define SSH2_MSG_KEXGSS_GROUPREQ 40
2497+#define SSH2_MSG_KEXGSS_GROUP 41
2498+#define KEX_GSS_GRP1_SHA1_ID "gss-group1-sha1-"
2499+#define KEX_GSS_GRP14_SHA1_ID "gss-group14-sha1-"
2500+#define KEX_GSS_GEX_SHA1_ID "gss-gex-sha1-"
2501+
2502 typedef struct {
2503 char *filename;
2504 char *envvar;
2505 char *envval;
2506+ struct passwd *owner;
2507 void *data;
2508 } ssh_gssapi_ccache;
2509
2510@@ -72,8 +84,11 @@ typedef struct {
2511 gss_buffer_desc displayname;
2512 gss_buffer_desc exportedname;
2513 gss_cred_id_t creds;
2514+ gss_name_t name;
2515 struct ssh_gssapi_mech_struct *mech;
2516 ssh_gssapi_ccache store;
2517+ int used;
2518+ int updated;
2519 } ssh_gssapi_client;
2520
2521 typedef struct ssh_gssapi_mech_struct {
2522@@ -84,6 +99,7 @@ typedef struct ssh_gssapi_mech_struct {
2523 int (*userok) (ssh_gssapi_client *, char *);
2524 int (*localname) (ssh_gssapi_client *, char **);
2525 void (*storecreds) (ssh_gssapi_client *);
2526+ int (*updatecreds) (ssh_gssapi_ccache *, ssh_gssapi_client *);
2527 } ssh_gssapi_mech;
2528
2529 typedef struct {
2530@@ -94,10 +110,11 @@ typedef struct {
2531 gss_OID oid; /* client */
2532 gss_cred_id_t creds; /* server */
2533 gss_name_t client; /* server */
2534- gss_cred_id_t client_creds; /* server */
2535+ gss_cred_id_t client_creds; /* both */
2536 } Gssctxt;
2537
2538 extern ssh_gssapi_mech *supported_mechs[];
2539+extern Gssctxt *gss_kex_context;
2540
2541 int ssh_gssapi_check_oid(Gssctxt *, void *, size_t);
2542 void ssh_gssapi_set_oid_data(Gssctxt *, void *, size_t);
2543@@ -119,16 +136,32 @@ void ssh_gssapi_build_ctx(Gssctxt **);
2544 void ssh_gssapi_delete_ctx(Gssctxt **);
2545 OM_uint32 ssh_gssapi_sign(Gssctxt *, gss_buffer_t, gss_buffer_t);
2546 void ssh_gssapi_buildmic(Buffer *, const char *, const char *, const char *);
2547-int ssh_gssapi_check_mechanism(Gssctxt **, gss_OID, const char *);
2548+int ssh_gssapi_check_mechanism(Gssctxt **, gss_OID, const char *, const char *);
2549+OM_uint32 ssh_gssapi_client_identity(Gssctxt *, const char *);
2550+int ssh_gssapi_credentials_updated(Gssctxt *);
2551
2552 /* In the server */
2553+typedef int ssh_gssapi_check_fn(Gssctxt **, gss_OID, const char *,
2554+ const char *);
2555+char *ssh_gssapi_client_mechanisms(const char *, const char *);
2556+char *ssh_gssapi_kex_mechs(gss_OID_set, ssh_gssapi_check_fn *, const char *,
2557+ const char *);
2558+gss_OID ssh_gssapi_id_kex(Gssctxt *, char *, int);
2559+int ssh_gssapi_server_check_mech(Gssctxt **,gss_OID, const char *,
2560+ const char *);
2561 OM_uint32 ssh_gssapi_server_ctx(Gssctxt **, gss_OID);
2562-int ssh_gssapi_userok(char *name);
2563+int ssh_gssapi_userok(char *name, struct passwd *);
2564 OM_uint32 ssh_gssapi_checkmic(Gssctxt *, gss_buffer_t, gss_buffer_t);
2565 void ssh_gssapi_do_child(char ***, u_int *);
2566 void ssh_gssapi_cleanup_creds(void);
2567 void ssh_gssapi_storecreds(void);
2568
2569+char *ssh_gssapi_server_mechanisms(void);
2570+int ssh_gssapi_oid_table_ok(void);
2571+
2572+int ssh_gssapi_update_creds(ssh_gssapi_ccache *store);
2573+void ssh_gssapi_rekey_creds(void);
2574+
2575 #endif /* GSSAPI */
2576
2577 #endif /* _SSH_GSS_H */
2578diff --git a/ssh_config b/ssh_config
2579index 03a228f..228e5ab 100644
2580--- a/ssh_config
2581+++ b/ssh_config
2582@@ -26,6 +26,8 @@
2583 # HostbasedAuthentication no
2584 # GSSAPIAuthentication no
2585 # GSSAPIDelegateCredentials no
2586+# GSSAPIKeyExchange no
2587+# GSSAPITrustDNS no
2588 # BatchMode no
2589 # CheckHostIP yes
2590 # AddressFamily any
2591diff --git a/ssh_config.5 b/ssh_config.5
2592index 140d0ba..4476171 100644
2593--- a/ssh_config.5
2594+++ b/ssh_config.5
2595@@ -743,11 +743,43 @@ Specifies whether user authentication based on GSSAPI is allowed.
2596 The default is
2597 .Dq no .
2598 Note that this option applies to protocol version 2 only.
2599+.It Cm GSSAPIKeyExchange
2600+Specifies whether key exchange based on GSSAPI may be used. When using
2601+GSSAPI key exchange the server need not have a host key.
2602+The default is
2603+.Dq no .
2604+Note that this option applies to protocol version 2 only.
2605+.It Cm GSSAPIClientIdentity
2606+If set, specifies the GSSAPI client identity that ssh should use when
2607+connecting to the server. The default is unset, which means that the default
2608+identity will be used.
2609+.It Cm GSSAPIServerIdentity
2610+If set, specifies the GSSAPI server identity that ssh should expect when
2611+connecting to the server. The default is unset, which means that the
2612+expected GSSAPI server identity will be determined from the target
2613+hostname.
2614 .It Cm GSSAPIDelegateCredentials
2615 Forward (delegate) credentials to the server.
2616 The default is
2617 .Dq no .
2618-Note that this option applies to protocol version 2 only.
2619+Note that this option applies to protocol version 2 connections using GSSAPI.
2620+.It Cm GSSAPIRenewalForcesRekey
2621+If set to
2622+.Dq yes
2623+then renewal of the client's GSSAPI credentials will force the rekeying of the
2624+ssh connection. With a compatible server, this can delegate the renewed
2625+credentials to a session on the server.
2626+The default is
2627+.Dq no .
2628+.It Cm GSSAPITrustDns
2629+Set to
2630+.Dq yes to indicate that the DNS is trusted to securely canonicalize
2631+the name of the host being connected to. If
2632+.Dq no, the hostname entered on the
2633+command line will be passed untouched to the GSSAPI library.
2634+The default is
2635+.Dq no .
2636+This option only applies to protocol version 2 connections using GSSAPI.
2637 .It Cm HashKnownHosts
2638 Indicates that
2639 .Xr ssh 1
2640diff --git a/sshconnect2.c b/sshconnect2.c
2641index ba56f64..faa8ec5 100644
2642--- a/sshconnect2.c
2643+++ b/sshconnect2.c
2644@@ -160,9 +160,34 @@ ssh_kex2(char *host, struct sockaddr *hostaddr, u_short port)
2645 struct kex *kex;
2646 int r;
2647
2648+#ifdef GSSAPI
2649+ char *orig = NULL, *gss = NULL;
2650+ char *gss_host = NULL;
2651+#endif
2652+
2653 xxx_host = host;
2654 xxx_hostaddr = hostaddr;
2655
2656+#ifdef GSSAPI
2657+ if (options.gss_keyex) {
2658+ /* Add the GSSAPI mechanisms currently supported on this
2659+ * client to the key exchange algorithm proposal */
2660+ orig = myproposal[PROPOSAL_KEX_ALGS];
2661+
2662+ if (options.gss_trust_dns)
2663+ gss_host = (char *)get_canonical_hostname(1);
2664+ else
2665+ gss_host = host;
2666+
2667+ gss = ssh_gssapi_client_mechanisms(gss_host, options.gss_client_identity);
2668+ if (gss) {
2669+ debug("Offering GSSAPI proposal: %s", gss);
2670+ xasprintf(&myproposal[PROPOSAL_KEX_ALGS],
2671+ "%s,%s", gss, orig);
2672+ }
2673+ }
2674+#endif
2675+
2676 if (options.ciphers == (char *)-1) {
2677 logit("No valid ciphers for protocol version 2 given, using defaults.");
2678 options.ciphers = NULL;
2679@@ -200,6 +225,17 @@ ssh_kex2(char *host, struct sockaddr *hostaddr, u_short port)
2680 myproposal[PROPOSAL_KEX_ALGS] = compat_kex_proposal(
2681 myproposal[PROPOSAL_KEX_ALGS]);
2682
2683+#ifdef GSSAPI
2684+ /* If we've got GSSAPI algorithms, then we also support the
2685+ * 'null' hostkey, as a last resort */
2686+ if (options.gss_keyex && gss) {
2687+ orig = myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS];
2688+ xasprintf(&myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS],
2689+ "%s,null", orig);
2690+ free(gss);
2691+ }
2692+#endif
2693+
2694 if (options.rekey_limit || options.rekey_interval)
2695 packet_set_rekey_limits((u_int32_t)options.rekey_limit,
2696 (time_t)options.rekey_interval);
2697@@ -218,10 +254,30 @@ ssh_kex2(char *host, struct sockaddr *hostaddr, u_short port)
2698 # endif
2699 #endif
2700 kex->kex[KEX_C25519_SHA256] = kexc25519_client;
2701+#ifdef GSSAPI
2702+ if (options.gss_keyex) {
2703+ kex->kex[KEX_GSS_GRP1_SHA1] = kexgss_client;
2704+ kex->kex[KEX_GSS_GRP14_SHA1] = kexgss_client;
2705+ kex->kex[KEX_GSS_GEX_SHA1] = kexgss_client;
2706+ }
2707+#endif
2708 kex->client_version_string=client_version_string;
2709 kex->server_version_string=server_version_string;
2710 kex->verify_host_key=&verify_host_key_callback;
2711
2712+#ifdef GSSAPI
2713+ if (options.gss_keyex) {
2714+ kex->gss_deleg_creds = options.gss_deleg_creds;
2715+ kex->gss_trust_dns = options.gss_trust_dns;
2716+ kex->gss_client = options.gss_client_identity;
2717+ if (options.gss_server_identity) {
2718+ kex->gss_host = options.gss_server_identity;
2719+ } else {
2720+ kex->gss_host = gss_host;
2721+ }
2722+ }
2723+#endif
2724+
2725 dispatch_run(DISPATCH_BLOCK, &kex->done, active_state);
2726
2727 if (options.use_roaming && !kex->roaming) {
2728@@ -313,6 +369,7 @@ int input_gssapi_token(int type, u_int32_t, void *);
2729 int input_gssapi_hash(int type, u_int32_t, void *);
2730 int input_gssapi_error(int, u_int32_t, void *);
2731 int input_gssapi_errtok(int, u_int32_t, void *);
2732+int userauth_gsskeyex(Authctxt *authctxt);
2733 #endif
2734
2735 void userauth(Authctxt *, char *);
2736@@ -328,6 +385,11 @@ static char *authmethods_get(void);
2737
2738 Authmethod authmethods[] = {
2739 #ifdef GSSAPI
2740+ {"gssapi-keyex",
2741+ userauth_gsskeyex,
2742+ NULL,
2743+ &options.gss_authentication,
2744+ NULL},
2745 {"gssapi-with-mic",
2746 userauth_gssapi,
2747 NULL,
2748@@ -634,19 +696,31 @@ userauth_gssapi(Authctxt *authctxt)
2749 static u_int mech = 0;
2750 OM_uint32 min;
2751 int ok = 0;
2752+ const char *gss_host;
2753+
2754+ if (options.gss_server_identity)
2755+ gss_host = options.gss_server_identity;
2756+ else if (options.gss_trust_dns)
2757+ gss_host = get_canonical_hostname(1);
2758+ else
2759+ gss_host = authctxt->host;
2760
2761 /* Try one GSSAPI method at a time, rather than sending them all at
2762 * once. */
2763
2764 if (gss_supported == NULL)
2765- gss_indicate_mechs(&min, &gss_supported);
2766+ if (GSS_ERROR(gss_indicate_mechs(&min, &gss_supported))) {
2767+ gss_supported = NULL;
2768+ return 0;
2769+ }
2770
2771 /* Check to see if the mechanism is usable before we offer it */
2772 while (mech < gss_supported->count && !ok) {
2773 /* My DER encoding requires length<128 */
2774 if (gss_supported->elements[mech].length < 128 &&
2775 ssh_gssapi_check_mechanism(&gssctxt,
2776- &gss_supported->elements[mech], authctxt->host)) {
2777+ &gss_supported->elements[mech], gss_host,
2778+ options.gss_client_identity)) {
2779 ok = 1; /* Mechanism works */
2780 } else {
2781 mech++;
2782@@ -743,8 +817,8 @@ input_gssapi_response(int type, u_int32_t plen, void *ctxt)
2783 {
2784 Authctxt *authctxt = ctxt;
2785 Gssctxt *gssctxt;
2786- int oidlen;
2787- char *oidv;
2788+ u_int oidlen;
2789+ u_char *oidv;
2790
2791 if (authctxt == NULL)
2792 fatal("input_gssapi_response: no authentication context");
2793@@ -857,6 +931,48 @@ input_gssapi_error(int type, u_int32_t plen, void *ctxt)
2794 free(lang);
2795 return 0;
2796 }
2797+
2798+int
2799+userauth_gsskeyex(Authctxt *authctxt)
2800+{
2801+ Buffer b;
2802+ gss_buffer_desc gssbuf;
2803+ gss_buffer_desc mic = GSS_C_EMPTY_BUFFER;
2804+ OM_uint32 ms;
2805+
2806+ static int attempt = 0;
2807+ if (attempt++ >= 1)
2808+ return (0);
2809+
2810+ if (gss_kex_context == NULL) {
2811+ debug("No valid Key exchange context");
2812+ return (0);
2813+ }
2814+
2815+ ssh_gssapi_buildmic(&b, authctxt->server_user, authctxt->service,
2816+ "gssapi-keyex");
2817+
2818+ gssbuf.value = buffer_ptr(&b);
2819+ gssbuf.length = buffer_len(&b);
2820+
2821+ if (GSS_ERROR(ssh_gssapi_sign(gss_kex_context, &gssbuf, &mic))) {
2822+ buffer_free(&b);
2823+ return (0);
2824+ }
2825+
2826+ packet_start(SSH2_MSG_USERAUTH_REQUEST);
2827+ packet_put_cstring(authctxt->server_user);
2828+ packet_put_cstring(authctxt->service);
2829+ packet_put_cstring(authctxt->method->name);
2830+ packet_put_string(mic.value, mic.length);
2831+ packet_send();
2832+
2833+ buffer_free(&b);
2834+ gss_release_buffer(&ms, &mic);
2835+
2836+ return (1);
2837+}
2838+
2839 #endif /* GSSAPI */
2840
2841 int
2842diff --git a/sshd.c b/sshd.c
2843index e1c767c..cf38bae 100644
2844--- a/sshd.c
2845+++ b/sshd.c
2846@@ -125,6 +125,10 @@
2847 #include "version.h"
2848 #include "ssherr.h"
2849
2850+#ifdef USE_SECURITY_SESSION_API
2851+#include <Security/AuthSession.h>
2852+#endif
2853+
2854 #ifndef O_NOCTTY
2855 #define O_NOCTTY 0
2856 #endif
2857@@ -1815,10 +1819,13 @@ main(int ac, char **av)
2858 logit("Disabling protocol version 1. Could not load host key");
2859 options.protocol &= ~SSH_PROTO_1;
2860 }
2861+#ifndef GSSAPI
2862+ /* The GSSAPI key exchange can run without a host key */
2863 if ((options.protocol & SSH_PROTO_2) && !sensitive_data.have_ssh2_key) {
2864 logit("Disabling protocol version 2. Could not load host key");
2865 options.protocol &= ~SSH_PROTO_2;
2866 }
2867+#endif
2868 if (!(options.protocol & (SSH_PROTO_1|SSH_PROTO_2))) {
2869 logit("sshd: no hostkeys available -- exiting.");
2870 exit(1);
2871@@ -2132,6 +2139,60 @@ main(int ac, char **av)
2872 remote_ip, remote_port,
2873 get_local_ipaddr(sock_in), get_local_port());
2874
2875+#ifdef USE_SECURITY_SESSION_API
2876+ /*
2877+ * Create a new security session for use by the new user login if
2878+ * the current session is the root session or we are not launched
2879+ * by inetd (eg: debugging mode or server mode). We do not
2880+ * necessarily need to create a session if we are launched from
2881+ * inetd because Panther xinetd will create a session for us.
2882+ *
2883+ * The only case where this logic will fail is if there is an
2884+ * inetd running in a non-root session which is not creating
2885+ * new sessions for us. Then all the users will end up in the
2886+ * same session (bad).
2887+ *
2888+ * When the client exits, the session will be destroyed for us
2889+ * automatically.
2890+ *
2891+ * We must create the session before any credentials are stored
2892+ * (including AFS pags, which happens a few lines below).
2893+ */
2894+ {
2895+ OSStatus err = 0;
2896+ SecuritySessionId sid = 0;
2897+ SessionAttributeBits sattrs = 0;
2898+
2899+ err = SessionGetInfo(callerSecuritySession, &sid, &sattrs);
2900+ if (err)
2901+ error("SessionGetInfo() failed with error %.8X",
2902+ (unsigned) err);
2903+ else
2904+ debug("Current Session ID is %.8X / Session Attributes are %.8X",
2905+ (unsigned) sid, (unsigned) sattrs);
2906+
2907+ if (inetd_flag && !(sattrs & sessionIsRoot))
2908+ debug("Running in inetd mode in a non-root session... "
2909+ "assuming inetd created the session for us.");
2910+ else {
2911+ debug("Creating new security session...");
2912+ err = SessionCreate(0, sessionHasTTY | sessionIsRemote);
2913+ if (err)
2914+ error("SessionCreate() failed with error %.8X",
2915+ (unsigned) err);
2916+
2917+ err = SessionGetInfo(callerSecuritySession, &sid,
2918+ &sattrs);
2919+ if (err)
2920+ error("SessionGetInfo() failed with error %.8X",
2921+ (unsigned) err);
2922+ else
2923+ debug("New Session ID is %.8X / Session Attributes are %.8X",
2924+ (unsigned) sid, (unsigned) sattrs);
2925+ }
2926+ }
2927+#endif
2928+
2929 /*
2930 * We don't want to listen forever unless the other side
2931 * successfully authenticates itself. So we set up an alarm which is
2932@@ -2561,6 +2622,48 @@ do_ssh2_kex(void)
2933 myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS] = compat_pkalg_proposal(
2934 list_hostkey_types());
2935
2936+#ifdef GSSAPI
2937+ {
2938+ char *orig;
2939+ char *gss = NULL;
2940+ char *newstr = NULL;
2941+ orig = myproposal[PROPOSAL_KEX_ALGS];
2942+
2943+ /*
2944+ * If we don't have a host key, then there's no point advertising
2945+ * the other key exchange algorithms
2946+ */
2947+
2948+ if (strlen(myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS]) == 0)
2949+ orig = NULL;
2950+
2951+ if (options.gss_keyex)
2952+ gss = ssh_gssapi_server_mechanisms();
2953+ else
2954+ gss = NULL;
2955+
2956+ if (gss && orig)
2957+ xasprintf(&newstr, "%s,%s", gss, orig);
2958+ else if (gss)
2959+ newstr = gss;
2960+ else if (orig)
2961+ newstr = orig;
2962+
2963+ /*
2964+ * If we've got GSSAPI mechanisms, then we've got the 'null' host
2965+ * key alg, but we can't tell people about it unless its the only
2966+ * host key algorithm we support
2967+ */
2968+ if (gss && (strlen(myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS])) == 0)
2969+ myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS] = "null";
2970+
2971+ if (newstr)
2972+ myproposal[PROPOSAL_KEX_ALGS] = newstr;
2973+ else
2974+ fatal("No supported key exchange algorithms");
2975+ }
2976+#endif
2977+
2978 /* start key exchange */
2979 if ((r = kex_setup(active_state, myproposal)) != 0)
2980 fatal("kex_setup: %s", ssh_err(r));
2981@@ -2575,6 +2678,13 @@ do_ssh2_kex(void)
2982 # endif
2983 #endif
2984 kex->kex[KEX_C25519_SHA256] = kexc25519_server;
2985+#ifdef GSSAPI
2986+ if (options.gss_keyex) {
2987+ kex->kex[KEX_GSS_GRP1_SHA1] = kexgss_server;
2988+ kex->kex[KEX_GSS_GRP14_SHA1] = kexgss_server;
2989+ kex->kex[KEX_GSS_GEX_SHA1] = kexgss_server;
2990+ }
2991+#endif
2992 kex->server = 1;
2993 kex->client_version_string=client_version_string;
2994 kex->server_version_string=server_version_string;
2995diff --git a/sshd_config b/sshd_config
2996index c9042ac..a71ad19 100644
2997--- a/sshd_config
2998+++ b/sshd_config
2999@@ -84,6 +84,8 @@ AuthorizedKeysFile .ssh/authorized_keys
3000 # GSSAPI options
3001 #GSSAPIAuthentication no
3002 #GSSAPICleanupCredentials yes
3003+#GSSAPIStrictAcceptorCheck yes
3004+#GSSAPIKeyExchange no
3005
3006 # Set this to 'yes' to enable PAM authentication, account processing,
3007 # and session processing. If this is enabled, PAM authentication will
3008diff --git a/sshd_config.5 b/sshd_config.5
3009index 6dce0c7..0331496 100644
3010--- a/sshd_config.5
3011+++ b/sshd_config.5
3012@@ -564,12 +564,40 @@ Specifies whether user authentication based on GSSAPI is allowed.
3013 The default is
3014 .Dq no .
3015 Note that this option applies to protocol version 2 only.
3016+.It Cm GSSAPIKeyExchange
3017+Specifies whether key exchange based on GSSAPI is allowed. GSSAPI key exchange
3018+doesn't rely on ssh keys to verify host identity.
3019+The default is
3020+.Dq no .
3021+Note that this option applies to protocol version 2 only.
3022 .It Cm GSSAPICleanupCredentials
3023 Specifies whether to automatically destroy the user's credentials cache
3024 on logout.
3025 The default is
3026 .Dq yes .
3027 Note that this option applies to protocol version 2 only.
3028+.It Cm GSSAPIStrictAcceptorCheck
3029+Determines whether to be strict about the identity of the GSSAPI acceptor
3030+a client authenticates against. If
3031+.Dq yes
3032+then the client must authenticate against the
3033+.Pa host
3034+service on the current hostname. If
3035+.Dq no
3036+then the client may authenticate against any service key stored in the
3037+machine's default store. This facility is provided to assist with operation
3038+on multi homed machines.
3039+The default is
3040+.Dq yes .
3041+Note that this option applies only to protocol version 2 GSSAPI connections,
3042+and setting it to
3043+.Dq no
3044+may only work with recent Kerberos GSSAPI libraries.
3045+.It Cm GSSAPIStoreCredentialsOnRekey
3046+Controls whether the user's GSSAPI credentials should be updated following a
3047+successful connection rekeying. This option can be used to accepted renewed
3048+or updated credentials from a compatible client. The default is
3049+.Dq no .
3050 .It Cm HostbasedAcceptedKeyTypes
3051 Specifies the key types that will be accepted for hostbased authentication
3052 as a comma-separated pattern list.
3053diff --git a/sshkey.c b/sshkey.c
3054index 4768790..cd5992e 100644
3055--- a/sshkey.c
3056+++ b/sshkey.c
3057@@ -116,6 +116,7 @@ static const struct keytype keytypes[] = {
3058 { "ssh-dss-cert-v00@openssh.com", "DSA-CERT-V00",
3059 KEY_DSA_CERT_V00, 0, 1 },
3060 #endif /* WITH_OPENSSL */
3061+ { "null", "null", KEY_NULL, 0, 0 },
3062 { NULL, NULL, -1, -1, 0 }
3063 };
3064
3065@@ -204,7 +205,7 @@ key_alg_list(int certs_only, int plain_only)
3066 const struct keytype *kt;
3067
3068 for (kt = keytypes; kt->type != -1; kt++) {
3069- if (kt->name == NULL)
3070+ if (kt->name == NULL || kt->type == KEY_NULL)
3071 continue;
3072 if ((certs_only && !kt->cert) || (plain_only && kt->cert))
3073 continue;
3074diff --git a/sshkey.h b/sshkey.h
3075index 62c1c3e..9314e85 100644
3076--- a/sshkey.h
3077+++ b/sshkey.h
3078@@ -64,6 +64,7 @@ enum sshkey_types {
3079 KEY_ED25519_CERT,
3080 KEY_RSA_CERT_V00,
3081 KEY_DSA_CERT_V00,
3082+ KEY_NULL,
3083 KEY_UNSPEC
3084 };
3085
diff --git a/debian/patches/helpful-wait-terminate.patch b/debian/patches/helpful-wait-terminate.patch
new file mode 100644
index 000000000..6ea643210
--- /dev/null
+++ b/debian/patches/helpful-wait-terminate.patch
@@ -0,0 +1,26 @@
1From 9a440da8025dbc120803ee09c2a7ac8c638d31c2 Mon Sep 17 00:00:00 2001
2From: Matthew Vernon <matthew@debian.org>
3Date: Sun, 9 Feb 2014 16:09:56 +0000
4Subject: Mention ~& when waiting for forwarded connections to terminate
5
6Bug-Debian: http://bugs.debian.org/50308
7Last-Update: 2010-02-27
8
9Patch-Name: helpful-wait-terminate.patch
10---
11 serverloop.c | 2 +-
12 1 file changed, 1 insertion(+), 1 deletion(-)
13
14diff --git a/serverloop.c b/serverloop.c
15index 306ac36..68f0251 100644
16--- a/serverloop.c
17+++ b/serverloop.c
18@@ -687,7 +687,7 @@ server_loop(pid_t pid, int fdin_arg, int fdout_arg, int fderr_arg)
19 if (!channel_still_open())
20 break;
21 if (!waiting_termination) {
22- const char *s = "Waiting for forwarded connections to terminate...\r\n";
23+ const char *s = "Waiting for forwarded connections to terminate... (press ~& to background)\r\n";
24 char *cp;
25 waiting_termination = 1;
26 buffer_append(&stderr_buffer, s, strlen(s));
diff --git a/debian/patches/keepalive-extensions.patch b/debian/patches/keepalive-extensions.patch
new file mode 100644
index 000000000..0adfbd2b5
--- /dev/null
+++ b/debian/patches/keepalive-extensions.patch
@@ -0,0 +1,135 @@
1From 7efad61f1e562f504a5ff3fb0ae90ac05a208e66 Mon Sep 17 00:00:00 2001
2From: Richard Kettlewell <rjk@greenend.org.uk>
3Date: Sun, 9 Feb 2014 16:09:52 +0000
4Subject: Various keepalive extensions
5
6Add compatibility aliases for ProtocolKeepAlives and SetupTimeOut, supported
7in previous versions of Debian's OpenSSH package but since superseded by
8ServerAliveInterval. (We're probably stuck with this bit for
9compatibility.)
10
11In batch mode, default ServerAliveInterval to five minutes.
12
13Adjust documentation to match and to give some more advice on use of
14keepalives.
15
16Author: Ian Jackson <ian@chiark.greenend.org.uk>
17Author: Matthew Vernon <matthew@debian.org>
18Author: Colin Watson <cjwatson@debian.org>
19Last-Update: 2015-08-19
20
21Patch-Name: keepalive-extensions.patch
22---
23 readconf.c | 14 ++++++++++++--
24 ssh_config.5 | 21 +++++++++++++++++++--
25 sshd_config.5 | 3 +++
26 3 files changed, 34 insertions(+), 4 deletions(-)
27
28diff --git a/readconf.c b/readconf.c
29index 278fe15..1d2d596 100644
30--- a/readconf.c
31+++ b/readconf.c
32@@ -159,6 +159,7 @@ typedef enum {
33 oCanonicalizeFallbackLocal, oCanonicalizePermittedCNAMEs,
34 oStreamLocalBindMask, oStreamLocalBindUnlink, oRevokedHostKeys,
35 oFingerprintHash, oUpdateHostkeys, oHostbasedKeyTypes,
36+ oProtocolKeepAlives, oSetupTimeOut,
37 oIgnoredUnknownOption, oDeprecated, oUnsupported
38 } OpCodes;
39
40@@ -288,6 +289,8 @@ static struct {
41 { "updatehostkeys", oUpdateHostkeys },
42 { "hostbasedkeytypes", oHostbasedKeyTypes },
43 { "ignoreunknown", oIgnoreUnknown },
44+ { "protocolkeepalives", oProtocolKeepAlives },
45+ { "setuptimeout", oSetupTimeOut },
46
47 { NULL, oBadOption }
48 };
49@@ -1299,6 +1302,8 @@ parse_int:
50 goto parse_flag;
51
52 case oServerAliveInterval:
53+ case oProtocolKeepAlives: /* Debian-specific compatibility alias */
54+ case oSetupTimeOut: /* Debian-specific compatibility alias */
55 intptr = &options->server_alive_interval;
56 goto parse_time;
57
58@@ -1858,8 +1863,13 @@ fill_default_options(Options * options)
59 options->rekey_interval = 0;
60 if (options->verify_host_key_dns == -1)
61 options->verify_host_key_dns = 0;
62- if (options->server_alive_interval == -1)
63- options->server_alive_interval = 0;
64+ if (options->server_alive_interval == -1) {
65+ /* in batch mode, default is 5mins */
66+ if (options->batch_mode == 1)
67+ options->server_alive_interval = 300;
68+ else
69+ options->server_alive_interval = 0;
70+ }
71 if (options->server_alive_count_max == -1)
72 options->server_alive_count_max = 3;
73 if (options->control_master == -1)
74diff --git a/ssh_config.5 b/ssh_config.5
75index dd35dd8..250c0d1 100644
76--- a/ssh_config.5
77+++ b/ssh_config.5
78@@ -233,8 +233,12 @@ Valid arguments are
79 If set to
80 .Dq yes ,
81 passphrase/password querying will be disabled.
82+In addition, the
83+.Cm ServerAliveInterval
84+option will be set to 300 seconds by default.
85 This option is useful in scripts and other batch jobs where no user
86-is present to supply the password.
87+is present to supply the password,
88+and where it is desirable to detect a broken network swiftly.
89 The argument must be
90 .Dq yes
91 or
92@@ -1420,8 +1424,15 @@ from the server,
93 will send a message through the encrypted
94 channel to request a response from the server.
95 The default
96-is 0, indicating that these messages will not be sent to the server.
97+is 0, indicating that these messages will not be sent to the server,
98+or 300 if the
99+.Cm BatchMode
100+option is set.
101 This option applies to protocol version 2 only.
102+.Cm ProtocolKeepAlives
103+and
104+.Cm SetupTimeOut
105+are Debian-specific compatibility aliases for this option.
106 .It Cm StreamLocalBindMask
107 Sets the octal file creation mode mask
108 .Pq umask
109@@ -1487,6 +1498,12 @@ Specifies whether the system should send TCP keepalive messages to the
110 other side.
111 If they are sent, death of the connection or crash of one
112 of the machines will be properly noticed.
113+This option only uses TCP keepalives (as opposed to using ssh level
114+keepalives), so takes a long time to notice when the connection dies.
115+As such, you probably want
116+the
117+.Cm ServerAliveInterval
118+option as well.
119 However, this means that
120 connections will die if the route is down temporarily, and some people
121 find it annoying.
122diff --git a/sshd_config.5 b/sshd_config.5
123index 0331496..d14576e 100644
124--- a/sshd_config.5
125+++ b/sshd_config.5
126@@ -1392,6 +1392,9 @@ This avoids infinitely hanging sessions.
127 .Pp
128 To disable TCP keepalive messages, the value should be set to
129 .Dq no .
130+.Pp
131+This option was formerly called
132+.Cm KeepAlive .
133 .It Cm TrustedUserCAKeys
134 Specifies a file containing public keys of certificate authorities that are
135 trusted to sign user certificates for authentication.
diff --git a/debian/patches/lintian-symlink-pickiness.patch b/debian/patches/lintian-symlink-pickiness.patch
new file mode 100644
index 000000000..7aa035726
--- /dev/null
+++ b/debian/patches/lintian-symlink-pickiness.patch
@@ -0,0 +1,32 @@
1From 90fc009420a03c598d6f003df5466191ab4d12b2 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:08 +0000
4Subject: Fix picky lintian errors about slogin symlinks
5
6Apparently this breaks some SVR4 packaging systems, so upstream can't win
7either way and opted to keep the status quo. We need this patch anyway.
8
9Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1728
10Last-Update: 2013-09-14
11
12Patch-Name: lintian-symlink-pickiness.patch
13---
14 Makefile.in | 4 ++--
15 1 file changed, 2 insertions(+), 2 deletions(-)
16
17diff --git a/Makefile.in b/Makefile.in
18index 37cb023..f52f903 100644
19--- a/Makefile.in
20+++ b/Makefile.in
21@@ -331,9 +331,9 @@ install-files:
22 $(INSTALL) -m 644 ssh-keysign.8.out $(DESTDIR)$(mandir)/$(mansubdir)8/ssh-keysign.8
23 $(INSTALL) -m 644 ssh-pkcs11-helper.8.out $(DESTDIR)$(mandir)/$(mansubdir)8/ssh-pkcs11-helper.8
24 -rm -f $(DESTDIR)$(bindir)/slogin
25- ln -s ./ssh$(EXEEXT) $(DESTDIR)$(bindir)/slogin
26+ ln -s ssh$(EXEEXT) $(DESTDIR)$(bindir)/slogin
27 -rm -f $(DESTDIR)$(mandir)/$(mansubdir)1/slogin.1
28- ln -s ./ssh.1 $(DESTDIR)$(mandir)/$(mansubdir)1/slogin.1
29+ ln -s ssh.1 $(DESTDIR)$(mandir)/$(mansubdir)1/slogin.1
30
31 install-sysconf:
32 if [ ! -d $(DESTDIR)$(sysconfdir) ]; then \
diff --git a/debian/patches/mention-ssh-keygen-on-keychange.patch b/debian/patches/mention-ssh-keygen-on-keychange.patch
new file mode 100644
index 000000000..127ed9f9e
--- /dev/null
+++ b/debian/patches/mention-ssh-keygen-on-keychange.patch
@@ -0,0 +1,41 @@
1From aedcf9cb37f512b929ce895ba1fccc9ca39166b0 Mon Sep 17 00:00:00 2001
2From: Scott Moser <smoser@ubuntu.com>
3Date: Sun, 9 Feb 2014 16:10:03 +0000
4Subject: Mention ssh-keygen in ssh fingerprint changed warning
5
6Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1843
7Bug-Ubuntu: https://bugs.launchpad.net/bugs/686607
8Last-Update: 2013-09-14
9
10Patch-Name: mention-ssh-keygen-on-keychange.patch
11---
12 sshconnect.c | 7 ++++++-
13 1 file changed, 6 insertions(+), 1 deletion(-)
14
15diff --git a/sshconnect.c b/sshconnect.c
16index 0073c6e..6065dff 100644
17--- a/sshconnect.c
18+++ b/sshconnect.c
19@@ -1078,9 +1078,12 @@ check_host_key(char *hostname, struct sockaddr *hostaddr, u_short port,
20 error("%s. This could either mean that", key_msg);
21 error("DNS SPOOFING is happening or the IP address for the host");
22 error("and its host key have changed at the same time.");
23- if (ip_status != HOST_NEW)
24+ if (ip_status != HOST_NEW) {
25 error("Offending key for IP in %s:%lu",
26 ip_found->file, ip_found->line);
27+ error(" remove with: ssh-keygen -f \"%s\" -R %s",
28+ ip_found->file, ip);
29+ }
30 }
31 /* The host key has changed. */
32 warn_changed_key(host_key);
33@@ -1088,6 +1091,8 @@ check_host_key(char *hostname, struct sockaddr *hostaddr, u_short port,
34 user_hostfiles[0]);
35 error("Offending %s key in %s:%lu", key_type(host_found->key),
36 host_found->file, host_found->line);
37+ error(" remove with: ssh-keygen -f \"%s\" -R %s",
38+ host_found->file, host);
39
40 /*
41 * If strict host key checking is in use, the user will have
diff --git a/debian/patches/no-openssl-version-status.patch b/debian/patches/no-openssl-version-status.patch
new file mode 100644
index 000000000..f4d8bca66
--- /dev/null
+++ b/debian/patches/no-openssl-version-status.patch
@@ -0,0 +1,62 @@
1From 6b85aa42144010401906754b98f9876651669163 Mon Sep 17 00:00:00 2001
2From: Kurt Roeckx <kurt@roeckx.be>
3Date: Sun, 9 Feb 2014 16:10:14 +0000
4Subject: Don't check the status field of the OpenSSL version
5
6There is no reason to check the version of OpenSSL (in Debian). If it's
7not compatible the soname will change. OpenSSH seems to want to do a
8check for the soname based on the version number, but wants to keep the
9status of the release the same. Remove that check on the status since
10it doesn't tell you anything about how compatible that version is.
11
12Author: Colin Watson <cjwatson@debian.org>
13Bug-Debian: https://bugs.debian.org/93581
14Bug-Debian: https://bugs.debian.org/664383
15Bug-Debian: https://bugs.debian.org/732940
16Forwarded: not-needed
17Last-Update: 2014-10-07
18
19Patch-Name: no-openssl-version-status.patch
20---
21 openbsd-compat/openssl-compat.c | 6 +++---
22 openbsd-compat/regress/opensslvertest.c | 1 +
23 2 files changed, 4 insertions(+), 3 deletions(-)
24
25diff --git a/openbsd-compat/openssl-compat.c b/openbsd-compat/openssl-compat.c
26index 63a660c..3f62403 100644
27--- a/openbsd-compat/openssl-compat.c
28+++ b/openbsd-compat/openssl-compat.c
29@@ -36,7 +36,7 @@
30 /*
31 * OpenSSL version numbers: MNNFFPPS: major minor fix patch status
32 * We match major, minor, fix and status (not patch) for <1.0.0.
33- * After that, we acceptable compatible fix versions (so we
34+ * After that, we accept compatible fix and status versions (so we
35 * allow 1.0.1 to work with 1.0.0). Going backwards is only allowed
36 * within a patch series.
37 */
38@@ -57,10 +57,10 @@ ssh_compatible_openssl(long headerver, long libver)
39 }
40
41 /*
42- * For versions >= 1.0.0, major,minor,status must match and library
43+ * For versions >= 1.0.0, major,minor must match and library
44 * fix version must be equal to or newer than the header.
45 */
46- mask = 0xfff0000fL; /* major,minor,status */
47+ mask = 0xfff00000L; /* major,minor */
48 hfix = (headerver & 0x000ff000) >> 12;
49 lfix = (libver & 0x000ff000) >> 12;
50 if ( (headerver & mask) == (libver & mask) && lfix >= hfix)
51diff --git a/openbsd-compat/regress/opensslvertest.c b/openbsd-compat/regress/opensslvertest.c
52index 5d019b5..5847487 100644
53--- a/openbsd-compat/regress/opensslvertest.c
54+++ b/openbsd-compat/regress/opensslvertest.c
55@@ -35,6 +35,7 @@ struct version_test {
56
57 /* built with 1.0.1b release headers */
58 { 0x1000101fL, 0x1000101fL, 1},/* exact match */
59+ { 0x1000101fL, 0x10001010L, 1}, /* different status: ok */
60 { 0x1000101fL, 0x1000102fL, 1}, /* newer library patch version: ok */
61 { 0x1000101fL, 0x1000100fL, 1}, /* older library patch version: ok */
62 { 0x1000101fL, 0x1000201fL, 1}, /* newer library fix version: ok */
diff --git a/debian/patches/openbsd-docs.patch b/debian/patches/openbsd-docs.patch
new file mode 100644
index 000000000..f5b96f4a1
--- /dev/null
+++ b/debian/patches/openbsd-docs.patch
@@ -0,0 +1,148 @@
1From 96c2797aaa79d687e75dc56f40f7102131d87fb1 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:09 +0000
4Subject: Adjust various OpenBSD-specific references in manual pages
5
6No single bug reference for this patch, but history includes:
7 http://bugs.debian.org/154434 (login.conf(5))
8 http://bugs.debian.org/513417 (/etc/rc)
9 http://bugs.debian.org/530692 (ssl(8))
10 https://bugs.launchpad.net/bugs/456660 (ssl(8))
11
12Forwarded: not-needed
13Last-Update: 2014-10-07
14
15Patch-Name: openbsd-docs.patch
16---
17 moduli.5 | 4 ++--
18 ssh-keygen.1 | 12 ++++--------
19 ssh.1 | 4 ++++
20 sshd.8 | 5 ++---
21 sshd_config.5 | 3 +--
22 5 files changed, 13 insertions(+), 15 deletions(-)
23
24diff --git a/moduli.5 b/moduli.5
25index ef0de08..149846c 100644
26--- a/moduli.5
27+++ b/moduli.5
28@@ -21,7 +21,7 @@
29 .Nd Diffie-Hellman moduli
30 .Sh DESCRIPTION
31 The
32-.Pa /etc/moduli
33+.Pa /etc/ssh/moduli
34 file contains prime numbers and generators for use by
35 .Xr sshd 8
36 in the Diffie-Hellman Group Exchange key exchange method.
37@@ -110,7 +110,7 @@ first estimates the size of the modulus required to produce enough
38 Diffie-Hellman output to sufficiently key the selected symmetric cipher.
39 .Xr sshd 8
40 then randomly selects a modulus from
41-.Fa /etc/moduli
42+.Fa /etc/ssh/moduli
43 that best meets the size requirement.
44 .Sh SEE ALSO
45 .Xr ssh-keygen 1 ,
46diff --git a/ssh-keygen.1 b/ssh-keygen.1
47index 9b93666..19bed1e 100644
48--- a/ssh-keygen.1
49+++ b/ssh-keygen.1
50@@ -174,9 +174,7 @@ key in
51 .Pa ~/.ssh/id_ed25519
52 or
53 .Pa ~/.ssh/id_rsa .
54-Additionally, the system administrator may use this to generate host keys,
55-as seen in
56-.Pa /etc/rc .
57+Additionally, the system administrator may use this to generate host keys.
58 .Pp
59 Normally this program generates the key and asks for a file in which
60 to store the private key.
61@@ -223,9 +221,7 @@ For each of the key types (rsa1, rsa, dsa, ecdsa and ed25519)
62 for which host keys
63 do not exist, generate the host keys with the default key file path,
64 an empty passphrase, default bits for the key type, and default comment.
65-This is used by
66-.Pa /etc/rc
67-to generate new host keys.
68+This is used by system administration scripts to generate new host keys.
69 .It Fl a Ar rounds
70 When saving a new-format private key (i.e. an ed25519 key or any SSH protocol
71 2 key when the
72@@ -638,7 +634,7 @@ option.
73 Valid generator values are 2, 3, and 5.
74 .Pp
75 Screened DH groups may be installed in
76-.Pa /etc/moduli .
77+.Pa /etc/ssh/moduli .
78 It is important that this file contains moduli of a range of bit lengths and
79 that both ends of a connection share common moduli.
80 .Sh CERTIFICATES
81@@ -837,7 +833,7 @@ on all machines
82 where the user wishes to log in using public key authentication.
83 There is no need to keep the contents of this file secret.
84 .Pp
85-.It Pa /etc/moduli
86+.It Pa /etc/ssh/moduli
87 Contains Diffie-Hellman groups used for DH-GEX.
88 The file format is described in
89 .Xr moduli 5 .
90diff --git a/ssh.1 b/ssh.1
91index 53c711a..04de6cf 100644
92--- a/ssh.1
93+++ b/ssh.1
94@@ -766,6 +766,10 @@ Protocol 1 is restricted to using only RSA keys,
95 but protocol 2 may use any.
96 The HISTORY section of
97 .Xr ssl 8
98+(on non-OpenBSD systems, see
99+.nh
100+http://www.openbsd.org/cgi\-bin/man.cgi?query=ssl&sektion=8#HISTORY)
101+.hy
102 contains a brief discussion of the DSA and RSA algorithms.
103 .Pp
104 The file
105diff --git a/sshd.8 b/sshd.8
106index fc2154c..8dba6cf 100644
107--- a/sshd.8
108+++ b/sshd.8
109@@ -67,7 +67,7 @@ over an insecure network.
110 .Nm
111 listens for connections from clients.
112 It is normally started at boot from
113-.Pa /etc/rc .
114+.Pa /etc/init.d/ssh .
115 It forks a new
116 daemon for each incoming connection.
117 The forked daemons handle
118@@ -862,7 +862,7 @@ This file is for host-based authentication (see
119 .Xr ssh 1 ) .
120 It should only be writable by root.
121 .Pp
122-.It Pa /etc/moduli
123+.It Pa /etc/ssh/moduli
124 Contains Diffie-Hellman groups used for the "Diffie-Hellman Group Exchange".
125 The file format is described in
126 .Xr moduli 5 .
127@@ -961,7 +961,6 @@ The content of this file is not sensitive; it can be world-readable.
128 .Xr ssh-keyscan 1 ,
129 .Xr chroot 2 ,
130 .Xr hosts_access 5 ,
131-.Xr login.conf 5 ,
132 .Xr moduli 5 ,
133 .Xr sshd_config 5 ,
134 .Xr inetd 8 ,
135diff --git a/sshd_config.5 b/sshd_config.5
136index ec58635..453d741 100644
137--- a/sshd_config.5
138+++ b/sshd_config.5
139@@ -322,8 +322,7 @@ This option is only available for protocol version 2.
140 By default, no banner is displayed.
141 .It Cm ChallengeResponseAuthentication
142 Specifies whether challenge-response authentication is allowed (e.g. via
143-PAM or through authentication styles supported in
144-.Xr login.conf 5 )
145+PAM).
146 The default is
147 .Dq yes .
148 .It Cm ChrootDirectory
diff --git a/debian/patches/package-versioning.patch b/debian/patches/package-versioning.patch
new file mode 100644
index 000000000..11674a915
--- /dev/null
+++ b/debian/patches/package-versioning.patch
@@ -0,0 +1,65 @@
1From 9f6aded97671ee8b9164f0524b3ac622d827dcde Mon Sep 17 00:00:00 2001
2From: Matthew Vernon <matthew@debian.org>
3Date: Sun, 9 Feb 2014 16:10:05 +0000
4Subject: Include the Debian version in our identification
5
6This makes it easier to audit networks for versions patched against security
7vulnerabilities. It has little detrimental effect, as attackers will
8generally just try attacks rather than bothering to scan for
9vulnerable-looking version strings. (However, see debian-banner.patch.)
10
11Forwarded: not-needed
12Last-Update: 2013-09-14
13
14Patch-Name: package-versioning.patch
15---
16 sshconnect.c | 4 ++--
17 sshd.c | 2 +-
18 version.h | 7 ++++++-
19 3 files changed, 9 insertions(+), 4 deletions(-)
20
21diff --git a/sshconnect.c b/sshconnect.c
22index 6065dff..a6c9e20 100644
23--- a/sshconnect.c
24+++ b/sshconnect.c
25@@ -524,10 +524,10 @@ send_client_banner(int connection_out, int minor1)
26 /* Send our own protocol version identification. */
27 if (compat20) {
28 xasprintf(&client_version_string, "SSH-%d.%d-%.100s\r\n",
29- PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION);
30+ PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_RELEASE);
31 } else {
32 xasprintf(&client_version_string, "SSH-%d.%d-%.100s\n",
33- PROTOCOL_MAJOR_1, minor1, SSH_VERSION);
34+ PROTOCOL_MAJOR_1, minor1, SSH_RELEASE);
35 }
36 if (roaming_atomicio(vwrite, connection_out, client_version_string,
37 strlen(client_version_string)) != strlen(client_version_string))
38diff --git a/sshd.c b/sshd.c
39index 3b4e97c..c362209 100644
40--- a/sshd.c
41+++ b/sshd.c
42@@ -442,7 +442,7 @@ sshd_exchange_identification(int sock_in, int sock_out)
43 }
44
45 xasprintf(&server_version_string, "SSH-%d.%d-%.100s%s%s%s",
46- major, minor, SSH_VERSION,
47+ major, minor, SSH_RELEASE,
48 *options.version_addendum == '\0' ? "" : " ",
49 options.version_addendum, newline);
50
51diff --git a/version.h b/version.h
52index dfe3ee9..94569ac 100644
53--- a/version.h
54+++ b/version.h
55@@ -3,4 +3,9 @@
56 #define SSH_VERSION "OpenSSH_6.8"
57
58 #define SSH_PORTABLE "p1"
59-#define SSH_RELEASE SSH_VERSION SSH_PORTABLE
60+#define SSH_RELEASE_MINIMUM SSH_VERSION SSH_PORTABLE
61+#ifdef SSH_EXTRAVERSION
62+#define SSH_RELEASE SSH_RELEASE_MINIMUM " " SSH_EXTRAVERSION
63+#else
64+#define SSH_RELEASE SSH_RELEASE_MINIMUM
65+#endif
diff --git a/debian/patches/quieter-signals.patch b/debian/patches/quieter-signals.patch
new file mode 100644
index 000000000..ff16b9850
--- /dev/null
+++ b/debian/patches/quieter-signals.patch
@@ -0,0 +1,40 @@
1From 34592a434851697537873eed1eb83ba0a640c5c8 Mon Sep 17 00:00:00 2001
2From: Peter Samuelson <peter@p12n.org>
3Date: Sun, 9 Feb 2014 16:09:55 +0000
4Subject: Reduce severity of "Killed by signal %d"
5
6This produces irritating messages when using ProxyCommand or other programs
7that use ssh under the covers (e.g. Subversion). These messages are more
8normally printed by the calling program, such as the shell.
9
10According to the upstream bug, the right way to avoid this is to use the -q
11option, so we may drop this patch after further investigation into whether
12any software in Debian is still relying on it.
13
14Author: Colin Watson <cjwatson@debian.org>
15Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1118
16Bug-Debian: http://bugs.debian.org/313371
17Last-Update: 2013-09-14
18
19Patch-Name: quieter-signals.patch
20---
21 clientloop.c | 6 ++++--
22 1 file changed, 4 insertions(+), 2 deletions(-)
23
24diff --git a/clientloop.c b/clientloop.c
25index 156a196..45cef88 100644
26--- a/clientloop.c
27+++ b/clientloop.c
28@@ -1707,8 +1707,10 @@ client_loop(int have_pty, int escape_char_arg, int ssh2_chan_id)
29 exit_status = 0;
30 }
31
32- if (received_signal)
33- fatal("Killed by signal %d.", (int) received_signal);
34+ if (received_signal) {
35+ debug("Killed by signal %d.", (int) received_signal);
36+ cleanup_exit((int) received_signal + 128);
37+ }
38
39 /*
40 * In interactive mode (with pseudo tty) display a message indicating
diff --git a/debian/patches/restore-tcp-wrappers.patch b/debian/patches/restore-tcp-wrappers.patch
new file mode 100644
index 000000000..c9da26f7d
--- /dev/null
+++ b/debian/patches/restore-tcp-wrappers.patch
@@ -0,0 +1,172 @@
1From 7df209aed8ded9a6cab34e704576998786bdc890 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Tue, 7 Oct 2014 13:22:41 +0100
4Subject: Restore TCP wrappers support
5
6Support for TCP wrappers was dropped in OpenSSH 6.7. See this message
7and thread:
8
9 https://lists.mindrot.org/pipermail/openssh-unix-dev/2014-April/032497.html
10
11It is true that this reduces preauth attack surface in sshd. On the
12other hand, this support seems to be quite widely used, and abruptly
13dropping it (from the perspective of users who don't read
14openssh-unix-dev) could easily cause more serious problems in practice.
15
16It's not entirely clear what the right long-term answer for Debian is,
17but it at least probably doesn't involve dropping this feature shortly
18before a freeze.
19
20Forwarded: not-needed
21Last-Update: 2014-10-07
22
23Patch-Name: restore-tcp-wrappers.patch
24---
25 configure.ac | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
26 sshd.8 | 7 +++++++
27 sshd.c | 25 +++++++++++++++++++++++++
28 3 files changed, 89 insertions(+)
29
30diff --git a/configure.ac b/configure.ac
31index 216a9fd..5f606ea 100644
32--- a/configure.ac
33+++ b/configure.ac
34@@ -1440,6 +1440,62 @@ AC_ARG_WITH([skey],
35 ]
36 )
37
38+# Check whether user wants TCP wrappers support
39+TCPW_MSG="no"
40+AC_ARG_WITH([tcp-wrappers],
41+ [ --with-tcp-wrappers[[=PATH]] Enable tcpwrappers support (optionally in PATH)],
42+ [
43+ if test "x$withval" != "xno" ; then
44+ saved_LIBS="$LIBS"
45+ saved_LDFLAGS="$LDFLAGS"
46+ saved_CPPFLAGS="$CPPFLAGS"
47+ if test -n "${withval}" && \
48+ test "x${withval}" != "xyes"; then
49+ if test -d "${withval}/lib"; then
50+ if test -n "${need_dash_r}"; then
51+ LDFLAGS="-L${withval}/lib -R${withval}/lib ${LDFLAGS}"
52+ else
53+ LDFLAGS="-L${withval}/lib ${LDFLAGS}"
54+ fi
55+ else
56+ if test -n "${need_dash_r}"; then
57+ LDFLAGS="-L${withval} -R${withval} ${LDFLAGS}"
58+ else
59+ LDFLAGS="-L${withval} ${LDFLAGS}"
60+ fi
61+ fi
62+ if test -d "${withval}/include"; then
63+ CPPFLAGS="-I${withval}/include ${CPPFLAGS}"
64+ else
65+ CPPFLAGS="-I${withval} ${CPPFLAGS}"
66+ fi
67+ fi
68+ LIBS="-lwrap $LIBS"
69+ AC_MSG_CHECKING([for libwrap])
70+ AC_LINK_IFELSE([AC_LANG_PROGRAM([[
71+#include <sys/types.h>
72+#include <sys/socket.h>
73+#include <netinet/in.h>
74+#include <tcpd.h>
75+int deny_severity = 0, allow_severity = 0;
76+ ]], [[
77+ hosts_access(0);
78+ ]])], [
79+ AC_MSG_RESULT([yes])
80+ AC_DEFINE([LIBWRAP], [1],
81+ [Define if you want
82+ TCP Wrappers support])
83+ SSHDLIBS="$SSHDLIBS -lwrap"
84+ TCPW_MSG="yes"
85+ ], [
86+ AC_MSG_ERROR([*** libwrap missing])
87+
88+ ])
89+ LIBS="$saved_LIBS"
90+ fi
91+ ]
92+)
93+
94 # Check whether user wants to use ldns
95 LDNS_MSG="no"
96 AC_ARG_WITH(ldns,
97@@ -4920,6 +4976,7 @@ echo " KerberosV support: $KRB5_MSG"
98 echo " SELinux support: $SELINUX_MSG"
99 echo " Smartcard support: $SCARD_MSG"
100 echo " S/KEY support: $SKEY_MSG"
101+echo " TCP Wrappers support: $TCPW_MSG"
102 echo " MD5 password support: $MD5_MSG"
103 echo " libedit support: $LIBEDIT_MSG"
104 echo " Solaris process contract support: $SPC_MSG"
105diff --git a/sshd.8 b/sshd.8
106index 3c53f7c..fc2154c 100644
107--- a/sshd.8
108+++ b/sshd.8
109@@ -851,6 +851,12 @@ the user's home directory becomes accessible.
110 This file should be writable only by the user, and need not be
111 readable by anyone else.
112 .Pp
113+.It Pa /etc/hosts.allow
114+.It Pa /etc/hosts.deny
115+Access controls that should be enforced by tcp-wrappers are defined here.
116+Further details are described in
117+.Xr hosts_access 5 .
118+.Pp
119 .It Pa /etc/hosts.equiv
120 This file is for host-based authentication (see
121 .Xr ssh 1 ) .
122@@ -954,6 +960,7 @@ The content of this file is not sensitive; it can be world-readable.
123 .Xr ssh-keygen 1 ,
124 .Xr ssh-keyscan 1 ,
125 .Xr chroot 2 ,
126+.Xr hosts_access 5 ,
127 .Xr login.conf 5 ,
128 .Xr moduli 5 ,
129 .Xr sshd_config 5 ,
130diff --git a/sshd.c b/sshd.c
131index cf38bae..9cbe8c4 100644
132--- a/sshd.c
133+++ b/sshd.c
134@@ -129,6 +129,13 @@
135 #include <Security/AuthSession.h>
136 #endif
137
138+#ifdef LIBWRAP
139+#include <tcpd.h>
140+#include <syslog.h>
141+int allow_severity;
142+int deny_severity;
143+#endif /* LIBWRAP */
144+
145 #ifndef O_NOCTTY
146 #define O_NOCTTY 0
147 #endif
148@@ -2133,6 +2140,24 @@ main(int ac, char **av)
149 #ifdef SSH_AUDIT_EVENTS
150 audit_connection_from(remote_ip, remote_port);
151 #endif
152+#ifdef LIBWRAP
153+ allow_severity = options.log_facility|LOG_INFO;
154+ deny_severity = options.log_facility|LOG_WARNING;
155+ /* Check whether logins are denied from this host. */
156+ if (packet_connection_is_on_socket()) {
157+ struct request_info req;
158+
159+ request_init(&req, RQ_DAEMON, __progname, RQ_FILE, sock_in, 0);
160+ fromhost(&req);
161+
162+ if (!hosts_access(&req)) {
163+ debug("Connection refused by tcp wrapper");
164+ refuse(&req);
165+ /* NOTREACHED */
166+ fatal("libwrap refuse returns");
167+ }
168+ }
169+#endif /* LIBWRAP */
170
171 /* Log the connection. */
172 verbose("Connection from %s port %d on %s port %d",
diff --git a/debian/patches/scp-quoting.patch b/debian/patches/scp-quoting.patch
new file mode 100644
index 000000000..52e709112
--- /dev/null
+++ b/debian/patches/scp-quoting.patch
@@ -0,0 +1,41 @@
1From 4f55e60d2296feba17b473b2146a75debe29993a Mon Sep 17 00:00:00 2001
2From: =?UTF-8?q?Nicolas=20Valc=C3=A1rcel?= <nvalcarcel@ubuntu.com>
3Date: Sun, 9 Feb 2014 16:09:59 +0000
4Subject: Adjust scp quoting in verbose mode
5
6Tweak scp's reporting of filenames in verbose mode to be a bit less
7confusing with spaces.
8
9This should be revised to mimic real shell quoting.
10
11Bug-Ubuntu: https://bugs.launchpad.net/bugs/89945
12Last-Update: 2010-02-27
13
14Patch-Name: scp-quoting.patch
15---
16 scp.c | 12 ++++++++++--
17 1 file changed, 10 insertions(+), 2 deletions(-)
18
19diff --git a/scp.c b/scp.c
20index 887b014..afa4a2f 100644
21--- a/scp.c
22+++ b/scp.c
23@@ -190,8 +190,16 @@ do_local_cmd(arglist *a)
24
25 if (verbose_mode) {
26 fprintf(stderr, "Executing:");
27- for (i = 0; i < a->num; i++)
28- fprintf(stderr, " %s", a->list[i]);
29+ for (i = 0; i < a->num; i++) {
30+ if (i == 0)
31+ fprintf(stderr, " %s", a->list[i]);
32+ else
33+ /*
34+ * TODO: misbehaves if a->list[i] contains a
35+ * single quote
36+ */
37+ fprintf(stderr, " '%s'", a->list[i]);
38+ }
39 fprintf(stderr, "\n");
40 }
41 if ((pid = fork()) == -1)
diff --git a/debian/patches/selinux-role.patch b/debian/patches/selinux-role.patch
new file mode 100644
index 000000000..da53671e3
--- /dev/null
+++ b/debian/patches/selinux-role.patch
@@ -0,0 +1,504 @@
1From b9e97e15e25e4c836cb550213e3ee59b19096f9d Mon Sep 17 00:00:00 2001
2From: Manoj Srivastava <srivasta@debian.org>
3Date: Sun, 9 Feb 2014 16:09:49 +0000
4Subject: Handle SELinux authorisation roles
5
6Rejected upstream due to discomfort with magic usernames; a better approach
7will need an SSH protocol change. In the meantime, this came from Debian's
8SELinux maintainer, so we'll keep it until we have something better.
9
10Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1641
11Bug-Debian: http://bugs.debian.org/394795
12Last-Update: 2015-08-19
13
14Patch-Name: selinux-role.patch
15---
16 auth.h | 1 +
17 auth1.c | 8 +++++++-
18 auth2.c | 10 ++++++++--
19 monitor.c | 32 +++++++++++++++++++++++++++++---
20 monitor.h | 2 ++
21 monitor_wrap.c | 22 ++++++++++++++++++++--
22 monitor_wrap.h | 3 ++-
23 openbsd-compat/port-linux.c | 27 ++++++++++++++++++++-------
24 openbsd-compat/port-linux.h | 4 ++--
25 platform.c | 4 ++--
26 platform.h | 2 +-
27 session.c | 10 +++++-----
28 session.h | 2 +-
29 sshd.c | 2 +-
30 sshpty.c | 4 ++--
31 sshpty.h | 2 +-
32 16 files changed, 104 insertions(+), 31 deletions(-)
33
34diff --git a/auth.h b/auth.h
35index db86037..4985cd8 100644
36--- a/auth.h
37+++ b/auth.h
38@@ -62,6 +62,7 @@ struct Authctxt {
39 char *service;
40 struct passwd *pw; /* set if 'valid' */
41 char *style;
42+ char *role;
43 void *kbdintctxt;
44 char *info; /* Extra info for next auth_log */
45 #ifdef BSD_AUTH
46diff --git a/auth1.c b/auth1.c
47index 5073c49..dd00648 100644
48--- a/auth1.c
49+++ b/auth1.c
50@@ -383,7 +383,7 @@ void
51 do_authentication(Authctxt *authctxt)
52 {
53 u_int ulen;
54- char *user, *style = NULL;
55+ char *user, *style = NULL, *role = NULL;
56
57 /* Get the name of the user that we wish to log in as. */
58 packet_read_expect(SSH_CMSG_USER);
59@@ -392,11 +392,17 @@ do_authentication(Authctxt *authctxt)
60 user = packet_get_cstring(&ulen);
61 packet_check_eom();
62
63+ if ((role = strchr(user, '/')) != NULL)
64+ *role++ = '\0';
65+
66 if ((style = strchr(user, ':')) != NULL)
67 *style++ = '\0';
68+ else if (role && (style = strchr(role, ':')) != NULL)
69+ *style++ = '\0';
70
71 authctxt->user = user;
72 authctxt->style = style;
73+ authctxt->role = role;
74
75 /* Verify that the user is a valid user. */
76 if ((authctxt->pw = PRIVSEP(getpwnamallow(user))) != NULL)
77diff --git a/auth2.c b/auth2.c
78index 3f49bdc..6eb3cc7 100644
79--- a/auth2.c
80+++ b/auth2.c
81@@ -216,7 +216,7 @@ input_userauth_request(int type, u_int32_t seq, void *ctxt)
82 {
83 Authctxt *authctxt = ctxt;
84 Authmethod *m = NULL;
85- char *user, *service, *method, *style = NULL;
86+ char *user, *service, *method, *style = NULL, *role = NULL;
87 int authenticated = 0;
88
89 if (authctxt == NULL)
90@@ -228,8 +228,13 @@ input_userauth_request(int type, u_int32_t seq, void *ctxt)
91 debug("userauth-request for user %s service %s method %s", user, service, method);
92 debug("attempt %d failures %d", authctxt->attempt, authctxt->failures);
93
94+ if ((role = strchr(user, '/')) != NULL)
95+ *role++ = 0;
96+
97 if ((style = strchr(user, ':')) != NULL)
98 *style++ = 0;
99+ else if (role && (style = strchr(role, ':')) != NULL)
100+ *style++ = '\0';
101
102 if (authctxt->attempt++ == 0) {
103 /* setup auth context */
104@@ -253,8 +258,9 @@ input_userauth_request(int type, u_int32_t seq, void *ctxt)
105 use_privsep ? " [net]" : "");
106 authctxt->service = xstrdup(service);
107 authctxt->style = style ? xstrdup(style) : NULL;
108+ authctxt->role = role ? xstrdup(role) : NULL;
109 if (use_privsep)
110- mm_inform_authserv(service, style);
111+ mm_inform_authserv(service, style, role);
112 userauth_banner();
113 if (auth2_setup_methods_lists(authctxt) != 0)
114 packet_disconnect("no authentication methods enabled");
115diff --git a/monitor.c b/monitor.c
116index a2027e5..6ff05e4 100644
117--- a/monitor.c
118+++ b/monitor.c
119@@ -127,6 +127,7 @@ int mm_answer_sign(int, Buffer *);
120 int mm_answer_pwnamallow(int, Buffer *);
121 int mm_answer_auth2_read_banner(int, Buffer *);
122 int mm_answer_authserv(int, Buffer *);
123+int mm_answer_authrole(int, Buffer *);
124 int mm_answer_authpassword(int, Buffer *);
125 int mm_answer_bsdauthquery(int, Buffer *);
126 int mm_answer_bsdauthrespond(int, Buffer *);
127@@ -208,6 +209,7 @@ struct mon_table mon_dispatch_proto20[] = {
128 {MONITOR_REQ_SIGN, MON_ONCE, mm_answer_sign},
129 {MONITOR_REQ_PWNAM, MON_ONCE, mm_answer_pwnamallow},
130 {MONITOR_REQ_AUTHSERV, MON_ONCE, mm_answer_authserv},
131+ {MONITOR_REQ_AUTHROLE, MON_ONCE, mm_answer_authrole},
132 {MONITOR_REQ_AUTH2_READ_BANNER, MON_ONCE, mm_answer_auth2_read_banner},
133 {MONITOR_REQ_AUTHPASSWORD, MON_AUTH, mm_answer_authpassword},
134 #ifdef USE_PAM
135@@ -879,6 +881,7 @@ mm_answer_pwnamallow(int sock, Buffer *m)
136 else {
137 /* Allow service/style information on the auth context */
138 monitor_permit(mon_dispatch, MONITOR_REQ_AUTHSERV, 1);
139+ monitor_permit(mon_dispatch, MONITOR_REQ_AUTHROLE, 1);
140 monitor_permit(mon_dispatch, MONITOR_REQ_AUTH2_READ_BANNER, 1);
141 }
142 #ifdef USE_PAM
143@@ -909,14 +912,37 @@ mm_answer_authserv(int sock, Buffer *m)
144
145 authctxt->service = buffer_get_string(m, NULL);
146 authctxt->style = buffer_get_string(m, NULL);
147- debug3("%s: service=%s, style=%s",
148- __func__, authctxt->service, authctxt->style);
149+ authctxt->role = buffer_get_string(m, NULL);
150+ debug3("%s: service=%s, style=%s, role=%s",
151+ __func__, authctxt->service, authctxt->style, authctxt->role);
152
153 if (strlen(authctxt->style) == 0) {
154 free(authctxt->style);
155 authctxt->style = NULL;
156 }
157
158+ if (strlen(authctxt->role) == 0) {
159+ free(authctxt->role);
160+ authctxt->role = NULL;
161+ }
162+
163+ return (0);
164+}
165+
166+int
167+mm_answer_authrole(int sock, Buffer *m)
168+{
169+ monitor_permit_authentications(1);
170+
171+ authctxt->role = buffer_get_string(m, NULL);
172+ debug3("%s: role=%s",
173+ __func__, authctxt->role);
174+
175+ if (strlen(authctxt->role) == 0) {
176+ free(authctxt->role);
177+ authctxt->role = NULL;
178+ }
179+
180 return (0);
181 }
182
183@@ -1540,7 +1566,7 @@ mm_answer_pty(int sock, Buffer *m)
184 res = pty_allocate(&s->ptyfd, &s->ttyfd, s->tty, sizeof(s->tty));
185 if (res == 0)
186 goto error;
187- pty_setowner(authctxt->pw, s->tty);
188+ pty_setowner(authctxt->pw, s->tty, authctxt->role);
189
190 buffer_put_int(m, 1);
191 buffer_put_cstring(m, s->tty);
192diff --git a/monitor.h b/monitor.h
193index bc50ade..2d82b8b 100644
194--- a/monitor.h
195+++ b/monitor.h
196@@ -68,6 +68,8 @@ enum monitor_reqtype {
197 MONITOR_REQ_GSSSIGN = 150, MONITOR_ANS_GSSSIGN = 151,
198 MONITOR_REQ_GSSUPCREDS = 152, MONITOR_ANS_GSSUPCREDS = 153,
199
200+ MONITOR_REQ_AUTHROLE = 154,
201+
202 };
203
204 struct mm_master;
205diff --git a/monitor_wrap.c b/monitor_wrap.c
206index b667218..5aa9c47 100644
207--- a/monitor_wrap.c
208+++ b/monitor_wrap.c
209@@ -329,10 +329,10 @@ mm_auth2_read_banner(void)
210 return (banner);
211 }
212
213-/* Inform the privileged process about service and style */
214+/* Inform the privileged process about service, style, and role */
215
216 void
217-mm_inform_authserv(char *service, char *style)
218+mm_inform_authserv(char *service, char *style, char *role)
219 {
220 Buffer m;
221
222@@ -341,12 +341,30 @@ mm_inform_authserv(char *service, char *style)
223 buffer_init(&m);
224 buffer_put_cstring(&m, service);
225 buffer_put_cstring(&m, style ? style : "");
226+ buffer_put_cstring(&m, role ? role : "");
227
228 mm_request_send(pmonitor->m_recvfd, MONITOR_REQ_AUTHSERV, &m);
229
230 buffer_free(&m);
231 }
232
233+/* Inform the privileged process about role */
234+
235+void
236+mm_inform_authrole(char *role)
237+{
238+ Buffer m;
239+
240+ debug3("%s entering", __func__);
241+
242+ buffer_init(&m);
243+ buffer_put_cstring(&m, role ? role : "");
244+
245+ mm_request_send(pmonitor->m_recvfd, MONITOR_REQ_AUTHROLE, &m);
246+
247+ buffer_free(&m);
248+}
249+
250 /* Do the password authentication */
251 int
252 mm_auth_password(Authctxt *authctxt, char *password)
253diff --git a/monitor_wrap.h b/monitor_wrap.h
254index 0c770e8..4d1e899 100644
255--- a/monitor_wrap.h
256+++ b/monitor_wrap.h
257@@ -41,7 +41,8 @@ void mm_log_handler(LogLevel, const char *, void *);
258 int mm_is_monitor(void);
259 DH *mm_choose_dh(int, int, int);
260 int mm_key_sign(Key *, u_char **, u_int *, const u_char *, u_int);
261-void mm_inform_authserv(char *, char *);
262+void mm_inform_authserv(char *, char *, char *);
263+void mm_inform_authrole(char *);
264 struct passwd *mm_getpwnamallow(const char *);
265 char *mm_auth2_read_banner(void);
266 int mm_auth_password(struct Authctxt *, char *);
267diff --git a/openbsd-compat/port-linux.c b/openbsd-compat/port-linux.c
268index 4637a7a..de6ad3f 100644
269--- a/openbsd-compat/port-linux.c
270+++ b/openbsd-compat/port-linux.c
271@@ -29,6 +29,12 @@
272 #include <string.h>
273 #include <stdio.h>
274
275+#ifdef WITH_SELINUX
276+#include "key.h"
277+#include "hostfile.h"
278+#include "auth.h"
279+#endif
280+
281 #include "log.h"
282 #include "xmalloc.h"
283 #include "port-linux.h"
284@@ -58,7 +64,7 @@ ssh_selinux_enabled(void)
285
286 /* Return the default security context for the given username */
287 static security_context_t
288-ssh_selinux_getctxbyname(char *pwname)
289+ssh_selinux_getctxbyname(char *pwname, const char *role)
290 {
291 security_context_t sc = NULL;
292 char *sename = NULL, *lvl = NULL;
293@@ -73,9 +79,16 @@ ssh_selinux_getctxbyname(char *pwname)
294 #endif
295
296 #ifdef HAVE_GET_DEFAULT_CONTEXT_WITH_LEVEL
297- r = get_default_context_with_level(sename, lvl, NULL, &sc);
298+ if (role != NULL && role[0])
299+ r = get_default_context_with_rolelevel(sename, role, lvl, NULL,
300+ &sc);
301+ else
302+ r = get_default_context_with_level(sename, lvl, NULL, &sc);
303 #else
304- r = get_default_context(sename, NULL, &sc);
305+ if (role != NULL && role[0])
306+ r = get_default_context_with_role(sename, role, NULL, &sc);
307+ else
308+ r = get_default_context(sename, NULL, &sc);
309 #endif
310
311 if (r != 0) {
312@@ -105,7 +118,7 @@ ssh_selinux_getctxbyname(char *pwname)
313
314 /* Set the execution context to the default for the specified user */
315 void
316-ssh_selinux_setup_exec_context(char *pwname)
317+ssh_selinux_setup_exec_context(char *pwname, const char *role)
318 {
319 security_context_t user_ctx = NULL;
320
321@@ -114,7 +127,7 @@ ssh_selinux_setup_exec_context(char *pwname)
322
323 debug3("%s: setting execution context", __func__);
324
325- user_ctx = ssh_selinux_getctxbyname(pwname);
326+ user_ctx = ssh_selinux_getctxbyname(pwname, role);
327 if (setexeccon(user_ctx) != 0) {
328 switch (security_getenforce()) {
329 case -1:
330@@ -136,7 +149,7 @@ ssh_selinux_setup_exec_context(char *pwname)
331
332 /* Set the TTY context for the specified user */
333 void
334-ssh_selinux_setup_pty(char *pwname, const char *tty)
335+ssh_selinux_setup_pty(char *pwname, const char *tty, const char *role)
336 {
337 security_context_t new_tty_ctx = NULL;
338 security_context_t user_ctx = NULL;
339@@ -147,7 +160,7 @@ ssh_selinux_setup_pty(char *pwname, const char *tty)
340
341 debug3("%s: setting TTY context on %s", __func__, tty);
342
343- user_ctx = ssh_selinux_getctxbyname(pwname);
344+ user_ctx = ssh_selinux_getctxbyname(pwname, role);
345
346 /* XXX: should these calls fatal() upon failure in enforcing mode? */
347
348diff --git a/openbsd-compat/port-linux.h b/openbsd-compat/port-linux.h
349index e3d1004..80ce13a 100644
350--- a/openbsd-compat/port-linux.h
351+++ b/openbsd-compat/port-linux.h
352@@ -21,8 +21,8 @@
353
354 #ifdef WITH_SELINUX
355 int ssh_selinux_enabled(void);
356-void ssh_selinux_setup_pty(char *, const char *);
357-void ssh_selinux_setup_exec_context(char *);
358+void ssh_selinux_setup_pty(char *, const char *, const char *);
359+void ssh_selinux_setup_exec_context(char *, const char *);
360 void ssh_selinux_change_context(const char *);
361 void ssh_selinux_setfscreatecon(const char *);
362 #endif
363diff --git a/platform.c b/platform.c
364index ee313da..f35ec39 100644
365--- a/platform.c
366+++ b/platform.c
367@@ -143,7 +143,7 @@ platform_setusercontext(struct passwd *pw)
368 * called if sshd is running as root.
369 */
370 void
371-platform_setusercontext_post_groups(struct passwd *pw)
372+platform_setusercontext_post_groups(struct passwd *pw, const char *role)
373 {
374 #if !defined(HAVE_LOGIN_CAP) && defined(USE_PAM)
375 /*
376@@ -184,7 +184,7 @@ platform_setusercontext_post_groups(struct passwd *pw)
377 }
378 #endif /* HAVE_SETPCRED */
379 #ifdef WITH_SELINUX
380- ssh_selinux_setup_exec_context(pw->pw_name);
381+ ssh_selinux_setup_exec_context(pw->pw_name, role);
382 #endif
383 }
384
385diff --git a/platform.h b/platform.h
386index 1c7a45d..436ae7c 100644
387--- a/platform.h
388+++ b/platform.h
389@@ -27,7 +27,7 @@ void platform_post_fork_parent(pid_t child_pid);
390 void platform_post_fork_child(void);
391 int platform_privileged_uidswap(void);
392 void platform_setusercontext(struct passwd *);
393-void platform_setusercontext_post_groups(struct passwd *);
394+void platform_setusercontext_post_groups(struct passwd *, const char *);
395 char *platform_get_krb5_client(const char *);
396 char *platform_krb5_get_principal_name(const char *);
397 int platform_sys_dir_uid(uid_t);
398diff --git a/session.c b/session.c
399index 54bac36..d4b7725 100644
400--- a/session.c
401+++ b/session.c
402@@ -1487,7 +1487,7 @@ safely_chroot(const char *path, uid_t uid)
403
404 /* Set login name, uid, gid, and groups. */
405 void
406-do_setusercontext(struct passwd *pw)
407+do_setusercontext(struct passwd *pw, const char *role)
408 {
409 char *chroot_path, *tmp;
410 #ifdef USE_LIBIAF
411@@ -1518,7 +1518,7 @@ do_setusercontext(struct passwd *pw)
412 endgrent();
413 #endif
414
415- platform_setusercontext_post_groups(pw);
416+ platform_setusercontext_post_groups(pw, role);
417
418 if (options.chroot_directory != NULL &&
419 strcasecmp(options.chroot_directory, "none") != 0) {
420@@ -1677,7 +1677,7 @@ do_child(Session *s, const char *command)
421
422 /* Force a password change */
423 if (s->authctxt->force_pwchange) {
424- do_setusercontext(pw);
425+ do_setusercontext(pw, s->authctxt->role);
426 child_close_fds();
427 do_pwchange(s);
428 exit(1);
429@@ -1704,7 +1704,7 @@ do_child(Session *s, const char *command)
430 /* When PAM is enabled we rely on it to do the nologin check */
431 if (!options.use_pam)
432 do_nologin(pw);
433- do_setusercontext(pw);
434+ do_setusercontext(pw, s->authctxt->role);
435 /*
436 * PAM session modules in do_setusercontext may have
437 * generated messages, so if this in an interactive
438@@ -2115,7 +2115,7 @@ session_pty_req(Session *s)
439 tty_parse_modes(s->ttyfd, &n_bytes);
440
441 if (!use_privsep)
442- pty_setowner(s->pw, s->tty);
443+ pty_setowner(s->pw, s->tty, s->authctxt->role);
444
445 /* Set window size from the packet. */
446 pty_change_window_size(s->ptyfd, s->row, s->col, s->xpixel, s->ypixel);
447diff --git a/session.h b/session.h
448index 6a2f35e..ef6593c 100644
449--- a/session.h
450+++ b/session.h
451@@ -77,7 +77,7 @@ void session_pty_cleanup2(Session *);
452 Session *session_new(void);
453 Session *session_by_tty(char *);
454 void session_close(Session *);
455-void do_setusercontext(struct passwd *);
456+void do_setusercontext(struct passwd *, const char *);
457 void child_set_env(char ***envp, u_int *envsizep, const char *name,
458 const char *value);
459
460diff --git a/sshd.c b/sshd.c
461index 9cbe8c4..3b4e97c 100644
462--- a/sshd.c
463+++ b/sshd.c
464@@ -781,7 +781,7 @@ privsep_postauth(Authctxt *authctxt)
465 explicit_bzero(rnd, sizeof(rnd));
466
467 /* Drop privileges */
468- do_setusercontext(authctxt->pw);
469+ do_setusercontext(authctxt->pw, authctxt->role);
470
471 skip:
472 /* It is safe now to apply the key state */
473diff --git a/sshpty.c b/sshpty.c
474index d2ff8c1..f7b1f6d 100644
475--- a/sshpty.c
476+++ b/sshpty.c
477@@ -187,7 +187,7 @@ pty_change_window_size(int ptyfd, u_int row, u_int col,
478 }
479
480 void
481-pty_setowner(struct passwd *pw, const char *tty)
482+pty_setowner(struct passwd *pw, const char *tty, const char *role)
483 {
484 struct group *grp;
485 gid_t gid;
486@@ -209,7 +209,7 @@ pty_setowner(struct passwd *pw, const char *tty)
487 strerror(errno));
488
489 #ifdef WITH_SELINUX
490- ssh_selinux_setup_pty(pw->pw_name, tty);
491+ ssh_selinux_setup_pty(pw->pw_name, tty, role);
492 #endif
493
494 if (st.st_uid != pw->pw_uid || st.st_gid != gid) {
495diff --git a/sshpty.h b/sshpty.h
496index cfa3224..edf2436 100644
497--- a/sshpty.h
498+++ b/sshpty.h
499@@ -24,4 +24,4 @@ int pty_allocate(int *, int *, char *, size_t);
500 void pty_release(const char *);
501 void pty_make_controlling_tty(int *, const char *);
502 void pty_change_window_size(int, u_int, u_int, u_int, u_int);
503-void pty_setowner(struct passwd *, const char *);
504+void pty_setowner(struct passwd *, const char *, const char *);
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000000000..bbc7a5fb4
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1,29 @@
1gssapi.patch
2restore-tcp-wrappers.patch
3selinux-role.patch
4ssh-vulnkey-compat.patch
5ssh1-keepalive.patch
6keepalive-extensions.patch
7syslog-level-silent.patch
8quieter-signals.patch
9helpful-wait-terminate.patch
10consolekit.patch
11user-group-modes.patch
12scp-quoting.patch
13shell-path.patch
14dnssec-sshfp.patch
15auth-log-verbosity.patch
16mention-ssh-keygen-on-keychange.patch
17package-versioning.patch
18debian-banner.patch
19authorized-keys-man-symlink.patch
20lintian-symlink-pickiness.patch
21openbsd-docs.patch
22ssh-argv0.patch
23doc-hash-tab-completion.patch
24doc-upstart.patch
25ssh-agent-setgid.patch
26no-openssl-version-status.patch
27gnome-ssh-askpass2-icon.patch
28sigstop.patch
29debian-config.patch
diff --git a/debian/patches/shell-path.patch b/debian/patches/shell-path.patch
new file mode 100644
index 000000000..549ef38dd
--- /dev/null
+++ b/debian/patches/shell-path.patch
@@ -0,0 +1,39 @@
1From 8a8bbc66b8eefd7c679d5769f087209188deafe7 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:00 +0000
4Subject: Look for $SHELL on the path for ProxyCommand/LocalCommand
5
6There's some debate on the upstream bug about whether POSIX requires this.
7I (Colin Watson) agree with Vincent and think it does.
8
9Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1494
10Bug-Debian: http://bugs.debian.org/492728
11Last-Update: 2013-09-14
12
13Patch-Name: shell-path.patch
14---
15 sshconnect.c | 4 ++--
16 1 file changed, 2 insertions(+), 2 deletions(-)
17
18diff --git a/sshconnect.c b/sshconnect.c
19index 9e51506..0073c6e 100644
20--- a/sshconnect.c
21+++ b/sshconnect.c
22@@ -231,7 +231,7 @@ ssh_proxy_connect(const char *host, u_short port, const char *proxy_command)
23 /* Execute the proxy command. Note that we gave up any
24 extra privileges above. */
25 signal(SIGPIPE, SIG_DFL);
26- execv(argv[0], argv);
27+ execvp(argv[0], argv);
28 perror(argv[0]);
29 exit(1);
30 }
31@@ -1470,7 +1470,7 @@ ssh_local_cmd(const char *args)
32 if (pid == 0) {
33 signal(SIGPIPE, SIG_DFL);
34 debug3("Executing %s -c \"%s\"", shell, args);
35- execl(shell, shell, "-c", args, (char *)NULL);
36+ execlp(shell, shell, "-c", args, (char *)NULL);
37 error("Couldn't execute %s -c \"%s\": %s",
38 shell, args, strerror(errno));
39 _exit(1);
diff --git a/debian/patches/sigstop.patch b/debian/patches/sigstop.patch
new file mode 100644
index 000000000..80e775dc1
--- /dev/null
+++ b/debian/patches/sigstop.patch
@@ -0,0 +1,35 @@
1From a8e779107942d044d281461c609ec29129dec51e Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:17 +0000
4Subject: Support synchronisation with service supervisor using SIGSTOP
5
6Author: Robie Basak <robie.basak@ubuntu.com>
7Forwarded: no
8Last-Update: 2014-04-14
9
10Patch-Name: sigstop.patch
11---
12 sshd.c | 10 ++++++++++
13 1 file changed, 10 insertions(+)
14
15diff --git a/sshd.c b/sshd.c
16index 5435968..f8db3ae 100644
17--- a/sshd.c
18+++ b/sshd.c
19@@ -2030,6 +2030,16 @@ main(int ac, char **av)
20 }
21 }
22
23+ if (getenv("SSH_SIGSTOP")) {
24+ /* Tell service supervisor that we are ready. */
25+ kill(getpid(), SIGSTOP);
26+ /* The service supervisor only ever expects a single
27+ * STOP signal, so do not ever signal it again, even
28+ * in the case of a re-exec or future children.
29+ */
30+ unsetenv("SSH_SIGSTOP");
31+ }
32+
33 /* Accept a connection and return in a forked child */
34 server_accept_loop(&sock_in, &sock_out,
35 &newsock, config_s);
diff --git a/debian/patches/ssh-agent-setgid.patch b/debian/patches/ssh-agent-setgid.patch
new file mode 100644
index 000000000..b382252a3
--- /dev/null
+++ b/debian/patches/ssh-agent-setgid.patch
@@ -0,0 +1,40 @@
1From 101d1dd7f95d75f1862c541a5b8d4032d4623d53 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:13 +0000
4Subject: Document consequences of ssh-agent being setgid in ssh-agent(1)
5
6Bug-Debian: http://bugs.debian.org/711623
7Forwarded: no
8Last-Update: 2013-06-08
9
10Patch-Name: ssh-agent-setgid.patch
11---
12 ssh-agent.1 | 15 +++++++++++++++
13 1 file changed, 15 insertions(+)
14
15diff --git a/ssh-agent.1 b/ssh-agent.1
16index 6759afe..25de326 100644
17--- a/ssh-agent.1
18+++ b/ssh-agent.1
19@@ -181,6 +181,21 @@ environment variable holds the agent's process ID.
20 .Pp
21 The agent exits automatically when the command given on the command
22 line terminates.
23+.Pp
24+In Debian,
25+.Nm
26+is installed with the set-group-id bit set, to prevent
27+.Xr ptrace 2
28+attacks retrieving private key material.
29+This has the side-effect of causing the run-time linker to remove certain
30+environment variables which might have security implications for set-id
31+programs, including
32+.Ev LD_PRELOAD ,
33+.Ev LD_LIBRARY_PATH ,
34+and
35+.Ev TMPDIR .
36+If you need to set any of these environment variables, you will need to do
37+so in the program executed by ssh-agent.
38 .Sh FILES
39 .Bl -tag -width Ds
40 .It Pa $TMPDIR/ssh-XXXXXXXXXX/agent.\*(Ltppid\*(Gt
diff --git a/debian/patches/ssh-argv0.patch b/debian/patches/ssh-argv0.patch
new file mode 100644
index 000000000..0fe3b6da4
--- /dev/null
+++ b/debian/patches/ssh-argv0.patch
@@ -0,0 +1,31 @@
1From fac628fd57d3d357b86d77987f896d6289240345 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:10:10 +0000
4Subject: ssh(1): Refer to ssh-argv0(1)
5
6Old versions of OpenSSH (up to 2.5 or thereabouts) allowed creating symlinks
7to ssh with the name of the host you want to connect to. Debian ships an
8ssh-argv0 script restoring this feature; this patch refers to its manual
9page from ssh(1).
10
11Bug-Debian: http://bugs.debian.org/111341
12Forwarded: not-needed
13Last-Update: 2013-09-14
14
15Patch-Name: ssh-argv0.patch
16---
17 ssh.1 | 1 +
18 1 file changed, 1 insertion(+)
19
20diff --git a/ssh.1 b/ssh.1
21index 04de6cf..c8892fe 100644
22--- a/ssh.1
23+++ b/ssh.1
24@@ -1471,6 +1471,7 @@ if an error occurred.
25 .Xr sftp 1 ,
26 .Xr ssh-add 1 ,
27 .Xr ssh-agent 1 ,
28+.Xr ssh-argv0 1 ,
29 .Xr ssh-keygen 1 ,
30 .Xr ssh-keyscan 1 ,
31 .Xr tun 4 ,
diff --git a/debian/patches/ssh-vulnkey-compat.patch b/debian/patches/ssh-vulnkey-compat.patch
new file mode 100644
index 000000000..28b98f527
--- /dev/null
+++ b/debian/patches/ssh-vulnkey-compat.patch
@@ -0,0 +1,42 @@
1From d027dea6b4b659a7ad537e452db563763302eabd Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@ubuntu.com>
3Date: Sun, 9 Feb 2014 16:09:50 +0000
4Subject: Accept obsolete ssh-vulnkey configuration options
5
6These options were used as part of Debian's response to CVE-2008-0166.
7Nearly six years later, we no longer need to continue carrying the bulk
8of that patch, but we do need to avoid failing when the associated
9configuration options are still present.
10
11Last-Update: 2014-02-09
12
13Patch-Name: ssh-vulnkey-compat.patch
14---
15 readconf.c | 1 +
16 servconf.c | 1 +
17 2 files changed, 2 insertions(+)
18
19diff --git a/readconf.c b/readconf.c
20index 254dbce..278fe15 100644
21--- a/readconf.c
22+++ b/readconf.c
23@@ -180,6 +180,7 @@ static struct {
24 { "passwordauthentication", oPasswordAuthentication },
25 { "kbdinteractiveauthentication", oKbdInteractiveAuthentication },
26 { "kbdinteractivedevices", oKbdInteractiveDevices },
27+ { "useblacklistedkeys", oDeprecated },
28 { "rsaauthentication", oRSAAuthentication },
29 { "pubkeyauthentication", oPubkeyAuthentication },
30 { "dsaauthentication", oPubkeyAuthentication }, /* alias */
31diff --git a/servconf.c b/servconf.c
32index f68c0d0..b3a2841 100644
33--- a/servconf.c
34+++ b/servconf.c
35@@ -503,6 +503,7 @@ static struct {
36 { "x11uselocalhost", sX11UseLocalhost, SSHCFG_ALL },
37 { "xauthlocation", sXAuthLocation, SSHCFG_GLOBAL },
38 { "strictmodes", sStrictModes, SSHCFG_GLOBAL },
39+ { "permitblacklistedkeys", sDeprecated, SSHCFG_GLOBAL },
40 { "permitemptypasswords", sEmptyPasswd, SSHCFG_ALL },
41 { "permituserenvironment", sPermitUserEnvironment, SSHCFG_GLOBAL },
42 { "uselogin", sUseLogin, SSHCFG_GLOBAL },
diff --git a/debian/patches/ssh1-keepalive.patch b/debian/patches/ssh1-keepalive.patch
new file mode 100644
index 000000000..e6bc72440
--- /dev/null
+++ b/debian/patches/ssh1-keepalive.patch
@@ -0,0 +1,74 @@
1From 396f7d932b391fc92ac7ccdf8813f49564e2bbab Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:09:51 +0000
4Subject: Partial server keep-alive implementation for SSH1
5
6Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1712
7Last-Update: 2013-09-14
8
9Patch-Name: ssh1-keepalive.patch
10---
11 clientloop.c | 25 +++++++++++++++----------
12 ssh_config.5 | 5 ++++-
13 2 files changed, 19 insertions(+), 11 deletions(-)
14
15diff --git a/clientloop.c b/clientloop.c
16index 7df9413..156a196 100644
17--- a/clientloop.c
18+++ b/clientloop.c
19@@ -564,16 +564,21 @@ client_global_request_reply(int type, u_int32_t seq, void *ctxt)
20 static void
21 server_alive_check(void)
22 {
23- if (packet_inc_alive_timeouts() > options.server_alive_count_max) {
24- logit("Timeout, server %s not responding.", host);
25- cleanup_exit(255);
26+ if (compat20) {
27+ if (packet_inc_alive_timeouts() > options.server_alive_count_max) {
28+ logit("Timeout, server %s not responding.", host);
29+ cleanup_exit(255);
30+ }
31+ packet_start(SSH2_MSG_GLOBAL_REQUEST);
32+ packet_put_cstring("keepalive@openssh.com");
33+ packet_put_char(1); /* boolean: want reply */
34+ packet_send();
35+ /* Insert an empty placeholder to maintain ordering */
36+ client_register_global_confirm(NULL, NULL);
37+ } else {
38+ packet_send_ignore(0);
39+ packet_send();
40 }
41- packet_start(SSH2_MSG_GLOBAL_REQUEST);
42- packet_put_cstring("keepalive@openssh.com");
43- packet_put_char(1); /* boolean: want reply */
44- packet_send();
45- /* Insert an empty placeholder to maintain ordering */
46- client_register_global_confirm(NULL, NULL);
47 }
48
49 /*
50@@ -635,7 +640,7 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp,
51 */
52
53 timeout_secs = INT_MAX; /* we use INT_MAX to mean no timeout */
54- if (options.server_alive_interval > 0 && compat20) {
55+ if (options.server_alive_interval > 0) {
56 timeout_secs = options.server_alive_interval;
57 server_alive_time = now + options.server_alive_interval;
58 }
59diff --git a/ssh_config.5 b/ssh_config.5
60index 4476171..dd35dd8 100644
61--- a/ssh_config.5
62+++ b/ssh_config.5
63@@ -1409,7 +1409,10 @@ If, for example,
64 .Cm ServerAliveCountMax
65 is left at the default, if the server becomes unresponsive,
66 ssh will disconnect after approximately 45 seconds.
67-This option applies to protocol version 2 only.
68+This option applies to protocol version 2 only; in protocol version
69+1 there is no mechanism to request a response from the server to the
70+server alive messages, so disconnection is the responsibility of the TCP
71+stack.
72 .It Cm ServerAliveInterval
73 Sets a timeout interval in seconds after which if no data has been received
74 from the server,
diff --git a/debian/patches/syslog-level-silent.patch b/debian/patches/syslog-level-silent.patch
new file mode 100644
index 000000000..d760e6c19
--- /dev/null
+++ b/debian/patches/syslog-level-silent.patch
@@ -0,0 +1,47 @@
1From fbe5bd9e957ea90404158b3a3c11a6b91fe6f010 Mon Sep 17 00:00:00 2001
2From: Jonathan David Amery <jdamery@ysolde.ucam.org>
3Date: Sun, 9 Feb 2014 16:09:54 +0000
4Subject: "LogLevel SILENT" compatibility
5
6"LogLevel SILENT" (-qq) was introduced in Debian openssh 1:3.0.1p1-1 to
7match the behaviour of non-free SSH, in which -q does not suppress fatal
8errors. However, this was unintentionally broken in 1:4.6p1-2 and nobody
9complained, so we've dropped most of it. The parts that remain are basic
10configuration file compatibility, and an adjustment to "Pseudo-terminal will
11not be allocated ..." which should be split out into a separate patch.
12
13Author: Matthew Vernon <matthew@debian.org>
14Author: Colin Watson <cjwatson@debian.org>
15Last-Update: 2013-09-14
16
17Patch-Name: syslog-level-silent.patch
18---
19 log.c | 1 +
20 ssh.c | 2 +-
21 2 files changed, 2 insertions(+), 1 deletion(-)
22
23diff --git a/log.c b/log.c
24index 32e1d2e..53e7b65 100644
25--- a/log.c
26+++ b/log.c
27@@ -94,6 +94,7 @@ static struct {
28 LogLevel val;
29 } log_levels[] =
30 {
31+ { "SILENT", SYSLOG_LEVEL_QUIET }, /* compatibility */
32 { "QUIET", SYSLOG_LEVEL_QUIET },
33 { "FATAL", SYSLOG_LEVEL_FATAL },
34 { "ERROR", SYSLOG_LEVEL_ERROR },
35diff --git a/ssh.c b/ssh.c
36index 0ad82f0..e8be6fe 100644
37--- a/ssh.c
38+++ b/ssh.c
39@@ -1107,7 +1107,7 @@ main(int ac, char **av)
40 /* Do not allocate a tty if stdin is not a tty. */
41 if ((!isatty(fileno(stdin)) || stdin_null_flag) &&
42 options.request_tty != REQUEST_TTY_FORCE) {
43- if (tty_flag)
44+ if (tty_flag && options.log_level != SYSLOG_LEVEL_QUIET)
45 logit("Pseudo-terminal will not be allocated because "
46 "stdin is not a terminal.");
47 tty_flag = 0;
diff --git a/debian/patches/user-group-modes.patch b/debian/patches/user-group-modes.patch
new file mode 100644
index 000000000..8ce3d1f71
--- /dev/null
+++ b/debian/patches/user-group-modes.patch
@@ -0,0 +1,266 @@
1From 39b2121148a0aa016a648446823c8f02c5fd95b3 Mon Sep 17 00:00:00 2001
2From: Colin Watson <cjwatson@debian.org>
3Date: Sun, 9 Feb 2014 16:09:58 +0000
4Subject: Allow harmless group-writability
5
6Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
7group-writable, provided that the group in question contains only the file's
8owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
9about the contents of gr->gr_mem). Given that per-user groups and umask 002
10are the default setup in Debian (for good reasons - this makes operating in
11setgid directories with other groups much easier), we need to permit this by
12default.
13
14Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
15Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
16Last-Update: 2013-09-14
17
18Patch-Name: user-group-modes.patch
19---
20 auth-rhosts.c | 6 ++----
21 auth.c | 9 +++-----
22 misc.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
23 misc.h | 2 ++
24 platform.c | 16 --------------
25 readconf.c | 5 +++--
26 ssh.1 | 2 ++
27 ssh_config.5 | 2 ++
28 8 files changed, 82 insertions(+), 29 deletions(-)
29
30diff --git a/auth-rhosts.c b/auth-rhosts.c
31index ee9e827..2ff2cff 100644
32--- a/auth-rhosts.c
33+++ b/auth-rhosts.c
34@@ -271,8 +271,7 @@ auth_rhosts2_raw(struct passwd *pw, const char *client_user, const char *hostnam
35 return 0;
36 }
37 if (options.strict_modes &&
38- ((st.st_uid != 0 && st.st_uid != pw->pw_uid) ||
39- (st.st_mode & 022) != 0)) {
40+ !secure_permissions(&st, pw->pw_uid)) {
41 logit("Rhosts authentication refused for %.100s: "
42 "bad ownership or modes for home directory.", pw->pw_name);
43 auth_debug_add("Rhosts authentication refused for %.100s: "
44@@ -298,8 +297,7 @@ auth_rhosts2_raw(struct passwd *pw, const char *client_user, const char *hostnam
45 * allowing access to their account by anyone.
46 */
47 if (options.strict_modes &&
48- ((st.st_uid != 0 && st.st_uid != pw->pw_uid) ||
49- (st.st_mode & 022) != 0)) {
50+ !secure_permissions(&st, pw->pw_uid)) {
51 logit("Rhosts authentication refused for %.100s: bad modes for %.200s",
52 pw->pw_name, buf);
53 auth_debug_add("Bad file modes for %.200s", buf);
54diff --git a/auth.c b/auth.c
55index f9b7673..41e3876 100644
56--- a/auth.c
57+++ b/auth.c
58@@ -423,8 +423,7 @@ check_key_in_hostfiles(struct passwd *pw, Key *key, const char *host,
59 user_hostfile = tilde_expand_filename(userfile, pw->pw_uid);
60 if (options.strict_modes &&
61 (stat(user_hostfile, &st) == 0) &&
62- ((st.st_uid != 0 && st.st_uid != pw->pw_uid) ||
63- (st.st_mode & 022) != 0)) {
64+ !secure_permissions(&st, pw->pw_uid)) {
65 logit("Authentication refused for %.100s: "
66 "bad owner or modes for %.200s",
67 pw->pw_name, user_hostfile);
68@@ -486,8 +485,7 @@ auth_secure_path(const char *name, struct stat *stp, const char *pw_dir,
69 snprintf(err, errlen, "%s is not a regular file", buf);
70 return -1;
71 }
72- if ((!platform_sys_dir_uid(stp->st_uid) && stp->st_uid != uid) ||
73- (stp->st_mode & 022) != 0) {
74+ if (!secure_permissions(stp, uid)) {
75 snprintf(err, errlen, "bad ownership or modes for file %s",
76 buf);
77 return -1;
78@@ -502,8 +500,7 @@ auth_secure_path(const char *name, struct stat *stp, const char *pw_dir,
79 strlcpy(buf, cp, sizeof(buf));
80
81 if (stat(buf, &st) < 0 ||
82- (!platform_sys_dir_uid(st.st_uid) && st.st_uid != uid) ||
83- (st.st_mode & 022) != 0) {
84+ !secure_permissions(&st, uid)) {
85 snprintf(err, errlen,
86 "bad ownership or modes for directory %s", buf);
87 return -1;
88diff --git a/misc.c b/misc.c
89index 38af3df..d745480 100644
90--- a/misc.c
91+++ b/misc.c
92@@ -50,8 +50,9 @@
93 #include <netdb.h>
94 #ifdef HAVE_PATHS_H
95 # include <paths.h>
96-#include <pwd.h>
97 #endif
98+#include <pwd.h>
99+#include <grp.h>
100 #ifdef SSH_TUN_OPENBSD
101 #include <net/if.h>
102 #endif
103@@ -60,6 +61,7 @@
104 #include "misc.h"
105 #include "log.h"
106 #include "ssh.h"
107+#include "platform.h"
108
109 /* remove newline at end of string */
110 char *
111@@ -644,6 +646,71 @@ read_keyfile_line(FILE *f, const char *filename, char *buf, size_t bufsz,
112 return -1;
113 }
114
115+/*
116+ * return 1 if the specified uid is a uid that may own a system directory
117+ * otherwise 0.
118+ */
119+int
120+platform_sys_dir_uid(uid_t uid)
121+{
122+ if (uid == 0)
123+ return 1;
124+#ifdef PLATFORM_SYS_DIR_UID
125+ if (uid == PLATFORM_SYS_DIR_UID)
126+ return 1;
127+#endif
128+ return 0;
129+}
130+
131+int
132+secure_permissions(struct stat *st, uid_t uid)
133+{
134+ if (!platform_sys_dir_uid(st->st_uid) && st->st_uid != uid)
135+ return 0;
136+ if ((st->st_mode & 002) != 0)
137+ return 0;
138+ if ((st->st_mode & 020) != 0) {
139+ /* If the file is group-writable, the group in question must
140+ * have exactly one member, namely the file's owner.
141+ * (Zero-member groups are typically used by setgid
142+ * binaries, and are unlikely to be suitable.)
143+ */
144+ struct passwd *pw;
145+ struct group *gr;
146+ int members = 0;
147+
148+ gr = getgrgid(st->st_gid);
149+ if (!gr)
150+ return 0;
151+
152+ /* Check primary group memberships. */
153+ while ((pw = getpwent()) != NULL) {
154+ if (pw->pw_gid == gr->gr_gid) {
155+ ++members;
156+ if (pw->pw_uid != uid)
157+ return 0;
158+ }
159+ }
160+ endpwent();
161+
162+ pw = getpwuid(st->st_uid);
163+ if (!pw)
164+ return 0;
165+
166+ /* Check supplementary group memberships. */
167+ if (gr->gr_mem[0]) {
168+ ++members;
169+ if (strcmp(pw->pw_name, gr->gr_mem[0]) ||
170+ gr->gr_mem[1])
171+ return 0;
172+ }
173+
174+ if (!members)
175+ return 0;
176+ }
177+ return 1;
178+}
179+
180 int
181 tun_open(int tun, int mode)
182 {
183diff --git a/misc.h b/misc.h
184index 374c33c..89e1f75 100644
185--- a/misc.h
186+++ b/misc.h
187@@ -135,4 +135,6 @@ char *read_passphrase(const char *, int);
188 int ask_permission(const char *, ...) __attribute__((format(printf, 1, 2)));
189 int read_keyfile_line(FILE *, const char *, char *, size_t, u_long *);
190
191+int secure_permissions(struct stat *st, uid_t uid);
192+
193 #endif /* _MISC_H */
194diff --git a/platform.c b/platform.c
195index f35ec39..9a23e6e 100644
196--- a/platform.c
197+++ b/platform.c
198@@ -197,19 +197,3 @@ platform_krb5_get_principal_name(const char *pw_name)
199 return NULL;
200 #endif
201 }
202-
203-/*
204- * return 1 if the specified uid is a uid that may own a system directory
205- * otherwise 0.
206- */
207-int
208-platform_sys_dir_uid(uid_t uid)
209-{
210- if (uid == 0)
211- return 1;
212-#ifdef PLATFORM_SYS_DIR_UID
213- if (uid == PLATFORM_SYS_DIR_UID)
214- return 1;
215-#endif
216- return 0;
217-}
218diff --git a/readconf.c b/readconf.c
219index 1d2d596..2ef8d7b 100644
220--- a/readconf.c
221+++ b/readconf.c
222@@ -39,6 +39,8 @@
223 #include <stdio.h>
224 #include <string.h>
225 #include <unistd.h>
226+#include <pwd.h>
227+#include <grp.h>
228 #ifdef HAVE_UTIL_H
229 #include <util.h>
230 #endif
231@@ -1579,8 +1581,7 @@ read_config_file(const char *filename, struct passwd *pw, const char *host,
232
233 if (fstat(fileno(f), &sb) == -1)
234 fatal("fstat %s: %s", filename, strerror(errno));
235- if (((sb.st_uid != 0 && sb.st_uid != getuid()) ||
236- (sb.st_mode & 022) != 0))
237+ if (!secure_permissions(&sb, getuid()))
238 fatal("Bad owner or permissions on %s", filename);
239 }
240
241diff --git a/ssh.1 b/ssh.1
242index da64b71..53c711a 100644
243--- a/ssh.1
244+++ b/ssh.1
245@@ -1355,6 +1355,8 @@ The file format and configuration options are described in
246 .Xr ssh_config 5 .
247 Because of the potential for abuse, this file must have strict permissions:
248 read/write for the user, and not writable by others.
249+It may be group-writable provided that the group in question contains only
250+the user.
251 .Pp
252 .It Pa ~/.ssh/environment
253 Contains additional definitions for environment variables; see
254diff --git a/ssh_config.5 b/ssh_config.5
255index 250c0d1..8abcf40 100644
256--- a/ssh_config.5
257+++ b/ssh_config.5
258@@ -1701,6 +1701,8 @@ The format of this file is described above.
259 This file is used by the SSH client.
260 Because of the potential for abuse, this file must have strict permissions:
261 read/write for the user, and not accessible by others.
262+It may be group-writable provided that the group in question contains only
263+the user.
264 .It Pa /etc/ssh/ssh_config
265 Systemwide configuration file.
266 This file provides defaults for those