1 files changed, 39 insertions, 20 deletions

diff --git a/misc.c b/misc.c
index 2adb8c6a8..eb57bfc1b 100644
--- a/misc.c
+++ b/misc.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: misc.c,v 1.86 2011/09/05 05:59:08 djm Exp $ */
+/* $OpenBSD: misc.c,v 1.91 2013/07/12 00:43:50 djm Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  * Copyright (c) 2005,2006 Damien Miller.  All rights reserved.
@@ -129,7 +129,7 @@ unset_nonblock(int fd)
 const char *
 ssh_gai_strerror(int gaierr)
 {
-        if (gaierr == EAI_SYSTEM)
+        if (gaierr == EAI_SYSTEM && errno != 0)
                 return strerror(errno);
         return gai_strerror(gaierr);
 }
@@ -208,16 +208,18 @@ pwcopy(struct passwd *pw)
 
         copy->pw_name = xstrdup(pw->pw_name);
         copy->pw_passwd = xstrdup(pw->pw_passwd);
+#ifdef HAVE_STRUCT_PASSWD_PW_GECOS
         copy->pw_gecos = xstrdup(pw->pw_gecos);
+#endif
         copy->pw_uid = pw->pw_uid;
         copy->pw_gid = pw->pw_gid;
-#ifdef HAVE_PW_EXPIRE_IN_PASSWD
+#ifdef HAVE_STRUCT_PASSWD_PW_EXPIRE
         copy->pw_expire = pw->pw_expire;
 #endif
-#ifdef HAVE_PW_CHANGE_IN_PASSWD
+#ifdef HAVE_STRUCT_PASSWD_PW_CHANGE
         copy->pw_change = pw->pw_change;
 #endif
-#ifdef HAVE_PW_CLASS_IN_PASSWD
+#ifdef HAVE_STRUCT_PASSWD_PW_CLASS
         copy->pw_class = xstrdup(pw->pw_class);
 #endif
         copy->pw_dir = xstrdup(pw->pw_dir);
@@ -253,13 +255,13 @@ a2tun(const char *s, int *remote)
                 *remote = SSH_TUNID_ANY;
                 sp = xstrdup(s);
                 if ((ep = strchr(sp, ':')) == NULL) {
-                        xfree(sp);
+                        free(sp);
                         return (a2tun(s, NULL));
                 }
                 ep[0] = '\0'; ep++;
                 *remote = a2tun(ep, NULL);
                 tun = a2tun(sp, NULL);
-                xfree(sp);
+                free(sp);
                 return (*remote == SSH_TUNID_ERR ? *remote : tun);
         }
 
@@ -492,7 +494,7 @@ replacearg(arglist *args, u_int which, char *fmt, ...)
         if (which >= args->num)
                 fatal("replacearg: tried to replace invalid arg %d >= %d",
                     which, args->num);
-        xfree(args->list[which]);
+        free(args->list[which]);
         args->list[which] = cp;
 }
 
@@ -503,8 +505,8 @@ freeargs(arglist *args)
 
         if (args->list != NULL) {
                 for (i = 0; i < args->num; i++)
-                        xfree(args->list[i]);
-                xfree(args->list);
+                        free(args->list[i]);
+                free(args->list);
                 args->nalloc = args->num = 0;
                 args->list = NULL;
         }
@@ -517,8 +519,8 @@ freeargs(arglist *args)
 char *
 tilde_expand_filename(const char *filename, uid_t uid)
 {
-        const char *path;
-        char user[128], ret[MAXPATHLEN];
+        const char *path, *sep;
+        char user[128], *ret;
         struct passwd *pw;
         u_int len, slash;
 
@@ -538,22 +540,21 @@ tilde_expand_filename(const char *filename, uid_t uid)
         } else if ((pw = getpwuid(uid)) == NULL)        /* ~/path */
                 fatal("tilde_expand_filename: No such uid %ld", (long)uid);
 
-        if (strlcpy(ret, pw->pw_dir, sizeof(ret)) >= sizeof(ret))
-                fatal("tilde_expand_filename: Path too long");
-
         /* Make sure directory has a trailing '/' */
         len = strlen(pw->pw_dir);
-        if ((len == 0 || pw->pw_dir[len - 1] != '/') &&
-            strlcat(ret, "/", sizeof(ret)) >= sizeof(ret))
-                fatal("tilde_expand_filename: Path too long");
+        if (len == 0 || pw->pw_dir[len - 1] != '/')
+                sep = "/";
+        else
+                sep = "";
 
         /* Skip leading '/' from specified path */
         if (path != NULL)
                 filename = path + 1;
-        if (strlcat(ret, filename, sizeof(ret)) >= sizeof(ret))
+
+        if (xasprintf(&ret, "%s%s%s", pw->pw_dir, sep, filename) >= MAXPATHLEN)
                 fatal("tilde_expand_filename: Path too long");
 
-        return (xstrdup(ret));
+        return (ret);
 }
 
 /*
@@ -920,6 +921,24 @@ ms_to_timeval(struct timeval *tv, int ms)
         tv->tv_usec = (ms % 1000) * 1000;
 }
 
+time_t
+monotime(void)
+{
+#if defined(HAVE_CLOCK_GETTIME) && defined(CLOCK_MONOTONIC)
+        struct timespec ts;
+        static int gettime_failed = 0;
+
+        if (!gettime_failed) {
+                if (clock_gettime(CLOCK_MONOTONIC, &ts) == 0)
+                        return (ts.tv_sec);
+                debug3("clock_gettime: %s", strerror(errno));
+                gettime_failed = 1;
+        }
+#endif
+
+        return time(NULL);
+}
+
 void
 bandwidth_limit_init(struct bwlimit *bw, u_int64_t kbps, size_t buflen)
 {