1 files changed, 12 insertions, 15 deletions

diff --git a/misc.c b/misc.c
index 8b303f16f..143dbf0e2 100644
--- a/misc.c
+++ b/misc.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: misc.c,v 1.69 2008/06/13 01:38:23 dtucker Exp $ */
+/* $OpenBSD: misc.c,v 1.71 2009/02/21 19:32:04 tobias Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  * Copyright (c) 2005,2006 Damien Miller.  All rights reserved.
@@ -221,23 +221,19 @@ pwcopy(struct passwd *pw)
 
 /*
  * Convert ASCII string to TCP/IP port number.
- * Port must be >0 and <=65535.
- * Return 0 if invalid.
+ * Port must be >=0 and <=65535.
+ * Return -1 if invalid.
  */
 int
 a2port(const char *s)
 {
-        long port;
-        char *endp;
-
-        errno = 0;
-        port = strtol(s, &endp, 0);
-        if (s == endp || *endp != '\0' ||
-            (errno == ERANGE && (port == LONG_MIN || port == LONG_MAX)) ||
-            port <= 0 || port > 65535)
-                return 0;
+        long long port;
+        const char *errstr;
 
-        return port;
+        port = strtonum(s, 0, 65535, &errstr);
+        if (errstr != NULL)
+                return -1;
+        return (int)port;
 }
 
 int
@@ -718,7 +714,8 @@ sanitise_stdfd(void)
         int nullfd, dupfd;
 
         if ((nullfd = dupfd = open(_PATH_DEVNULL, O_RDWR)) == -1) {
-                fprintf(stderr, "Couldn't open /dev/null: %s", strerror(errno));
+                fprintf(stderr, "Couldn't open /dev/null: %s\n",
+                    strerror(errno));
                 exit(1);
         }
         while (++dupfd <= 2) {
@@ -726,7 +723,7 @@ sanitise_stdfd(void)
                 if (fcntl(dupfd, F_GETFL, 0) >= 0)
                         continue;
                 if (dup2(nullfd, dupfd) == -1) {
-                        fprintf(stderr, "dup2: %s", strerror(errno));
+                        fprintf(stderr, "dup2: %s\n", strerror(errno));
                         exit(1);
                 }
         }