1 files changed, 27 insertions, 6 deletions

diff --git a/openbsd-compat/regress/utimensattest.c b/openbsd-compat/regress/utimensattest.c
index a7bc7634b..24312e5d8 100644
--- a/openbsd-compat/regress/utimensattest.c
+++ b/openbsd-compat/regress/utimensattest.c
@@ -33,7 +33,14 @@
 
 int utimensat(int, const char *, const struct timespec[2], int);
 
-void
+static void
+cleanup(void)
+{
+        (void)unlink(TMPFILE);
+        (void)unlink(TMPFILE2);
+}
+
+static void
 fail(char *msg, long expect, long got)
 {
         int saved_errno = errno;
@@ -44,6 +51,7 @@ fail(char *msg, long expect, long got)
         else
                 fprintf(stderr, "utimensat: %s: expected %ld got %ld\n",
                      msg, expect, got);
+        cleanup();
         exit(1);
 }
 
@@ -54,6 +62,7 @@ main(void)
         struct stat sb;
         struct timespec ts[2];
 
+        cleanup();
         if ((fd = open(TMPFILE, O_CREAT, 0600)) == -1)
                 fail("open", 0, 0);
         close(fd);
@@ -83,15 +92,27 @@ main(void)
                 fail("mtim.tv_nsec", 45678000, sb.st_mtim.tv_nsec);
 #endif
 
+        /*
+         * POSIX specifies that when given a symlink, AT_SYMLINK_NOFOLLOW
+         * should update the symlink and not the destination.  The compat
+         * code doesn't have a way to do this, so where possible it fails
+         * with instead of following a symlink when explicitly asked not to.
+         * Here we just test that it does not update the destination.
+         */
         if (rename(TMPFILE, TMPFILE2) == -1)
                 fail("rename", 0, 0);
         if (symlink(TMPFILE2, TMPFILE) == -1)
                 fail("symlink", 0, 0);
+        ts[0].tv_sec = 11223344;
+        ts[1].tv_sec = 55667788;
+        (void)utimensat(AT_FDCWD, TMPFILE, ts, AT_SYMLINK_NOFOLLOW);
+        if (stat(TMPFILE2, &sb) == -1)
+                fail("stat", 0, 0 );
+        if (sb.st_atime == 11223344)
+                fail("utimensat symlink st_atime", 0, 0 );
+        if (sb.st_mtime == 55667788)
+                fail("utimensat symlink st_mtime", 0, 0 );
 
-        if (utimensat(AT_FDCWD, TMPFILE, ts, AT_SYMLINK_NOFOLLOW) != -1)
-                fail("utimensat followed symlink", 0, 0);
-
-        if (!(unlink(TMPFILE) == 0 && unlink(TMPFILE2) == 0))
-                fail("unlink", 0, 0);
+        cleanup();
         exit(0);
 }