1 files changed, 26 insertions, 23 deletions

diff --git a/serverloop.c b/serverloop.c
index 9e5fa555e..5f22df3df 100644
--- a/serverloop.c
+++ b/serverloop.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: serverloop.c,v 1.164 2012/12/07 01:51:35 dtucker Exp $ */
+/* $OpenBSD: serverloop.c,v 1.168 2013/07/12 00:19:59 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -148,7 +148,7 @@ static void
 notify_parent(void)
 {
         if (notify_pipe[1] != -1)
-                write(notify_pipe[1], "", 1);
+                (void)write(notify_pipe[1], "", 1);
 }
 static void
 notify_prepare(fd_set *readset)
@@ -277,7 +277,7 @@ client_alive_check(void)
  */
 static void
 wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp,
-    u_int *nallocp, u_int max_time_milliseconds)
+    u_int *nallocp, u_int64_t max_time_milliseconds)
 {
         struct timeval tv, *tvp;
         int ret;
@@ -563,7 +563,7 @@ server_loop(pid_t pid, int fdin_arg, int fdout_arg, int fderr_arg)
         int wait_status;        /* Status returned by wait(). */
         pid_t wait_pid;         /* pid returned by wait(). */
         int waiting_termination = 0;    /* Have displayed waiting close message. */
-        u_int max_time_milliseconds;
+        u_int64_t max_time_milliseconds;
         u_int previous_stdout_buffer_bytes;
         u_int stdout_buffer_bytes;
         int type;
@@ -694,7 +694,7 @@ server_loop(pid_t pid, int fdin_arg, int fdout_arg, int fderr_arg)
                                 /* Display list of open channels. */
                                 cp = channel_open_message();
                                 buffer_append(&stderr_buffer, cp, strlen(cp));
-                                xfree(cp);
+                                free(cp);
                         }
                 }
                 max_fd = MAX(connection_in, connection_out);
@@ -722,10 +722,8 @@ server_loop(pid_t pid, int fdin_arg, int fdout_arg, int fderr_arg)
                 /* Process output to the client and to program stdin. */
                 process_output(writeset);
         }
-        if (readset)
-                xfree(readset);
-        if (writeset)
-                xfree(writeset);
+        free(readset);
+        free(writeset);
 
         /* Cleanup and termination code. */
 
@@ -825,7 +823,9 @@ void
 server_loop2(Authctxt *authctxt)
 {
         fd_set *readset = NULL, *writeset = NULL;
-        int rekeying = 0, max_fd, nalloc = 0;
+        int rekeying = 0, max_fd;
+        u_int nalloc = 0;
+        u_int64_t rekey_timeout_ms = 0;
 
         debug("Entering interactive session for SSH2.");
 
@@ -854,8 +854,13 @@ server_loop2(Authctxt *authctxt)
 
                 if (!rekeying && packet_not_very_much_data_to_write())
                         channel_output_poll();
+                if (options.rekey_interval > 0 && compat20 && !rekeying)
+                        rekey_timeout_ms = packet_get_rekey_timeout() * 1000;
+                else
+                        rekey_timeout_ms = 0;
+
                 wait_until_can_do_something(&readset, &writeset, &max_fd,
-                    &nalloc, 0);
+                    &nalloc, rekey_timeout_ms);
 
                 if (received_sigterm) {
                         logit("Exiting on signal %d", (int)received_sigterm);
@@ -879,10 +884,8 @@ server_loop2(Authctxt *authctxt)
         }
         collect_children();
 
-        if (readset)
-                xfree(readset);
-        if (writeset)
-                xfree(writeset);
+        free(readset);
+        free(writeset);
 
         /* free all channels, no more reads and writes */
         channel_free_all();
@@ -917,7 +920,7 @@ server_input_stdin_data(int type, u_int32_t seq, void *ctxt)
         packet_check_eom();
         buffer_append(&stdin_buffer, data, data_len);
         memset(data, 0, data_len);
-        xfree(data);
+        free(data);
 }
 
 static void
@@ -974,8 +977,8 @@ server_request_direct_tcpip(void)
                     originator, originator_port, target, target_port);
         }
 
-        xfree(originator);
-        xfree(target);
+        free(originator);
+        free(target);
 
         return c;
 }
@@ -1104,7 +1107,7 @@ server_input_channel_open(int type, u_int32_t seq, void *ctxt)
                 }
                 packet_send();
         }
-        xfree(ctype);
+        free(ctype);
 }
 
 static void
@@ -1149,7 +1152,7 @@ server_input_global_request(int type, u_int32_t seq, void *ctxt)
                             listen_address, listen_port,
                             &allocated_listen_port, options.gateway_ports);
                 }
-                xfree(listen_address);
+                free(listen_address);
         } else if (strcmp(rtype, "cancel-tcpip-forward") == 0) {
                 char *cancel_address;
                 u_short cancel_port;
@@ -1161,7 +1164,7 @@ server_input_global_request(int type, u_int32_t seq, void *ctxt)
 
                 success = channel_cancel_rport_listener(cancel_address,
                     cancel_port);
-                xfree(cancel_address);
+                free(cancel_address);
         } else if (strcmp(rtype, "no-more-sessions@openssh.com") == 0) {
                 no_more_sessions = 1;
                 success = 1;
@@ -1174,7 +1177,7 @@ server_input_global_request(int type, u_int32_t seq, void *ctxt)
                 packet_send();
                 packet_write_wait();
         }
-        xfree(rtype);
+        free(rtype);
 }
 
 static void
@@ -1206,7 +1209,7 @@ server_input_channel_req(int type, u_int32_t seq, void *ctxt)
                 packet_put_int(c->remote_id);
                 packet_send();
         }
-        xfree(rtype);
+        free(rtype);
 }
 
 static void