summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-23Include stdlib.h for free() and calloc().Darren Tucker
2019-07-23Re-apply portability changes to current sha2.{c,h}.Darren Tucker
Rather than attempt to apply 14 years' worth of changes to OpenBSD's sha2 I imported the current versions directly then re-applied the portability changes. This also allowed re-syncing digest-libc.c against upstream.
2019-07-23Import current sha2.c and sha2.h from OpenBSD.Darren Tucker
These are not changed from their original state, the next commit will re-apply the portable changes.
2019-07-23Rename valgrind "errors" to "failures".Darren Tucker
When valgrind is enabled, test-exec.sh counts the number of invocations that valgrind detects failures in, not the total number of errors detected. This makes the name to be more accurate.
2019-07-20Skip running sftp-chroot under Valgrind.Darren Tucker
2019-07-20upstream: Remove the sleeps and thus races from the forwardingdtucker@openbsd.org
test. They were originally required to work with Protocol 1, but now we can use ssh -N and the control socket without the sleeps. While there, suppress output fro the control exit commands. OpenBSD-Regress-ID: 4c51a1d651242f12c90074c18c61008a74c1c790
2019-07-20upstream: Allow SLEEPTIME to be overridden.dtucker@openbsd.org
OpenBSD-Regress-ID: 1596ab168729954be3d219933b2d01cc93687e76
2019-07-20upstream: Move sleep time into a variable so that we can increasedtucker@openbsd.org
it for platforms or configurations that are much slower then usual. OpenBSD-Regress-ID: 88586cabc800062c260d0b876bdcd4ca3f58a872
2019-07-19upstream: add regression tests for scp for out-of-destination path filedjm@openbsd.org
creation by Harry Sintonen via Jakub Jelen in bz3007 OpenBSD-Regress-ID: 01ae5fbc6ce400b2df5a84dc3152a9e31f354c07
2019-07-19upstream: Accept the verbose flag when searching for host keys in knowndjm@openbsd.org
hosts (i.e. "ssh-keygen -vF host") to print the matching host's random- art signature too. bz#3003 "amusing, pretty" deraadt@ OpenBSD-Commit-ID: 686221a5447d6507f40a2ffba5393984d889891f
2019-07-19Revert one dependency per line change.Darren Tucker
It turns out that having such a large number of lines in the .depend file will cause the memory usage of awk during AC_SUBST to blow up on at least NetBSD's awk, causing configure to fail.
2019-07-19fix SIGWINCH delivery of Solaris for mux sessionsDamien Miller
Remove PRIV_PROC_SESSION which was limiting ability to send SIGWINCH signals to other sessions. bz#3030; report and fix from Darren Moffat
2019-07-19Force dependencies one per line.Darren Tucker
Force makedepend to output one dependency per line, which will make reading diffs against it much easier. ok djm@
2019-07-19make depend.Darren Tucker
2019-07-19Show when skipping valgrind for a test.Darren Tucker
2019-07-19Enable connect-privsep test with valgrind.Darren Tucker
connect-privsep seems to work OK with valgrind now so don't skip valgrind on it.
2019-07-19Show valgrind results and error counts.Darren Tucker
2019-07-19Fix format string integer type in error message.Darren Tucker
2019-07-18upstream: fix off-by-one in sshbuf_dtob64() base64 wrapping that coulddjm@openbsd.org
cause extra newlines to be appended at the end of the base64 text (ugly, but harmless). Found and fixed by Sebastian Kinne OpenBSD-Commit-ID: 9fe290bd68f706ed8f986a7704ca5a2bd32d7b68
2019-07-18Fail tests if Valgrind enabled and reports errors.Darren Tucker
Also dump the failing valgrind report to stdout (not the cleanest solution, but better than nothing).
2019-07-18Allow low-priv tests to write to pipe dir.Darren Tucker
When running regression tests with Valgrind and SUDO, the low-priv agent tests need to be able to create pipes in the appropriate directory.
2019-07-17Put valgrind vgdb files to a specific directory.Darren Tucker
Valgrind by default puts vgdb files and pipes under /tmp, however it is not always able to clean them up, which can cause test failures when there's a pid/file collision. Using a specific directory ensures that we can clean up and start clean.
2019-07-17upstream: adapt to sshbuf_dtob64() changedjm@openbsd.org
OpenBSD-Regress-ID: 82374a83edf0955fd1477169eee3f5d6467405a6
2019-07-17upstream: Remove ssh1 files from CLEANFILES since ssh1 no longerdtucker@openbsd.org
supported. OpenBSD-Regress-ID: 5b9ae869dc669bac05939b4a2fdf44ee067acfa0
2019-07-17upstream: Update names of host key files in CLEANFILES to matchdtucker@openbsd.org
recent changes to the tests. OpenBSD-Regress-ID: 28743052de3acf70b06f18333561497cd47c4ecf
2019-07-16dependDamien Miller
2019-07-16upstream: remove mostly vestigal uuencode.[ch]; moving the only uniquedjm@openbsd.org
functionality there (wrapping of base64-encoded data) to sshbuf functions; feedback and ok markus@ OpenBSD-Commit-ID: 4dba6735d88c57232f6fccec8a08bdcfea44ac4c
2019-07-16Hook memmem compat code into build.Darren Tucker
This fixes builds on platforms that don't have it (at least old DragonFly, probably others).
2019-07-16Import memmem.c from OpenBSD.Darren Tucker
2019-07-15upstream: unit tests for sshbuf_cmp() and sshbuf_find(); ok markusdjm@openbsd.org
OpenBSD-Regress-ID: b52d36bc3ab6dc158c1e59a9a4735f821cf9e1fd
2019-07-15upstream: support PKCS8 as an optional format for storage ofdjm@openbsd.org
private keys, enabled via "ssh-keygen -m PKCS8" on operations that save private keys to disk. The OpenSSH native key format remains the default, but PKCS8 is a superior format to PEM if interoperability with non-OpenSSH software is required, as it may use a less terrible KDF (IIRC PEM uses a single round of MD5 as a KDF). adapted from patch by Jakub Jelen via bz3013; ok markus OpenBSD-Commit-ID: 027824e3bc0b1c243dc5188504526d73a55accb1
2019-07-15upstream: two more bounds-checking sshbuf counterparts to commondjm@openbsd.org
string operations: sshbuf_cmp() (bcmp-like) and sshbuf_find() (memmem like) feedback and ok markus@ OpenBSD-Commit-ID: fd071ec2485c7198074a168ff363a0d6052a706a
2019-07-15Clear valgrind-out dir to prevent collisions.Darren Tucker
2019-07-15Allow agent tests to write to valgrind dir.Darren Tucker
2019-07-15upstream: unit tests for sshbuf_peek/poke bounds-checked random accessdjm@openbsd.org
functions. ok markus@ OpenBSD-Regress-ID: 034c4284b1da6b12e25c762a6b958efacdafbaef
2019-07-15upstream: add some functions to perform random-access read/writedjm@openbsd.org
operations inside buffers with bounds checking. Intended to replace manual pointer arithmetic wherever possible. feedback and ok markus@ OpenBSD-Commit-ID: 91771fde7732738f1ffed078aa5d3bee6d198409
2019-07-12upstream: include SHA2-variant RSA key algorithms in KEX proposal;djm@openbsd.org
allows ssh-keyscan to harvest keys from servers that disable olde SHA1 ssh-rsa. bz#3029 from Jakub Jelen OpenBSD-Commit-ID: 9f95ebf76a150c2f727ca4780fb2599d50bbab7a
2019-07-12upstream: print explicit "not modified" message if a file wasdjm@openbsd.org
requested for resumed download but was considered already complete. bz#2978 ok dtucker OpenBSD-Commit-ID: f32084b26a662f16215ee4ca4a403d67e49ab986
2019-07-12upstream: Fix a typo and make <esc><right> move right to thetb@openbsd.org
closest end of a word just like <esc><left> moves left to the closest beginning of a word. ok djm OpenBSD-Commit-ID: 6afe01b05ed52d8b12eb1fda6e9af5afb5e198ee
2019-07-10fix typo that prevented detection of Linux VRFDamien Miller
Reported by hexiaowen AT huawei.com
2019-07-09upstream: cap the number of permiopen/permitlisten directives we'redjm@openbsd.org
willing to parse on a single authorized_keys line; ok deraadt@ OpenBSD-Commit-ID: a43a752c2555d26aa3fc754805a476f6e3e30f46
2019-07-08Move log.h include inside ifdefs.Darren Tucker
Fixes build on some other platforms that don't have va_list immediately available (eg NetBSD).
2019-07-08Include log.h for debug() and friends.Darren Tucker
Should fix some compiler warnings on IRIX (bz#3032).
2019-07-08sftp-realpath.c needs includes.hDamien Miller
2019-07-08remove realpath() compat replacementDamien Miller
We shipped a BSD implementation of realpath() because sftp-server depended on its behaviour. OpenBSD is now moving to a more strictly POSIX-compliant realpath(2), so sftp-server now unconditionally requires its own BSD-style realpath implementation. As such, there is no need to carry another independant implementation in openbsd-compat. ok dtucker@
2019-07-08upstream: Remove some set but never used variables. ok daraadt@dtucker@openbsd.org
OpenBSD-Commit-ID: 824baf9c59afc66a4637017e397b9b74a41684e7
2019-07-08upstream: still compile uuencode.c, unbreaks buildderaadt@openbsd.org
OpenBSD-Commit-ID: 5ea3d63ab972691f43e9087ab5fd8376d48e898f
2019-07-08upstream: revert header removal that snuck into previousdjm@openbsd.org
OpenBSD-Commit-ID: 3919cdd58989786660b8269b325646ef8856428e
2019-07-08upstream: add a local implementation of BSD realpath() fordjm@openbsd.org
sftp-server use ahead of OpenBSD's realpath changing to match POSIX; ok deraadt@ (thanks for snaps testing) OpenBSD-Commit-ID: 4f8cbf7ed8679f6237264301d104ecec64885d55
2019-07-06Add prototype for strnlen to prevent warnings.Darren Tucker