summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2006-05-04 - (dtucker) [auth-pam.c groupaccess.c monitor.c monitor_wrap.c scard-opensc.cDarren Tucker
session.c ssh-rand-helper.c sshd.c openbsd-compat/bsd-cygwin_util.c openbsd-compat/setproctitle.c] Convert malloc(foo*bar) -> calloc(foo,bar) in Portable-only code; since calloc zeros, remove now-redundant memsets. Also add a couple of sanity checks. With & ok djm@
2006-05-03 - (dtucker) [packet.c] Remove in_systm.h since it's also in includes.hDarren Tucker
and double including it on IRIX 5.3 causes problems. From Georg Schwarz, "no objections" tim@
2006-04-23missing fileDamien Miller
2006-04-23 - (djm) [auth.h dispatch.h kex.h] sprinkle in signal.h to getDamien Miller
sig_atomic_t
2006-04-23 - dtucker@cvs.openbsd.org 2006/04/18 10:44:28Damien Miller
[bufaux.c bufbn.c Makefile.in] Move Buffer bignum functions into their own file, bufbn.c. This means that sftp and sftp-server (which use the Buffer functions in bufaux.c but not the bignum ones) no longer need to be linked with libcrypto. ok markus@
2006-04-23 - stevesk@cvs.openbsd.org 2006/04/22 18:29:33Damien Miller
[crc32.c] remove extra spaces
2006-04-23 - djm@cvs.openbsd.org 2006/04/22 04:06:51Damien Miller
[uidswap.c] use setres[ug]id() to permanently revoke privileges; ok deraadt@ (ID Sync only - portable already uses setres[ug]id() whenever possible)
2006-04-23 - djm@cvs.openbsd.org 2006/04/20 21:53:44Damien Miller
[includes.h session.c sftp.c] Switch from using pipes to socketpairs for communication between sftp/scp and ssh, and between sshd and its subprocesses. This saves a file descriptor per session and apparently makes userland ppp over ssh work; ok markus@ deraadt@ (ID Sync only - portable makes this decision on a per-platform basis)
2006-04-23 - markus@cvs.openbsd.org 2006/04/20 09:47:59Damien Miller
[sshconnect.c] simplify; ok djm@
2006-04-23 - djm@cvs.openbsd.org 2006/04/20 09:27:09Damien Miller
[auth.h clientloop.c dispatch.c dispatch.h kex.h] replace the last non-sig_atomic_t flag used in a signal handler with a sig_atomic_t, unfortunately with some knock-on effects in other (non- signal) contexts in which it is used; ok markus@
2006-04-23 - dtucker@cvs.openbsd.org 2006/04/18 10:44:28Damien Miller
[bufaux.c bufbn.c] Move Buffer bignum functions into their own file, bufbn.c. This means that sftp and sftp-server (which use the Buffer functions in bufaux.c but not the bignum ones) no longer need to be linked with libcrypto. ok markus@
2006-04-23 - djm@cvs.openbsd.org 2006/04/16 07:59:00Damien Miller
[atomicio.c] reorder sanity test so that it cannot dereference past the end of the iov array; well spotted canacar@!
2006-04-23 - djm@cvs.openbsd.org 2006/04/16 00:54:10Damien Miller
[sftp-client.c] avoid making a tiny 4-byte write to send the packet length of sftp commands, which would result in a separate tiny packet on the wire by using atomiciov(writev, ...) to write the length and the command in one pass; ok deraadt@
2006-04-23 - djm@cvs.openbsd.org 2006/04/16 00:52:55Damien Miller
[atomicio.c atomicio.h] introduce atomiciov() function that wraps readv/writev to retry interrupted transfers like atomicio() does for read/write; feedback deraadt@ dtucker@ stevesk@ ok deraadt@
2006-04-23 - djm@cvs.openbsd.org 2006/04/16 00:48:52Damien Miller
[buffer.c buffer.h channels.c] Fix condition where we could exit with a fatal error when an input buffer became too large and the remote end had advertised a big window. The problem was a mismatch in the backoff math between the channels code and the buffer code, so make a buffer_check_alloc() function that the channels code can use to propsectivly check whether an incremental allocation will succeed. bz #1131, debugged with the assistance of cove AT wildpackets.com; ok dtucker@ deraadt@
2006-04-23 - djm@cvs.openbsd.org 2006/04/03 07:10:38Damien Miller
[gss-genr.c] GSSAPI buffers shouldn't be nul-terminated, spotted in bugzilla #1066 by dleonard AT vintela.com. use xasprintf() to simplify code while in there; "looks right" deraadt@
2006-04-23 - dtucker@cvs.openbsd.org 2006/04/02 08:34:52Damien Miller
[ssh-keysign.c] sessionid can be 32 bytes now too when sha256 kex is used; ok djm@
2006-04-23 - djm@cvs.openbsd.org 2006/04/01 05:51:34Damien Miller
[atomicio.c] ANSIfy; requested deraadt@
2006-04-23 - djm@cvs.openbsd.org 2006/04/01 05:50:29Damien Miller
[scp.c] xasprintification; ok deraadt@
2006-04-23 - (djm) OpenBSD CVS SyncDamien Miller
- deraadt@cvs.openbsd.org 2006/04/01 05:42:20 [scp.c] minimal lint cleanup (unused crud, and some size_t); ok djm
2006-04-22 - (djm) [Makefile.in configure.ac session.c sshpty.c]Damien Miller
[contrib/redhat/sshd.init openbsd-compat/Makefile.in] [openbsd-compat/openbsd-compat.h openbsd-compat/port-linux.c] [openbsd-compat/port-linux.h] Add support for SELinux, setting the execution and TTY contexts. based on patch from Daniel Walsh, bz #880; ok dtucker@
2006-04-18 - (djm) Reorder IP options check so that it isn't broken byDamien Miller
mapped addresses; bz #1179 reported by markw wtech-llc.com; ok dtucker@
2006-03-31 - djm@cvs.openbsd.org 2006/03/31 09:13:56Damien Miller
[ssh_config.5] remote user escape is %r not %h; spotted by jmc@
2006-03-31 - jmc@cvs.openbsd.org 2006/03/31 09:09:30Damien Miller
[ssh_config.5] kill trailing whitespace;
2006-03-31 - dtucker@cvs.openbsd.org 2006/03/30 11:40:21Damien Miller
[auth.c monitor.c] Prevent duplicate log messages when privsep=yes; ok djm@
2006-03-31 - dtucker@cvs.openbsd.org 2006/03/30 11:05:17Damien Miller
[ssh-keygen.c] Correctly handle truncated files while converting keys; ok djm@
2006-03-31 - djm@cvs.openbsd.org 2006/03/30 10:41:25Damien Miller
[ssh.c ssh_config.5] add percent escape chars to the IdentityFile option, bz #1159 based on a patch by imaging AT math.ualberta.ca; feedback and ok dtucker@
2006-03-31 - djm@cvs.openbsd.org 2006/03/30 09:58:16Damien Miller
[authfd.c bufaux.c deattack.c gss-serv.c mac.c misc.c misc.h] [monitor_wrap.c msg.c packet.c sftp-client.c sftp-server.c ssh-agent.c] replace {GET,PUT}_XXBIT macros with functionally similar functions, silencing a heap of lint warnings. also allows them to use __bounded__ checking which can't be applied to macros; requested by and feedback from deraadt@
2006-03-31 - djm@cvs.openbsd.org 2006/03/30 09:41:25Damien Miller
[channels.c] ARGSUSED for dispatch table-driven functions
2006-03-31 - deraadt@cvs.openbsd.org 2006/03/28 01:53:43Damien Miller
[ssh-agent.c] use strtonum() to parse the pid from the file, and range check it better; ok djm
2006-03-31 - deraadt@cvs.openbsd.org 2006/03/28 01:52:28Damien Miller
[channels.c] do not accept unreasonable X ports numbers; ok djm
2006-03-31 - deraadt@cvs.openbsd.org 2006/03/28 00:12:31Damien Miller
[README.tun ssh.c] spacing
2006-03-31 - djm@cvs.openbsd.org 2006/03/27 23:15:46Damien Miller
[sftp.c] always use a format string for addargs; spotted by mouring@
2006-03-31 - deraadt@cvs.openbsd.org 2006/03/27 13:03:54Damien Miller
[dh.c] use strtonum() instead of atoi(), limit dhg size to 64k; ok djm
2006-03-31 - OpenBSD CVS SyncDamien Miller
- deraadt@cvs.openbsd.org 2006/03/27 01:21:18 [xmalloc.c] we can do the size & nmemb check before the integer overflow check; evol
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/26 01:31:48Damien Miller
[uuencode.c] typo
2006-03-26 - djm@cvs.openbsd.org 2006/03/25 22:22:43Damien Miller
[atomicio.h auth-options.h auth.h auth2-gss.c authfd.h authfile.h] [bufaux.h buffer.h canohost.h channels.h cipher.h clientloop.h] [compat.h compress.h crc32.c crc32.h deattack.h dh.h dispatch.h] [dns.c dns.h getput.h groupaccess.h gss-genr.c gss-serv-krb5.c] [gss-serv.c hostfile.h includes.h kex.h key.h log.h mac.h match.h] [misc.h monitor.h monitor_fdpass.h monitor_mm.h monitor_wrap.h msg.h] [myproposal.h packet.h pathnames.h progressmeter.h readconf.h rsa.h] [scard.h servconf.h serverloop.h session.h sftp-common.h sftp.h] [ssh-gss.h ssh.h ssh1.h ssh2.h sshconnect.h sshlogin.h sshpty.h] [ttymodes.h uidswap.h uuencode.h xmalloc.h] standardise spacing in $OpenBSD$ tags; requested by deraadt@
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:58:10Damien Miller
[channels.c] delete cast not required
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:56:55Damien Miller
[bufaux.c channels.c packet.c] remove (char *) casts to a function that accepts void * for the arg
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:43:30Damien Miller
[channels.c] use strtonum() instead of atoi() [limit X screens to 400, sorry]
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:41:45Damien Miller
[ssh-agent.c] mark two more signal handlers ARGSUSED
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:40:14Damien Miller
[ssh-keygen.c] cast strtonum() result to right type
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:36:15Damien Miller
[sshlogin.c sshlogin.h] nicer size_t and time_t types
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:30:55Damien Miller
[clientloop.c serverloop.c] spacing
2006-03-26 - deraadt@cvs.openbsd.org 2006/03/25 18:29:35Damien Miller
[auth-rsa.c authfd.c packet.c] needed casts (always will be needed)
2006-03-26oops, rewrapDamien Miller
2006-03-26 - djm@cvs.openbsd.org 2006/03/25 13:17:03Damien Miller
[atomicio.c auth-bsdauth.c auth-chall.c auth-options.c auth-passwd.c] [auth-rh-rsa.c auth-rhosts.c auth-rsa.c auth-skey.c auth.c auth1.c] [auth2-chall.c auth2-hostbased.c auth2-kbdint.c auth2-none.c] [auth2-passwd.c auth2-pubkey.c auth2.c authfd.c authfile.c bufaux.c] [buffer.c canohost.c channels.c cipher-3des1.c cipher-bf1.c] [cipher-ctr.c cipher.c cleanup.c clientloop.c compat.c compress.c] [deattack.c dh.c dispatch.c fatal.c groupaccess.c hostfile.c kex.c] [kexdh.c kexdhc.c kexdhs.c kexgex.c kexgexc.c kexgexs.c key.c log.c] [mac.c match.c md-sha256.c misc.c monitor.c monitor_fdpass.c] [monitor_mm.c monitor_wrap.c msg.c nchan.c packet.c progressmeter.c] [readconf.c readpass.c rsa.c scard.c scp.c servconf.c serverloop.c] [session.c sftp-client.c sftp-common.c sftp-glob.c sftp-server.c] [sftp.c ssh-add.c ssh-agent.c ssh-dss.c ssh-keygen.c ssh-keyscan.c] [ssh-keysign.c ssh-rsa.c ssh.c sshconnect.c sshconnect1.c] [sshconnect2.c sshd.c sshlogin.c sshpty.c sshtty.c ttymodes.c] [uidswap.c uuencode.c xmalloc.c] Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that Theo nuked - our scripts to sync -portable need them in the files
2006-03-26 - djm@cvs.openbsd.org 2006/03/25 01:30:23Damien Miller
[sftp.c] "abormally" is a perfectly cromulent word, but "abnormally" is better
2006-03-26 - djm@cvs.openbsd.org 2006/03/25 01:13:23Damien Miller
[buffer.c channels.c deattack.c misc.c scp.c session.c sftp-client.c] [sftp-server.c ssh-agent.c ssh-rsa.c xmalloc.c xmalloc.h auth-pam.c] [uidswap.c] change OpenSSH's xrealloc() function from being xrealloc(p, new_size) to xrealloc(p, new_nmemb, new_itemsize). realloc is particularly prone to integer overflows because it is almost always allocating "n * size" bytes, so this is a far safer API; ok deraadt@
2006-03-26 - djm@cvs.openbsd.org 2006/03/25 00:05:41Damien Miller
[auth-bsdauth.c auth-skey.c auth.c auth2-chall.c channels.c] [clientloop.c deattack.c gss-genr.c kex.c key.c misc.c moduli.c] [monitor.c monitor_wrap.c packet.c scard.c sftp-server.c ssh-agent.c] [ssh-keyscan.c ssh.c sshconnect.c sshconnect2.c sshd.c uuencode.c] [xmalloc.c xmalloc.h] introduce xcalloc() and xasprintf() failure-checked allocations functions and use them throughout openssh xcalloc is particularly important because malloc(nmemb * size) is a dangerous idiom (subject to integer overflow) and it is time for it to die feedback and ok deraadt@