Age | Commit message (Collapse) | Author |
|
[ssh-agent.c]
use strtonum() to parse the pid from the file, and range check it
better; ok djm
|
|
[channels.c]
do not accept unreasonable X ports numbers; ok djm
|
|
[README.tun ssh.c]
spacing
|
|
[sftp.c]
always use a format string for addargs; spotted by mouring@
|
|
[dh.c]
use strtonum() instead of atoi(), limit dhg size to 64k; ok djm
|
|
- deraadt@cvs.openbsd.org 2006/03/27 01:21:18
[xmalloc.c]
we can do the size & nmemb check before the integer overflow check;
evol
|
|
[uuencode.c]
typo
|
|
[atomicio.h auth-options.h auth.h auth2-gss.c authfd.h authfile.h]
[bufaux.h buffer.h canohost.h channels.h cipher.h clientloop.h]
[compat.h compress.h crc32.c crc32.h deattack.h dh.h dispatch.h]
[dns.c dns.h getput.h groupaccess.h gss-genr.c gss-serv-krb5.c]
[gss-serv.c hostfile.h includes.h kex.h key.h log.h mac.h match.h]
[misc.h monitor.h monitor_fdpass.h monitor_mm.h monitor_wrap.h msg.h]
[myproposal.h packet.h pathnames.h progressmeter.h readconf.h rsa.h]
[scard.h servconf.h serverloop.h session.h sftp-common.h sftp.h]
[ssh-gss.h ssh.h ssh1.h ssh2.h sshconnect.h sshlogin.h sshpty.h]
[ttymodes.h uidswap.h uuencode.h xmalloc.h]
standardise spacing in $OpenBSD$ tags; requested by deraadt@
|
|
[channels.c]
delete cast not required
|
|
[bufaux.c channels.c packet.c]
remove (char *) casts to a function that accepts void * for the arg
|
|
[channels.c]
use strtonum() instead of atoi() [limit X screens to 400, sorry]
|
|
[ssh-agent.c]
mark two more signal handlers ARGSUSED
|
|
[ssh-keygen.c]
cast strtonum() result to right type
|
|
[sshlogin.c sshlogin.h]
nicer size_t and time_t types
|
|
[clientloop.c serverloop.c]
spacing
|
|
[auth-rsa.c authfd.c packet.c]
needed casts (always will be needed)
|
|
|
|
[atomicio.c auth-bsdauth.c auth-chall.c auth-options.c auth-passwd.c]
[auth-rh-rsa.c auth-rhosts.c auth-rsa.c auth-skey.c auth.c auth1.c]
[auth2-chall.c auth2-hostbased.c auth2-kbdint.c auth2-none.c]
[auth2-passwd.c auth2-pubkey.c auth2.c authfd.c authfile.c bufaux.c]
[buffer.c canohost.c channels.c cipher-3des1.c cipher-bf1.c]
[cipher-ctr.c cipher.c cleanup.c clientloop.c compat.c compress.c]
[deattack.c dh.c dispatch.c fatal.c groupaccess.c hostfile.c kex.c]
[kexdh.c kexdhc.c kexdhs.c kexgex.c kexgexc.c kexgexs.c key.c log.c]
[mac.c match.c md-sha256.c misc.c monitor.c monitor_fdpass.c]
[monitor_mm.c monitor_wrap.c msg.c nchan.c packet.c progressmeter.c]
[readconf.c readpass.c rsa.c scard.c scp.c servconf.c serverloop.c]
[session.c sftp-client.c sftp-common.c sftp-glob.c sftp-server.c]
[sftp.c ssh-add.c ssh-agent.c ssh-dss.c ssh-keygen.c ssh-keyscan.c]
[ssh-keysign.c ssh-rsa.c ssh.c sshconnect.c sshconnect1.c]
[sshconnect2.c sshd.c sshlogin.c sshpty.c sshtty.c ttymodes.c]
[uidswap.c uuencode.c xmalloc.c]
Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
Theo nuked - our scripts to sync -portable need them in the files
|
|
[sftp.c]
"abormally" is a perfectly cromulent word, but "abnormally" is better
|
|
[buffer.c channels.c deattack.c misc.c scp.c session.c sftp-client.c]
[sftp-server.c ssh-agent.c ssh-rsa.c xmalloc.c xmalloc.h auth-pam.c]
[uidswap.c]
change OpenSSH's xrealloc() function from being xrealloc(p, new_size)
to xrealloc(p, new_nmemb, new_itemsize).
realloc is particularly prone to integer overflows because it is
almost always allocating "n * size" bytes, so this is a far safer
API; ok deraadt@
|
|
[auth-bsdauth.c auth-skey.c auth.c auth2-chall.c channels.c]
[clientloop.c deattack.c gss-genr.c kex.c key.c misc.c moduli.c]
[monitor.c monitor_wrap.c packet.c scard.c sftp-server.c ssh-agent.c]
[ssh-keyscan.c ssh.c sshconnect.c sshconnect2.c sshd.c uuencode.c]
[xmalloc.c xmalloc.h]
introduce xcalloc() and xasprintf() failure-checked allocations
functions and use them throughout openssh
xcalloc is particularly important because malloc(nmemb * size) is a
dangerous idiom (subject to integer overflow) and it is time for it
to die
feedback and ok deraadt@
|
|
[ttymodes.c]
spacing
|
|
[channels.c fatal.c kex.c packet.c serverloop.c]
spacing
|
|
[canohost.c match.c ssh.c sshconnect.c]
be strict with tolower() casting
|
|
[dns.c]
cast xstrdup to propert u_char *
|
|
[channels.c]
x11_fake_data is only ever used as u_char *
|
|
[monitor.c]
spacing
|
|
[channels.c monitor.c session.c session.h ssh-agent.c ssh-keygen.c]
[ssh-rsa.c ssh.c sshlogin.c]
annoying spacing fixes getting in the way of real diffs
|
|
[auth1.c auth2.c sshd.c]
sprinkle some ARGSUSED for table driven functions (which sometimes
must ignore their args)
|
|
|
|
[channels.c clientloop.c monitor_wrap.c monitor_wrap.h serverloop.c]
[ssh.c sshpty.c sshpty.h]
sprinkle u_int throughout pty subsystem, ok markus
|
|
[ssh-rsa.c]
in a switch (), break after return or goto is stupid
|
|
[key.c]
djm did a typo
|
|
[auth.c key.c misc.c packet.c ssh-add.c]
in a switch (), break after return or goto is stupid
|
|
[key.c]
(really) last of the Coverity diffs: avoid possible NULL deref in
key_free. via elad AT netbsd.org; markus@ ok
|
|
[monitor.c]
memory leaks detected by Coverity via elad AT netbsd.org;
deraadt@ ok
that should be all of them now
|
|
[authfile.c]
whoever thought that break after return was a good idea needs to
get their head examimed
|
|
[ssh.c]
spacing
|
|
[ssh-keyscan.c]
please lint
|
|
[clientloop.c progressmeter.c serverloop.c sshd.c]
ARGSUSED for signal handlers
|
|
[kex.c kex.h monitor.c myproposal.h session.c]
spacing
|
|
[auth1.c authfd.c channels.c]
spacing
|
|
[servconf.c]
Correct strdelim null test; ok djm@
|
|
[sshconnect2.c]
memory leaks detected by Coverity via elad AT netbsd.org;
deraadt@ ok
|
|
[dh.c readconf.c servconf.c]
potential NULL pointer dereferences detected by Coverity
via elad AT netbsd.org; ok deraadt@
|
|
[hostfile.c]
FILE* leak detected by Coverity via elad AT netbsd.org;
ok deraadt@
|
|
[sftp.c]
more memory leaks detected by Coverity via elad AT netbsd.org;
deraadt@ ok
|
|
[serverloop.c]
memory leaks detected by Coverity via elad AT netbsd.org;
ok deraadt@ dtucker@
|
|
[authfd.c]
unreachanble statement, found by lint
|
|
[authfd.c]
another unreachable found by lint
|